Sunday, March 29, 2026
2 changes · saas-19.1
Resolved issues and error corrections
This update resolves a problem where creating payments for expenses linked to a 'Branch' company would trigger an error. The fix ensures that payment journal entries correctly link to the expense company, preventing these errors and improving the accuracy of financial reporting for multi-company setups.
Original PR description
**Steps to reproduce:** - Install Accounting and Expenses - Create a Branch company (e.g. Branch) - In company selector, select both Branch (as main) and its parent - In Bank journal settings, make…
**Steps to reproduce:** - Install Accounting and Expenses - Create a Branch company (e.g. Branch) - In company selector, select both Branch (as main) and its parent - In Bank journal settings, make sure that there is an outstanding payment account for "Manual Payment" - Create an employee in Branch - Create an expense: * Category: [any] (e.g. [EXP_GEN] Expenses) * Total: [anything] (e.g. 100.00) * Employee: [the created employee] * Paid By: company * Company: Branch - Create Report - Submit to Manager - Approve **Issue:** A UserError is raised because it tries to create a payment in Branch linked to a journal entry in the parent company. **Cause:** The payment is initialized with the company of the expense but not the related journal entry. **(A similar issue happens with an expense paid by the employee when generating the bill upon approval of the expense sheet)** opw-6007859 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#256489 Forward-Port-Of: odoo/odoo#254434
This update fixes an issue where mixed POS orders (with both sales and settlement lines) weren't being properly validated. The change ensures that settlement lines are correctly identified, preventing incorrect validation and improving the accuracy of financial reporting for Saudi POS transactions. This update aligns with newer Odoo versions and enhances the reliability of the l10n_sa_edi_pos integration.
Original PR description
# Description of the issue/feature this PR addresses: From saas-18.3 onward, the pos_settle_due module introduced a new method to identify settlement lines. While the old method **isSettleDueLine()**…
# Description of the issue/feature this PR addresses: From saas-18.3 onward, the pos_settle_due module introduced a new method to identify settlement lines. While the old method **isSettleDueLine()** is still there, the new **isAnySettleLine()** covers both order settlement and invoice settlement. This change was not reflected in the Saudi POS EDI integration during forward-porting, which caused incorrect validation when processing POS orders containing both regular sale lines and settlement lines. # Current behavior before PR: - Orders containing a mix of new sale lines and settlement lines could bypass the intended validation. - The validation logic relied on the old isSettleDueLine() method # Desired behavior after PR is merged: - Update the validation flow to use isAnySettleLine() (when available) to correctly detect settlement lines. - Prevent validation of POS orders that contain both settlement lines and new sale lines. - Ensure compatibility with newer versions of the pos_settle_due module and restore the intended settlement validation behavior. - Test case to ensure no regression on this feature I confirm I have signed the CLA and read the PR guidelines at [www.odoo.com/submit-pr](http://www.odoo.com/submit-pr) Forward-Port-Of: odoo/odoo#256177 Forward-Port-Of: odoo/odoo#254275