Saturday, May 9, 2026
7 changes · saas-19.1
Resolved issues and error corrections
This update fixes a bug where abandoned cart emails were sometimes sent twice. A recent change in how the system determines the customer's email address caused a conflict with an older fix. This change ensures that emails are only sent once, regardless of how the customer's email address is determined.
Original PR description
During a previous fix (https://github.com/odoo/odoo/pull/206158), fallback values were added for an explicit `email_to` if the default email template for the abandonned cart was missing them. But…
During a previous fix (https://github.com/odoo/odoo/pull/206158), fallback values were added for an explicit `email_to` if the default email template for the abandonned cart was missing them. But since (https://github.com/odoo/odoo/pull/172714), the template uses `use_default_to` == True, which will compute the default partner and add them to `partner_ids` of the `mail.mail` record. So the old bug of "abandoned cart email is sent twice" reappered: the if condition fails to account for `use_default_to` being set, so the partner email is set explicitly on `email_to` AND referenced in `partner_ids`, which de-facto sends the email twice to the customer on the sales order. ## FIX: We account for `use_default_to` in the if condition before adding the fallback. How to reproduce: 1) Setup a database with demo data and website_sale 2) Visit the shop as a visitor, add stuff to your cart 3) Sign up for portal access and add new stuff to cart (will attribute SO to new portal account) 4) Wait for the abandoned cart email to trigger (can be forced by playing with `cart_recovery_email_sent`: false,`is_abandoned_cart`: true and triggering the CRON) -> mail is sent twice to the customer Remarks: - changed the unit test to actually capture the generated `mail.mail` and apply some asserts on it OPW-6134731 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#261039
This update prevents website editors from getting stuck when interactions fail during the edit mode transition. Previously, a single error would halt the entire process, blocking content changes. Now, errors are handled gracefully, allowing the editor to continue and ensuring a smoother editing experience.
Original PR description
When entering website edit mode, `websiteEditService.handleEditPage()` calls `InteractionService.stopInteractions()`. Currently, a failure while destroying a single interaction aborts the entire stop sequence. This prevents the editor from loading, leaving users unable to modify or delete the element that caused the failure. Any errors encountered during destruction are caught and stored so the remaining cleanup can complete, and then they are rethrown. This ensures the transition to edit mode is not blocked by a single element's failure. task-5180598 Forward-Port-Of: odoo/odoo#263098
This update resolves an issue where standard users couldn't create projects from templates due to permission restrictions. Adding `sudo` ensures the necessary access is granted, preventing errors and allowing all users to utilize project creation features without disruption. This improves overall system stability and usability.
Original PR description
Steps to reproduce: - Ensure: - Marc Demo is a “Project” admin - All projects have “allow_task_dependencies” set to false. This will remove the “Use Task Dependencies” group from Role / User, so the…
Steps to reproduce: - Ensure: - Marc Demo is a “Project” admin - All projects have “allow_task_dependencies” set to false. This will remove the “Use Task Dependencies” group from Role / User, so the order of these steps is important - Add Role / User implies “Use Task Dependencies” - Sign in as Marc Demo and attempt to create a new project from the “Product Launch Campaign” template Description: `_inverse_allow_task_dependencies()` uses `_check_project_group_with_field()` to determine if task dependency features should be enabled/disabled by modifying the `hidden` field on `mail.message.subtype` records (e.g. `mt_task_waiting`). This occurs whenever a project is created from templates. However write access to these records are restricted to admins, so we need elevated permissions when attempting to do so. Without `sudo`, access errors are thrown if non-admin users attempt to create projects under specific scenarios (i.e. when `_check_project_group_with_field()` adds or removes a group from the user base group). The search within `_check_project_group_with_field()` also needs elevated permissions to prevent false negatives. Without `sudo`, this search is restricted by the user's record rules. If the user cannot see the specific projects where dependencies are active, the system may incorrectly assume that no projects use these dependencies, and will forcefully unlink the dependency group from `base.group_user`, breaking the feature globally for all users. Applying `.sudo()` to the subtype modification and the project search ensures standard users can create projects from templates without crashing and prevents the accidental global removal of the dependency group. opw-6099425 Forward-Port-Of: odoo/odoo#258996
This update optimizes a key calculation within the sale_timesheet module, significantly speeding up the process of determining employee timesheet warnings. The previous method was inefficient due to unnecessary data retrieval, but this change uses a more targeted SQL query to filter results, resulting in a substantial performance boost.
Original PR description
Previously, computing warning_employee_rate fetched all analytic lines associated with projects.task_ids to check if any employee lacked a sale_order_line in project.sale.line.employee.map. This…
Previously, computing warning_employee_rate fetched all analytic lines associated with projects.task_ids to check if any employee lacked a sale_order_line in project.sale.line.employee.map. This approach had two major flaws: 1- Iterating over all accessible tasks is highly inefficient for large projects, especially since many tasks do not even have associated analytic lines. 2- Fetching analytic lines blindly by task_id could pull in lines linked to a completely different project_id adding performance issues. **Solution**: Since the compute method for the `project_id` field for the `account.analytic.line` model is making sure that the field `project_id` equal the project for the task, then we can remove the domain matching for the `task_id`. We now can replace the `_read_group` with a simple SQL query, filtering out the unmapped projects directly. The benchmark done below was on a database that had around 10M analytic lines, 2K `project_sale_line_employee_map` records and 1M tasks with the top 80 projects in terms of the number of `analytic.lines` + projects that had the most records in the `project_sale_line_employee_map`. | Before | After | | :--- | :--- | | 33.0s | 170.0ms | Forward-Port-Of: odoo/odoo#260935
This update fixes an issue where taxes were incorrectly assigned to the wrong company due to a change in how the system cached tax information. By partitioning the cache based on company ID, we ensure that taxes are now correctly associated with the appropriate business, improving data accuracy and financial reporting.
Original PR description
Details and steps to reproduce are in Issue #262709 Cause: In #248680 the cache was changed to be global (per cr), meaning it is shared across companies. We need to partition the cache by company_id to prevent the assignment of taxes from the wrong company. OPW-6189579 Forward-Port-Of: odoo/odoo#262779
This update fixes a reporting issue where service reverse charge tax wasn't correctly included in the GSTR-3B reports. Now, journal items related to reverse charge supplies are accurately reported in the designated table, ensuring compliance with tax regulations. This improves the accuracy of financial reporting.
Original PR description
Previously, journal items for import of services with reverse charge tax were shown only in table 4(A)(2) and not in table 3.1(d). However, since table 3.1(d) is meant for supplies liable to reverse charge, those entries should also be reported there. With this commit, import of service reverse charge entries are now correctly included in table 3.1(d) as well. Forward-Port-Of: odoo/enterprise#116708
The Project Gantt view was incorrectly graying out weekends and off-hours for employees with flexible schedules who had no approved leaves. This update corrects a bug where the system wasn't properly accounting for flexible work arrangements, ensuring accurate availability representation in the Gantt view.
Original PR description
Steps to Reproduce --- - Assign a flexible working schedule to an employee (no leaves) - Open Project > Tasks > Gantt view grouped by Assignee - The employee's weekends and off-hours are grayed out…
Steps to Reproduce --- - Assign a flexible working schedule to an employee (no leaves) - Open Project > Tasks > Gantt view grouped by Assignee - The employee's weekends and off-hours are grayed out Current Behavior --- Flex employees with no approved leaves in the viewed date range have incorrect grayed-out days in the Project Gantt view. Expected Behavior --- Flex employees should have no grayed-out days except approved leaves and public holidays. Issue --- When a flex employee has no leaves in the viewed period, `_get_unavailable_intervals()` returns an empty dict for that resource. `_gantt_unavailability()` then falls back to `company_leaves`, producing incorrect gray intervals. The same case is already handled in `planning` (ref PR), but `project_enterprise` was not covered. Fix --- Add a guard in `_gantt_unavailability()` to return no unavailabilities for flexible resources absent from `leaves_mapping`. Related : https://github.com/odoo/odoo/commit/5f1cd39944134ffa2c30c331f8a5daca56446d78 task - 5063071 Forward-Port-Of: odoo/enterprise#113247