Wednesday, May 20, 2026
24 changes · master
Resolved issues and error corrections
Fixes an issue in the HTML editor where selecting all cells in a table header could cause an error and interrupt editing. Users can now work with table headers more reliably without unexpected crashes.
Original PR description
### Steps to Reproduce : - Add a table (e.g., /table). - Turn the first row into table header. - Select all the cells of the table header. - Traceback occurs. ### Purpose of this PR: - Selecting a table header row caused a `Cannot read properties of null (reading 'getBoundingClientRect')` error because the table plugin only looked for `td` elements. This PR replaces hardcoded `td` selectors with the `isTableCell` helper to handle both `td` and `th` elements. task-6220287 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#264670
Closing the full composer after logging a note no longer clears suggested recipients. This prevents users from losing recommended contacts when switching composer views, preserving a smoother communication workflow.
Original PR description
Purpose: -------- Suggested recipients were lost when closing the full composer after opening it to log a note. This happened because the list of suggested recipients is updated when closing the full composer in case the user removed recipients from the full composer view. However, in the case of logging a note, there is no recipient so every suggested recipient was removed. Now, the list of suggested recipients is not updated when the full composer was opened to log a note. Task-6229585
This fix ensures email template subtitles are translated using the correct language when newer system libraries are installed. It prevents customers or users from seeing missing or incorrect translations while keeping support for older supported environments.
Original PR description
In Markupsafe 3.0.0, a refactoring [^1] aiming at simplifying speedups implementation had an impact on the encapsulated templates introduced in commit odoo/odoo@aab7b846cdb8e77701c5e84e81d9c95bd9cd0894. More precisely, the eventual subtitles containing most of the time lazy translation, those were not evaluated in the right context anymore leading to being unable to find the lang to translate into. This commit fixes it by forcing the evaluation of the translation at a point were the context makes sense and contains the right lang when using Markupsafe 3.0.0+ (used in Ubuntu Resolute), while maintaining compatibility with 2.1.5 (used in Ubuntu Noble and Debian Trixie). [^1]: https://github.com/pallets/markupsafe/commit/dcb170b127137880729ac66f03cb590fff562225 Forward-Port-Of: odoo/odoo#264023
This fixes an issue that could block upgrades when the website CRM partner assignment app was installed. The partner list view now applies its activity-related changes in the correct place, improving upgrade reliability without changing business workflows.
Original PR description
The `partner_pages_tree_view` was attempting to modify `activity_ids` field attributes, but this field is added by the mail module in a sibling inheritance branch…
The `partner_pages_tree_view` was attempting to modify `activity_ids` field attributes, but this field is added by the mail module in a sibling inheritance branch ([mail.res_partner_view_tree_inherit_mail]), making it unreachable from the [`partnership.view_res_partner_grade_tree`] ancestry chain:
```py
base.view_partner_tree → partnership.view_res_partner_grade_tree → partner_pages_tree_view
base.view_partner_tree → mail.res_partner_view_tree_inherit_mail ← activity_ids lives here
```
This caused a ParseError during base module upgrade:
```py
File "/home/odoo/odoo/odoo/odoo/tools/convert.py", line 639, in _tag_root
raise ParseError(msg) from None # Restart with "--log-handler odoo.tools.convert:DEBUG" for complete traceback
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
odoo.tools.convert.ParseError: while parsing /home/odoo/odoo/odoo/odoo/addons/base/views/res_partner_views.xml:13
Error while parsing or validating view:
Element '<field name="activity_ids">' cannot be located in parent view
View error context:
{'file': '/home/odoo/odoo/odoo/odoo/addons/base/views/res_partner_views.xml',
'line': 1,
'name': 'Partner Pages List',
'view': ir.ui.view(2148,),
'view.model': 'res.partner',
'view.parent': ir.ui.view(2108,),
'xmlid': 'website_crm_partner_assign.partner_pages_tree_view'}
```
**Steps to reproduce:**
- In a v19.1 db install `website_crm_partner_assign`
- Go to apps and search base module and click upgrade
**Fix:**
Make the partner view from partnership inherit from the one defined in mail instead of the one defined in base.
opw-6186684
[mail.res_partner_view_tree_inherit_mail]: https://github.com/odoo/odoo/blob/saas-19.3/addons/mail/views/res_partner_views.xml#L58C21-L67
[`partnership.view_res_partner_grade_tree`]: https://github.com/odoo/odoo/blob/f3b317310b84edb073009f7d15d7fec002f3ccf0/addons/partnership/views/res_partner_views.xml#L48-L57
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#264639Fixed an issue where weekly accrual plan levels in Time Off could show the wrong weekday after saving, such as displaying Monday when Tuesday was selected. This helps HR users review and configure leave accrual schedules accurately.
Original PR description
**Steps to reproduce:** 1. Install Time Off 2. Go to Accrual Plans and create a new plan with a milestone 3. Set frequency to Weekly and choose a day other than Monday (e.g., Tuesday) 4. Save and…
**Steps to reproduce:** 1. Install Time Off 2. Go to Accrual Plans and create a new plan with a milestone 3. Set frequency to Weekly and choose a day other than Monday (e.g., Tuesday) 4. Save and check the displayed weekday in the accrual plan level **Issue:** The displayed weekday is incorrect (e.g., shows Monday instead of Tuesday). **Cause:** Previously, the weekday value was directly displayed using: https://github.com/odoo/odoo/blob/b40184ab371f7a4708621ecf7f25b4e2daaae38d/addons/hr_holidays/views/hr_leave_accrual_views.xml#L212-L214 so no conversion was involved. Now, the value is processed using Luxon. However, the week_day field stores values from 0 (Monday) to 6 (Sunday), while Luxon expects ISO weekday numbers from 1 (Monday) to 7 (Sunday). This mismatch causes an off-by-one error during conversion. https://github.com/odoo/odoo/blob/1b3d0a3c2f794324f8b230a9ae19f097454e3bdd/addons/hr_holidays/models/hr_leave_accrual_plan_level.py#L54-L62 **Solution:** Adjust the value before passing it to Luxon by adding +1 to match ISO format. opw-6112614 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#259054
This fix keeps the “Add Property” option visible when users move between form pages and resets the property editing button when they switch or create records. It prevents confusing button states, making property management in forms more predictable.
Original PR description
Before this commit: - The “+ Add Property” button was not visible when switching between notebook pages if it was present initially. - when we are doing edit properties from the cog menu and without doing save properties if we are creating new record or switch to other record at that time button still shows “Save Properties.” leading to inconsistent UI behavior. After this commit: - The “+ Add Property” button remains visible when switching between pages. - When in property edit mode, switching records or creating a new record now correctly resets the button state back to “Edit Properties”, ensuring consistent UI behavior. task-6051322 ENT PR: https://github.com/odoo/enterprise/pull/113248 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#265013 Forward-Port-Of: odoo/odoo#258030
Odoo now correctly handles attachment downloads when a filename contains a leading tab character, such as files extracted from ZIP archives. This prevents a browser error that could block users from downloading affected XML attachments from the chatter.
Original PR description
**Steps to reproduce:** * Upload an XML file whose filename starts with a tab character (e.g. extracted from a ZIP that preserves the tab in the filename). * Go to Accounting > Vendor > Bills and import the XML file. * In the chatter, click the attached XML file to download it. **Observed behavior:** * A JavaScript error is raised in the browser console: `TypeError: invalid parameter format` * The file cannot be downloaded. **Cause:** * `PARAM_REGEXP` in `download.js` defines qdtext as `[\x20!\x23-\x5b\x5d-\x7e\x80-\xff]`, which excludes `\x09 (HT/tab)`. * Per RFC 2616, `qdtext = any TEXT` except `"`, and `TEXT` includes `LWS` which includes HT `(\x09)`, making `filename="\ttest.xml"` a valid Content-Disposition header. * The JS parser was incorrectly rejecting a valid header value. **Fix:** * Add `\x09` to the qdtext character class in `PARAM_REGEXP` in `download.js`, making the parser `RFC 2616` compliant. opw-6052996 Forward-Port-Of: odoo/odoo#265176
This fixes a display issue in selection dialogs where the main controls and column headers could scroll out of view. Users can now keep important actions and list headings visible while browsing long lists, making record selection easier and less error-prone.
Original PR description
This commit fixes an issue where the SelectCreateDialog's control panel and list headers would scroll out of view, restoring the intended behavior introduced in https://github.com/odoo/odoo/pull/206433. The feature was inadvertently broken by https://github.com/odoo/odoo/pull/219972, which removed the `overflow: auto` rule from `o_content` elements outside of actions. To resolve this, the `overflow: auto` rule has been explicitly reapplied to the SelectCreateDialog content area. task-6214232 Forward-Port-Of: odoo/odoo#264965
This fix ensures the website keeps handling the new campaign reference parameter correctly when the cookie consent banner is shown. It helps preserve marketing attribution data without disrupting the visitor consent flow.
Original PR description
Since we've added the utm_reference parameter, it should be correctly handled in when the cookies bar is present Added in: https://github.com/odoo/odoo/pull/233963 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#265011
Fixed an issue where archived sales teams and other inactive CRM records appeared in dropdowns when creating an opportunity from a contact. Users can still view archived opportunities where intended, while new opportunity forms now show only active selectable records.
Original PR description
When you open a contact, click the Opportunities smart button, then click New and open the Sales Team dropdown, archived sales teams show up in the list. The same thing happens for the user, tags and…
When you open a contact, click the Opportunities smart button, then click New and open the Sales Team dropdown, archived sales teams show up in the list. The same thing happens for the user, tags and stage dropdowns. Creating an opportunity from the CRM app does not have this issue.
`res.partner.action_view_opportunity` sets `active_test: False` in the action context so archived opportunities show up in the list view. That context is passed down to the form opened from the action, and to every search the form runs to fill its dropdowns. So the dropdowns also return archived records.
The action's domain already has `('active', 'in', [True, False])`, which is enough to keep archived opportunities in the list on its own (the ORM only adds the "active = True" filter when `active` is not already in the domain). So we can just remove `active_test: False` from the context. This is what 18.0 was doing before https://github.com/odoo/odoo/commit/59feed9f26937ae8e2cab5cd7d2b6743ab6c0717 put the context flag back in.
The override in `website_crm_partner_assign` was setting `active_test: False` back on the action context for the same reason (so its extra search for assigned leads picks up archived ones). The flag is now applied locally on the `crm.lead` handle used for those searches, so archived leads are still found without polluting the action's context.
Steps to reproduce:
1. Archive a Sales Team in CRM > Configuration > Sales Teams
2. Open the Contacts app and pick any contact
3. Click the Opportunities smart button
4. Click "New" and open the Sales Team dropdown
=> Archived teams appear in the dropdown
Ticket [link](https://www.odoo.com/odoo/project.task/6134801)
opw-6134801
Forward-Port-Of: odoo/odoo#263283
Forward-Port-Of: odoo/odoo#261300This change stabilizes an automated test for the HTML editor by removing timing-related uncertainty. It helps reduce false failures in the development pipeline, especially on slower test servers, without changing customer-facing behavior.
Original PR description
Description of the issue this PR addresses: Previously the test relied on real timers, animation frames and simulateArrowKeyPress(), making it sensitive to browser scheduling, native selectionchange timing and CPU slowness. The test now: - use advanceTime() instead of real setTimeout() - Replace simulateArrowKeyPress() with manual selectionchange dispatch to make debounce scheduling deterministic and avoid relying on the browser's asynchronous native selectionchange dispatch. - Add patchWithCleanup + verifySteps to test actual debounce execution rather than DOM visibility timing, which is sensitive to rendering and brwoser scheduling variance. This removes timing races and stabilizes the test on slow CI workers. runbot-242466 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#264893
The IoT app's Test button has been corrected so it no longer causes an unexpected error when used. This helps users validate IoT device connections more reliably without encountering confusing system messages.
Original PR description
This PR fixes the following traceback when using "Test" button in the iot app: ``` 2026-05-18 07:48:36,248 22727 ERROR ? websocket: error from callback <bound method WebsocketClient.on_message of <WebsocketClient(Thread-6, started daemon 3995071456)>>: list index out of range 2026-05-18 07:48:36,249 22727 ERROR ? odoo.addons.iot_drivers.websocket_client: websocket received an error: list index out of range ``` opw-6226014 Forward-Port-Of: odoo/odoo#264897
The shared project task timesheet view now correctly highlights negative Time Remaining values in red, matching the label. This makes overdue or overrun time easier for users to spot at a glance.
Original PR description
**Steps to reproduce:** - Open project shared form view. - Go to the Timesheets tab. - Observe the Time Remaining value. **Issue:** - The Time Remaining label is red properly but its value does not becomes red even when the value is negative. **Fix:** - Adjusted the logic to ensure the Time Remaining value is highlighted in red when value is negative **Task-id: 5404009** Forward-Port-Of: odoo/odoo#260996 Forward-Port-Of: odoo/odoo#240489
The website builder's AI-generated content was causing spacing issues due to overly broad rules. This update refines the AI's spacing adjustments, now focusing only on new layout changes and preserving existing snippet styles during content edits. This ensures a cleaner and more consistent website experience.
Original PR description
Snippets added by AI have its elements glued with no proper spacing. The problem is the spacing rule in the builder topic was too broad and implied existing Bootstrap margin or gutter classes should be removed, even when only editing snippet content. Limit the rule to new layout spacing changes and tell the AI to preserve existing snippet structure/classes during content-only edits. task-id-6230199 Forward-Port-Of: odoo/enterprise#117712
This update resolves a crash that occurred when users clicked the 'hide' button on the payroll dashboard. The issue stemmed from in-memory warning records being incorrectly processed, leading to database errors. The fix ensures these warnings are handled correctly, preventing the crash and improving dashboard stability.
Original PR description
Closing date payrun warnings are created as in-memory records (.new()), giving them a NewId instead of a real integer DB id. When the user clicked the hide button, this NewId string was passed to action_snooze/action_archive, causing a psycopg2.errors.InvalidTextRepresentation SQL error. Fix by sending False as the id for in-memory warnings in get_payroll_dashboard_warning_cards, and suppressing the hide button on the dashboard when warning.id is falsy. task-6205849
A bug was causing a 'Create Ticket' action to appear unexpectedly in the WhatsApp sidebar. This commit removes this action, resolving a technical issue that prevented users from accessing the WhatsApp feature as intended. This ensures a smoother and more reliable experience for WhatsApp conversations.
Original PR description
The 'Create Ticket' action was incorrectly visible in the sidebar actions of WhatsApp conversations in Discuss. Clicking it caused a traceback because `owner.root` is not defined in the sidebar action context. This commit removes the action from sidebar actions. Task-[6220037](https://www.odoo.com/odoo/project/1519/tasks/6220037) Forward-Port-Of: odoo/enterprise#117571
This update adjusts the default date range for the Lead and Pipeline dashboards to 'Last 30 days'. This change provides users with a more relevant and current view of their sales data, making it easier to analyze recent performance and trends. It resolves a previous issue where the default date range was not consistently set.
Original PR description
This commmit fixes the date filter default value to `Last 30 days`. Task: 5902231 Forward-Port-Of: odoo/enterprise#114560
This update resolves an issue where long events were incorrectly marked as 'all-day' events. The change ensures that event data is accurately interpreted, preventing scheduling errors and improving the reliability of the appointment calendar. This improves the overall user experience for managing appointments.
Original PR description
fcEventToRecord is updated in web calendar to take an additional "oldEvent" parameter when creating record values from an update. This is used to distinguish between an event becoming an allday vs an event that appears as allday but actually is not. task-6033474
This update fixes a UI inconsistency in the worksheet property editor. Now, the "Add Property" button remains visible while editing and correctly resets to "Edit Properties" when switching records or creating new ones, ensuring a smoother and more reliable user experience. This resolves a previous issue where the button's state was confusing.
Original PR description
Before this commit: - The “+ Add Property” button was not visible when switching between notebook pages if it was present initially. - when we are doing edit properties from the cog menu and without doing save properties if we are creating new record or switch to other record at that time button still shows “Save Properties.” leading to inconsistent UI behavior. After this commit: - The “+ Add Property” button remains visible when switching between pages. - When in property edit mode, switching records or creating a new record now correctly resets the button state back to “Edit Properties”, ensuring consistent UI behavior. task-6051322 Forward-Port-Of: odoo/enterprise#117614 Forward-Port-Of: odoo/enterprise#113248
This update ensures that all text within the MRP MPS component of Odoo Enterprise is properly prepared for translation. Previously, placeholder text was not translatable, limiting the system's ability to support multiple languages. This change improves the localization capabilities of the module.
Original PR description
Forward-Port-Of: odoo/enterprise#117750
This update optimizes a key query in the sales commission reporting process. By removing an unnecessary bit shift, the system now handles significantly larger sales commission data, expanding its capabilities and avoiding potential limitations. This change improves report generation speed and accuracy.
Original PR description
The combined query for sale.commission.achievement.report originally performs several bitwise shifts, starting with the max AML ID. This is done to create a composite number ID for the combined IDs.…
The combined query for sale.commission.achievement.report originally performs several bitwise shifts, starting with the max AML ID. This is done to create a composite number ID for the combined IDs. `MAX(aml.id)::bigint <<20) | max(rules.id)::bigint <<10 | rules.user_id <<10` This shifts the max aml.id 40 bits to the left. Example: Let's say MAX(aml.id) = 1; we will set the other variables to 1, as they often have little impact on the total size of the number. 1 << 20 = 1048576 1048576 | 1 = 1048577 1048577 << 10 = 1099512676352 1099512676352 | 1 = 1099512676353 1099512676353 << 10 = 1152922604119523328 With this format, the highest guaranteed AML ID this query can handle is under 838,861. The last 10-bit shift is unnecessary and increases the result. If we remove the last shift, the AMD ID this query can handle becomes much higher. `MAX(aml.id)::bigint <<20) | max(rules.id)::bigint <<10 | rules.user_id` | | AML Max | RULES.ID Max |RULES.USER_ID Max| | --------------------- | ------ | ------ | ------ | | Before | 838,861 | 1,048,576 | 1,024 | | After | 858,993,459 |1,048,576 | 1,024| opw-6124026 Forward-Port-Of: odoo/enterprise#114711
This update corrects a visual inconsistency in the project timesheet display. Previously, the 'Time Remaining' value wasn't highlighted in red when negative, even though the label was. This fix ensures that negative time remaining values are correctly displayed with a red color, improving clarity and accuracy for users.
Original PR description
**Steps to reproduce:** - Open project shared form view. - Go to the Timesheets tab. - Observe the Time Remaining value. **Issue:** - The Time Remaining label is red properly but its value does not becomes red even when the value is negative. **Fix:** In hr_timesheet, the remaining_hours field has a decoration-danger applied In sale_timesheet_enterprise, this field is overridden as portal_remaining_hours So, Added the corresponding decoration-danger on portal_remaining_hours. task-5404009 Forward-Port-Of: odoo/enterprise#114836 Forward-Port-Of: odoo/enterprise#113632
This update clarifies the labels for vehicle deductibility rates within the Enterprise module. The previous labels were inaccurate, representing the deductible portion instead of the non-deductible amount. This change ensures accurate reporting and financial calculations related to vehicle expenses.
Original PR description
The "Deductibility Rates" and "Deductibility (%)" labels are wrong for vehicles as they are supposed to represent the non-deductible part. This commit fixes these labels. task-6121629 Forward-Port-Of: odoo/enterprise#116878
This update corrects a bug where merging duplicate records caused multiple XML IDs to point to the same master record, compromising the system's ability to uniquely identify data. The fix ensures that each record has a single, unique XML ID, maintaining data integrity and reliability. This resolves a potential issue with data tracking and reporting.
Original PR description
When merging duplicate records, the merged record's XML ID was moved onto the master. Since the master already had its own XML ID, it ended up with several XML IDs pointing at it, breaking the assumption that an XML ID is a unique identifier for a single record. task-6186726