Saturday, August 29, 2026
41 changes · master
Resolved issues and error corrections
When an X (Twitter) account token becomes invalid, Odoo now disconnects the account instead of showing a generic error while refreshing the feed. This reduces confusion for social media users and helps them reconnect the account to restore the feed.
Original PR description
Bug === If the token because invalid, then an UserError is raised instead of disconnecting the account. This is because we "blind raise" all errors we get from X, instead of filtering the error linked to the stream configuration. Task-6499283 Forward-Port-Of: odoo/enterprise#129560 Forward-Port-Of: odoo/enterprise#129110
This fix keeps the appointment page controls properly sized when editing the website, preventing a dropdown button from appearing squeezed. It also hides an unnecessary loading indicator in editor mode, making the page easier and cleaner to configure.
Original PR description
Introduced in [1], and in a series of related changes, the time selection page has been reworked to be managed more from the JS, using the Interaction benefits. The entity selection is now a custom dropdown, handled in the JS. When editing the page with the website editor, the button is squashed, because no content is rendered inside. This is not the case for other ones as either a select element, either have a t-out dynamic content that will still instanciate some content at loading. Therefore, instead of meddling with a complex JS, add some simple styling to make sure the element has a consistent height. Also, hide the loader when editing the page in a similar way. [1] odoo/enterprise@a5712d284a87af7530f186ecad765d2cfaf1f9d2 Task-6482389 Forward-Port-Of: odoo/enterprise#129646
This fixes an issue where color labels used outside the color picker could lose their intended styling, such as resource colors in Planning configuration. The change makes color styling consistent across screens and display modes, improving visual clarity for users.
Original PR description
The `o_colorlist_item_color_*` classes were scoped to `.o_colorlist > button` by 1aa9b957afdd , but they are also used standalone outside any colorlist, e.g. in Planning's `many2one_avatar_resource` field. `web_enterprise`'s dark-mode counterpart also defines them unscoped, so the two stylesheets disagreed. Move the color rules back to the root scope. The colors themselves and the `color-contrast()` text color introduced by the refactoring are kept. Steps to reproduce: - Go to "Planning" - Open "Configuration" => the resources in the "Resources" column. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#283821 Forward-Port-Of: odoo/odoo#283232
This update fixes a failing automated guided test for the Knowledge calendar by switching it to the newer standard text entry method. It helps keep quality checks reliable and removes reliance on an outdated helper that is no longer used.
Original PR description
[Related PR 1] modified `editSelectMenuInput` to use the standard 'edit' action instead of a custom action, and moved several tours off of the helper function, but missed the knowledge calendar tour. In combination with [Related PR 2] which changed the conditions of editing a select input to not include the intial 'click' action, causes this tour to now fail to properly input the text value. This commit fixes this issue by using the new standard approach with the 'edit' action. Since there are no tours which make use of `editSelectMenuInput`, it is also deprecated and to be removed in master. Related PR 1: https://github.com/odoo/odoo/pull/264913 Related PR 2: https://github.com/odoo/odoo/pull/266912 runbot-941336 Forward-Port-Of: odoo/enterprise#128462
This update prevents barcode EPC generation from failing when tracked and untracked stock move lines are processed together. It keeps valid tracked items aligned correctly and gives untracked items a clear error instead of causing broader list-view failures.
Original PR description
Problem: `_compute_electronic_product_code` built `tracking_number_list` by filtering out move lines without a lot_id/lot_name, but kept iterating over the full, unfiltered `move_line_ids`. As soon…
Problem: `_compute_electronic_product_code` built `tracking_number_list` by filtering out move lines without a lot_id/lot_name, but kept iterating over the full, unfiltered `move_line_ids`. As soon as a tracked product had an untracked move line mixed in with tracked ones (e.g. a manufacturing byproduct move line with no lot), the two lists fell out of sync: at best tracking numbers got assigned to the wrong move line, at worst `tracking_number_list[i]` went out of range and raised an IndexError. Solution: Exclude untracked move lines from `move_line_ids` before building `tracking_number_list`, so both stay the same length and index- aligned. Untracked lines get their own explicit "no tracking number" error instead of breaking the alignment for the rest. Steps to reproduce: Open runbot V19 -> go to moves history (Inventory) -> add `electronic_product_code` to list view using studio -> remove filter/select all records -> https://anotepad.com/notes/jwxyskc2 Forward-Port-Of: odoo/enterprise#128521 Forward-Port-Of: odoo/enterprise#123859
Website helpdesk forms now keep the translations from the original form template. This ensures customers see the form in the website or visitor language, instead of the language used by the employee who created the helpdesk team.
Original PR description
When a helpdesk team has its website form enabled, a dedicated qweb view is generated from the `ticket_submit_form` template. The arch was read in the language of the user creating or editing the…
When a helpdesk team has its website form enabled, a dedicated qweb view is generated from the `ticket_submit_form` template. The arch was read in the language of the user creating or editing the team, so a team set up by an English user language produced an English form even when the website served another language. Steps to reproduce ================== 1. Set a language other than English as the website default language. 2. While your user language is English, create a helpdesk team with the website form enabled. 3. Open the team form on the website. => The form is rendered in English instead of the website language. Root cause ========== `_ensure_submit_form_view` read the template arch without forcing a language, so it used the current user's language and stored only that value on the generated per-team view. Fix === Read the template arch in the default language of the team's website, so the generated form matches the website language regardless of the user's own language. opw-6303903 Forward-Port-Of: odoo/enterprise#129265 Forward-Port-Of: odoo/enterprise#121164
Fixed an issue in the Sign app related to user group handling. This helps ensure the right access or grouping behavior is applied when users work with signing features.
Original PR description
opw-6518598 Forward-Port-Of: odoo/enterprise#129647
This fixes an error that could block website editors from saving SEO cover images when unrelated expense attachments existed in the system. The change keeps attachment checks focused on the selected file, avoiding unnecessary access checks on records the user should not see.
Original PR description
### Issue: A user with Website Editor rights but no Accounting or Expense access gets an `AccessError` when using Optimize SEO to add a cover image, if another user has an expense with an attachment…
### Issue:
A user with Website Editor rights but no Accounting or Expense access gets an `AccessError` when using Optimize SEO to add a cover image, if another user has an expense with an attachment
### Steps to reproduce:
- Install `ai` and `hr_expense`
- With Admin, upload an image as an expense
- Update Demo user rights (Accounting: No, Expenses: No, Website: Editor and Designer)
- Log in as Demo
- Go to Website > Site > This page > Optimize SEO
- In Cover Image, add any image, select it and save
Before the fix, an `AccessError` is raised
### Cause:
When Save is triggered, `ai.attachment.vacuum.mark_attachments_used()` is called with the outer domain:
`[('attachment_id', 'in', [3868])]`
The `ai.attachment.vacuum` security rule uses:
`domain_force = [('attachment_id.res_access_write', '=', True)]` https://github.com/odoo/enterprise/blob/474ee25f82a3980530aae4c3450c69d925b6076e/ai/security/security.xml#L1-L24
During optimization, the dotted path is decomposed into an `any` condition:
`('attachment_id', 'any', [('res_access_write', '=', True)])` https://github.com/odoo/odoo/blob/dcb9ad42ba302a5ed0ec334daf4c8a4cb5ec0931/odoo/orm/domains.py#L999-L1004
`_optimize_any_domain_at_level` tries to narrow the comodel scan by reusing the outer constraint on `attachment_id` via `search_domain` in context
It finds `c` where `c.field_expr == 'attachment_id'`, but `c.value` is `{3868}` — a plain set of ids, not a `Domain`
Since the code only recognized `Domain` values, it treated this as unknown and fell back to `comodel_domain = Domain.TRUE`
`_search_res_access` for `ir.attachment` then scanned every attachment using:
`['&', ('res_model', '!=', False),
'|', ('res_id', '!=', False), ('create_uid', '!=', 5)]`
This matches a lot of attachments because the initial `attachment_id` constraint is missing
This scan included an attachment linked to an expense the current user cannot read
`_inaccessible_comodel_records` in `hr_expense` then checked all expenses linked to the found attachments and raised the `AccessError`
This fallback also triggers a second failure when the database contains more than 10 000 attachments: `_search_res_access` caps its unbounded scan at `MAX_SEARCH_LIMIT` and raises `ValueError("Cannot search, too many attachments")`
Confirmed by seeding ~10 500 attachments and reproducing the error
### Notes:
A new test in `test_any_domain_search_context.py` verifies in isolation that unrelated attachments are never scanned when a plain `in` condition narrows the search
opw-6467087
Forward-Port-Of: odoo/odoo#285384
Forward-Port-Of: odoo/odoo#284678A test workflow for Knowledge calendar editing was updated to use the current standard editing behavior. This helps keep automated checks reliable and prevents false failures during product validation.
Original PR description
[Related PR 1] modified `editSelectMenuInput` to use the standard 'edit' action instead of a custom action, and moved several tours off of the helper function, but missed the knowledge calendar tour. In combination with [Related PR 2] which changed the conditions of editing a select input to not include the intial 'click' action, causes this tour to now fail to properly input the text value. This commit fixes this issue by using the new standard approach with the 'edit' action. Since there are no tours which make use of `editSelectMenuInput`, it is also deprecated and to be removed in master. Related PR 1: https://github.com/odoo/odoo/pull/264913 Related PR 2: https://github.com/odoo/odoo/pull/266912 runbot-941336 Forward-Port-Of: odoo/odoo#283328
Point of Sale managers can now open payment method settings without running into an access error. The change gives POS managers the read access needed for online payment provider information while keeping the field hidden from users without the right roles.
Original PR description
Only admin users have read access to the `payment.provider` model. Opening the PoS payment method form as a non-admin would raise an access error because the `online_payment_provider_ids` many2many field tries to fetch `payment.provider` records on form load. Grant read-only access on `payment.provider` to `group_pos_manager` so POS admins can use the field. Restrict the field's group in the form view to `point_of_sale.group_pos_manager,base.group_system` so it is not rendered for users without either role. opw-6208656 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#278792 Forward-Port-Of: odoo/odoo#263837
This fixes an error that prevented sale timesheet reports from being printed when using German or other translated languages. The report now identifies the description column in a language-independent way, making printing more reliable for multilingual users.
Original PR description
Currently a traceback is occurring when the user tries to print a sale timesheet report in the German language. **<h3>To reproduce the issue:</h3>** 1) Install the `sale_timesheet` module. 2) Create…
Currently a traceback is occurring when the user tries to print a sale timesheet report in the German language. **<h3>To reproduce the issue:</h3>** 1) Install the `sale_timesheet` module. 2) Create a `service` product configured to create a `project and task` on the order. 3) Create a confirmed SO with that product 4) Add a timesheet line to the SO from the `Recorded` stat button 5) Switch to the German language 6) Print `Timesheet(Zeiterfassung)` report 7) A traceback occurs **<h3>Error:</h3>** ``` ValueError: Element „<xpath expr="//th/span[text()='Description']">“ kann nicht in der übergeordneten Ansicht lokalisiert werden ``` **<h3>Cause:</h3>** The xpath relies on the plain text `Description` to identify the `<th>` element. https://github.com/odoo/odoo/blob/5f63fb1af418cc75ff2e382b0455002e7a798071/addons/sale_timesheet/report/report_timesheet_templates.xml#L3-L4 The xpath cannot find the Description header when the language is changed because the text is translated in the base template. As a result, the xpath fails due to the missing target. **<h3>Fix:</h3>** Use a language-independent `name` attribute as the `xpath` anchor. So the `Description` column can be reliably matched regardless of the active language. **<h3> Note:</h3>** This fix requires both modules update, which is generally risky in stable branches. However, this template was recently introduced in [saas-19.4](https://github.com/odoo/odoo/pull/191969/changes#diff-9f4f0d28ffb3aa9fcc4a5f1037bdf532e1e71c4e9703e13b6856ddfd79e15e69R4). So there should be no existing customers using it yet, except saas customers coming from a new database. Therefore, applying this fix in 19.4 is less risky. opw- 6475623 Forward-Port-Of: odoo/odoo#284096
This update replaces an older loop style with the preferred clearer wording in several core areas. It helps keep the codebase aligned with automated quality checks, reducing maintenance friction without changing user-facing behavior.
Original PR description
Ruff checks on runbot flagged `while 1:` Preferred syntax is to use `while True` [UP048](https://docs.astral.sh/ruff/rules/while-one) runbot-945983 Forward-Port-Of: odoo/odoo#284900 Forward-Port-Of: odoo/odoo#283962
Tax returns will no longer be incorrectly marked as paid when someone replies to or sends a normal chatter message. Payment finalization now only happens from the intended tax payment instructions flow, preventing accidental status changes and reducing accounting confusion.
Original PR description
Before this fix: Replying to or sending a message from the chatter of a tax return could incorrectly change its state to Paid. This happened because action_send_mail() automatically called _action_finalize_payment() for account.return records. After this fix: Payment finalization only happens when the composer is opened from the tax payment instructions flow. Normal chatter messages and replies will no longer change the tax return state to Paid. task-6469536 Forward-Port-Of: odoo/enterprise#129161
Bank payment XML files now use uppercase encoding labels to satisfy stricter validation by some banking providers, such as SIX in Switzerland. This reduces the risk of warnings or rejected payment files when exchanging data with banks.
Original PR description
The W3C recommendations for XML state that the encoding defined for an XML document should not be case-sensitive. However, some banking providers (SIX for Switzerland) are stricter and may throw warnings or errors if upper-case is not used. https://www.w3.org/TR/2008/REC-xml-20081126/#NT-EncodingDecl opw-4948708 Forward-Port-Of: odoo/enterprise#129596 Forward-Port-Of: odoo/enterprise#125807
This fixes a dark mode display issue in the Point of Sale where some search and form fields could show dark text on a dark background. POS users can now read and enter information reliably when working in dark mode, reducing confusion during sales or restaurant operations.
Original PR description
**Description of the issue/feature this PR addresses:** When using the POS in dark mode, certain form control elements display black text on a dark background, making them illegible. This occurred…
**Description of the issue/feature this PR addresses:** When using the POS in dark mode, certain form control elements display black text on a dark background, making them illegible. This occurred because the POS application lacked the `color-scheme` CSS property. While the backend web client correctly applied this property, its absence in the POS meant the browser still assumed a light theme, forcing default User Agent styles (black text) onto native form controls that escaped standard view helpers. This commit resolves the issue by applying the `$o-webclient-color-scheme` variable to the POS application. This signals the browser to render form controls and UI elements based on the current web client color scheme, ensuring text remains legible within the POS app. **Steps to reproduce:** - POS > Open Restaurant Register - Hamburger icon (top right) > Switch to Dark Mode - Register > vertical ellipses icon (bottom left) > Quotation/Order > type in the search bar > observe black text on dark grey background **Current behavior before PR:** <img width="1911" height="588" alt="Before 1" src="https://github.com/user-attachments/assets/99581745-23eb-45e1-96f7-bca78853369c" /> <img width="1919" height="550" alt="Before 2" src="https://github.com/user-attachments/assets/b7eb9726-e2d2-492b-ad2b-6c0cc6613bb8" /> **Desired behavior after PR is merged:** <img width="1910" height="433" alt="After 1" src="https://github.com/user-attachments/assets/419b7a2a-234e-47c8-854e-22adf6a7c5c1" /> <img width="1915" height="513" alt="After 2" src="https://github.com/user-attachments/assets/8f1cf5c9-5ad1-4aac-9879-840d6d9d537e" /> opw-6508945 Forward-Port-Of: odoo/odoo#284831
Point of Sale settings now keep all employees added to Advanced rights when saving configurations that also use employee login and delivery integrations. This prevents selected staff from disappearing after save, so access permissions remain as intended.
Original PR description
Steps to reproduce ------------------ 1. Go to the Point of Sale settings and select a shop. 2. Enable UrbanPiper and set a delivery provider. 3. Enable "Log in with Employees". 4. Add two employees…
Steps to reproduce ------------------ 1. Go to the Point of Sale settings and select a shop. 2. Enable UrbanPiper and set a delivery provider. 3. Enable "Log in with Employees". 4. Add two employees to the "Advanced rights" field. 5. Save. Observation -> Only the employee of the PoS manager is left, the two employees are gone. Why it's happening ------------------ When saving from the settings, `pos.config` is written with the context key `from_settings_view`, which tells `_preprocess_x2many_vals_from_settings_view` that the commands received for an `x2many` field are the complete new list, so every record not in these commands is unlinked. The `write` of `pos_hr` always puts `advanced_employee_ids` in the values, even when the caller does not write this field, to keep the employees of the PoS managers in the list (1766d6d40a45). Since b48ddcce7bf in enterprise, UrbanPiper writes on the config a second time during the same save, still with `from_settings_view`. That write does not touch the employees, so `pos_hr` fills `advanced_employee_ids` with the managers only (cf 1766d6d40a45), and the ones that were just saved are unlinked. The fix ------- When `pos_hr` adds the field by itself, keep the employees already set on the config instead of starting from an empty list. opw-6500207 Forward-Port-Of: odoo/odoo#284961
This fixes an automated Knowledge calendar walkthrough that could fail when creating or editing calendar item properties. The change helps keep quality checks stable so future updates can be validated more reliably.
Original PR description
In `knowledge_calendar_command_tour`, we were experiencing two issues 1. First, when we change the properties of a new calendar item, we were running into an issues where the tour would fail due to…
In `knowledge_calendar_command_tour`, we were experiencing two issues 1. First, when we change the properties of a new calendar item, we were running into an issues where the tour would fail due to not being able to locate the dropdown option to create a new property. This only occurs if you don't set a step delay on the tour. This happens because in the `editSelectMenuInput` helper, we first check if the dropdown is open bfore we proceed. Since the tour runs so fast, we detect that the dropdown for the first property is open, so we pass the check. However, this then closes since we've moved on to the next dropdown, and since nothing has been input into the next dropdown, the create option doesn't appear. Now, we ensure that the create option will be present before attempting to click it 2. Later in the tour, we attempt to edit the properties on a new calendar item. We previously used `edit` to edit the property name, however this resulted in the "Select a template" modal being opened, which broke the tour, since we needed to click elements behind it. Using `fill` instead to populate the text field doesn't produce this behavior, allowing the tour to proceed without error. [runbot-939647](https://runbot.odoo.com/odoo/error/939647?debug=assets) Forward-Port-Of: odoo/enterprise#128830
The inventory report now prints with aligned columns and complete table borders when locations are grouped. This prevents confusing or unprofessional-looking PDF reports after warehouse inventory counts.
Original PR description
When new columns were added to the stock inventory report, the location grouping row was not updated. This results in mismatched column counts, causing missing gridlines and broken borders in the PDF output Fixed by ensuring the location row's column count matches the header <img width="603" height="200" alt="image" src="https://github.com/user-attachments/assets/86872bee-f315-4bdd-b3f2-a525e3bb5fe0" /> ### Steps to reproduce: - Ensure warehouses are activated in the settings - Go to Barcode -> Count Inventory - Add a Product - Select the gear Icon then "Print Inventory" - You will notice that the location row has missing gridlines opw-6307728 Forward-Port-Of: odoo/odoo#275918
Fixed the Real Margin report so that drilling into pivot results opens the standard analytic entries list instead of the timesheet list. This preserves expected navigation for project margin analysis and gives users access to the right detail records from the report.
Original PR description
**Steps to reproduce:** 1. Open a project. 2. Click on the Real Margin stat button or top menu action. 3. The pivot view opens by default. 4. Click on a cell in the pivot view to drill down into the list view. **Issue:** The system opens the timesheet list view instead of the standard analytic entries list view. **Cause:** Overwriting action['views'] erased the default list view, causing to fall back to the timesheet view during drill-down. **Fix:** Used a list comprehension to inject the custom pivot view while preserving the original view types. Added all view options to the Real Margin top bar. task-6192267 Forward-Port-Of: odoo/odoo#270494
This fixes an intermittent issue in an automated CRM forecast check by ensuring the system waits until an opportunity is fully marked as won before moving on. It helps keep internal quality checks stable and reduces false failures during release validation.
Original PR description
The crm_forecast tour is red randomly on runbot on the Won banner step. We click the won button and go back directly, so the kanban can be loaded before the lead is won. Now we wait for the ribbon first. runbot-242139 Forward-Port-Of: odoo/odoo#284721
New onsite learning events created from the Onsite view or an employee resume now appear immediately after creation. The update relaxes the visibility rules and automatically links the current user's employee record, reducing confusion and duplicate event creation.
Original PR description
Onsite events created from the "Onsite" view or the employee resume selector do not appear immediatlely after creation This occurs because currently the domain for onsite events requires that the…
Onsite events created from the "Onsite" view or the employee resume selector do not appear immediatlely after creation This occurs because currently the domain for onsite events requires that the event to have multiple slots as well as to have at least one employee registered to it. Therefore, newly created records often fail these criteria and remain hidden. In further versions, this pr: https://github.com/odoo/odoo/pull/246285/ changes the domain of the event selector in the employee resume by removing the dependency on the multiple slots and filtering by the specific employee for registration. This change is not stable to backport as it indroduces the `employee_id` field as an invisible field in the xml to be able to compare in the domain. This commit partly changes both domains to not require the multiple slots anymore, while still showing all events for which an employee is registered. This commit also ensures that when an event is created from the Onsite view or selector, the current user's employee will be registered to it. Steps to reproduce - Go to employees->Learning->Onsite - Select New and create an event - Go back to Onsite Courses - You will not see the created event (unless it is multi_slot and an employee was registered) opw-5915686 Forward-Port-Of: odoo/odoo#284200 Forward-Port-Of: odoo/odoo#258952
Fixes an issue where confirming a sales order again after cancellation could fail to create the expected event registration. This helps ensure customers who re-confirm event orders are properly registered, including through portal or preview flows.
Original PR description
**Steps to reproduce:** - Create a SO and add the Event Registration - Standard product and specify an event - Confirm the SO then select "Create/Update registrations" - Cancel the SO, then "Set to…
**Steps to reproduce:** - Create a SO and add the Event Registration - Standard product and specify an event - Confirm the SO then select "Create/Update registrations" - Cancel the SO, then "Set to Quotation" - Select "Preview" and confirm the Sale Order again - There will not be any new registration created when there should be one. **Behavior:** Usually when a sale order is confirmed the `action_sale_order_event_registration` form will be opened which when filled correctly creates registrations. However in certain cases: confirming from the customer portal, or simply closing the form when it is opened, will not trigger `action_make_registration` which creates registrations if it is not already the case `action_confirm()` should be creating the registrations correctly on its own anyway by calling ´init_registrations()´ : https://github.com/odoo/odoo/blob/beed378cde592bc96c1e79a976ac775264b843ed/addons/event_sale/models/sale_order_line.py#L49-L66 This function tries to create each missing registrations by looking at the amount in the so_line and deducting the already created registrations, however since some of them can be cancelled, this computation is wrong. And leads to registration not being created when they should. opw-6444127 Forward-Port-Of: odoo/odoo#280426
This fix prevents Belgian payroll paid time off allocation from failing when an employee has no work schedule available. It adds a safety check and tests so the payroll process handles missing calendar data more reliably.
Original PR description
. Add check for the resource calendar before calling _get_days_per_week_for_period() method . Add corresponding tests task-6479161 Forward-Port-Of: odoo/enterprise#128319
The project margin grid view has been corrected so the real margin top bar displays updated information as intended. This helps sales and project users review profitability figures more clearly and consistently.
Original PR description
- update the grid view in project real margin top bar task-6192267 Forward-Port-Of: odoo/enterprise#122586
This fixes an issue where manually adjusted prices on optional quotation items could be overwritten when a customer changed the quantity in the portal preview. Sales teams can now trust that custom prices remain as intended while still allowing standard pricelist updates when no manual price was set.
Original PR description
When a user manually sets a price on an optional line (overriding the pricelist), and then changes the quantity in the portal preview, the manual price is lost and gets reset to the pricelist price.…
When a user manually sets a price on an optional line (overriding the pricelist), and then changes the quantity in the portal preview, the manual price is lost and gets reset to the pricelist price. Steps to reproduce: --- - Install Sales module and enable Pricelists. - Create a product with qty-based pricelist rules: - min qty: 1 → price: 100 - min qty: 10 → price: 80 - Create a quotation with an optional section containing this product. - Manually change the product price to 150 (overriding pricelist). - Mark the section as optional and preview the quotation. - Change the quantity to 10 in portal preview. Issue: --- - The manually set price (150) is incorrectly reset to the pricelist price (80). Root cause: --- - After [commit], if there is no config parameter set and if there is an active pricelist, we simply call `_reset_price_unit()` without checking whether the price was manually set or not. - Additionally, `_reset_price_unit()` calls `update()` which writes `price_unit` and `technical_price_unit` one by one as separate `write()` calls. The `write()` method has a guard([1]) that strips a lone `technical_price_unit` write unless `sale_write_from_compute` is set in context. Without this flag, `technical_price_unit` is silently discarded, causing it to drift from `price_unit`. On the next qty change, this mismatch is detected as a manual price, permanently blocking further pricelist updates. Solution: --- - Check whether the price was manually set before calling `_reset_price_unit()`, and pass `sale_write_from_compute=True` in context so both `price_unit` and `technical_price_unit` are written correctly. [commit]: https://github.com/odoo/odoo/commit/93b6bdd6a4909bc0b45b90ab6a2d0734a218292d [1]https://github.com/odoo/odoo/blob/fffd987cc98d1ea0cd04e24dda2ed8b64a219cdc/addons/sale/models/sale_order_line.py#L1391-L1399 opw-6426634 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#285212 Forward-Port-Of: odoo/odoo#281107
Closed or renewed subscriptions will no longer incorrectly appear in Orders to Invoice because prepaid recurring lines are cleared when billing should stop. Postpaid lines remain invoiceable where needed, so delivered products can still be billed after closure.
Original PR description
When a closed subscription could still show up in the Orders to Invoice because its recurring lines kept their "to invoice" status. This was misleading since no further period should be billed. When a subscription is churned (or renewed), prepaid lines are now flagged as nothing to invoice. Postpaid lines are left as is so that already delivered products can still be billed after closing. task-6227787 Forward-Port-Of: odoo/enterprise#117797
Project settings forms now align section headings more consistently and let setting descriptions use the available space before wrapping. This makes project-related configuration screens easier to read and reduces visual clutter for users.
Original PR description
In the project form settings: - The sections that sit on the same horizontal level should have their header aligned. - Settings description should use all the horizontal space available before wrapping to the next line Task-6360046 Forward-Port-Of: odoo/odoo#284771
This fixes a problem that could stop PDF quotes from being generated when Quote Builder documents included dynamic fields. Sales teams can now print these quotes without encountering an error in affected Python and PDF library setups.
Original PR description
Issue: --- Due to this issue, generating PDF Quote using Quote Builder with dynamic fields leads to a traceback. This was partially fixed by: e16edc7b0d9f56cb7769068ecf7d64ff8b0f6359 Steps: --- 1-…
Issue: --- Due to this issue, generating PDF Quote using Quote Builder with dynamic fields leads to a traceback. This was partially fixed by: e16edc7b0d9f56cb7769068ecf7d64ff8b0f6359 Steps: --- 1- Using a python 3.13 env, install requirements.txt. (You could instead uninstall pypdf2 and install pypdf==5.4.0) 2- Enable Quote Builder. 3- Create a SO and in quote builder tab, select a document. This document should have dynamic fields. e.g. you could use`Office Furnitures Header` document. 4- Print -> PDF Quote. Cause: --- In previous fix, we fixed the traceback when no dynamic field is set. However, if you have a dynamic field, then inside `PdfWriter._update_field_annotation()`, the font is get from `DR` dict inside acroform: https://github.com/py-pdf/pypdf/blob/f20954f2241640feb484800e191373f8fbdfa44b/pypdf/_writer.py#L917-L929 Even if we are not setting a font, we need to have an empty `DR` dict inside acroform, in order to avoid calling `get` on a none object, which is leading to the traceback. Also in previous fix we were losing `NeedAppearances` inside `AcroForm` by creating new dict which wasn't right. opw-6392001 Forward-Port-Of: odoo/odoo#278881
Checkout now checks whether an invoicing step is required for each shopper individually instead of relying on a shared published state. This prevents customers from skipping required Taiwanese e-invoice details by going directly to payment and avoids one visitor's checkout state affecting another's.
Original PR description
Commit 1facbc0646bd made the checkout validate every `website.checkout.step` through a single flow, but the localization invoicing steps were left out. These steps are shown or hidden by publishing…
Commit 1facbc0646bd made the checkout validate every `website.checkout.step` through a single flow, but the localization invoicing steps were left out. These steps are shown or hidden by publishing or unpublishing a shared step record on each checkout. This is unreliable: the cart and payment pages don't refresh it, so the step can be left in the state set by another visitor. The step is also only validated when the visitor goes through it, so opening `/shop/payment` directly skips it. An override also forces `try_skip_step` off so the checkout page cannot jump past the step. This commit filters the invoicing step out of the breadcrumb steps domain per request when it is not needed, instead of toggling the shared record. The cart is passed to the breadcrumb helpers and their cache is removed so the filter runs for each visitor. The Taiwanese step is now checked by the validation flow, so opening `/shop/payment` redirects back to it while incomplete. The checkout page now jumps to the next step, which is the invoicing step when required, so forcing `try_skip_step` off is no longer needed. task-6045788 See also: - https://github.com/odoo/enterprise/pull/124616 - https://github.com/odoo/upgrade/pull/10806
Employee forms now only allow eligible users with the required employee access rights to be selected as time off or attendance managers. This prevents low-access users from being assigned manager responsibilities they should not have.
Original PR description
Before this commit, even light users with no access rights could be selected as time off or attendance managers on employee forms. By design, a light user shouldn't be selectable, and even regular users should require a specific access right. We restricted the domain of the leave manager field so that only users who possess the "User" or "Administrator" role and the "Employees" access right (or higher) can be selected. We did the same change for the attendance manager field. Task-6498276 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Time Off app now correctly finds time types when users search by their code. This removes a redundant app-specific search setup so the app uses the shared search behavior that already supports code searches.
Original PR description
Prior to this commit, searching for a time type by its code in the Time Off app yielded no results. This occurred because `hr_holidays` maintained its own search view (`view_holidays_status_filter`), which lacked the code filtering present in `hr_work_entry`. Since filtering on `create_calendar_meeting` is no longer needed, this view is entirely redundant. This commit removes `view_holidays_status_filter` so that `hr_holidays` falls back on the base search view from `hr_work_entry`, which already handles searching by code. Task: 6502422
This fixes an internal point-of-sale loyalty test so expired gift cards are consistently recognized as expired regardless of timezone. It helps prevent false test failures and keeps quality checks reliable without changing customer-facing behavior.
Original PR description
In the test "test_physical_gift_card", the expiration date of the expired gift card was set as date.today() - timedelta(days=1). It was then compared in a test against the current date to check if the gift card was expired. The problem was that the test would compare date.today() - timedelta(days=1) which is a day before the day of the run in the server timezone to a date in the American timezone. Between 0 and 6am, the expiration date would be the same date as the present day for the test timezone. This led to a gift card which was accepted instead of being flagged as invalid. We fix the issue by putting the expiration date a day before. runbot-error: 946584 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The website configurator now shows the upload logo icon without cutting off its left edge. This small visual fix makes the setup flow look cleaner and avoids confusion during website customization.
Original PR description
Steps to reproduce: - Open the website configurator. - Continue to the color palette selection. => The upload logo icon is cropped on its left side. Before this commit, the gradient did not cover icon parts extending beyond the glyph box. After this commit, extra inline space lets the gradient cover the entire icon.
Checks created from templates and assigned to a tax return are visible again when users generate and open that type of tax return. This restores expected review controls in the Accounting app and helps teams verify tax filings without missing configured checks.
Original PR description
commit introducing the issue: https://github.com/odoo/enterprise/commit/034e0157eed0f19471879ca133faa40b7f0aabf3 Since this commit, it's no longer possible to see a check defined from a check template in a tax return. Steps to reproduce: - Go to Accounting / Configuration / Checks - Create a new one, give it a name, a random cycle and assign it a to a tax return - Open the tax returns view, generate them, and open a tax return of the same type -> The check should be visible Forward-Port-Of: odoo/enterprise#129707
The Belgian payroll salary simulation now opens correctly for eligible full-time employees instead of showing an error. This prevents disruption when HR users estimate employee salary details.
Original PR description
Steps to reproduce: - Go to a full-time employee form eligible for employment bonus (e.g. Laurie Poiret). - Click on the salary simulation button. - A traceback is raised (UnboundLocalError: 'paid_days'). Reason: `paid_days` and `total_days` were not defined in simulation context. As a result, testing the full-time condition (`paid_days < total_days`) raised an UnboundLocalError. Solution: Set `paid_hours = total_hours = paid_days = total_days = 1` when running in salary simulation context. Task-6485330
The attendance Gantt view now correctly displays progress bars for employees who have no attendance records, making empty schedules easier to understand. It also improves the warning display so managers can better distinguish attendance-based employees with missing entries.
Original PR description
[FIX] hr_attendance_gantt: missing progress bars for empty employees On the attendance gantt view, employees without any attendances would have their progress bar hidden, and their label being something like `0h / 8h (+-8h)` in orange. This PR changes it to get the expected behavior: we should also show the progress bar for employees without attendances, and, instead of showing it in yellow all the time, show it when attendance-based employees have no attendances. Since we need to `patch` a renderer class from `hr_attendance_gantt` in `hr_work_entry_attendance`, we need to make the link between those two modules explicit in the manifest file (otherwise hoot tests will fail) This should not change much, as `hr_work_entry_attendance` already installs `hr_attendance_gantt` through an auto_install chain. See this [Discord discussion](https://discord.com/channels/678381219515465750/687338039717920792/1537826154814378167) (in french, sorry) task-6453757
The social media comments window now shows the correct like icon and supports liking Tweets from the comments view. Users also get clearer feedback when creating leads from social posts, and social users have more consistent access to live post information.
Original PR description
Bug === Since https://github.com/odoo/enterprise/commit/86659741990de2ba9c8bf738207edf0e8a0ba8c4 the like icon in the comment in the modal view is broken. We added a new getter `likesIcon` but we didn't use it... Improvements ==== Show create message when creating lead. Make the access of `social.live.post` consistent with the access of `social.post`. Task-6425391
This update corrects visual problems introduced by the Frost design changes in the Accounting bank reconciliation screens. It helps keep statement line review and reconciliation clear and usable for accounting users.
Original PR description
Odoo frost created some css problem this pr will address them no task id
Restored padding around the Helpdesk teams dashboard so the page has proper visual spacing again. This makes the Helpdesk homepage easier to read and keeps the layout consistent after a shared Kanban layout change.
Original PR description
This PR restores a padding around the Teams Kanban view on the Helpdesk homepage. As the vertical padding was removed from the generic ungrouped Kanban component with the assumption it often stands below the `ControlPanel` which provides the right spacing, we need to ensure some scenario like the one in Helpdesk work well. task-6516134
This fix adjusts test dates so they are compared using the correct timezone. It helps prevent false test failures in point-of-sale planning checks, improving release reliability without changing user-facing behavior.
Original PR description
In the tests, the planning slot start and end times were set compared to current datetime in the server timezone. But in the tests, we have a timezone which is american. This leads to incorrect comparisons and that is why in the tests of pos_sale_planning, the dates of the planning slots were adjusted. runbot-error: 946614
Employer-initiated departure reasons in Belgian payroll are now handled like dismissals. This ensures notice details, 13th month eligibility, and outplacement information are calculated and shown correctly during the end-of-collaboration process.
Original PR description
New departure reasons were added previously but their computation for the end of collaboration process was missing. Selecting employer-initiated reasons (codes `358` and `359`) didn't treat them as "Fired" so the notice duration, notice start date, and 13th month eligibility were not calculated and the `Outplacement` field stayed hidden. This treats these reasons as "Fired" in the departure model and updates the view to display the `Outplacement` field when needed. Task-6499788