Odoo Changelog — 2018-10-08

Monday, October 8, 2018

2 changes

Bug Fixes(2)

Resolved issues and error corrections

[FIX] http: Bypass SharedDataMiddleware if it's going to fail.

CoremasterhttpMEDIUM

The web request handling now avoids a failure that could block custom pages when URLs contain special characters. This improves reliability for installations using custom controllers or links with non-standard encoded text.

Original PR description

SharedDataMiddleware expects the encoding in the URL be the same on the file system. See the issue mitsuhiko/werkzeug#379 For custom controllers where portions of the URL may contain components…

SharedDataMiddleware expects the encoding in the URL be the same on the file system.  See the issue mitsuhiko/werkzeug#379

For custom controllers where portions of the URL may contain components otherwise encoded this assumption won't hold. Furthermore custom controllers won't even get the change to try themselves up to the task ;)  We'll see the following error:

```
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 38: ordinal not in range(128)
  File "openerp/service/wsgi_server.py", line 203, in application_unproxied
result = handler(environ, start_response)
  File "openerp/http.py", line 1292, in __call__
return self.dispatch(environ, start_response)
  File "openerp/http.py", line 1266, in __call__
return self.app(environ, start_wrapped)
  File "werkzeug/wsgi.py", line 570, in __call__
cleaned_path = cleaned_path.encode(sys.getfilesystemencoding())
```

This patch avoids the problem at the cost of a little overhead. Probably what should be done is to check the controllers routes for a match before wrapping the WSGI with SharedDataMiddleware.

Related: #7862

#web#url#custom controllers#reliability

[FIX] l10n_mx_edi: invoice PDF adjustments

PR #2480

Enterprisemasterl10n_mx_edi

Mexican electronic invoice PDFs now show key payment and tax details more neatly on the same line. This makes invoices easier to read and helps customers quickly find important SAT, barcode, usage, and payment information.

Original PR description

- Adjust fields: Usage, Payment Way, Payment Method to display in-line
- Adjust barcode and SAT data to display in-line

#invoicing#mexico#pdf#layout

SharedDataMiddleware expects the encoding in the URL be the same on the file system. See the issue mitsuhiko/werkzeug#379 For custom controllers where portions of the URL may contain components otherwise encoded this assumption won't hold. Furthermore custom controllers won't even get the change to try themselves up to the task ;) We'll see the following error: ``` UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 38: ordinal not in range(128) File "openerp/service/wsgi_server.py", line 203, in application_unproxied result = handler(environ, start_response) File "openerp/http.py", line 1292, in __call__ return self.dispatch(environ, start_response) File "openerp/http.py", line 1266, in __call__ return self.app(environ, start_wrapped) File "werkzeug/wsgi.py", line 570, in __call__ cleaned_path = cleaned_path.encode(sys.getfilesystemencoding()) ``` This patch avoids the problem at the cost of a little overhead. Probably what should be done is to check the controllers routes for a match before wrapping the WSGI with SharedDataMiddleware. Related: #7862