Thursday, December 13, 2018
6 changes · master
Enhancements to existing features
Inventory valuation now includes non-deductible taxes that are charged to the product or inventory account. This keeps stock values aligned with accounting entries and prevents unexplained price differences after taxed purchases or stock moves.
Original PR description
Non deductible taxes (ones without an account set), increase the target account of the product. In case of a inventory operation, this means the inventory account. To reflect this stock valuation…
Non deductible taxes (ones without an account set), increase the target account of the product. In case of a inventory operation, this means the inventory account. To reflect this stock valuation wise, we need to calculate this incremented values and rely on it during the inventory move price calculation. This commit does exactly that. **Description of the issue/feature this PR addresses:** - Inventory value and accounting value diverge on taxes which are summoned upon the target account - This is due to a inventory valuation based on the subtotal amount - Meanwhile balance accounts are charged with subtotal + value of taxes without accounts **Current behavior before PR:** - Inventory valuation and accounting valuation diverege - Consecutive accounting moves originated by stock moves do not reflect the accounting value at which the first move was charged (eg. by an invoice). - There is always an "inexplicable" price difference when working with taxes that don't have an account set (cost increasing taxes) **Desired behavior after PR is merged:** - The stock move will take exactly the same valuation as has been accrued on the taxed accounting move. - Balances do not diverge - No "mysterious" price differences appear. **Note:** Please do not close, even if not immediately accepted (`wishlist` tag). This PR is meant to be carried along and actively maintained, until this semantic will be completed this way or another. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr @xoe-labs
This change updates internal test counters for the test_mail module so they match current automated test results more closely. It helps keep Odoo's quality checks accurate and reduces noise from outdated expectations.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This change renames an internal web test file to better match Odoo's test naming conventions. It has no expected impact on day-to-day users, but helps keep the codebase easier to maintain and validate.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
This pull request changes a test file in the Web module. The provided description does not identify a user-facing issue or feature, so the expected business impact appears limited to maintaining internal quality checks.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The CRM opportunity form now restores the previous layout for expected revenue and probability fields. This reverses a recent simplification so users see the original design again, reducing disruption in daily sales workflows.
Original PR description
In task 1893160, we wanted to shorten the 'planned_revenue' and 'probability' fields on the crm.lead formview. For simplicity's sake, we are reverting this change. Task-1917357 Closes #29475 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A duplicated and unused test file was removed from the web module. This is a small cleanup that reduces maintenance noise without changing product behavior for users.
Original PR description
Remove a unused file -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr