Tuesday, March 26, 2019
12 changes · master
Enhancements to existing features
Payroll now includes better Belgian benefit and leave data, shows worked-day amounts on payslips, and calculates 13th month pay more accurately. This helps employees and payroll teams see clearer payslip details and ensures special salary payments account for seniority and unpaid or reduced-work absences.
Original PR description
1/ Add Belgian benefit and leave types ============================= 2/ [IMP] hr_payroll: display worked days amount on payslip ============================================= Purpose -----------…
1/ Add Belgian benefit and leave types
=============================
2/ [IMP] hr_payroll: display worked days amount on payslip
=============================================
Purpose
-----------
Currently, the number of days and hours for each `worked_days_line_ids` are
displayed on the payslip report. However the corresponding amount is not.
Specification
-----------------
For each `worked_days_line_ids` of a payslip, display the corresponding
amount on the report.
Amounts should be computed as follows:
Worked days lines of unpaid benefit type: 0
For other worked days lines:
1. Compute what the employee should **not** earn for the unpaid days
`unpaid amount = (average salary per day)*(number of unpaid days)`
The average salary per day is computed on a 3 month basis (there are always the
same number of days in 3 months=13 weeks).
=> `unpaid amount = wage*3/13/5 (5 days/week)`
2. Compute what the basic salary becomes:
`basic = wage - unpaid amount`
3. Distribute the basic salary among paid worked days types.
`amount of the line = basic * (number of days of the line)/(total number of paid days)`
3/ [IMP] l10n_be_hr_payroll: 13th month salary structure
=============================================
Purpose
---------
Currently, 13th month computation doesn't take into account several things:
- An employee should not receive a 13th month if he arrive after the 1st July
- The amount should be proportional to the employee seniority if he arrived between the 1st January and 1st July.
- Several benefit type should be deducted from the 13th month:
- Unpaid
- Time Credit
- Parental Time Off
- Unpredictable Reason
- Long Term Sick
- Long Term Sick > 12 months
- Part Time Sick
- Notice
Specification
--------
Take into account points above
Task 1923143
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis update adjusts Belgian payroll settings to reflect current employer social contribution rates and revised default allowances. It also changes how commissions are paid and adds a clearer, rule-based reimbursement option for employees commuting by private car.
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
When a salesperson creates a quotation from an opportunity without a customer, Odoo now asks whether to create a new customer from the opportunity details or select an existing one. This prevents quotations from being created without customer information and keeps the opportunity and quotation aligned.
Original PR description
When creating a quotation from a opportunity that does not have any customer set, we ended up on a quotation without any customer or any of the contact information entered on the crm.lead. With this commit, if no customer is set on the opportunity, when hitting New Quotation button, a modal is displayed to ask the user what to do to fill in the customer field. - Create a new customer : Use the information from the opportunity to create automatically a res.partner. Set the res.partner on the quotation and on the opportunity. - Use an existing customer : Set this customer on the quotation and on the opportunity. Extra For consistency, in the 'convert to opportunity' modal, move the 'create a new customer' at the top of the selection values + change the group title to 'Customer' instead of 'Customers' Task-1917332
The Belgian payroll accounting test data was updated to stay aligned with related payroll changes. This helps ensure automated checks continue to validate 13th month payroll behavior correctly without affecting regular users directly.
Original PR description
Adapt tests and demo data according to changes in community PR https://github.com/odoo/odoo/pull/30562
The salary configurator now presents clearer choices for phone subscriptions, including international communication as part of the highest plan. It also aligns commission plan handling with related payroll changes and updates commuting options by adding private car while removing the generic other option.
Belgian payroll contracts can now set a voluntary higher withholding tax rate, helping employees spread tax payments across the year instead of facing a larger year-end bill. Payslip reporting is also improved with clearer fleet vehicle information, including license plate display.
PDF attachment previews in Odoo Mail no longer display Odoo’s separate download button. This avoids duplicate controls because major browsers already provide a built-in PDF download option, making the preview cleaner for users.
Original PR description
Task 1945059 Since there is a button to download a pdf from the preview of all major browsers, there is no need to add one on the view in odoo
Resolved issues and error corrections
This change appears to address a locking conflict during automatic payroll loading, helping payroll processes run more reliably. It should reduce interruptions or failures when payroll data is loaded automatically, though the available PR details do not identify the exact files changed.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change corrects how grouped records are reused when data is refreshed, avoiding mismatched internal details from being carried over. It helps keep grouped views stable and accurate for users without changing visible workflows.
Original PR description
Rev. odoo/odoo@5c6a7c9 made a change to reuse an old group datapoint when performing a read_group, instead of restoring *some* properties of the old group (so basically a `_.omit` instead of a `_.pick`). This is a bad idea as some properties were bound to the new datapoint (`evaluateModifiers` for example) so it doesn't make any sense to update the old datapoint with theses properties.
This fixes an error that could prevent employees from opening the My Time Off dashboard. The Time Off dashboard now loads reliably by using the correct internal method setup.
Original PR description
Before 1ced3bfca, the get_days_all_request method was called with the context as an argument. As a consequence, because of the api.multi, the first arg is used as the ids of the record. As the id is not used in this method, it was not harmful. With the above mentioned fix, there is no more argument. This causes a traceback when clicking on menu "My Time Off/Dashboard". With this commit, the api.model is used instead, that way, the first arg is not considered as ids.
This update corrects a visual glitch in the Website Forum edit profile form. It helps forum users update their profile with a cleaner, more reliable interface aligned with the current website styling.
Original PR description
Description of the issue/feature this PR addresses: Issue: - https://drive.google.com/file/d/1b1YdE64IPJdTy9-87cbimpplRxNpQBDm/view - https://drive.google.com/file/d/1QENgFndpKrycLhRk0mcotus_E3GZoyXK/view?usp=drivesdk Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Belgian CODA bank statement import tests have been re-enabled so they are properly included in validation. This helps ensure future changes do not accidentally break CODA import behavior for Belgian accounting users.
Original PR description
Task 1922108 The tests were commented but are running