Daily updates from Odoo
Friday, June 7, 2019
2 changes
Resolved issues and error corrections
This corrects a small typo in the Website Slides app introduced by an earlier change. It helps keep online course content and interface text polished without changing functionality.
Original PR description
…323d82758ed4c487 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update ensures the signing dialog waits for all required signature components to load before users interact with it. It helps prevent errors or incomplete signature fields when opening signature-related popups.
Original PR description
The name and signature widget needs to load additional xml dependencies which is asynchronous so the start method of this widget (originally called by 'replace' when the modal was opened) cannot be called in the modal opened handler like it used to as this breaks the loading promise chain since nothing would wait on the promise returned by the start of the name and signature widget. The start of this widget is now relegated to the willStart of the dialog such that it can be waited for appropriately. However, the start of name and signature used to call resetSignature, which would not work properly unless the node is in the DOM, which is not yet the case during willStart. So it was changed so that it would not call resetSignature in its start method. It is now the responsibility of the widget which uses name and signature to call resetSignature when it is in the DOM, so the code of sign has to be adapted as well.