Daily updates from Odoo
Navigate
Branch
Monday, September 9, 2019
2 changes
Security fixes and vulnerability patches
This update adds a new automated quality check that detects patterns which could lead to SQL injection vulnerabilities before code is merged. It helps protect Odoo users by catching security risks earlier in the development and testing process.
Original PR description
You can see the check working from a sql-injection detected from the following runbot build: - http://runbot.odoo.com/runbot/build/379671 (Notice 🔴 result) The possible sql injection detected was: - https://github.com/odoo/odoo/blob/2cee34fea2bccf3320f0d09969e300361995d428/addons/mail/wizard/mail_compose_message.py#L265-L290 After the following fix: - https://github.com/odoo/odoo/commit/2ff9b379ef80ba6a8744fb9702a8088284372ddd Now the runbot is green. - http://runbot.odoo.com/runbot/build/380338 Odoo enterprise has a case of posible pylint check detected from tests I just fixed by request of @KangOl: - https://github.com/odoo/enterprise/pull/5349
Code cleanup and technical improvements
This update changes internal test code for website CRM scoring to use safer database parameter handling. It helps avoid misleading automated code-check failures, keeping development checks clearer without changing customer-facing behavior.
Original PR description
In order to avoid a false red from pylint check of sql-injection - https://github.com/odoo/odoo/pull/35874