Daily updates from Odoo
Thursday, October 10, 2019
27 changes
Resolved issues and error corrections
The Mexico accounting setup now marks transition tax accounts as reconcilable. This helps payments and invoices with different currency rates reconcile correctly for cash-basis taxes, reducing accounting discrepancies.
Original PR description
[FIX] l10n_mx: Transition Tax Accounts must be reconcilable [FIX] l10n_mx: Transition Tax Accounts must be reconcilable = This issue is relevant for MX Localization because Cash Basis is created with…
[FIX] l10n_mx: Transition Tax Accounts must be reconcilable [FIX] l10n_mx: Transition Tax Accounts must be reconcilable = This issue is relevant for MX Localization because Cash Basis is created with the rate of the payment, and not with the rate of the invoice as is done for odoo core. (some pictures were taken from other versions - main issue remains the same) Impacted versions: - 11.0 Steps to reproduce: - - Set company Country MX <img width="1270" alt="Screen Shot 2019-08-22 at 9 43 42 AM" src="https://user-images.githubusercontent.com/7598010/63524311-67c1d800-c4c1-11e9-9abd-2003e6c4b997.png"> - Set Multi-currency Environment <img width="909" alt="Screen Shot 2019-08-22 at 9 44 40 AM" src="https://user-images.githubusercontent.com/7598010/63524353-7b6d3e80-c4c1-11e9-8c2f-624563df231c.png"> - Create two rates for USD for Date1 and Date2 <img width="1676" alt="Screen Shot 2019-08-22 at 9 47 03 AM" src="https://user-images.githubusercontent.com/7598010/63524552-d0a95000-c4c1-11e9-8ba7-00fff11a6adf.png"> - Leave Transition account `119.01.01 IVA pendiente de pago` for `IVA(16%) COMPRAS` as reconcile=False. Tax is Due on Payment  <img width="794" alt="Screen Shot 2019-08-22 at 9 49 10 AM" src="https://user-images.githubusercontent.com/7598010/63524724-2120ad80-c4c2-11e9-94be-48b2b0219353.png"> - Create a Vendor Bill for Date1: <img width="1272" alt="Screen Shot 2019-08-22 at 9 52 41 AM" src="https://user-images.githubusercontent.com/7598010/63525021-9b513200-c4c2-11e9-961a-4103a6c9156b.png"> - Create a Payment for Date2: <img width="1085" alt="Screen Shot 2019-08-22 at 9 53 21 AM" src="https://user-images.githubusercontent.com/7598010/63525116-c471c280-c4c2-11e9-8fc1-649e633e883b.png"> <img width="1265" alt="Screen Shot 2019-08-22 at 9 53 56 AM" src="https://user-images.githubusercontent.com/7598010/63525122-c8054980-c4c2-11e9-944b-e8b6ff819aa2.png"> - Check Journal Entries. Only Four Journal Entries. one for invoice, one for payment, one for CABA, one for FX in Payable. <img width="1616" alt="Screen Shot 2019-08-22 at 9 54 52 AM" src="https://user-images.githubusercontent.com/7598010/63525200-e8350880-c4c2-11e9-9195-6447893d0260.png"> - Check the Journal Entry Exchange Difference. <img width="1261" alt="Screen Shot 2019-08-22 at 9 55 52 AM" src="https://user-images.githubusercontent.com/7598010/63525294-0e5aa880-c4c3-11e9-9692-3ee1eeecd9da.png"> Current behavior: - No Exchange Difference Journal Entries for the transition accounts is created Expected behavior: - After full reconciliation of Vendor Bill and Payment there should be one Exchange Difference Journal Entry for the Payable Account and one for the Transition Account. Video - https://youtu.be/UbsisoqcmqA Regards Forward-Port-Of: odoo/odoo#38215 Forward-Port-Of: odoo/odoo#35990
The email compose wizard now handles cases where recipients and a message template are selected together without causing an error. This helps users send templated messages more reliably and avoids interruptions during communication workflows.
Original PR description
[FIX] mail: message compose wizard if partner_ids and template_id are set, a traceback happens. Indeed, some mail fields are not taken from the res_ids when partner_ids is set. When trying to update the values with the one from the template, the existing values are popped, which raised an error as those keys weren't set. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38298
Point of Sale now preserves the actual employee or user responsible when creating or updating session records, rather than showing OdooBot. This improves traceability and makes troubleshooting audit information more useful without changing day-to-day workflows.
Original PR description
[IMP] point_of_sale: use sudo instead of with_user(SUPERUSER_ID). This avoids to loose user information when creating/updating records. Create_user = OdooBot is not helpful at all when debugging, ... -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38062
This fix prevents imports from failing when spreadsheet data contains an empty linked field, such as a missing country on a customer record. Users can now re-import exported Excel files with blank values without seeing an incorrect “False” lookup error.
Original PR description
[FIX] odoo: Import data with falsy many2one fields Steps to reproduce: - Export a partner with country set to False, using EXCELL - Try to import it with the xls file Bug: It raised: "No matching record found for name 'False' in field 'Country' at row 2" opw:2080376 Forward-Port-Of: odoo/odoo#38220
This fix prevents errors when certain optional field setup information is absent. It improves reliability in the base sparse field and mail areas by handling missing values safely instead of crashing.
Original PR description
[FIX] base_sparse_field,mail: handle None _instanciate_attrs override The parent was expected to return a dict, but it can also return None in some cases. When that happens, the overrides were crashing because it is impossible to assign a key/val to None. Note that using `if` conditions like this also prevents from writing on the dict if it is existing but empty, but due to the definition of the parent, if there is a dict, it will not be empty. Forward-Port-Of: odoo/odoo#38259 Forward-Port-Of: odoo/odoo#38168
Sales order lead times can now only be edited before the order is confirmed. This prevents unexpected changes to scheduled delivery dates after related warehouse operations already exist.
Original PR description
[FIX] sale: edit lead time Allow the edition of Lead Time only when the SO is not confirmed yet since the modification of the scheduled date on an existing picking is not expected. opw-2083070 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38337
New accounting move lines now round debit and credit amounts correctly when they are created. This prevents small currency precision differences from accumulating and causing accounting reports to appear unbalanced.
Original PR description
Forward Port of #37398 to 13.0 This fix is similar to 8020033; both are workarounds for the bug (limitation) introduced by 9d87d15db6dd40a5a0162fb126c725a2f0a40414. In this case, the currency_field…
Forward Port of #37398 to 13.0 This fix is similar to 8020033; both are workarounds for the bug (limitation) introduced by 9d87d15db6dd40a5a0162fb126c725a2f0a40414. In this case, the currency_field is a related field, and these fields are only computed after scalar values are written in database. As a result, this value is not rounded at creation. It is a problem since typically accounting reports are written directly in SQL, and thus reuse the values directly. Anyway even in the ORM the convert_to_cache optimised this away using the assumption that 'the value should have been rounded in convert_to_column'. It follows that in the report, errors can be accumulated to the point where the report is not balanced. This needs to be fixed in database by going through every existing line. Of note: the limitation that was readily acknowledged has not been worked around anywhere, in fact almost every single currency_field is a related one. Also of note, commit afef71d6b should "Always round monetary values in database" while it explicitly checked for the presence of the currency_field in the values and while not introducing a mechanism to make sure it would always be in the values. opw 2066849 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38341
This update fixes several issues in the website shop experience: product search counts now display correctly, customers can re-add items after removing them from a wishlist, and products can no longer be selected as their own alternatives. These changes reduce confusion for shoppers and help maintain cleaner product recommendations.
Original PR description
12.0 website sale fix fja Now a product removed from wishlist as a connected user can be added again. In the product page the found count was not display It was possible to add the product itself as alternative product -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#37135
Installing a new website theme now handles related dependency upgrades in the same operation. This prevents installation errors caused by stale module information, making theme setup more reliable for users.
Original PR description
[FIX] website_theme_install: theme installation Group the upgrade of upstream dependencies with the installation of a new theme into a single install/upgrade operation. This fixes cache misses occurring when accessing the state of a module after having upgraded other modules. Co-authored-by: Sébastien Theys <seb@odoo.com> Forward-Port-Of: odoo/odoo#38209
This update fixes small wording and spacing issues in accounting and payment messages so they appear more consistently to users and translators. It helps prevent awkward or duplicated translated text, with no expected change to business workflows.
Original PR description
[FIX] account: add missing space Courtesy of primes2h on Transifex Forward-Port-Of: odoo/odoo#38154
This fixes an issue where the Send & Print action could fail or show incorrect recipient information when sending multiple invoices through postal mail. It ensures recipient details are handled consistently and hides the recipient field when no customer is set, making invoice mailing more reliable.
Original PR description
[FIX] snailmail_account: send multiple invoices * Ensure compute always sets partner_id. * Don't show "to" when partner_id is not set FIX "Send & Print" Action on account.move model. Fixes https://github.com/odoo/odoo/issues/38228 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38264
This fixes a duplicated accounting configuration record in the system data. It helps prevent unnecessary duplication during setup or updates, reducing the chance of confusion or maintenance issues for accounting features.
Original PR description
[FIX] account: remove duplicated record definition Forward-Port-Of: odoo/odoo#38306
This fix prevents the customer-facing POS display from showing a blank white screen when the hardware box cannot reach the Odoo server. Instead, it shows the default POS client display with the IP address, helping staff identify and resolve connection issues more easily.
Original PR description
[FIX] hw_drivers: Fix for Customer display When a box was unable to reach the Odoo server the customer display show a white screen. With this fix we show the default POS Client display with IP address Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38271
Company records now show the intended placeholder avatar when no logo is available. This prevents blank or poorly cropped images in contact views, improving clarity when users browse companies and addresses.
Original PR description
[FIX] base: correctly set partner placeholder avatar for companies closes #38001 Forward-Port-Of: odoo/odoo#38267
This update fixes issues in the Lunch app that could cause default setup data to be changed or recreated unexpectedly. It also ensures a lunch-related action opens with a clean setup, helping users avoid confusing or incorrect behavior.
Original PR description
13.0 - lunch fixes Forward-Port-Of: odoo/odoo#38260
Website editor dropdowns now keep Odoo's intended visual style even when custom themes are applied. This prevents theme styling from accidentally breaking dropdown menus, improving consistency and reliability for website users.
Original PR description
[FIX] website, *: force website UI dropdown style * web_editor The purpose is to force our dropdown style in our UI so that themes do not break it anymore (same way all the other elements are forced (cards, headings, etc)). task-2059538 Co-authored-by: qsm-odoo <qsm@odoo.com> Forward-Port-Of: odoo/odoo#38268
Background videos placed inside website mega menus now display correctly when visitors open the menu. This fixes a visibility issue that previously made those videos work only while editing the page, improving the live website experience.
Original PR description
[FIX] website: make background videos in mega menus work When a background video was used in a mega menu, it was only working in edit mode. Indeed, the background video size is computed on page load (and on window resize) but as the video is inside a hidden dropdown menu in this case, the size cannot be properly computed. This commit fixes the issue by recomputing the video size on dropdown menu opening. task-2080590 Forward-Port-Of: odoo/odoo#38208
This update fixes an issue in the Mail app where email template previews could fail or show incorrect information when no record value was available. It helps keep email preview behavior consistent and avoids confusion for users preparing messages.
Original PR description
13.0 - [FIX] mail: force empty value on record Forward-Port-Of: odoo/odoo#38285
The sales invoicing wizard now respects the user's choice when they turn off down payment deduction. This prevents down payments from being incorrectly subtracted from final invoices, helping keep customer billing accurate.
Original PR description
[FIX] sale: fix down payments being deducted when they should not Prior to this commit, un-checking 'Deduct down payments' on the invoice wizard had no effect: down payments were still deducted from the final (regular) invoice. task-2081012 @dbo-odoo Do we have a "World shortest fix" badge ? -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38284
Archived projects can no longer be deleted when they still contain tasks. This prevents accidental loss of project records when related tasks are hidden because they were archived too.
Original PR description
[FIX] project: can delete archived project with tasks Create a Project with tasks, archive it, delete it. The project is deleted, but this should not happen: tasks are present, but they are hidden because when the project is archived all its tasks are archived too (active flag is set to false). On project unlinking only active tasks are checked, thus allowing the deletion. Using a context flag to avoid filtering the non active tasks. opw-2080515 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38270 Forward-Port-Of: odoo/odoo#38251
Adding the same product to the website cart multiple times now increases the quantity on the existing order line instead of creating duplicate lines. This keeps carts and quotations cleaner and helps avoid confusion during checkout.
Original PR description
Before this commit add several time the same product will duplicate the sale order line instead to update the quantity. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an error that occurred when printing a canceled invoice with no invoice lines. Users can now print these canceled invoices without the system crashing, improving reliability in edge-case accounting workflows.
Original PR description
[FIX] sale_stock: print canceled invoice Install both Sale Management and Invoicing. Create an invoice without any line, save it and cancel the entry. Print the canceled invoice, traceback. The python's `max` function requires an non-empty iterable to retrieve the maximum element. For line less invoices, the value must be None. closes #38175 Forward-Port-Of: odoo/odoo#38197
The stock product replenishment wizard now receives the needed product information when opened from the appropriate product views. The general action dropdown access is avoided so users are not offered replenishment for items where it does not make business sense, such as services or consumables.
Original PR description
[FIX] stock: product replenish wizard Description of the issue/feature this PR addresses: Fixes https://github.com/odoo/odoo/issues/38238 Current behavior before PR: `default_get` expects `default_product_id` or `default_product_tmpl_id` in the Context, while it was not passed in Action here. Desired behavior after PR is merged: This commits adds default_product_id Cc @sle-odoo -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38239
This fixes an error that occurred when printing an ISR payment slip from a Swiss customer invoice. Businesses using Swiss localization can now generate the payment slip reliably without the invoice process being interrupted.
Original PR description
[FIX] l10n_ch: print ISR On a customer invoice, click on 'Print ISR' => Error This is because of computed fields not set. opw-2081567 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38282
Odoo now returns a clean “not found” response when requested binary content is missing or cannot be read, instead of triggering a server crash and noisy error logs. This makes file access failures less disruptive and easier for teams to manage.
Original PR description
[FIX] ir_http: return a 404 if binary content cannot be decoded Commit 5a9e1af64acc has the unfortunate side-effect of crashing early if for any reason the content cannot be decoded. However, simply ignoring that the content cannot be decoded is no better idea: some functions pipe the result to decoding functions that crash the same. The resulting traceback pollutes the log with uninformative message such as: binascii.Error: Incorrect padding 5 0.002 0.016 In case the content cannot be decoded (data corruption, or simply missing file) we return a clean 404 instead, which is morally almost equivalent, and is clean even from functions that depend on binary_content. opw 2072586 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38261
This update fixes a compatibility issue in the IoT module where driver browsing relied on a deprecated method. It helps keep connected device integrations working reliably, including Ingenico payment terminal support.
Original PR description
[FIX] iot: fix depreciated "ad_paths" We fix the depreciated function "ad_paths" which was used to browse the drivers in the modules Forward-Port-Of: odoo/enterprise#5975
This update cleans up an unused or incorrectly named field in the employee appraisal area. It helps keep appraisal data structures clearer and reduces the chance of confusion for future maintenance, with no expected impact on day-to-day users.
Original PR description
[FIX] hr_appraisal: remove unused field Forward-Port-Of: odoo/enterprise#5971