Daily updates from Odoo
Navigate
Branch
Tuesday, October 15, 2019
56 changes
Security fixes and vulnerability patches
Users can no longer upload new documents into folders where they only have read access. This protects workspace permissions and prevents unauthorized content from being added by mistake or through a loophole.
Original PR description
[FIX] documents: prevents upload in limited workspaces Before this commit, a user could still upload a new document in a folder for which they only have a read access as the AccessError was intercepted in the upload route. This commit fixes this issue and makes so that the route now uses the multi create. Task: #2083596 Forward-Port-Of: odoo/enterprise#6024
New functionality added to Odoo
The HR Referral app now has an updated icon in its app listing and related visuals. This is a small branding update that helps keep the app’s appearance current and easier to recognize.
Original PR description
[ADD] hr_referral: Add new icon id=2072146 Forward-Port-Of: odoo/enterprise#5948
Enhancements to existing features
This update makes long copyable text, such as payment URLs, display more cleanly instead of disrupting the page layout. It also improves the payment link wizard layout by grouping small fields so users can read and copy payment details more easily.
Original PR description
[IMP] web: CopyClipboardCharLong widget for long strings
- The copy CopyClipboardChar widget is not nicely rendered for very long strings (e.g. URL).
- This commit modify the behavior of the CopyClipboardChar widget to display it nicely win such cases.
TaskID: 2059972
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe project overview now filters its information to the specific project being viewed. This helps users see accurate, relevant timesheet and sales information without unrelated project data getting mixed in.
Original PR description
Before this task, The overview wasn't filtered on the corresponding project. task-2057325 pad link-https://pad.odoo.com/p/r.fc6877abbbe12c498c373290ec63b0e7
The online shop can now use custom ribbons on product listings, making it easier to highlight promotions, new items, or featured products. The update also improves how product images and ribbon click areas behave, creating a clearer and more consistent shopping experience.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
When a product is archived, it will now also be unpublished from the website store. This helps prevent inactive products from remaining visible to shoppers and reduces the risk of customers trying to view or buy products that are no longer available.
Original PR description
On archive of product template, it also unpublishes product template. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Restricted website editors can no longer edit protected forum and event titles or open the media dialog to alter the website logo. The snippet bar is also hidden when no snippets can be dropped, reducing confusion and making restricted editing clearer.
Original PR description
PR creation -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This fix restores the ability to reverse multiple invoices or accounting moves in one operation. It ensures the reversal wizard uses all selected records, reducing manual work and preventing missed reversals when processing batches.
Original PR description
[FIX] account: allow to reverse multiple moves at the same time again The way the active_id(s) were retrieved made the wizard only take care of one active_id. This prevented from reverse multiple invoices at the same time. https://github.com/odoo/odoo/issues/35759 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#37681
The Accounting app now uses the term “Vendors” instead of “Suppliers” in the affected partner view. This aligns the wording with the existing menu label, making navigation and terminology more consistent for users.
Original PR description
For more consistency, as the menu item calling the corresponding action is named "Vendors".
This fix removes an unwanted gap that appeared before sale order lines when previewing quotations on the website. The spacing behavior is now limited to website edit mode, so customer-facing previews display more cleanly without affecting editing tools.
Original PR description
[FIX] website: oe_no_empty only in edit mode Test case; The user as edition rights on the website Install quotation builder Have a sale order with many lines Click preview > you end up on the portal view Before this commit, there was a blank space just before the sale order lines per se This was because the sale order's lines website description were in the dom and took some fixed space, which is a feature meant for the edit mode by using the class oe_no_empty After this commit, we restrict the effect of that class concerning the fixed height only to edit mode There is no more gaps in the sale order preview OPW 2082267 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38396
Fixes an issue where invoices created from multiple sales orders were no longer grouped correctly. This helps businesses keep billing consolidated as expected and reduces manual invoice cleanup.
Original PR description
[FIX] sale: correctly group invoices when invoicing multiple orders It seems the grouping feature was lost during the accountpocalypse. Add a test as long as I'm at it. Forward-Port-Of: odoo/odoo#38500
Portal messages posted by portal users now send email notifications from the user's own partner email address instead of OdooBot. This makes recipient communications clearer and avoids confusion about who sent the message.
Original PR description
[FIX] portal: portal send mail with right email address Go on the portal with a portal user Drop a message in the chatter The message is logged in the chatter from the right partner Before this commit however, the email that was sent had its address from of the OdooBot After this commit, the mail is sent with the partner's email from OPW 2074154 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38507 Forward-Port-Of: odoo/odoo#38410
Website editor snippets can now display multiple matching options when they are meant to apply to the same snippet. This fixes a case where some map snippet settings in the Avantgarde theme were hidden, helping users configure pages as intended.
Original PR description
[FIX] web_editor: allow a snippet to use the same option multiple times If two snippet options are declared using the same data-js="..." and that they end up targeting the same snippet in some cases, only one of those two snippet options was shown. This case occurred in a theme (avantgarde) for the map snippet. Forward-Port-Of: odoo/odoo#38498 Forward-Port-Of: odoo/odoo#38385
This update fixes the Helpdesk accounting flow so users can reverse multiple accounting documents at the same time. It keeps the reversal wizard aligned with updated accounting behavior, reducing errors when handling refunds or corrections from helpdesk-related invoices.
Original PR description
[FIX] helpdesk_account: adapt for reverting multiple document at the same time The wizard account.move.reversal now implements default_get to retrieve the default values instead of a function per field. Community PR: https://github.com/odoo/odoo/pull/37681 Forward-Port-Of: odoo/enterprise#5876
This update fixes errors that could occur when staff create or edit appointments and when customers submit appointment requests online. It also improves appointment navigation so users can more easily choose another appointment type without getting stuck.
Original PR description
[FIX] website_calendar: fix tracebacks Stabilize online appointments and make it usable. This PR will: 1. fix traceback when creating/editing an appointment in backend. It was due to a call to an unexisting field. 2. fix traceback when submitting an appointment in frontend. It was due to the wrong conversion of country_id (was str instead of int) 3. use slug(appointment_type) for the form action instead of just appointment_type.id. 4. change the route of the breadcrumb Appointment item and cancel button in order to be able to select any registered appointment type. task-2077856 Forward-Port-Of: odoo/enterprise#5805
Receipt printing during Point of Sale session closing is now handled directly in the screen layout instead of being added through extra script logic. This makes the behavior more reliable and easier to maintain without changing what users see.
Original PR description
In commit d63f02f we had to dynamically add the 'pos-receipt-print' class in the JS because we couldn't change the view in stable. We can now change the view directly.
The IoT device scan now uses a default IP address when Chrome prevents automatic local IP detection. This restores the scan flow so users can continue finding and connecting IoT devices without manual troubleshooting.
Original PR description
The latest version of Chrome blocks the detection of the local IP and no default address was set. Making the scan unusable.
Code cleanup and technical improvements
The repair app has been reorganized to better support businesses operating with multiple companies in the same Odoo database. This helps keep repair orders, numbering, access rules, demo data, and traceability aligned with the correct company, reducing confusion for users working across entities.
Original PR description
task-2081645
The mail message code has been reorganized to make it easier for developers to understand and maintain. This is an internal cleanup only, with no expected change to how users experience the mail features.
Original PR description
Purpose of this commit is to reorganize mail.message file in order to better understand its content. It is done according to guidelines * computed fields; * CRUD and search / check access overrides; * actions (discuss, moderation, fetch / failure); * tools;
Miscellaneous changes
### Description of the issue/feature this PR addresses: We revert the changes we apply in order to let the user to define their own fiscal positions for Argentinian company. In Argentina the fiscal position will be set always depending on the AFIP Responsibility. ### Current behavior before PR: The fiscal positions is not properly detect when customers are "Responsable Inscription" or "Consumidor Final" (AFIP Responsibility). Is setting "Compras / Ventas en el Exterior" fiscal positi
Original PR description
### Description of the issue/feature this PR addresses: We revert the changes we apply in order to let the user to define their own fiscal positions for Argentinian company. In Argentina the fiscal position will be set always depending on the AFIP Responsibility. ### Current behavior before PR: The fiscal positions is not properly detect when customers are "Responsable Inscription" or "Consumidor Final" (AFIP Responsibility). Is setting "Compras / Ventas en el Exterior" fiscal position which should only applies for customers outside of Argentina and that also is causing that the vat taxes are not properly set in the invoice lines. ### Desired behavior after PR is merged: The fiscal position for the customers with the mentioned AFIP Responsabilities are now properly setted to empty which let to set the correct vat taxes in the invoice lines. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38431
In 12.0 it was 3.5 but for 13.0, it is acceptable 3.6. Debian Buster has 3.7 and Ubuntu 18.04 LTS has 3.6 This will avoid undeterminist errors with OrderedDict CentOS 7 still does not ship python3 by default but it is possible to install it (e.g. https://www.digitalocean.com/community/tutorials/how-to-install-python-3-and-set-up-a-local-programming-environment-on-centos-7) And CentOS 8 has been released 15 days ago [with python 3.6 in RHEL](https://access.redhat.com/documentation/en-us/r
Original PR description
In 12.0 it was 3.5 but for 13.0, it is acceptable 3.6. Debian Buster has 3.7 and Ubuntu 18.04 LTS has 3.6 This will avoid undeterminist errors with OrderedDict CentOS 7 still does not ship python3 by default but it is possible to install it (e.g. https://www.digitalocean.com/community/tutorials/how-to-install-python-3-and-set-up-a-local-programming-environment-on-centos-7) And CentOS 8 has been released 15 days ago [with python 3.6 in RHEL](https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/8.0_release_notes/rhel-8_0_0_release#web-servers-databases-dynamic-languages) Following discussion at https://github.com/OCA/maintainer-quality-tools/pull/613 cc @odony can we clean some [safe_eval 3.5 opcodes](https://github.com/odoo/odoo/blob/a5c4e262449fef03d05d5250e4523832db5fbf00/odoo/tools/safe_eval.py#L71) ? Forward-Port-Of: odoo/odoo#38364
CCLA for Nanobytes Forward-Port-Of: odoo/odoo#38770
Original PR description
CCLA for Nanobytes Forward-Port-Of: odoo/odoo#38770
Before this commit, trying to print a registration without a name specified (not required), was failing Fixes odoo/odoo#38564 Replace and closes odoo/odoo#38582 Courtesy of Swapnesh Shah Forward-Port-Of: odoo/odoo#38767
Original PR description
Before this commit, trying to print a registration without a name specified (not required), was failing Fixes odoo/odoo#38564 Replace and closes odoo/odoo#38582 Courtesy of Swapnesh Shah Forward-Port-Of: odoo/odoo#38767
- Let a model M define a Many2oneReference field F1. - Let a model N define a One2many field F2 whose inverse is M->F1 - Define a computed field N->F3 that depends on N->F2 If, for whatever reason, a recordset of M contains records that have been unlinked already and we try to unlink them again, the system will crash with a MissingException error. This happened because, while most _modified_trigger cases cover the case of a MissingException (i.e. record not in cache), the case for a
Original PR description
- Let a model M define a Many2oneReference field F1. - Let a model N define a One2many field F2 whose inverse is M->F1 - Define a computed field N->F3 that depends on N->F2 If, for whatever reason, a recordset of M contains records that have been unlinked already and we try to unlink them again, the system will crash with a MissingException error. This happened because, while most _modified_trigger cases cover the case of a MissingException (i.e. record not in cache), the case for a Many2oneReference didn't. This is fixed by simply ignoring these "stale" records in the _modified_triggers section for Many2oneReference fields. Co-authored-by: mreficent <miquel.raich@eficent.com> Forward-Port-Of: odoo/odoo#38697
Forward-Port-Of: odoo/odoo#38727 Forward-Port-Of: odoo/odoo#38510
Original PR description
Forward-Port-Of: odoo/odoo#38727 Forward-Port-Of: odoo/odoo#38510
Description of the issue/feature this PR addresses: Make sure that all partner levels have a name Fixes https://github.com/odoo/odoo/issues/38579 Current behavior before PR: If you don't set a name it'll create an empty recording resulting in it showing "False" throughout Odoo, for example from the contacts form:  Desired behavior after PR is merged: The name is required and th
Original PR description
Description of the issue/feature this PR addresses: Make sure that all partner levels have a name Fixes https://github.com/odoo/odoo/issues/38579 Current behavior before PR: If you don't set a name it'll create an empty recording resulting in it showing "False" throughout Odoo, for example from the contacts form:  Desired behavior after PR is merged: The name is required and thus it always shows a nice, human readable name for the partner levels. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38211
Ease module upgrade. Forward-Port-Of: odoo/odoo#38741
Original PR description
Ease module upgrade. Forward-Port-Of: odoo/odoo#38741
Since the ir.sequence records linked to pos.config records are on delete restrict, it is necessary to delete the pos.config records first before deleting the ir.sequence's linked to them. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38760
Original PR description
Since the ir.sequence records linked to pos.config records are on delete restrict, it is necessary to delete the pos.config records first before deleting the ir.sequence's linked to them. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38760
Products were not adding up when added to cart separately when adding first product to compare animation was wrong When first adding a product to cart from shop the nav bar was not updated -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38538 Forward-Port-Of: odoo/odoo#37132
Original PR description
Products were not adding up when added to cart separately when adding first product to compare animation was wrong When first adding a product to cart from shop the nav bar was not updated -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38538 Forward-Port-Of: odoo/odoo#37132
From Accounting Dashboard, under the kanban card "Customer Invoices" click on "Upload Invoice" and submit an e-fff invoice (xml) which is actually an invoice (e-fff type 380, should be uploaded under "Vendor Bills" card). The server will reply "Cannot create an invoice of type in_invoice with a journal having purchase as type." because it will fetch the type not from the destination journal but from the guessed journal. opw-2083545 -- I confirm I have signed the CLA and read the PR
Original PR description
From Accounting Dashboard, under the kanban card "Customer Invoices" click on "Upload Invoice" and submit an e-fff invoice (xml) which is actually an invoice (e-fff type 380, should be uploaded under "Vendor Bills" card). The server will reply "Cannot create an invoice of type in_invoice with a journal having purchase as type." because it will fetch the type not from the destination journal but from the guessed journal. opw-2083545 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38755
Follow up of commit a3845ae3f058772d4b548c703f5ddf94b571d903 Issue ===== Since the above commit there is a confirmation dialog when clicking on a button, for which the only options are to Discard or Cancel. The problem is that when discarding it will revert the selected website back to the default value. Therefore before the current commit it is impossible to install a theme on a website other than the first. Solution ======== The solution is to avoid showing this dialog when
Original PR description
Follow up of commit a3845ae3f058772d4b548c703f5ddf94b571d903 Issue ===== Since the above commit there is a confirmation dialog when clicking on a button, for which the only options are to Discard or…
Follow up of commit a3845ae3f058772d4b548c703f5ddf94b571d903 Issue ===== Since the above commit there is a confirmation dialog when clicking on a button, for which the only options are to Discard or Cancel. The problem is that when discarding it will revert the selected website back to the default value. Therefore before the current commit it is impossible to install a theme on a website other than the first. Solution ======== The solution is to avoid showing this dialog when clicking on buttons for which the result depends on the currently selected website. This leads to the same behavior as what existed before the mentioned commit: the settings are implicitly discarded because they are not saved, but at the time of the click the transient model still holds the non-discarded value that the user selected. This restores the "select a theme" feature, but also restores the unfortunate side effect that the user might unknowingly loose all of his pending changes when clicking on the button, but only for those two specific buttons. Other considerations ==================== Saving instead of Discarding was considered but it is impossible to do because saving might do a lot of changes that might even lead to the installation of modules, so the settings page has to be reloaded to apply them, and then the website field will be reset to its default value again. Instead of changing website specific settings from the main settings, it was considered to update them through a form view, but it is apparently too complicated for on-boarding. The last consideration was that the settings view should actually mark the corresponding fields as unchanged when changing the website, but it is too complex to implement for a case that is not supported in the first place, especially for a fix in a stable version. Forward-Port-Of: odoo/odoo#38716
When you are adding a line on your sale order that is a delivery line, the carrier is not always set on the sale order which means that when the carrier is not explicitly set on the sale order, the carrier won't be set on picking created from the sale order. When you are using the wizard on sale order, it works, but when the carrier is selected on the e-commerce, it is not set on the sale order. To avoid such difference in behavior, we are writing the carrier_id of sale order in the f
Original PR description
When you are adding a line on your sale order that is a delivery line, the carrier is not always set on the sale order which means that when the carrier is not explicitly set on the sale order, the carrier won't be set on picking created from the sale order. When you are using the wizard on sale order, it works, but when the carrier is selected on the e-commerce, it is not set on the sale order. To avoid such difference in behavior, we are writing the carrier_id of sale order in the function 'set_delivery_line' insread of the wizard and e-commerce. closes odoo/odoo#35855 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com> Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38730
Task: https://www.odoo.com/web?#id=2027729&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.b314b3cc84c3dca119342c6ae50162ef Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38504
Original PR description
Task: https://www.odoo.com/web?#id=2027729&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.b314b3cc84c3dca119342c6ae50162ef Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38504
Revision on https://github.com/odoo/odoo/commit/9a66619db33fca5f0cb81d9f6bfeb0fb0290cf68 Commit above improves the web client startup by not having to wait for discuss widgets to fully load beforehand. However, it introduced an issue with chatter when the 1st rendering happens before messaging becomes ready: it displays "Creating a record..." instead of the whole history of messages. This happens because when messaging is ready, it updates data from the chatter but it does not trigger
Original PR description
Revision on https://github.com/odoo/odoo/commit/9a66619db33fca5f0cb81d9f6bfeb0fb0290cf68 Commit above improves the web client startup by not having to wait for discuss widgets to fully load beforehand. However, it introduced an issue with chatter when the 1st rendering happens before messaging becomes ready: it displays "Creating a record..." instead of the whole history of messages. This happens because when messaging is ready, it updates data from the chatter but it does not trigger a re-render. This commit fixes the issue by triggering a re-render on messaging ready. When messaging is not ready, thread field now displays "Loading..." instead of the message "Creating a record...". Task-Id 2078193 Forward-Port-Of: odoo/odoo#38171
As the python3-xlrd package is available in Debian stretch and Ubuntu bionic, there is no reason to not include it in Odoo debian package. However, it cannot be used in Odoo 11.0 package as it does not exists in Ubuntu Xenial. ubuntu package: https://packages.ubuntu.com/bionic/python3-xlrd debian package: https://packages.debian.org/stretch/python3-xlrd closes odoo/docker#276 Forward-Port-Of: odoo/odoo#38728
Original PR description
As the python3-xlrd package is available in Debian stretch and Ubuntu bionic, there is no reason to not include it in Odoo debian package. However, it cannot be used in Odoo 11.0 package as it does not exists in Ubuntu Xenial. ubuntu package: https://packages.ubuntu.com/bionic/python3-xlrd debian package: https://packages.debian.org/stretch/python3-xlrd closes odoo/docker#276 Forward-Port-Of: odoo/odoo#38728
Before this commit, the editable quant list was editable by top, which is not really pratical when the user creates (with the keyboard) multiple quants tracked by SN because the focus always go back on the top of the list. Now, this list is editable by bottom. Forward-Port-Of: odoo/odoo#38704
Original PR description
Before this commit, the editable quant list was editable by top, which is not really pratical when the user creates (with the keyboard) multiple quants tracked by SN because the focus always go back on the top of the list. Now, this list is editable by bottom. Forward-Port-Of: odoo/odoo#38704
The product copy was fixed in https://github.com/odoo/odoo/pull/38303 but the result is still not intuitive. You could duplicate one of the multiple variants of a template and see another variant form opened than the one you just duplicated. If you want to create variants, you should do so through product templates. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38725
Original PR description
The product copy was fixed in https://github.com/odoo/odoo/pull/38303 but the result is still not intuitive. You could duplicate one of the multiple variants of a template and see another variant form opened than the one you just duplicated. If you want to create variants, you should do so through product templates. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38725
[FIX] mail: deletable attachments in attachment box Task-Id 2081987 closes #38003 [FIX] mail: discuss unstar all closes #37994 Forward-Port-Of: odoo/odoo#38226
Original PR description
[FIX] mail: deletable attachments in attachment box Task-Id 2081987 closes #38003 [FIX] mail: discuss unstar all closes #37994 Forward-Port-Of: odoo/odoo#38226
When you try to create two users with the same login, the shown error message is the Postgresql integrity error instead of a nice (translated) validation error. This happens since bf88f3e which changed the way error messages are translated. The reason is the manually created unique index `res_users_login_key_unique_website_index`. The error handling and translation mechanisms don't know it exists. The index was created for performance reasons in commit b5a12b4aac9484cd342e29f2a0402fb148b0
Original PR description
When you try to create two users with the same login, the shown error message is the Postgresql integrity error instead of a nice (translated) validation error. This happens since bf88f3e which changed the way error messages are translated. The reason is the manually created unique index `res_users_login_key_unique_website_index`. The error handling and translation mechanisms don't know it exists. The index was created for performance reasons in commit b5a12b4aac9484cd342e29f2a0402fb148b09e2e where the original python constraint was replaced with this custom SQL index. In this commit, the python constraint is re-introduced to remove the index hack, but the implementation now uses a single SQL query, which should be quite fast. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#37901
Go to hr.applicant view form, Edit and change something. Each time you change a field, the Attachment box in the chatter is toggled (as if you were clicking on the small attachment button each time). This is a wrong behavior of the `open_attachments` option of the `mail_thread` widget. Opening the attachment box should be done at the widget initialization, not at every render. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: od
Original PR description
Go to hr.applicant view form, Edit and change something. Each time you change a field, the Attachment box in the chatter is toggled (as if you were clicking on the small attachment button each time). This is a wrong behavior of the `open_attachments` option of the `mail_thread` widget. Opening the attachment box should be done at the widget initialization, not at every render. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38519
When you try to delete a floor, an error is raised if a pos config has an opened session. Even if the floor is not used in the opened pos config. The real goal of this constraint is to avoid deleting a floor plan linked to a pos config having an opened session. Github issue: https://github.com/odoo/odoo/issues/38581 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA an
Original PR description
When you try to delete a floor, an error is raised if a pos config has an opened session. Even if the floor is not used in the opened pos config. The real goal of this constraint is to avoid deleting a floor plan linked to a pos config having an opened session. Github issue: https://github.com/odoo/odoo/issues/38581 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38674
Description of the issue/feature this PR addresses: Make the location name required Fixes https://github.com/odoo/odoo/issues/38566 Current behavior before PR: The location name is not required, resulting in empty location names which are shown throughout Odoo (frontend/backend). Desired behavior after PR is merged: The location name is required so that a location name is shown everywhere in Odoo -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submi
Original PR description
Description of the issue/feature this PR addresses: Make the location name required Fixes https://github.com/odoo/odoo/issues/38566 Current behavior before PR: The location name is not required, resulting in empty location names which are shown throughout Odoo (frontend/backend). Desired behavior after PR is merged: The location name is required so that a location name is shown everywhere in Odoo -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38571
Before this commit, some images would display incorrectly orientated. This typically happens for images taken from a non-standard orientation by some phones or other devices that are able to report orientation. The specified transposition is applied to the image before all other operations, because all of them expect the image to be in its final orientation, which is the case only when the first row of pixels is the top of the image and the first column of pixels is the left of the ima
Original PR description
Before this commit, some images would display incorrectly orientated. This typically happens for images taken from a non-standard orientation by some phones or other devices that are able to report orientation. The specified transposition is applied to the image before all other operations, because all of them expect the image to be in its final orientation, which is the case only when the first row of pixels is the top of the image and the first column of pixels is the left of the image. Moreover the EXIF tags will not be kept when the image is later saved, so the transposition has to be done to ensure the final image is correctly orientated. Forward-Port-Of: odoo/odoo#37448
- Create a sales order for a company with a contact name. - Click the Preview button. - The company and contact names appear on the same line, only separated by a comma. Before this commit: it's not possible to easily override this behavior. After this commit: it's possible to override `Partner._get_contact_name` to change the format of contact name. Beware that this method is used in `_get_name` which is called from various places. A check on the context may be necessary.
Original PR description
- Create a sales order for a company with a contact name. - Click the Preview button. - The company and contact names appear on the same line, only separated by a comma. Before this commit: it's not possible to easily override this behavior. After this commit: it's possible to override `Partner._get_contact_name` to change the format of contact name. Beware that this method is used in `_get_name` which is called from various places. A check on the context may be necessary. OPW: 2077294 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38586 Forward-Port-Of: odoo/odoo#38100
Before this commit, in base we use bus to notify the user but bus module is not always installed and so we can't call it. After this commit, now we use a client action to notify the success test. Steps to reproduce: * install a Odoo with no apps * go in debug mode * go to "Outgoing Mail Servers" technical settings * create a valid SMTP record * click on "Test Connection" button (BUG) We add also the display_notification client action -- I confirm I have signed the CLA and read
Original PR description
Before this commit, in base we use bus to notify the user but bus module is not always installed and so we can't call it. After this commit, now we use a client action to notify the success test. Steps to reproduce: * install a Odoo with no apps * go in debug mode * go to "Outgoing Mail Servers" technical settings * create a valid SMTP record * click on "Test Connection" button (BUG) We add also the display_notification client action -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38276
-Define "g" as the default UoM for a product. -Make a purchase order with that product. -Select the "kg" UoM in the order line and a price of 50. -Check the Purchase tab of the product. Before this commit: the UoM of the price created is the default UoM for the product, "g". This is because it's a related field. However, the price wasn't converted to the default UoM, it's still 50. After this commit: the price is converted to the default UoM, it's 0.05 per "g". OPW: 2076722
Original PR description
-Define "g" as the default UoM for a product. -Make a purchase order with that product. -Select the "kg" UoM in the order line and a price of 50. -Check the Purchase tab of the product. Before this commit: the UoM of the price created is the default UoM for the product, "g". This is because it's a related field. However, the price wasn't converted to the default UoM, it's still 50. After this commit: the price is converted to the default UoM, it's 0.05 per "g". OPW: 2076722 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38522 Forward-Port-Of: odoo/odoo#38049
Description of the issue/feature this PR addresses: Fixes https://github.com/odoo/odoo/issues/38233 Current behavior before PR: Invoice can be Created from Payment, Which won't be linked there Desired behavior after PR is merged: New Invoices shouldn't be created from the Payment screen. Cc @qdp-odoo -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38240
Original PR description
Description of the issue/feature this PR addresses: Fixes https://github.com/odoo/odoo/issues/38233 Current behavior before PR: Invoice can be Created from Payment, Which won't be linked there Desired behavior after PR is merged: New Invoices shouldn't be created from the Payment screen. Cc @qdp-odoo -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38240
OPW: 2085934 On the website, in /my/tickets there is a search field that search tickets. Before this commit: - one cannot search by textual content. After this commit: - one can search by textual content. Forward-Port-Of: odoo/enterprise#6127
Original PR description
OPW: 2085934 On the website, in /my/tickets there is a search field that search tickets. Before this commit: - one cannot search by textual content. After this commit: - one can search by textual content. Forward-Port-Of: odoo/enterprise#6127
…n https://github.com/odoo/enterprise/commit/faf69b3de1d7fc955e3f6271fd24b901310fe5e4#diff-cb72d8e4bde305abd2cacd46a31d5f51. Helps the upgrade of the module Forward-Port-Of: odoo/enterprise#6125
Original PR description
…n https://github.com/odoo/enterprise/commit/faf69b3de1d7fc955e3f6271fd24b901310fe5e4#diff-cb72d8e4bde305abd2cacd46a31d5f51. Helps the upgrade of the module Forward-Port-Of: odoo/enterprise#6125
In Generic Tax Report _query_get is called but not use in grid query so other report filter is not working so after this commit all other report filter is working in in generic tax report Forward-Port-Of: odoo/enterprise#5873
Original PR description
In Generic Tax Report _query_get is called but not use in grid query so other report filter is not working so after this commit all other report filter is working in in generic tax report Forward-Port-Of: odoo/enterprise#5873
3 things were wrong here: * The xml was not loaded after the refactoring of 267123d * The called report template was moved in the same commit * The model values were not correcly retrieved Forward-Port-Of: odoo/enterprise#6056
Original PR description
3 things were wrong here: * The xml was not loaded after the refactoring of 267123d * The called report template was moved in the same commit * The model values were not correcly retrieved Forward-Port-Of: odoo/enterprise#6056
It was not possible to select a fixed Asset account that was different from the depreciation account. From documentation: https://www.accountingtools.com/articles/what-is-accumulated-depreciation.html It must be possible to specify a Fixed asset account such as "Fixed Assets - Computers & Equipment" and then a separate depreciation account such as "Accumulated Deprecation - Computers & Equipment" as a contra-asset account. opw:2083242 Forward-Port-Of: odoo/enterprise#6078
Original PR description
It was not possible to select a fixed Asset account that was different from the depreciation account. From documentation: https://www.accountingtools.com/articles/what-is-accumulated-depreciation.html It must be possible to specify a Fixed asset account such as "Fixed Assets - Computers & Equipment" and then a separate depreciation account such as "Accumulated Deprecation - Computers & Equipment" as a contra-asset account. opw:2083242 Forward-Port-Of: odoo/enterprise#6078
A rate request for fedex GROUND_HOME_DELIVERY will return nothing. It's due to different options that are not provided to easypost: - residential flag on addresses. - saturday_delivery on shipment. It's unfortunately impossible to add fields on delivery carrier in order to manage those options. However it could be imporved in master. opw-2081066 Forward-Port-Of: odoo/enterprise#6126 Forward-Port-Of: odoo/enterprise#6016
Original PR description
A rate request for fedex GROUND_HOME_DELIVERY will return nothing. It's due to different options that are not provided to easypost: - residential flag on addresses. - saturday_delivery on shipment. It's unfortunately impossible to add fields on delivery carrier in order to manage those options. However it could be imporved in master. opw-2081066 Forward-Port-Of: odoo/enterprise#6126 Forward-Port-Of: odoo/enterprise#6016
Before this commit, after installing l10n_mx_edi a rendering problem was found in the unit of measure form. This arises because, l10n_mx_edi adds a new group in an existing group with fields. Note that, a group with existing fields cannot contain also a group, this will break the rendering of the aforementioned fields. Now, the module adds the group outside all the existing ones. opw-2080722 opw-2082014 Co-authored-by: Jorge Pinna Puissant <jpp@odoo.com> Forward-Port-Of: odoo/ente
Original PR description
Before this commit, after installing l10n_mx_edi a rendering problem was found in the unit of measure form. This arises because, l10n_mx_edi adds a new group in an existing group with fields. Note that, a group with existing fields cannot contain also a group, this will break the rendering of the aforementioned fields. Now, the module adds the group outside all the existing ones. opw-2080722 opw-2082014 Co-authored-by: Jorge Pinna Puissant <jpp@odoo.com> Forward-Port-Of: odoo/enterprise#6011
Forward-Port-Of: odoo/enterprise#6014
Original PR description
Forward-Port-Of: odoo/enterprise#6014
Task: https://www.odoo.com/web?#id=2026776&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.cf13f687b5e10e960158b568c8b1f558 Forward-Port-Of: odoo/enterprise#5782
Original PR description
Task: https://www.odoo.com/web?#id=2026776&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.cf13f687b5e10e960158b568c8b1f558 Forward-Port-Of: odoo/enterprise#5782