Monday, October 21, 2019
31 changes
Enhancements to existing features
Documentation course cards no longer show a progress bar. This makes documentation pages clearer by avoiding progress indicators that are not relevant for that type of content.
Original PR description
[IMP] website_slides: remove the progress bar on "course_card" if the channel type is "documentation" Task #2080594
Survey test data is now prepared once for the full test class instead of being recreated before every individual test. This reduces repeated setup work and helps make the survey test suite run more efficiently without changing user-facing behavior.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This change relaxes an internal performance test threshold for the email test module because the query count was fluctuating between test runs. It helps prevent unreliable staging failures while the underlying cause is investigated, with no expected impact on end users.
Original PR description
New performances test looks non deterministic, sometimes break with 28 queries instead of 25. This commit temporary pump up query count to avoid staging fails, further investigation is needed. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Those tests were raising an assert error if the DB has other websites than the data/demo ones. As we have a new module in Odoo 13.0 (odoo/design-themes#178) which is creating 25 websites, and since the design-themes runbot is now running tests, we were having a red design-themes runbot. Forward-Port-Of: odoo/odoo#39140
Original PR description
Those tests were raising an assert error if the DB has other websites than the data/demo ones. As we have a new module in Odoo 13.0 (odoo/design-themes#178) which is creating 25 websites, and since the design-themes runbot is now running tests, we were having a red design-themes runbot. Forward-Port-Of: odoo/odoo#39140
after paypal onboarding, merchant email and PDT token is not required at all, for the new users. They can accept payment with just an email address. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38756
Original PR description
after paypal onboarding, merchant email and PDT token is not required at all, for the new users. They can accept payment with just an email address. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38756
Do not return a boolean but skip bad translations Introduced at 19e50ea37435c2d9 Fixes odoo/odoo#39001 Forward-Port-Of: odoo/odoo#39021
Original PR description
Do not return a boolean but skip bad translations Introduced at 19e50ea37435c2d9 Fixes odoo/odoo#39001 Forward-Port-Of: odoo/odoo#39021
Go on a kanban view with a scroll bar scroll all the way down Open a record in form view Use the breadcrumb to go back to the kanban Before this commit, the kanban was re-opened but the position were we were before opening the record was lost This was due to 40dd121938552d3f88289d2e5fcd1d57a0dd01bb which refactors the dom, puting the action manager on top of controllers After this commit, when re-opening the kanban, we end up at the same position we left it at OPW 2074077
Original PR description
Go on a kanban view with a scroll bar scroll all the way down Open a record in form view Use the breadcrumb to go back to the kanban Before this commit, the kanban was re-opened but the position were we were before opening the record was lost This was due to 40dd121938552d3f88289d2e5fcd1d57a0dd01bb which refactors the dom, puting the action manager on top of controllers After this commit, when re-opening the kanban, we end up at the same position we left it at OPW 2074077 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#37655
Forward-Port-Of: odoo/odoo#39020
Original PR description
Forward-Port-Of: odoo/odoo#39020
Install l10n_it_edi, try to import an italian e-invoice (xml). Odoo will create 2 invoices, one draft with the attachment but empty, and another one with the parsed content of the file. This happen because the module responsible for the import systematically create a new invoice instead of reusing the open one. opw-2089521 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39095
Original PR description
Install l10n_it_edi, try to import an italian e-invoice (xml). Odoo will create 2 invoices, one draft with the attachment but empty, and another one with the parsed content of the file. This happen because the module responsible for the import systematically create a new invoice instead of reusing the open one. opw-2089521 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39095
Fine tuning of c351f00 In the POS module there is the possibility to print receipts. Before this commit: - The currency symbol appears in the receipts but not in sublines and discount After this commit: - The currency symbol appears in the receipts but not in sublines OPW-2083188 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR
Original PR description
Fine tuning of c351f00
In the POS module there is the possibility to print receipts.
Before this commit:
- The currency symbol appears in the receipts but not in sublines
and discount
After this commit:
- The currency symbol appears in the receipts but not in sublines
OPW-2083188
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#39089The method does not work with all value formats (string, date, datetime). Forward-Port-Of: odoo/odoo#38949
Original PR description
The method does not work with all value formats (string, date, datetime). Forward-Port-Of: odoo/odoo#38949
At the moment the weight is read from all scales automatically. The problem is that Adam scales beep every time we read the weight, making them almost unusable in a shop. We set the manufacturer on the IoT Device to be able to identify those scales and get the weight manually instead of reading it automatically. TaskID: 2089995 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39083
Original PR description
At the moment the weight is read from all scales automatically. The problem is that Adam scales beep every time we read the weight, making them almost unusable in a shop. We set the manufacturer on the IoT Device to be able to identify those scales and get the weight manually instead of reading it automatically. TaskID: 2089995 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39083
Lets say we have 2 payment references on our invoices: * `45 RE34Y U0000 00000 02019 00014` * `45 RE34Y U0000 00000 02019 00022` A customer pays with the communication: `45 RE34Y U0000 00000 02019 00014` Before this commit, the query in _get_invoice_matching_query was looking at the invoice number, the invoice line label, and the vendor reference all the same way; it was never looking specifically at the payment reference (which is copied on the receivable line). This was an issue be
Original PR description
Lets say we have 2 payment references on our invoices: * `45 RE34Y U0000 00000 02019 00014` * `45 RE34Y U0000 00000 02019 00022` A customer pays with the communication: `45 RE34Y U0000 00000 02019…
Lets say we have 2 payment references on our invoices: * `45 RE34Y U0000 00000 02019 00014` * `45 RE34Y U0000 00000 02019 00022` A customer pays with the communication: `45 RE34Y U0000 00000 02019 00014` Before this commit, the query in _get_invoice_matching_query was looking at the invoice number, the invoice line label, and the vendor reference all the same way; it was never looking specifically at the payment reference (which is copied on the receivable line). This was an issue because the matching was done by keeping only the digits, grouped by word. If at least one group of digit matched, then the statement matched with the line. In our example, both invoices were proposed because `45`, `RE34Y`, `Ù0000`, `00000` and `02019` matched. (one is enough). The fix consists of ignoring the lines that match with the number, label and vendor ref if we find an exact match with the payment reference. : -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39005
@robodoo rebase-ff related to #38026 Forward-Port-Of: odoo/odoo#38292
Original PR description
@robodoo rebase-ff related to #38026 Forward-Port-Of: odoo/odoo#38292
Since commit https://github.com/odoo/odoo/commit/dba478332681dd21a39c4a183c002b1cf6e046d2, a survey can have questions with no section associated, which means 'page_ids' field will be empty. This prevents to display the analysis results of a survey, as we are still expecting a structure page/questions. To solve it, if a question does not have a section associated, we use an empty page instead. Description of the issue/feature this PR addresses: opw-2078788 Current behavior before PR
Original PR description
Since commit https://github.com/odoo/odoo/commit/dba478332681dd21a39c4a183c002b1cf6e046d2, a survey can have questions with no section associated, which means 'page_ids' field will be empty. This prevents to display the analysis results of a survey, as we are still expecting a structure page/questions. To solve it, if a question does not have a section associated, we use an empty page instead. Description of the issue/feature this PR addresses: opw-2078788 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38928
The analytic account/tags must be set on taxes only when the 'analytic' box is ticked. --task: 2089557 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39004
Original PR description
The analytic account/tags must be set on taxes only when the 'analytic' box is ticked. --task: 2089557 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39004
Managers were receiving 2 emails to say basically the same thing. This commit removes one of those emails ("You have been assigned to ..."). TaskID: 2067994 Forward-Port-Of: odoo/odoo#39039
Original PR description
Managers were receiving 2 emails to say basically the same thing. This
commit removes one of those emails ("You have been assigned to ...").
TaskID: 2067994
Forward-Port-Of: odoo/odoo#39039Forward-Port-Of: odoo/odoo#39050
Original PR description
Forward-Port-Of: odoo/odoo#39050
Before this commit, if the user clicked on a company which have no company logo, the system did not let him create a contact. opw-2086824 Forward-Port-Of: odoo/odoo#38887
Original PR description
Before this commit, if the user clicked on a company which have no company logo, the system did not let him create a contact. opw-2086824 Forward-Port-Of: odoo/odoo#38887
### Description of the issue/feature this PR addresses: * Some AFIP codes where missing in the res.country data. * Also some numeric AFIP codes in res.currency need to pass the proper char, Example '60' is different of '060', The correct value is '060 ### Current behavior before PR: ### Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38735
Original PR description
### Description of the issue/feature this PR addresses: * Some AFIP codes where missing in the res.country data. * Also some numeric AFIP codes in res.currency need to pass the proper char, Example '60' is different of '060', The correct value is '060 ### Current behavior before PR: ### Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38735
### Description of the issue/feature this PR addresses: Since we are not using document only in invoice by now we remove the option to include receipts. ### Current behavior before PR: We are including account.move that we are not currently managing with document types ### Desired behavior after PR is merged: We are filtering to the account.move that matters by the moment -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of:
Original PR description
### Description of the issue/feature this PR addresses: Since we are not using document only in invoice by now we remove the option to include receipts. ### Current behavior before PR: We are including account.move that we are not currently managing with document types ### Desired behavior after PR is merged: We are filtering to the account.move that matters by the moment -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38439
Have an event in Mexico timezone As a begin date, choose something in the morning As a end date, choose 18:00 in that timezone (or later) in the same day The end date will be written as the day after at 00:00 in UTC Before this commit, the event was considered taking more than one day After this commit, the event is considered taking place in the same day OPW 2087828 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is
Original PR description
Have an event in Mexico timezone As a begin date, choose something in the morning As a end date, choose 18:00 in that timezone (or later) in the same day The end date will be written as the day after at 00:00 in UTC Before this commit, the event was considered taking more than one day After this commit, the event is considered taking place in the same day OPW 2087828 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39036
Add the description, counterpart to the name of the bank statement line. Remittance should also go to reference. Forward-Port-Of: odoo/enterprise#6281
Original PR description
Add the description, counterpart to the name of the bank statement line. Remittance should also go to reference. Forward-Port-Of: odoo/enterprise#6281
Reverts eb6ee7dbfce and b39d9a096e which was a fix of that first commit. Because automatic sending to the OCR was done only when going through message_post, they used the fact that _message_post_process_attachments adds to the thread the attachments on the 'mail.compose.message' model. However this method also checks the create_uid, which would mean another horrible hack would be needed to make the feature work for multi-users setups. Moreover this relies on a feature that is not part of
Original PR description
Reverts eb6ee7dbfce and b39d9a096e which was a fix of that first commit. Because automatic sending to the OCR was done only when going through message_post, they used the fact that…
Reverts eb6ee7dbfce and b39d9a096e which was a fix of that first commit. Because automatic sending to the OCR was done only when going through message_post, they used the fact that _message_post_process_attachments adds to the thread the attachments on the 'mail.compose.message' model. However this method also checks the create_uid, which would mean another horrible hack would be needed to make the feature work for multi-users setups. Moreover this relies on a feature that is not part of the interface, private, in another model, and simply undocumented. But the issue was also caused by the fact that the way documents_account linked the attachment was non-standard: it bypasses the standard methods that would have set the message_main_attachment_id by just editing the related record. So in that case an explicit call to register_as_main_attachment is needed. We add automatic sending to this method so that all flows are uniform. (there are 4 flows, adding attachments in comments or in the attachment box, programmatically or through the interface.) Note that we also remove the attachments argument from the call to message_post since it is useless and misleading. Similarly in message_post we can avoid the big code duplication by simply relying on retry_ocr, since at this point the attachments should already have been processed by the super. opw 2086239 Forward-Port-Of: odoo/enterprise#6198
Before this commit, a normal user can't access to his dashboard and he can't see the heads of referred friends. After this commit, he can access to his dashboard and see all heads. id=2081112 Forward-Port-Of: odoo/enterprise#5965
Original PR description
Before this commit, a normal user can't access to his dashboard and he can't see the heads of referred friends. After this commit, he can access to his dashboard and see all heads. id=2081112 Forward-Port-Of: odoo/enterprise#5965
Needs odoo/odoo#37655 Go on a kanban view with a scroll bar scroll all the way down Open a record in form view Use the breadcrumb to go back to the kanban Before this commit, the kanban was re-opened but the position were we were before opening the record was lost This was due to 40dd121 which refactors the dom, puting the action manager on top of controllers After this commit, when re-opening the kanban, we end up at the same position we left it at OPW 2074077 Forward-Po
Original PR description
Needs odoo/odoo#37655 Go on a kanban view with a scroll bar scroll all the way down Open a record in form view Use the breadcrumb to go back to the kanban Before this commit, the kanban was re-opened but the position were we were before opening the record was lost This was due to 40dd121 which refactors the dom, puting the action manager on top of controllers After this commit, when re-opening the kanban, we end up at the same position we left it at OPW 2074077 Forward-Port-Of: odoo/enterprise#5862
Forward-Port-Of: odoo/enterprise#6245
Original PR description
Forward-Port-Of: odoo/enterprise#6245
Forward-Port-Of: odoo/enterprise#6252
Original PR description
Forward-Port-Of: odoo/enterprise#6252
At the moment the weight is read from all scales automatically. The problem is that Adam scales beep every time we read the weight, making them almost unusable in a shop. We set the manufacturer on the IoT Device to be able to identify those scales and get the weight manually instead of reading it automatically. TaskID: 2089995 Forward-Port-Of: odoo/enterprise#6289
Original PR description
At the moment the weight is read from all scales automatically. The problem is that Adam scales beep every time we read the weight, making them almost unusable in a shop. We set the manufacturer on the IoT Device to be able to identify those scales and get the weight manually instead of reading it automatically. TaskID: 2089995 Forward-Port-Of: odoo/enterprise#6289
Fix a few mistakes in line codes and names that caused the report to crash. They were introduced by 861c56b , 4cfac52#diff-60d484a6a7ec0a7f98c878f5ca0099c8R83 , 83bd5aa , 4cfac52 and ed0bab6 . We re-do here these fixes in a cleaner way by just keeping the right xmlid on each line. Forward-Port-Of: odoo/enterprise#6013
Original PR description
Fix a few mistakes in line codes and names that caused the report to crash. They were introduced by 861c56b , 4cfac52#diff-60d484a6a7ec0a7f98c878f5ca0099c8R83 , 83bd5aa , 4cfac52 and ed0bab6 . We re-do here these fixes in a cleaner way by just keeping the right xmlid on each line. Forward-Port-Of: odoo/enterprise#6013
Add tests to Field Service. Task-2082479 Forward-Port-Of: odoo/enterprise#5983
Original PR description
Add tests to Field Service. Task-2082479 Forward-Port-Of: odoo/enterprise#5983