Daily updates from Odoo
Thursday, October 24, 2019
22 changes
Enhancements to existing features
This update starts improving how server actions are presented when setting up marketing automation activities. It makes the underlying action form naming clearer, helping pave the way for a simpler experience for non-technical users.
Original PR description
When creating a marketing automation activity, one can choose to trigger a server action. This task aims at improving a the usability of this option for non-technical users as well as cleaning the view a bit (because so far we display the standard server action form view). taskid: 2088171 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
The update clarifies documentation so developers can correctly use configuration files with command-line options. It also fixes a small wording issue in an error message shown for unknown commands, reducing confusion during setup and troubleshooting.
Original PR description
Description of the issue/feature this PR addresses: Developer is not able to use configuration file after reading the documentation. Current behavior before PR: Developer is not able to use configuration file after reading the documentation. Desired behavior after PR is merged: Developer is able to use configuration file after reading the documentation. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Documentation and clarification updates
This documentation update explains that module license entries must use one of Odoo's accepted values and lists those options. It helps teams avoid mistakes when preparing module metadata, with no change to product behavior.
Original PR description
Pulled list directly from https://github.com/odoo/odoo/blob/13.0/odoo/addons/base/models/ir_module.py#L278 ## Description of the issue/feature this PR addresses: The documentation for `__manifest__.py` does not make it clear that the value of `license` must be one value from a set list of values, and not just any string. In addition, the docs for this does not list the actual values. ## Current behavior before PR: No Odoo product behavior changes ## Desired behavior after PR is merged: No Odoo product behavior changes -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr * See #39270 for my signature addition
Miscellaneous changes
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38530
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38530
The reloading of the registry causes cache misses when creating or modifying automated actions via Odoo Studio. Right after the reloading happened, some field is computed in an environment `env` that no longer appears in `Environment.envs` (collecting existing environments), because the latter has been explicitly reset. Performing `sudo()` or `with_context()` in the compute method creates a new environment that appears in `Environment.envs`, and uses a different cache from `env`. The re
Original PR description
The reloading of the registry causes cache misses when creating or modifying automated actions via Odoo Studio. Right after the reloading happened, some field is computed in an environment `env` that no longer appears in `Environment.envs` (collecting existing environments), because the latter has been explicitly reset. Performing `sudo()` or `with_context()` in the compute method creates a new environment that appears in `Environment.envs`, and uses a different cache from `env`. The recomputed field is thus stored in the other cache, and retrieving its value from `env` issues a cache miss... The fix consists in resetting up the registry models without reloading the registry from scratch. opw:2082497 Forward-Port-Of: odoo/odoo#39233
Forward-Port-Of: odoo/odoo#39319
Original PR description
Forward-Port-Of: odoo/odoo#39319
Forward-Port-Of: odoo/odoo#36141
Original PR description
Forward-Port-Of: odoo/odoo#36141
- Create a product A with a barcode, UOM as 'Unit(s)' with a BOM - Create a MO for A with more than one unit, validate - Print the 'Finished Product Label (PDF)' A single label is printed for all units, although it is not logical: a label should be printed for each unit, as already done for the Zebra labels. In case the product UOM is 'Unit(s)', we print a label per unit. To do so, we use a template similar to `label_transfer_template_view_pdf`. opw-2091663 Description of the is
Original PR description
- Create a product A with a barcode, UOM as 'Unit(s)' with a BOM - Create a MO for A with more than one unit, validate - Print the 'Finished Product Label (PDF)' A single label is printed for all units, although it is not logical: a label should be printed for each unit, as already done for the Zebra labels. In case the product UOM is 'Unit(s)', we print a label per unit. To do so, we use a template similar to `label_transfer_template_view_pdf`. opw-2091663 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39251
- Create a customer invoice or a vendor bill - Add a product with any pre-defined tax The tax line is not added. This is because the account 2221 is set as 'Payable' instead of 'Current Liabilities', as it is the case in other localizations. For reference, the tax line is created then removed because: https://github.com/odoo/odoo/blob/db2e6bc600364c00e8a1d528d4b17ae052ecd41e/addons/account/models/account_move.py#L816 The line is part of `existing_terms_lines` instead of `others_
Original PR description
- Create a customer invoice or a vendor bill - Add a product with any pre-defined tax The tax line is not added. This is because the account 2221 is set as 'Payable' instead of 'Current Liabilities', as it is the case in other localizations. For reference, the tax line is created then removed because: https://github.com/odoo/odoo/blob/db2e6bc600364c00e8a1d528d4b17ae052ecd41e/addons/account/models/account_move.py#L816 The line is part of `existing_terms_lines` instead of `others_lines`. opw-2089955 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39241
Do not use `tickets` which is a recordset with more than one record. opw-2092231 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39303
Original PR description
Do not use `tickets` which is a recordset with more than one record. opw-2092231 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39303
Forward-Port-Of: odoo/odoo#39252
Original PR description
Forward-Port-Of: odoo/odoo#39252
**Description of the issue/feature this PR addresses:** As `payment.acquirer` is readable for all for almost forever since https://github.com/odoo/odoo/commit/9386acc59fe2ca1f9c0628c320757bb7bcbc3743 and we do not need the sudo. Otherwise the record rules would not take effect for the user who is retrieving the records. **Current behavior before PR:** Record Rules are useless for retrieving the allowed payment acquirer. **Desired behavior after PR is merged:** Record Rules will provide
Original PR description
**Description of the issue/feature this PR addresses:** As `payment.acquirer` is readable for all for almost forever since https://github.com/odoo/odoo/commit/9386acc59fe2ca1f9c0628c320757bb7bcbc3743 and we do not need the sudo. Otherwise the record rules would not take effect for the user who is retrieving the records. **Current behavior before PR:** Record Rules are useless for retrieving the allowed payment acquirer. **Desired behavior after PR is merged:** Record Rules will provide only allowed records for the user. @nim-odoo @tde-banana-odoo May I ask you to review and merge this? Info: @wt-io-it -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39289 Forward-Port-Of: odoo/odoo#36149
Various fixes in the list view Enterprise PR: https://github.com/odoo/enterprise/pull/6174 Task 2076721 Task 2086594 Forward-Port-Of: odoo/odoo#38113
Original PR description
Various fixes in the list view Enterprise PR: https://github.com/odoo/enterprise/pull/6174 Task 2076721 Task 2086594 Forward-Port-Of: odoo/odoo#38113
some external ids of account.fiscal.position.tax.template used as duplicated. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38843
Original PR description
some external ids of account.fiscal.position.tax.template used as duplicated. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#38843
`_` is not available when loading this part of the template, leading to an error on `_.str.trim()`. We can simply use `trim()` to do so. By the way, `google_analytics_key` is now trimmed automatically when adding it in the settings, so this is only useful for migrated databases. Fixes #38891 opw-2089296 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the P
Original PR description
`_` is not available when loading this part of the template, leading to an error on `_.str.trim()`. We can simply use `trim()` to do so. By the way, `google_analytics_key` is now trimmed automatically when adding it in the settings, so this is only useful for migrated databases. Fixes #38891 opw-2089296 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39255
Various company and other fixes Enterprise counterpart of https://github.com/odoo/odoo/pull/38530 Forward-Port-Of: odoo/enterprise#6122
Original PR description
Various company and other fixes Enterprise counterpart of https://github.com/odoo/odoo/pull/38530 Forward-Port-Of: odoo/enterprise#6122
Make consistent cancelling invoice already cancelled on PAC & reset PAC status when setting invoice to draft state. Before this commit, invoices that are not signed on SAT (because and error or missing configuration, etc) and previously cancelled and set them to draft state are not possible to cancel again because the method action_invoice_cancel filter the invoices where l10n_mx_edi_pac_status is on [False, 'retry', 'to_sign'] only, the rest of them are not candidates to be cancelled.
Original PR description
Make consistent cancelling invoice already cancelled on PAC & reset PAC status when setting invoice to draft state. Before this commit, invoices that are not signed on SAT (because and error or…
Make consistent cancelling invoice already cancelled on PAC & reset PAC
status when setting invoice to draft state.
Before this commit, invoices that are not signed on SAT (because and
error or missing configuration, etc) and previously
cancelled and set them to draft state are not possible to cancel again
because the method action_invoice_cancel filter the invoices where
l10n_mx_edi_pac_status is on [False, 'retry', 'to_sign'] only, the rest
of them are not candidates to be cancelled.
So considering the following Case:
Create an invoice, try to validate it and Fails
- Invoice is validated
- PAC status is to_sing or retry
Call cancellation
- invoice is cancelled
- PAC status now is cancelled because of this line
https://github.com/odoo/enterprise/blob/11.0/l10n_mx_edi/models/account_invoice.py#L580
Set the invoice to draft
- Invoice now is on the draft state
Try to cancel the invoice again
- it Fails because invoices are filtered by PAC status False, 'retry', 'to_sign'
and it does not consider invoices in cancelled status.
Also PAC status is reset to False when invoice is set to draft in order
to reset the cycle in order to make consistency.
Fix 2: In the cancel process that reset2open an invoice cancelled in
Odoo and open in the SAT, and the invoices cancelled in the SAT but open
in Odoo, was improved to only consider customer invoices. The vendor
bills cannot be affected with this process.
Cherry-pick from https://github.com/odoo/enterprise/pull/5816 and replace https://github.com/odoo/enterprise/pull/6350
Forward-Port-Of: odoo/enterprise#6387Now in v13, vendor bills and customer invoices have the same view for both types. Then, now are hide the fields required only to generate the CFDI, to not show in the vendor bills. Before this change:  Now:  F
Original PR description
Now in v13, vendor bills and customer invoices have the same view for both types. Then, now are hide the fields required only to generate the CFDI, to not show in the vendor bills. Before this change:  Now:  Forward-Port-Of: odoo/enterprise#6401
Since we removed the `relativeWidth` attribute for columns in #38113, we had to remove it from a specific test assertion where it was checked. Community PR: https://github.com/odoo/odoo/pull/38113 Task 2076721 Forward-Port-Of: odoo/enterprise#6174
Original PR description
Since we removed the `relativeWidth` attribute for columns in #38113, we had to remove it from a specific test assertion where it was checked. Community PR: https://github.com/odoo/odoo/pull/38113 Task 2076721 Forward-Port-Of: odoo/enterprise#6174
Steps to reproduce the bug: - Let's consider P tracked by serial number and SN a valid serial number for P - Create a PO for product P (whatever the quantity) - Confirm PO and receive P by selecting SN on picking PCK(This is the first step of the reception and it is handled manually) - The second step is handled with the barcode. Go to Barcode App > click on operation > select the source location where PCK has been moved - Scan the source location - Scan the serial number SN - Finally s
Original PR description
Steps to reproduce the bug: - Let's consider P tracked by serial number and SN a valid serial number for P - Create a PO for product P (whatever the quantity) - Confirm PO and receive P by selecting SN on picking PCK(This is the first step of the reception and it is handled manually) - The second step is handled with the barcode. Go to Barcode App > click on operation > select the source location where PCK has been moved - Scan the source location - Scan the serial number SN - Finally scan the destination location Bug: The error message asked to scan one or several products. opw:2091229 Forward-Port-Of: odoo/enterprise#6352
Now the complement for ``donatarias`` need the version 1.1, was updated the URL to get XSD files for that version Forward-Port-Of: odoo/enterprise#6159
Original PR description
Now the complement for ``donatarias`` need the version 1.1, was updated the URL to get XSD files for that version Forward-Port-Of: odoo/enterprise#6159
When trying to validate a bank reconciliation a traceback is raised, this occurs because since the accounting-pocalypse, the move_line no longer have an invoice_id, this was remplaced by a move_id. After this commit, there is no traceback. opw-2086481 Forward-Port-Of: odoo/enterprise#6380
Original PR description
When trying to validate a bank reconciliation a traceback is raised, this occurs because since the accounting-pocalypse, the move_line no longer have an invoice_id, this was remplaced by a move_id. After this commit, there is no traceback. opw-2086481 Forward-Port-Of: odoo/enterprise#6380