Wednesday, October 30, 2019
32 changes · master
Enhancements to existing features
Point of Sale now warns cashiers when a serial or lot number may block delivery, helping teams catch traceability issues earlier. If related delivery operations still cannot be confirmed, the system creates an exception activity on the POS session with links to the affected deliveries so responsible staff can follow up quickly.
Original PR description
**Task**: https://www.odoo.com/web#id=1906359&model=project.task&menu_id=4720 **Pad**: https://pad.odoo.com/p/r.4743e005b9bcb7d415399d5f1c055be6 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Point of Sale now warns users when a scanned or entered serial or lot number may no longer be available for delivery, helping prevent fulfillment mistakes. If related delivery operations cannot be confirmed, the system creates a follow-up exception activity on the PoS session so the responsible person can review and resolve them.
Original PR description
1. ONLINE
- Raise a warning when encoding the SN/LN to inform the user if this
SN/LN cannot be delivered
"This Serial number has already been delivered and is not available
anymore, are you sure you have encoded the right number ?"
(+ see if other mistakes are possible)
2. OFFLINE
- No change
3. GENERAL
- Log a next activity of type exception the PoS Session if some
delivery orders could not be confirmed + with link to the pickings
Responsible = PoS Session responsible
"Some operations could not be confirmed due to exceptions :
- WH/OUT/xxxx (clickable link)
- WH/OUT/yyyy (clickable link)
Task #1906359This update helps prevent browser-based tests from running too early during installation, which can cause false failures when required components are not yet loaded. It also cleans up older deprecated test helpers and fixes a related routing setup issue, making test results more reliable for teams maintaining Odoo.
Original PR description
When an HttpCase is used at install time, all modules are not yest installed. If the tour/test needs data from a not yet installed module, it will crash. While at it, remove deprecated at_install and post_install helpers and remove the deprecated phantom_js alias.
Several older internal helper functions are now marked as deprecated because modern Python tools already provide equivalent functionality. This reduces long-term maintenance work without changing normal user-facing behavior.
Original PR description
* walksymlinks is useless, os.walk got followlinks in 2.6 * tempdir is redundant with tempfile.TemporaryDirectory added in 3.2 * listdir(recursive=False) is just os.listdir. listdir(recursive=True) is untouched but only used in one place so seems fairly low-value versus just using os.walk there
Test tools now capture and display logged error objects more completely, not just plain text messages. This helps developers diagnose issues from newer interface components more reliably, reducing time spent investigating failed automated tests.
Original PR description
Before this commit, console.error were catched by browser_js in order to log them but only value was used on received object, which is correct only when the received object is text. With owl arrival, error object may be logged. This commit add the ability to manage logged object, fallbacking on a complete representation of object if object is not an error or description is empty.
This update adjusts automated browser-based tests so they run after installation, improving confidence that key workflows keep working correctly. It also removes older testing shortcuts, helping maintain a cleaner and more dependable test suite without changing user-facing features.
Original PR description
And while at it, remove deprecated usage of phantom_js alias, post_install and at_install helpers.
Resolved issues and error corrections
Payment checkout no longer shows an extra technical error dialog when a background request fails. Customers instead see the existing payment form message, reducing confusion during checkout.
Original PR description
Task: https://www.odoo.com/web#id=2045189&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.1d4999fed88b8bf01765f7ab02310481 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Forward-Port-Of: https://github.com/odoo/odoo/pull/39595. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39603
Original PR description
Forward-Port-Of: https://github.com/odoo/odoo/pull/39595. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39603
Fixes #39546 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39605
Original PR description
Fixes #39546 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39605
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39217
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39217
before this commit it shows error dialog when rpc fail after this commit, error dialog will not be shown to user, instead we have already shown error in payment form Forward-Port-Of: odoo/odoo#39564
Original PR description
before this commit it shows error dialog when rpc fail after this commit, error dialog will not be shown to user, instead we have already shown error in payment form Forward-Port-Of: odoo/odoo#39564
The two method valid valid_alternative_icon_text and valid_title_icon represent ~13% of an install all. Rewriting them in master with in #36373 is the main reason of the performance improvement. Those two method logic were broken, because `xpath += '[not(//*[' + valid_attrs_xpath + '])]'` will actually search for valid_attrs_xpath from view root, not from fa- node. -since this check will only log a warning and so only impact bugfix, no impact on user editing views, -since a new che
Original PR description
The two method valid valid_alternative_icon_text and valid_title_icon represent ~13% of an install all. Rewriting them in master with in #36373 is the main reason of the performance improvement. Those two method logic were broken, because `xpath += '[not(//*[' + valid_attrs_xpath + '])]'` will actually search for valid_attrs_xpath from view root, not from fa- node. -since this check will only log a warning and so only impact bugfix, no impact on user editing views, -since a new check is added in master with the corresponding fix in views, -since this check doesn't really test what it is suppose to check, -since fa accessibility is great, but not critical ->removing those check will slightly speed up build without major impact on views quality Forward-Port-Of: odoo/odoo#39494
- Go to POS application - Click on the 3 dots of the session to open configuration - Remove the "Cash" payment method and just keep "Bank" - Open the session, proceed to a sell and close it. - Try to open the session either clicking on "Close" on the kanban card `CacheMiss` error. opw-2116470 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guideline
Original PR description
- Go to POS application - Click on the 3 dots of the session to open configuration - Remove the "Cash" payment method and just keep "Bank" - Open the session, proceed to a sell and close it. - Try to open the session either clicking on "Close" on the kanban card `CacheMiss` error. opw-2116470 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39563
In the sales modules, set a down payment product with a different UoM than the default one. If you create an invoice, select the down payment option, click on create and view. Before this commit: - The down payment tax & UoM are not on the invoice line After this commit: - They are on the invoice line, like in V12 OPW-2086146 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I con
Original PR description
In the sales modules, set a down payment product with a different UoM
than the default one.
If you create an invoice, select the down payment option, click on
create and view.
Before this commit:
- The down payment tax & UoM are not on the invoice line
After this commit:
- They are on the invoice line, like in V12
OPW-2086146
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#39557- Install `pos_restaurant` - Make an order, choose 'Split' At validation, an error is raised because the field `mp_dirty` doesn't exist. We filter out the non-existing fields sent by the server. opw-2116461 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39552
Original PR description
- Install `pos_restaurant` - Make an order, choose 'Split' At validation, an error is raised because the field `mp_dirty` doesn't exist. We filter out the non-existing fields sent by the server. opw-2116461 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39552
Allow to see a pricelist if its company is in the current companies, even if not the website company or the user company. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39511
Original PR description
Allow to see a pricelist if its company is in the current companies, even if not the website company or the user company. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39511
### Description of the issue/feature this PR addresses: This ones were inactive by default, we think that need to be active in order to be able to be added to vendor bills. Also change the amount from 0.0 to 1.0 of all the perception tax templates to make it appears in the manual taxes widget when they are added to the invoice/bills lines. ### Current behavior before PR: Suffered Perception Purchase taxes are deactivate and can be used. ### Desired behavior after PR is merged:
Original PR description
### Description of the issue/feature this PR addresses: This ones were inactive by default, we think that need to be active in order to be able to be added to vendor bills. Also change the amount from 0.0 to 1.0 of all the perception tax templates to make it appears in the manual taxes widget when they are added to the invoice/bills lines. ### Current behavior before PR: Suffered Perception Purchase taxes are deactivate and can be used. ### Desired behavior after PR is merged: Suffered Perception Purchase taxes are activate and can be used in the the vendor bills directly. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39392
These changes were announced in the new Annex 24 RFM 2019 [1] and define the new code for accounts for the northern border zone. This change affects a part of the CoA because these accounts were changed from the middile to the end of the group. [1] https://www.sat.gob.mx/cs/Satellite?blobcol=urldata&blobkey=id&blobtable=MungoBlobs&blobwhere=1461173776384&ssbinary=true -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo
Original PR description
These changes were announced in the new Annex 24 RFM 2019 [1] and define the new code for accounts for the northern border zone. This change affects a part of the CoA because these accounts were changed from the middile to the end of the group. [1] https://www.sat.gob.mx/cs/Satellite?blobcol=urldata&blobkey=id&blobtable=MungoBlobs&blobwhere=1461173776384&ssbinary=true -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39545
In some case, a browser_js test with login "None" following a browser_js test with a defined login could result in the second test being executed with the previous user. This was caused by a race condition, a request response comming back to chrome just after browser clear, restoring the old cookie. (All odoo request have the set_cookie flag set in order to refresh cookie timeout) The solution here is to check one more time for cookie in authenticate, but also to remove HTTPCase sess
Original PR description
In some case, a browser_js test with login "None" following a browser_js test with a defined login could result in the second test being executed with the previous user. This was caused by a race condition, a request response comming back to chrome just after browser clear, restoring the old cookie. (All odoo request have the set_cookie flag set in order to refresh cookie timeout) The solution here is to check one more time for cookie in authenticate, but also to remove HTTPCase session from session_store. This will only be effective when calling browser_js without login in the same HTTPCase . Forward-Port-Of: odoo/odoo#39504 Forward-Port-Of: odoo/odoo#39424
We can't edit the random question count field from the survey form (in list widget). Change the function which compute the colspan of a field (during edition). TASK_ID : 2075216 Co-authored-by: Michaël Mattiello <mcm@odoo.com> Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#37300
Original PR description
We can't edit the random question count field from the survey form (in list widget). Change the function which compute the colspan of a field (during edition). TASK_ID : 2075216 Co-authored-by: Michaël Mattiello <mcm@odoo.com> Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#37300
Do not attempt to create a valuation layer if the quantity is zero, otherwise this will crash: https://github.com/odoo/odoo/blob/8777f525ced87890242e1c73cac55c70444de351/addons/stock_account/models/product.py#L291 opw-2115764 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39509
Original PR description
Do not attempt to create a valuation layer if the quantity is zero, otherwise this will crash: https://github.com/odoo/odoo/blob/8777f525ced87890242e1c73cac55c70444de351/addons/stock_account/models/product.py#L291 opw-2115764 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39509
TaxCloud integration is no longer working since the account-apocalypse. The main issue is that taxes are auto-generated in inactive state and never taken into account by the computation of orders' and invoices' totals. It seemed like a bad idea to try introduce `with_context(active_test=False)` wherever the taxes are needed in active state as it concerns quite a lot of methods in different modules. In addition, the only way to tell if a tax originates from TaxCloud is to check the fiscal po
Original PR description
TaxCloud integration is no longer working since the account-apocalypse. The main issue is that taxes are auto-generated in inactive state and never taken into account by the computation of orders' and invoices' totals. It seemed like a bad idea to try introduce `with_context(active_test=False)` wherever the taxes are needed in active state as it concerns quite a lot of methods in different modules. In addition, the only way to tell if a tax originates from TaxCloud is to check the fiscal position of the order or invoice which is relevant in the context. However, this information is not kept in most of the cases where the taxes are involved in the computation of a total. Forward-Port-Of: odoo/enterprise#6447
- Create a DB without demo data - Configure a mail server - Set a country to the company, e.g. 'United States' - Install 'Accounting' A next activity email is sent about 'Tax Return'. This email is confusing for new users. Moreover, on the SaaS, this happens before the first connection of the user. In this case, `web.base.url` is not set yet and the email contains a link to `localhost`. There is no need to send an email for this activity. opw-2115458 Forward-Port-Of: odoo/ente
Original PR description
- Create a DB without demo data - Configure a mail server - Set a country to the company, e.g. 'United States' - Install 'Accounting' A next activity email is sent about 'Tax Return'. This email is confusing for new users. Moreover, on the SaaS, this happens before the first connection of the user. In this case, `web.base.url` is not set yet and the email contains a link to `localhost`. There is no need to send an email for this activity. opw-2115458 Forward-Port-Of: odoo/enterprise#6490
This commit includes several small changes of views and usability for the social module. Here is a quick summary of the changes made: - Display a warning when testing push notifications if they are blocked by the browser - Restrict the uploaded files to images for social.posts - Improve the social.post calendar view to enable drag&drop of scheduled posts - When a post is scheduled, you can now switch it back to "post now" - A notification is logged in the social.post chatter when the p
Original PR description
This commit includes several small changes of views and usability for the social module. Here is a quick summary of the changes made: - Display a warning when testing push notifications if they are blocked by the browser - Restrict the uploaded files to images for social.posts - Improve the social.post calendar view to enable drag&drop of scheduled posts - When a post is scheduled, you can now switch it back to "post now" - A notification is logged in the social.post chatter when the post is published - Avoid spam of forged unicode characters in stream.post comments in the Feed view - Adjust notification request modal position to match the browser's one More details can be found in underlying commits. Task #2082478 closes #6196 Forward-Port-Of: odoo/enterprise#6196
Back port of hr_appraisal part of #5391 Forward-Port-Of: odoo/enterprise#6478 Forward-Port-Of: odoo/enterprise#6469
Original PR description
Back port of hr_appraisal part of #5391 Forward-Port-Of: odoo/enterprise#6478 Forward-Port-Of: odoo/enterprise#6469
In the case the OCR doesn't find a vat number, avoid to pick a supplier that hasn't a valid VAT number encoded on it, but choose based on name instead Forward-Port-Of: odoo/enterprise#6483 Forward-Port-Of: odoo/enterprise#6476
Original PR description
In the case the OCR doesn't find a vat number, avoid to pick a supplier that hasn't a valid VAT number encoded on it, but choose based on name instead Forward-Port-Of: odoo/enterprise#6483 Forward-Port-Of: odoo/enterprise#6476
Before this commit: - When you click on a relational field on mobile, you are redirected to a view with a "Quick search" filter which is undefined. After this commit: - The "Quick search" filter doesn't appears when he doesn't have the necessary data to work correctly. OPW-2090181 Forward-Port-Of: odoo/enterprise#6486
Original PR description
Before this commit:
- When you click on a relational field on mobile, you are redirected
to a view with a "Quick search" filter which is undefined.
After this commit:
- The "Quick search" filter doesn't appears when he doesn't have
the necessary data to work correctly.
OPW-2090181
Forward-Port-Of: odoo/enterprise#6486With db's having a lot of rental products, the group_expand to see all products in the gantt view is useless. Indeed, seeing 2k empty sections in a gantt view is just useless. Forward-Port-Of: odoo/enterprise#6474
Original PR description
With db's having a lot of rental products, the group_expand to see all products in the gantt view is useless. Indeed, seeing 2k empty sections in a gantt view is just useless. Forward-Port-Of: odoo/enterprise#6474
Wrong model for the search Forward-Port-Of: odoo/enterprise#6466
Original PR description
Wrong model for the search Forward-Port-Of: odoo/enterprise#6466
After 267123d, the action was called from accout_reports but was defined in account_followup. Everything should be done in account_reports because reports doesn't depend on followup; its the opposite. Forward-Port-Of: odoo/enterprise#6468
Original PR description
After 267123d, the action was called from accout_reports but was defined in account_followup. Everything should be done in account_reports because reports doesn't depend on followup; its the opposite. Forward-Port-Of: odoo/enterprise#6468
- Open the Balance Sheet report - Applies a custom comparison, date = December 31st 2018 The template rendering crashes because there is no key `options['comparison']['date']`. opw-2092299 Forward-Port-Of: odoo/enterprise#6473
Original PR description
- Open the Balance Sheet report - Applies a custom comparison, date = December 31st 2018 The template rendering crashes because there is no key `options['comparison']['date']`. opw-2092299 Forward-Port-Of: odoo/enterprise#6473
cf feedback at opw-2093823 Forward-Port-Of: odoo/enterprise#6463
Original PR description
cf feedback at opw-2093823 Forward-Port-Of: odoo/enterprise#6463