Daily updates from Odoo
Navigate
Branch
Tuesday, November 5, 2019
17 changes
Enhancements to existing features
Website profiles can now rank users by recent karma gains for the past week or month, in addition to total karma. This helps communities highlight currently active contributors while keeping the tracking data consolidated and private.
Original PR description
PURPOSE Allow karma gain tracking enabling notably display of top users based on weekly / monthly gain in website profile. SPECIFICATIONS Each time a user gains karma a record is created in the gamification karma tracking model. Scheduled activity runs to consolidate the records into monthly gain records to avoid having crowdy table and unnecessary noise in karma gain. This model is made private and only accessible through some dedicated compute methods / controllers used in website profile. In website profile module buttons are added to see users ranking based on their total karma (like before) but also by last week and last month gains (using the newly introduced tracking model). Some fixes are provided in this merge as well as tests. LINKS Task ID 2003505 PR #34594
Changes made to down payment invoices, such as taxes or amounts, are now reflected back on the related sales order when the invoice is posted. This keeps sales order totals and final invoice calculations accurate, especially when down payments are partially or fully refunded.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The point-of-sale payment screen now shows the total, amount due, and change in one clear area instead of scattering values across payment lines. It also improves handling of electronic terminal payments so pending or invalid payments are not double-counted or saved by mistake.
Original PR description
The previous behavior is that the change is displayed at each payment line and the remaining is displayed at the bottom. Also, total amount is lost in the screen. This commit addresses this issue by showing the values of remaining amount and change at just one area of the payment screen. TASK-ID: 1984690 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Bank statements can now automatically fill starting and ending balances from the previous statement, helping avoid gaps between statements. This improves usability for imported or synchronized statements and keeps later statements aligned when a statement is inserted between existing ones.
Original PR description
To prevent having holes between statements and for better usability using import and synchronization we try to automatically set the starting and ending balance based on the previous existing statement. To do that, we added a new field previous_statement_id so that whenever we change the ending_balance of the previous statement, we recompute the starting balance and ending balance of the current statement. Also creating a new statement in between 2 others statements will automatically set the correct value to the starting and ending balance of that statement and all the statements afterwards. Exception: creating a statement by hand won't automatically set the balance_end_real, however if you create one between 2 statements, the balance_end_real of next statements will be recomputed -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Odoo's internal test tools now support custom messages when checking that errors are raised, matching standard Python behavior. This helps developers understand test failures more quickly and keeps existing tests aligned with expected conventions.
Original PR description
The unittest signature of `assertRaises` allows a named parameter `msg`. (see the official documentation [1]). The message is displayed in case of assertion failure. The Odoo implementation of assertRaises does not implement it but many occurences are found in Odoo tests. Odoo developpers usually expect the same signature as found in the unittest documentation. This commit implements the `msg` parameter in a similar way as unittest. [1] https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRaises -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Users can now start reconciliation directly when viewing a specific partner in the partner ledger. This reduces extra navigation for accounting teams and makes it easier to clean up partner balances from the report context.
Original PR description
Task [2092080](https://www.odoo.com/web#id=2092080&action=333&active_id=967&model=project.task&view_type=form&menu_id=4720) Allow reconciling entries for a dedicated partner when we are browsing their data in the partner ledger. The template was already correct in `account_reports.line_template_partner_ledger_report` but the needed value partner_id was never set in _get_report_line_partner
Resolved issues and error corrections
This update cleans up documentation issues that were causing build warnings. It removes references to outdated test tags and corrects minor JavaScript reference warnings, helping keep Odoo's documentation accurate and easier to maintain.
Original PR description
* Since https://github.com/odoo/odoo/commit/8d5da6e4be05428f3243f92c0464d3c1f6a43873, `post_install` and `at_install` test tags have been removed. * minor warnings in javascript reference. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Online bank synchronization now groups imported transactions by their actual transaction dates instead of only looking at the most recent statement. This prevents transactions from being placed in the wrong daily or periodic statement and may reopen a posted statement when a matching transaction needs to be added.
Original PR description
Previously we were splitting transactions in the following way: We only checked the last statement date and based on the split frequency we decided if we had to create a new statement or not. We did not take into account the transactions date at all, which means that it was possible to have daily statement with transactions from another date. Now we base ourselves on the transactions date and we move each transactions to the correct statement based on the spit frequency. -> This implies some changes, if the transactions has to be put in a posted bank statement, we will add the line inside and reset the statement to 'draft'. Other transactions will be created in new statements which can possibly be between two others statements.
Code cleanup and technical improvements
This update removes an old compatibility helper that is no longer needed and simplifies how internal errors are re-raised. It should make the codebase easier to maintain while preserving existing error behavior for users and administrators.
Original PR description
@Elkasitu @rco-odoo pycompat.reraise had few callsites, and for most `reraise` is needless complexity since P3 chains exceptions by default. There is one callsite where things are a bit less trivial, but I think removing reraise still makes things *better* (nb: reraising the exception object itself also works but see commit messages for rationale, and note that per its original comment _handle_exception can be called from outside of an `except` block which is why a plain `raise` doesn't work). Also removed unused `collections` import and outdated comment from pycompat.
Miscellaneous changes
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39819
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39819
Go on the accounting module, you'll find a kanban view with a few cards including "Bank" and "Cash". Click on the Cash card. The default import button doesn't appears because it is hidden. The reason of this hiding is that the bank statements of type "Bank" have a custom import method and the users where confuse. They didn't know which is the right button for the special import so we hid the default import button for the whole model. But there is also a "Cash" type bank statement who
Original PR description
Go on the accounting module, you'll find a kanban view with a few cards including "Bank" and "Cash". Click on the Cash card. The default import button doesn't appears because it is hidden. The reason of this hiding is that the bank statements of type "Bank" have a custom import method and the users where confuse. They didn't know which is the right button for the special import so we hid the default import button for the whole model. But there is also a "Cash" type bank statement who doesn't have that special import and his default import button is hidden too. This commit checks the type of the bank statement and hide the default import button only if the type is not "Cash". OPW-2090477 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39787
In 6b048a8b8 most issue with trigger causing error when uninstalling a module were solved. But there was a particular case if the current uninstallation of modules there was an update of `ir.model.fields.selection` to be removed. The unlink of `ir.model.fields.selection` would cause a `setup_models` call that would add all removed triggers back and possibly down the line cause an trigger recomputation error. With this changeset, we do as is already done for ir.model.fields and do not re-initia
Original PR description
In 6b048a8b8 most issue with trigger causing error when uninstalling a module were solved. But there was a particular case if the current uninstallation of modules there was an update of `ir.model.fields.selection` to be removed. The unlink of `ir.model.fields.selection` would cause a `setup_models` call that would add all removed triggers back and possibly down the line cause an trigger recomputation error. With this changeset, we do as is already done for ir.model.fields and do not re-initialize the registry during module uninstallation. opw-2098915 Forward-Port-Of: odoo/odoo#39796
When building the MS Windows package, the PYTHON_VERSION variable is not used and the WinPython path is hard coded in the Makefile and NSI file. This prevent the usage of a newer version of Python. With this commit, the PYTHON_VERSION is used to compute the WinPython Python directory. That way, this directory can be derived from package.py command line argument --vm-winxp-python-version. Also the less windows binaries are not packaged anymore. Forward-Port-Of: odoo/odoo#39816
Original PR description
When building the MS Windows package, the PYTHON_VERSION variable is not used and the WinPython path is hard coded in the Makefile and NSI file. This prevent the usage of a newer version of Python. With this commit, the PYTHON_VERSION is used to compute the WinPython Python directory. That way, this directory can be derived from package.py command line argument --vm-winxp-python-version. Also the less windows binaries are not packaged anymore. Forward-Port-Of: odoo/odoo#39816
- Create a project - Create 3 tasks in the project (top, middle, bottom) - Set top as the parent of middle - Set middle as the parent of bottom We don't want to allow multi level subtasks. The behavior is not the same if you set middle as the parent of bottom first. The "parent task" field will not be displayed. This commit remove the tasks who have a parent from the m2o field. OPW-2087921 Description of the issue/feature this PR addresses: Current behavior before PR: Desi
Original PR description
- Create a project - Create 3 tasks in the project (top, middle, bottom) - Set top as the parent of middle - Set middle as the parent of bottom We don't want to allow multi level subtasks. The behavior is not the same if you set middle as the parent of bottom first. The "parent task" field will not be displayed. This commit remove the tasks who have a parent from the m2o field. OPW-2087921 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39718
URLs with parameters were not correctly supported by the regular expression. For example, URLs with parameters were truncated before the `?`. This patch adds support for a wider range of URLs, and checks in a test that the parameters are correctly handled. Forward-Port-Of: odoo/odoo#39716
Original PR description
URLs with parameters were not correctly supported by the regular expression. For example, URLs with parameters were truncated before the `?`. This patch adds support for a wider range of URLs, and checks in a test that the parameters are correctly handled. Forward-Port-Of: odoo/odoo#39716
Someone new to Linux can run into problems when some system dependencies are missing. There is a single sentence warning talking about those hard dependencies and it does not explain how to install them. Added two § containing the missing `apt` commands required to install the dependencies on a fresh debian minimal install. Forward-Port-Of: odoo/odoo#38948
Original PR description
Someone new to Linux can run into problems when some system dependencies are missing. There is a single sentence warning talking about those hard dependencies and it does not explain how to install them. Added two § containing the missing `apt` commands required to install the dependencies on a fresh debian minimal install. Forward-Port-Of: odoo/odoo#38948
- Create an event - Add a mail reminder for it - Run the mail scheduler manually - Duplicate the event The mail reminder is sent on the duplicate too. This commit remove the field `mail_sent` from duplicating. OPW-2117343 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39742
Original PR description
- Create an event - Add a mail reminder for it - Run the mail scheduler manually - Duplicate the event The mail reminder is sent on the duplicate too. This commit remove the field `mail_sent` from duplicating. OPW-2117343 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39742