Daily updates from Odoo
Wednesday, November 13, 2019
20 changes
Resolved issues and error corrections
This update aligns many business screens and view definitions with stricter internal validation rules. It helps prevent display or configuration issues across accounting, HR, documents, subscriptions, inventory, manufacturing, and related apps without changing day-to-day workflows.
Miscellaneous changes
Planning a production for a product tracked by serial number will set 1 as quantity on all workorders. This will implies to loose the info regarding the capacity and always planning only one batch of production even if the production quantity exceed the workcenter capacity Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-
Original PR description
Planning a production for a product tracked by serial number will set 1 as quantity on all workorders. This will implies to loose the info regarding the capacity and always planning only one batch of production even if the production quantity exceed the workcenter capacity Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39857
Make sure to update the standard price with the computed unit cost of the candidate and not its `unit_cost` field, as the computed could contain an extra value from a landed cost. Forward-Port-Of: odoo/odoo#40185
Original PR description
Make sure to update the standard price with the computed unit cost of the candidate and not its `unit_cost` field, as the computed could contain an extra value from a landed cost. Forward-Port-Of: odoo/odoo#40185
Forward-Port-Of: odoo/odoo#40184
Original PR description
Forward-Port-Of: odoo/odoo#40184
**Description of the issue/feature this PR addresses:** Without this commit, if you have the `hr_timesheet` installed, the one2many analytic lines view (in the `Journal Items` form) shows the `hr_timesheet_line_tree` view instead, which is not desired. **Current behavior before PR:** With `hr_timesheet` installed:  **Desired behavior after PR is merged:** With `
Original PR description
**Description of the issue/feature this PR addresses:** Without this commit, if you have the `hr_timesheet` installed, the one2many analytic lines view (in the `Journal Items` form) shows the `hr_timesheet_line_tree` view instead, which is not desired. **Current behavior before PR:** With `hr_timesheet` installed:  **Desired behavior after PR is merged:** With `hr_timesheet` installed:  -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39754 Forward-Port-Of: odoo/odoo#39670
Introduced by https://github.com/odoo/odoo/commit/ab483a3a6610a09391ec00e9c1c49489ca4a4f12 There was no way to exit the 'cancelled' state of an account.payment. The new live-cycle is: - draft -> posted -> sent -> reconciled -> cancelled - action_draft to move the account.payment from ('cancelled', 'posted', 'sent', 'reconciled') -> 'draft' - cancel to move the account.payment from 'draft' -> 'cancel' -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Original PR description
Introduced by https://github.com/odoo/odoo/commit/ab483a3a6610a09391ec00e9c1c49489ca4a4f12
There was no way to exit the 'cancelled' state of an account.payment.
The new live-cycle is:
- draft -> posted -> sent -> reconciled -> cancelled
- action_draft to move the account.payment from ('cancelled', 'posted', 'sent', 'reconciled') -> 'draft'
- cancel to move the account.payment from 'draft' -> 'cancel'
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#40179Add information for end-users about the documentation eLearning and scale-up, the [business game](https://www.odoo.com/page/scale-up-business-game). -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40008
Original PR description
Add information for end-users about the documentation eLearning and scale-up, the [business game](https://www.odoo.com/page/scale-up-business-game). -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40008
self.env.user returns the current user but browsed with the superuser: - self.env.user == current user - self.env.user.env.user == administrator get_context uses self.env.user to retrieve the context of the user. Before this patch, the name of the filters was translated in the language of the administrator instead of the current user. Closes odoo/odoo#40086 Forward-Port-Of: odoo/odoo#40142 Forward-Port-Of: odoo/odoo#40108
Original PR description
self.env.user returns the current user but browsed with the superuser: - self.env.user == current user - self.env.user.env.user == administrator get_context uses self.env.user to retrieve the context of the user. Before this patch, the name of the filters was translated in the language of the administrator instead of the current user. Closes odoo/odoo#40086 Forward-Port-Of: odoo/odoo#40142 Forward-Port-Of: odoo/odoo#40108
In IE Edge async and await are supported, but guardedCatch is added to polyfilled MyPromise object and async methods return original Promise so depending of chain guardedCatch can cause en error or not. It seems that historically, the MyPromise patching has also had issue in firefox with it sometimes working or not. In this changeset we completely remove it (which will have the drawback of more error shown in console in firefox). opw-2116839 closes #39946 Forward-Port-Of: odoo/odo
Original PR description
In IE Edge async and await are supported, but guardedCatch is added to polyfilled MyPromise object and async methods return original Promise so depending of chain guardedCatch can cause en error or not. It seems that historically, the MyPromise patching has also had issue in firefox with it sometimes working or not. In this changeset we completely remove it (which will have the drawback of more error shown in console in firefox). opw-2116839 closes #39946 Forward-Port-Of: odoo/odoo#39953
* In a pos-session with table management create a new order with products and go back to the floor-plan. * The order is sinced to the back-end. * Open the table again, remove all products but keep the order. * Go back to floorplan to trigger syncing again. * Open the table again. behaviour before fix: * The empty order is not loaded in the frontend anymore. * To close the session the order has to be manually removed in the backend. After fix: * The order is still visible in the fro
Original PR description
* In a pos-session with table management create a new order with products and go back to the floor-plan. * The order is sinced to the back-end. * Open the table again, remove all products but keep the order. * Go back to floorplan to trigger syncing again. * Open the table again. behaviour before fix: * The empty order is not loaded in the frontend anymore. * To close the session the order has to be manually removed in the backend. After fix: * The order is still visible in the frontend and can be removed or finalysed as expected. solves https://github.com/odoo/odoo/issues/40053 Forward-Port-Of: odoo/odoo#40103
Add the id of the current company to the evaluation context for ir.rule domains Forward-Port-Of: odoo/odoo#40035
Original PR description
Add the id of the current company to the evaluation context for ir.rule domains Forward-Port-Of: odoo/odoo#40035
Fine tuning of this commit: f93fcaffb5287bc6ff52e33e3cc9edecb50058c4 Steps to reproduce the bug: - Open runbot v11 - Restrict Demo's access to Sales Manager for sales and employee for Employee - Try to create a new quotation Bug: - You got Odoo server Error Sorry, you are not allowed to access this document. Only users with the following access level are currently allowed to do that: - Inventory/User - Accounting & Finance/Billing - Purchases/User - Purchases/Manager - Other Ex
Original PR description
Fine tuning of this commit: f93fcaffb5287bc6ff52e33e3cc9edecb50058c4 Steps to reproduce the bug: - Open runbot v11 - Restrict Demo's access to Sales Manager for sales and employee for Employee - Try to create a new quotation Bug: - You got Odoo server Error Sorry, you are not allowed to access this document. Only users with the following access level are currently allowed to do that: - Inventory/User - Accounting & Finance/Billing - Purchases/User - Purchases/Manager - Other Extra Rights/Portal (Document model: purchase.order.line) - (Operation: read, User: 5) opw:2120692 Forward-Port-Of: odoo/odoo#40094
**[IMP] account: Remove dead code** This field has been introduced by 2d1b8e9 but is no longer used anywhere and is not a valid field on account.move.line. **[FIX] account: Fix lost constraint during the account-pocalypse** A journal entry must always have the same currency as the account when a secondary currency is set on this one. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39744
Original PR description
**[IMP] account: Remove dead code** This field has been introduced by 2d1b8e9 but is no longer used anywhere and is not a valid field on account.move.line. **[FIX] account: Fix lost constraint during the account-pocalypse** A journal entry must always have the same currency as the account when a secondary currency is set on this one. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#39744
- Go to Account > Configuration > Asset Models - Set a Fixed Asset Account - Set a different Depreciation Account The Fixed Asset Account is overwritten. If it is set, it should not be changed. opw-2116305 Forward-Port-Of: odoo/enterprise#6670
Original PR description
- Go to Account > Configuration > Asset Models - Set a Fixed Asset Account - Set a different Depreciation Account The Fixed Asset Account is overwritten. If it is set, it should not be changed. opw-2116305 Forward-Port-Of: odoo/enterprise#6670
- Go to Account > Configuration > Deferred Revenue Models - Duplicate the demo record - Save Impossible to save because Fixed Asset Account is mandatory but not set. Moreover, it is hidden, so there is no way to set it. Since `original_move_line_ids` is empty, the computation of the field result in a `False` value. We force the value when copying in order to keep it. opw-2122998 Forward-Port-Of: odoo/enterprise#6666
Original PR description
- Go to Account > Configuration > Deferred Revenue Models - Duplicate the demo record - Save Impossible to save because Fixed Asset Account is mandatory but not set. Moreover, it is hidden, so there is no way to set it. Since `original_move_line_ids` is empty, the computation of the field result in a `False` value. We force the value when copying in order to keep it. opw-2122998 Forward-Port-Of: odoo/enterprise#6666
WARNING on module for missing model description was fixed. ``` WARNING openerp_test odoo.models: The model l10n_mx.trial.closing.report has no _description ``` Forward-Port-Of: odoo/enterprise#6665
Original PR description
WARNING on module for missing model description was fixed. ``` WARNING openerp_test odoo.models: The model l10n_mx.trial.closing.report has no _description ``` Forward-Port-Of: odoo/enterprise#6665
Correct the current company in a force domain in the ir_rule to be compatible with the new multi-company behaviour. opw-2093198 Forward-Port-Of: odoo/enterprise#6622
Original PR description
Correct the current company in a force domain in the ir_rule to be compatible with the new multi-company behaviour. opw-2093198 Forward-Port-Of: odoo/enterprise#6622
Forward-Port-Of: odoo/enterprise#6660
Original PR description
Forward-Port-Of: odoo/enterprise#6660
Now Banxico provides the rate that will be used in the CFDIs every day, and the date could be used as parameter to get the specific date. With this, Banxico provides the serie ``SF60653``, and that serie returns the rate that must be used in the day that is downloaded. The day -1 now is incorrect, because uses the rate from the last day. Forward-Port-Of: odoo/enterprise#6647 Forward-Port-Of: odoo/enterprise#6485
Original PR description
Now Banxico provides the rate that will be used in the CFDIs every day, and the date could be used as parameter to get the specific date. With this, Banxico provides the serie ``SF60653``, and that serie returns the rate that must be used in the day that is downloaded. The day -1 now is incorrect, because uses the rate from the last day. Forward-Port-Of: odoo/enterprise#6647 Forward-Port-Of: odoo/enterprise#6485
Reproduce this issue - Install Sales & Studio - Edit the Quotation/Order report with studio - Click on an element then click on the pencil of "Visible if" in the left sidebar - Select anything on the first domain field who make the third domain field appears It closes the dialog and doesn't apply the filter. Cause When editing the first domain field, the `_onDirectiveChange` method is called. This method triggers the `view_change` event
Original PR description
Reproduce this issue
- Install Sales & Studio
- Edit the Quotation/Order report with studio
- Click on an element then click on the pencil of "Visible if"
in the left sidebar
- Select anything on the first domain field who make the third
domain field appears
It closes the dialog and doesn't apply the filter.
Cause
When editing the first domain field, the `_onDirectiveChange`
method is called. This method triggers the `view_change` event
with the new attrs to apply on the field.
When you change the first domain field value, it calls the event
even if the new attrs are empty.
This commit prevent the event to be called if the new attrs are empty.
Forward-Port-Of: odoo/enterprise#6614