Daily updates from Odoo
Navigate
Branch
Friday, November 15, 2019
25 changes
Enhancements to existing features
Countries now have a dedicated indicator showing whether they accept SEPA payments, instead of relying on broader regional groupings like Europe. This improves payment and QR code reliability and removes an outdated BIC requirement for SEPA QR code generation.
Original PR description
Create a reliable way to know if a country accepts SEPA. Checking if country belongs to "europe" group IS NOT a valid way to know if it accepts SEPA. BIC is not mandatory anymore to generate SEPA QR Code task : https://www.odoo.com/web?#id=2056370&action=327&model=project.task&view_type=form&menu_id=4720
Luxembourg tax report lines now show concise code-only tag names instead of the full report line text. This makes reports easier to scan and also adds missing tags to several lines for more complete reporting.
Original PR description
show only code in 'Tag Name' instead of showing whole tax report line's string task: 1917932
This change adds automated checks for the Sales Timesheet project overview to confirm key reported values are prepared correctly. It helps reduce the risk of future changes breaking project overview information used by teams to monitor work and billing.
Original PR description
Task: https://www.odoo.com/web?#id=2084995&action=327&model=project.task&view_type=form&menu_id=4720 PAD: https://pad.odoo.com/p/r.65902a77d5c33be2d99788486317b69b
Resolved issues and error corrections
This fixes how Odoo tests its connection with Pingen, the external service used to print and mail PDF documents. The change ensures test documents are generated with the required visual assets, helping maintain compatibility with Pingen without changing day-to-day user workflows.
Original PR description
Pingen is a service that print (like really, using a printer) pdfs document in order to mail them (using the real post and postmen). In order to ensure we are compatible with their API, we send to their sandbox environment a bunch of standard documents (like an invoice). Those PDFs documents are generated our side using wkhtmltopdf but as the test were not started using a HttpCase, the assets were not correctly available. This also reverts commit 3f5a0a1ef46c3ae6c4ed318d05d519c9e85b4e3b.
Code cleanup and technical improvements
This change simplifies how purchase order taxes are calculated so there is a single, consistent source for the logic. It makes customization easier for implementers and reduces the risk of inconsistent tax behavior across purchase workflows.
Original PR description
Rebased on master as per: https://github.com/odoo/odoo/issues/21654#issuecomment-369258583 Authorized: https://github.com/odoo/odoo/issues/21654#issuecomment-369258583 **Description of the issue/feature this PR addresses:** - Code smell made it very complicated to cleanly override respective computation method in custom modules - Unverified: It smells like both implementations actually diverge. **Current behavior before PR:** - No clean inheritance in custom modules - Code smell, that smells. **Desired behavior after PR is merged:** - Fresh air - Clean inheritance **Note:** Please do not close, even if not immediately accepted (`wishlist` tag). This PR is meant to be carried along and actively maintained, until this semantic will be completed this way or another. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr @xoe-labs
Miscellaneous changes
When a call to init_models() fails, the post-init queue still contains callables that refer to a soon-to-be-closed cursor. If one calls init_models() in another request, the post-init process will inevitably fail because it refers to closed cursors. Forward-Port-Of: odoo/odoo#40358
Original PR description
When a call to init_models() fails, the post-init queue still contains callables that refer to a soon-to-be-closed cursor. If one calls init_models() in another request, the post-init process will inevitably fail because it refers to closed cursors. Forward-Port-Of: odoo/odoo#40358
Commit https://github.com/odoo/odoo/commit/f6bbc40fbe16ea5ab01ad03b8e1519c4e559bf6d introduced a method to destroy all current editors to refresh them when necessary... but forgot to empty the array that contains them. In a 12.0 without custo, this is only slowing down the editor but in master (or with custo) this makes the editor crash. Forward-Port-Of: odoo/odoo#40335
Original PR description
Commit https://github.com/odoo/odoo/commit/f6bbc40fbe16ea5ab01ad03b8e1519c4e559bf6d introduced a method to destroy all current editors to refresh them when necessary... but forgot to empty the array that contains them. In a 12.0 without custo, this is only slowing down the editor but in master (or with custo) this makes the editor crash. Forward-Port-Of: odoo/odoo#40335
The company_id field is present twice in the view. Fixes #40328 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40338
Original PR description
The company_id field is present twice in the view. Fixes #40328 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40338
- Create a tax of type "Fixed". - Put some name in its 'Label on Invoices' field. - Change the type to "group of taxes". The view hides the field Label on Invoices, since it doesn't make sense any more. However, it doesn't actually remove the label on invoices. As a result in the taxes list you can still see the old label on invoice information, this behaviour misleading. We modify an existing onchange to avoid that unfortunate situation. opw-2115984 Forward-Port-Of: odoo/odoo#40311
Original PR description
- Create a tax of type "Fixed". - Put some name in its 'Label on Invoices' field. - Change the type to "group of taxes". The view hides the field Label on Invoices, since it doesn't make sense any more. However, it doesn't actually remove the label on invoices. As a result in the taxes list you can still see the old label on invoice information, this behaviour misleading. We modify an existing onchange to avoid that unfortunate situation. opw-2115984 Forward-Port-Of: odoo/odoo#40311
Currently, if the first week day was Saturday the calendar week view would possibly get the wrong week. This is because current heuristic would get date of current week from 6 (Saturday) to 12 (Sunday). Thus if we were: - on Friday 14th, we would have a week day ranges: 15-21 (wrong) - on Saturday 15th, we would have a week day ranges: 15-21 (ok) - on Sunday 16th, we would have a week day ranges: 22-28 (wrong) So it would only get the right range when getting range from saturday.
Original PR description
Currently, if the first week day was Saturday the calendar week view would possibly get the wrong week. This is because current heuristic would get date of current week from 6 (Saturday) to 12…
Currently, if the first week day was Saturday the calendar week view would possibly get the wrong week. This is because current heuristic would get date of current week from 6 (Saturday) to 12 (Sunday). Thus if we were: - on Friday 14th, we would have a week day ranges: 15-21 (wrong) - on Saturday 15th, we would have a week day ranges: 15-21 (ok) - on Sunday 16th, we would have a week day ranges: 22-28 (wrong) So it would only get the right range when getting range from saturday. If a week: - start on monday, the week range would only be wrong on sunday. - start on sunday, the week range would always be alright. Added test without the fix fail: - CalendarView: Saturday week start week mode The domain to search events in should be correct (domain range 14-20 instead of correct 07-13 whilst the day was 12th) - CalendarView: Monday week start week mode The domain to search events in should be correct (domain range 16-22 instead of correct 09-15 whilst the day was 15th) opw-2091448 Forward-Port-Of: odoo/odoo#40296 Forward-Port-Of: odoo/odoo#40244
Description of the issue/feature this PR addresses: https://www.odoo.com/web#id=2122810&action=333&active_id=1691&model=project.task&view_type=form&menu_id=4720 Current behavior before PR: bad translations, redundant prefixes, click on VI. ... from Balance Sheet list details under, group by account_id, account 142 Equity, account 999999 exists Desired behavior after PR is merged: Good translations, no prefixes, click on VI. ... from Balance Sheet links to Profit & Loss, no group by, acc
Original PR description
Description of the issue/feature this PR addresses: https://www.odoo.com/web#id=2122810&action=333&active_id=1691&model=project.task&view_type=form&menu_id=4720 Current behavior before PR: bad translations, redundant prefixes, click on VI. ... from Balance Sheet list details under, group by account_id, account 142 Equity, account 999999 exists Desired behavior after PR is merged: Good translations, no prefixes, click on VI. ... from Balance Sheet links to Profit & Loss, no group by, account 142 Current Year Earnings, account 999999 doesn't exist Forward-Port-Of: odoo/odoo#40290
*: point_of_sale In c212cfe8992292f57acacd809de26e1817533095 the field 'datas_fname' was removed as it was mostly almost always a duplicate of the name or url field. Two uses of this field were not removed in the rest of the code, one in web_editor which caused a crash when trying to save a cropped image. There was also one in pos_order, which I changed at the same time, even though it isn't known to cause a bug yet, the create call is bound to fail if it is ever triggered. Forward-Por
Original PR description
*: point_of_sale In c212cfe8992292f57acacd809de26e1817533095 the field 'datas_fname' was removed as it was mostly almost always a duplicate of the name or url field. Two uses of this field were not removed in the rest of the code, one in web_editor which caused a crash when trying to save a cropped image. There was also one in pos_order, which I changed at the same time, even though it isn't known to cause a bug yet, the create call is bound to fail if it is ever triggered. Forward-Port-Of: odoo/odoo#40275
Reproduce this bug - Install Calendar - Create a recurring event starting at the date of yesterday (later than your actual time) - Set the recurrency to every day, 1 time (today) - Click on the today's event - Add attendees > Invitations > Send mail - Run the mail queue manually (Technical > Scheduled actions) The mail you sent are for the date of yesterday The behavior is the same for the reminders Cause The mail are sent with the `_s
Original PR description
Reproduce this bug - Install Calendar - Create a recurring event starting at the date of yesterday (later than your actual time) - Set the recurrency to every day, 1 time (today) - Click on the…
Reproduce this bug
- Install Calendar
- Create a recurring event starting at the date of yesterday
(later than your actual time)
- Set the recurrency to every day, 1 time (today)
- Click on the today's event
- Add attendees > Invitations > Send mail
- Run the mail queue manually (Technical > Scheduled actions)
The mail you sent are for the date of yesterday
The behavior is the same for the reminders
Cause
The mail are sent with the `_send_mail_to_attendees` method
who pass the attendee_id to the templates.
The `attendee_id.event_id` is always the first one.
This commit pass the correct event to the template via the context.
I replaced only the dates values in the template.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#40288
Forward-Port-Of: odoo/odoo#40166Promotion programs can be added in 3 ways, no_code_promo_program_ids, code_promo_program_id, and through applied_coupon_ids. So free delivery obtained by the two latter would not correctly update the cart page, because the result of _get_free_shipping_lines would be empty. Forward-Port-Of: https://github.com/odoo/enterprise/pull/6663 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have s
Original PR description
Promotion programs can be added in 3 ways, no_code_promo_program_ids, code_promo_program_id, and through applied_coupon_ids. So free delivery obtained by the two latter would not correctly update the cart page, because the result of _get_free_shipping_lines would be empty. Forward-Port-Of: https://github.com/odoo/enterprise/pull/6663 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40268
Before this fix translations of the order names missed a crusial space that is needed to get information out of it in the front-end. This fix adds a variable to the translation string making it more clear the space is part of the string. solves https://github.com/odoo/odoo/issues/40036 Forward-Port-Of: odoo/odoo#40252
Original PR description
Before this fix translations of the order names missed a crusial space that is needed to get information out of it in the front-end. This fix adds a variable to the translation string making it more clear the space is part of the string. solves https://github.com/odoo/odoo/issues/40036 Forward-Port-Of: odoo/odoo#40252
Closes odoo/odoo#29548 cc @blaggacao Forward-Port-Of: odoo/odoo#40283
Original PR description
Closes odoo/odoo#29548 cc @blaggacao Forward-Port-Of: odoo/odoo#40283
This is linked to this commit 30e4d89a62c21e76db651ca54f8c132b96e7668d. It came from a properly reviewed pull request so I assume the functionality is correct. We just need to correct this part. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40259
Original PR description
This is linked to this commit 30e4d89a62c21e76db651ca54f8c132b96e7668d. It came from a properly reviewed pull request so I assume the functionality is correct. We just need to correct this part. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40259
[FIX] web: moving non-all day events In a view month of calendar, when moving a non-all day event from a date A to a date B. Before this commit, the event will be changed to an all day event type. Now, the event will be staid unchanged, only the date will be updated. ---------------------------------------------- [FIX] web: hours in event detail In a view month of calendar, when seen the details of a non-all day event. Before this commit, the end hour was always 00h00m. Now
Original PR description
[FIX] web: moving non-all day events In a view month of calendar, when moving a non-all day event from a date A to a date B. Before this commit, the event will be changed to an all day event type. Now, the event will be staid unchanged, only the date will be updated. ---------------------------------------------- [FIX] web: hours in event detail In a view month of calendar, when seen the details of a non-all day event. Before this commit, the end hour was always 00h00m. Now, the end hour is the encoded one. Forward-Port-Of: odoo/odoo#40139
User Demo cannot access products views because he doesn't have the sale_manager rights.  Forward-Port-Of: odoo/enterprise#6636
Original PR description
User Demo cannot access products views because he doesn't have the sale_manager rights.  Forward-Port-Of: odoo/enterprise#6636
Description of the issue/feature this PR addresses: https://www.odoo.com/web#id=2122810&action=333&active_id=1691&model=project.task&view_type=form&menu_id=4720 Current behavior before PR: bad translations, redundant prefixes, click on VI. ... from Balance Sheet list details under, group by account_id, account 142 Equity, account 999999 exists Desired behavior after PR is merged: Good translations, no prefixes, click on VI. ... from Balance Sheet links to Profit & Loss, no group by, acc
Original PR description
Description of the issue/feature this PR addresses: https://www.odoo.com/web#id=2122810&action=333&active_id=1691&model=project.task&view_type=form&menu_id=4720 Current behavior before PR: bad translations, redundant prefixes, click on VI. ... from Balance Sheet list details under, group by account_id, account 142 Equity, account 999999 exists Desired behavior after PR is merged: Good translations, no prefixes, click on VI. ... from Balance Sheet links to Profit & Loss, no group by, account 142 Current Year Earnings, account 999999 doesn't exist Forward-Port-Of: odoo/enterprise#6721
In 55f0d485d8f the structure of menu was changed but there was an irreducible menu in website_studio. Thus it did not work, and with this change works once again. opw-2118567 Forward-Port-Of: odoo/enterprise#6723
Original PR description
In 55f0d485d8f the structure of menu was changed but there was an irreducible menu in website_studio. Thus it did not work, and with this change works once again. opw-2118567 Forward-Port-Of: odoo/enterprise#6723
- Go to Helpdesk > Configuration > Helpdesk Teams > [team] - Enable posting ticket from website - Create a form on the website with the action: Create a ticket - Add 2 fields: Customer Name and Customer Email - With the public user, submit a ticket using non-ascii characters in the email field It's not possible to create the ticket. The root cause is because `formataddr` doesn't support such emails. We fall back on a simple partner creation. opw-2092052 Forward-Port-Of: odoo/
Original PR description
- Go to Helpdesk > Configuration > Helpdesk Teams > [team] - Enable posting ticket from website - Create a form on the website with the action: Create a ticket - Add 2 fields: Customer Name and Customer Email - With the public user, submit a ticket using non-ascii characters in the email field It's not possible to create the ticket. The root cause is because `formataddr` doesn't support such emails. We fall back on a simple partner creation. opw-2092052 Forward-Port-Of: odoo/enterprise#6718 Forward-Port-Of: odoo/enterprise#6700
- the 'Mark as done' button should not be visible while the timer is running - the 'Send report' button should not be visible twice - the 'Mark as done' button should no longer be visible once the task is done TASK-ID: 2115879 Forward-Port-Of: odoo/enterprise#6522
Original PR description
- the 'Mark as done' button should not be visible while the timer is running - the 'Send report' button should not be visible twice - the 'Mark as done' button should no longer be visible once the task is done TASK-ID: 2115879 Forward-Port-Of: odoo/enterprise#6522
In the barcode app, select a picking and process only part of the reserved units. When validating the transfer, you get the wizard asking to create a back order/do not create a back order. After clicking on any of those buttons, the picking should be set as done and we should be redirected to the Kanban with the different operations. This isn't the case at the moment. After 0bf9217f01d8cf2b0fe1ed533c4afde9286bc909 the structure of the 'infos' variable has been changed, however the behav
Original PR description
In the barcode app, select a picking and process only part of the reserved units. When validating the transfer, you get the wizard asking to create a back order/do not create a back order. After clicking on any of those buttons, the picking should be set as done and we should be redirected to the Kanban with the different operations. This isn't the case at the moment. After 0bf9217f01d8cf2b0fe1ed533c4afde9286bc909 the structure of the 'infos' variable has been changed, however the behavior is the same: * On Apply (green button) infos is undefined * On Cancel (red button) infos is defined, contains special: true * On window close (x button) infos is undefined This change however affect how the "not special" case should be handled, because 'infos && !info.special' does not pass the check when infos is undefined opw-2124191 Forward-Port-Of: odoo/enterprise#6705
- Go to Accounting > Configuration > Financial Reports - Enable the hierarchy option on any report, e.g. Profit and Loss - Go to 'Profit and Loss' report - Expand the hierarchy - Click on 'Journal Items' A traceback appears. This is because `financial_group_line_id` is not an idea but `hierarchy_xxx`. This causes a crash at domain evaluation. opw-2123432 Forward-Port-Of: odoo/enterprise#6694
Original PR description
- Go to Accounting > Configuration > Financial Reports - Enable the hierarchy option on any report, e.g. Profit and Loss - Go to 'Profit and Loss' report - Expand the hierarchy - Click on 'Journal Items' A traceback appears. This is because `financial_group_line_id` is not an idea but `hierarchy_xxx`. This causes a crash at domain evaluation. opw-2123432 Forward-Port-Of: odoo/enterprise#6694