Daily updates from Odoo
Navigate
Branch
Thursday, November 28, 2019
39 changes
Enhancements to existing features
Accounting entries now keep a clearer history when key details are changed after an entry has been posted. This helps businesses trace edits to accounts, labels, references, tags, and due dates, supporting stronger compliance and review processes.
Original PR description
### Purpose: Audit Trail for accounting modifications. Since Odoo 13, posted journal entries can be changed until the period is locked. As a result, providing audit trail becomes an important topic, especially for suspense account, accruals, tax closing features when Odoo replace the account by itself or in case of massive editions from the list view. Now, some fields in account move and account move line are tracked. **List of these fields:** - account on account move line - label on account move line - ref on account move - tag on account move line - due date on account move line All these fields are tracked only if the move containing the account move line has been posted once. (It does mean that it could be in posted or draft(but posted before) state) **Task ID: 2061399** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Bank Identifier Codes are no longer required for SEPA payments, so this change removes BIC-related barriers when creating bank accounts, mandates, vendor bills, and credit transfers. It also improves SEPA country handling so QR codes and SEPA modules apply only where relevant.
Original PR description
{ As the SEPA BIC is no longer mandatory we simplify bank creation removing constrains about BIC }
As of 01/02/2016, the BIC is no longer mandatory, you can see the page 25 ==> https://www.febelfin.be/sites/default/files/2019-04/standard-xml-sdd-initiation-_v4.1a-en.pdf
As a result, in order to simplify both the code and the process, we don’t want anymore constrains about that.
task : https://www.odoo.com/web#id=2056370&action=327&model=project.task&view_type=form&menu_id=4720Italian electronic invoicing now blocks invoice validation when the seller's company tax representative is missing a required VAT number. This prevents invoices from being approved with incomplete mandatory tax information, reducing compliance issues.
Original PR description
Description of the issue/feature this PR addresses: - Related task: https://www.odoo.com/web?#id=1971512&model=project.task&view_type=form&menu_id=4720
Account groups are now organized automatically based on account codes, reducing manual setup during chart of accounts configuration. Businesses can still override group assignments for exceptions, while localization data has been updated to support the new behavior.
Original PR description
Task [2092104](https://www.odoo.com/web#id=2092104&action=333&active_id=967&model=project.task&view_type=form&menu_id=4720) Accounts group Hierarchy should be automatically well done without to have to specify the parent (based on the account group CODE) Before, we had to set all the accounts in the correct groups manually and it was cumbersome. Now: * No need to fulfill account group parent * No need to fulfill account group id on account We can still change the groups if there are exceptions; the groups are only set at create and write time. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fleet vehicles can now be linked to analytic accounts based on vehicle details, improving cost allocation and reporting. Employees also gain a mobility card number that can automatically carry over to assigned vehicles, reducing manual entry and improving fleet administration.
Original PR description
Create analytic account from fleet (and link it to vehicle) based on the plate and the fiscal deduction rate (if l10n_hr_payroll_fleet is installed). Add on employee a Mobility Card number. This number is set on vehicle when we put a partner linked to employee on a vehicle. taskID: 2127641 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Survey creators can now choose from several predefined certificate layouts when setting up certification documents. This makes it easier to produce polished certificates that fit different branding or presentation needs, with a preview available before use.
Original PR description
Description of the issue/feature this PR addresses: Allows template selection for the certification document when creating a survey. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Odoo’s web interface icons were updated to a newer FontAwesome version, aligning icon names and visuals with the newer library. This helps keep the user interface current and consistent while reducing the risk of outdated icons breaking in future updates.
Original PR description
[IMP] web: update to fontawesome 4.7.0 to 5.10.1
FontAwesome 5 introduced new names for some icons as described on
https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4#name-changes
TaskID: 2050241
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe default website shown for sample company and contact records is now set to www.example.com instead of www.yourcompany.com. This uses a neutral standard example domain, reducing confusion in demo or starter data.
Original PR description
Purpose ======== Change www.yourcompany.com default link for the 'Website' field of the res.company and res.partner to 'www.example.com' TaskID: 2129147 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
SEPA payment and direct debit workflows now allow IBAN bank accounts without requiring a BIC code, matching current SEPA rules. This simplifies bank account setup, vendor payments, QR code payment display, and direct debit mandate creation for eligible SEPA countries.
Original PR description
[IMP] various : remove-bic-constraint-on-sepa-operations
{ As the SEPA BIC is no longer mandatory we simplify bank creation removing constrains about BIC }
As of 01/02/2016, the BIC is no longer mandatory, you can see the page 25 ==> https://www.febelfin.be/sites/default/files/2019-04/standard-xml-sdd-initiation-_v4.1a-en.pdf
As a result, in order to simplify both the code and the process, we don’t want anymore constrains about that.
task : https://www.odoo.com/web#id=2056370&action=327&model=project.task&view_type=form&menu_id=4720Fleet vehicles can now automatically get an analytic account based on their license plate and fiscal deduction rate, helping companies track vehicle-related costs more consistently. Employees can also store a Mobility Card number, which is applied to vehicles when assigning a related employee partner.
Original PR description
Create analytic account from fleet (and link it to vehicle) based on the plate and the fiscal deduction rate (if l10n_hr_payroll_fleet is installed). Add on employee a Mobility Card number. This number is set on vehicle when we put a partner linked to employee on a vehicle. taskID: 2127641
Several Odoo screens and reports now use the newer FontAwesome icon names introduced in version 5. This keeps icons displaying consistently and helps maintain compatibility with the updated icon library, without changing business workflows.
Original PR description
FontAwesome 5 introduced new names for some icons as described on https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4#name-changes This commit replaces the old names to the new ones.
Financial reports now show hierarchy and subtotal options automatically when account groups exist for the selected company. This avoids unnecessary manual setup and prevents misleading hierarchy displays when accounts are not grouped.
Original PR description
The model account.group has changed and now takes a range of code prefixes.
Resolved issues and error corrections
This fixes an issue where rating values were not being converted properly in the Ratings module. The change helps ensure displayed or submitted ratings are accurate, improving reliability for feedback and customer satisfaction tracking.
Original PR description
TaskID: 2145481 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Manufacturing orders opened from the Inventory dashboard now default to a kanban view on mobile instead of a list view. This makes the information easier to browse and use on smaller screens, including when users are redirected from work orders to manufacturing orders.
Original PR description
**Task:** https://www.odoo.com/web#id=2127508&action=327&model=project.task&view_type=form&menu_id=4720 **Pad:** https://pad.odoo.com/p/r.ee4d17544d602a41dc738365c97ea7d4 **Description of the issue/feature this PR addresses:** previously, in the mobile view, while accessing Manufacturing orders from the dashboard in inventory, the default view was set to tree. changed it to be kanban instead. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix stops fleet vehicle odometer updates from being automatically posted into the vehicle chatter. It keeps vehicle communication logs cleaner so users can focus on meaningful messages and activities.
Original PR description
TaskID: 1931775 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Documentation and clarification updates
This pull request updates the corporate contributor agreement record for Avoin.Systems. It keeps Odoo's legal contribution documentation current, with no expected impact on product features or user workflows.
Miscellaneous changes
Reproduce the issue - Install eCommerce & Sales - Create a quotation - Preview - Switch to french on the website page - Click on "Signer & Payer" There is a lot of things not translated. Cause On the website, the route `/website/translations` is called. The route calls a method `_get_translation_frontend_modules_domain` which teturn a domain to list the domain adding web-translations and dynamic resources that may be used frontend views.
Original PR description
Reproduce the issue
- Install eCommerce & Sales
- Create a quotation
- Preview
- Switch to french on the website page
- Click on "Signer & Payer"
There is a lot of things not translated.
Cause
On the website, the route `/website/translations` is called.
The route calls a method `_get_translation_frontend_modules_domain`
which teturn a domain to list the domain adding web-translations and
dynamic resources that may be used frontend views.
The missing translations are in the web module and the module is not
loaded by the method.
This commit adds the `web` module to the domain.
OPW-2120397
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#40904
Forward-Port-Of: odoo/odoo#40873**[FIX] account: Don't generate 0 balance payment term lines** In the Mexican Localisation (l10n_mx), there is a "custom" behavior made when there is more than one payment term lines. Before the account-pocalypse, the receivable lines having a balance equals to zero was ignored. This commit aims to restore this behavior and then, fix l10n_mx. --issue: 2121973 **[FIX] account: Don't compute invoice_payment_state for Misc. Journal entry** The reason is the invoice_payment_state is
Original PR description
**[FIX] account: Don't generate 0 balance payment term lines** In the Mexican Localisation (l10n_mx), there is a "custom" behavior made when there is more than one payment term lines. Before the…
**[FIX] account: Don't generate 0 balance payment term lines** In the Mexican Localisation (l10n_mx), there is a "custom" behavior made when there is more than one payment term lines. Before the account-pocalypse, the receivable lines having a balance equals to zero was ignored. This commit aims to restore this behavior and then, fix l10n_mx. --issue: 2121973 **[FIX] account: Don't compute invoice_payment_state for Misc. Journal entry** The reason is the invoice_payment_state is tracked by the chatter and displayed when the field is recomputed during the 'post'. However, this field has no meaning in a Miscellaneous Journal entry. **[FIX] account: Fix amount_total_signed in account.move** The miscalleneous journal entries has displayed in the tree view with a negative amount in amount_total_signed that has no meaning. **[FIX] account: Fix mobile view of invoice's lines.** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41050
This commit applies the following CRUD rules: C : Any user can create. website.visitors are only created in sudo mode. R : everyone that should access to this model U : website_designer can update (even if only few fields are editable), mainly useful for language (+ system obviously) + livechat users as they are the guys who directly speaks with the visitors D : system + website_designer can delete, mainly useful to clean if necessary This fixes the 'can create' that should n
Original PR description
This commit applies the following CRUD rules:
C : Any user can create. website.visitors are only created in sudo mode.
R : everyone that should access to this model
U : website_designer can update (even if only few fields are editable),
mainly useful for language (+ system obviously)
+ livechat users as they are the guys who directly speaks with the visitors
D : system + website_designer can delete, mainly useful to clean if necessary
This fixes the 'can create' that should not be done by any users except the system.
Task ID: 2092502
Forward-Port-Of: odoo/odoo#40439cc @adr-odoo Forward-Port-Of: odoo/odoo#41008
Original PR description
cc @adr-odoo Forward-Port-Of: odoo/odoo#41008
Reproduce the issue - Select a language (done by default) - Install Project - Create a project - Create a task with a formatted date - Reset the language - Go on the project Traceback Cause In 7e42c663, I format the date_deadline based on the user's language but did'nt know that we could have no language selected. This commit uses the `format_date` method from `odoo.tools.misc` which fallback on the first language installed if there is no
Original PR description
Reproduce the issue
- Select a language (done by default)
- Install Project
- Create a project
- Create a task with a formatted date
- Reset the language
- Go on the project
Traceback
Cause
In 7e42c663, I format the date_deadline based on the user's language
but did'nt know that we could have no language selected.
This commit uses the `format_date` method from `odoo.tools.misc`
which fallback on the first language installed if there is no
language selected.
OPW-2146479
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#41037- Create a picking type with specific default locations, for type Manufacturing - Go to Inventory, click on the 'To Process' button - Create a MO The default locations are not taken into account. This is because the default picking type is not in the context. opw-2128182 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/
Original PR description
- Create a picking type with specific default locations, for type Manufacturing - Go to Inventory, click on the 'To Process' button - Create a MO The default locations are not taken into account. This is because the default picking type is not in the context. opw-2128182 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41035
Enable units of measure from Settings. Go to Point of Sale, enable "Invoicing" from the PoS, open the session, sell something specifing customer and invoice. Close the session and post. Check the sale order, UoM is specified. Now check the associated invoice, UoM is missing. This is because the UoM is not propagated from the sale order to the invoice. Adding the missing value opw-2129428 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forw
Original PR description
Enable units of measure from Settings. Go to Point of Sale, enable "Invoicing" from the PoS, open the session, sell something specifing customer and invoice. Close the session and post. Check the sale order, UoM is specified. Now check the associated invoice, UoM is missing. This is because the UoM is not propagated from the sale order to the invoice. Adding the missing value opw-2129428 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41018
Add tutorials/examples on multi-company features of the ORM. In master, will also contain information about new with_company feature. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40520
Original PR description
Add tutorials/examples on multi-company features of the ORM. In master, will also contain information about new with_company feature. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40520
Exceptions were logged to stderr so we couldn't see them when Odoo was running as a service on the IoT Box. We now redirect stderr to the logger to see track errors in the log file too. TaskID: 2146835 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41011
Original PR description
Exceptions were logged to stderr so we couldn't see them when Odoo was running as a service on the IoT Box. We now redirect stderr to the logger to see track errors in the log file too. TaskID: 2146835 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41011
We now support the RPI4 which has 2 micro-HDMI outputs, while the prvious driver only supported one display. We add support for a second display. TaskID: 2123511 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40427
Original PR description
We now support the RPI4 which has 2 micro-HDMI outputs, while the prvious driver only supported one display. We add support for a second display. TaskID: 2123511 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40427
Steps to reproduce the bug: - Let's consider two companies C1 and C2 - Let's consider website W - Activate multi-company - Disable common contact book and common catalog - Switch the superuser in company C2 - Activate pricelist - Create a public pricelist PL for C1 and available on W - Set up a pricelist with compute price = formula and based on = cost - Go Sales > Configuration > tick Multiple Sales Prices per Product and tick Prices computed from formulas - Create a portal user PU a
Original PR description
Steps to reproduce the bug: - Let's consider two companies C1 and C2 - Let's consider website W - Activate multi-company - Disable common contact book and common catalog - Switch the superuser in company C2 - Activate pricelist - Create a public pricelist PL for C1 and available on W - Set up a pricelist with compute price = formula and based on = cost - Go Sales > Configuration > tick Multiple Sales Prices per Product and tick Prices computed from formulas - Create a portal user PU and set PL on him - Create a product P with cost = 10$ and publish it on W - Set up the product valuation as: automated - Log as PU and go on the shop - Put P on your cart Bug: The price of P was 0$ instead of 10$ opw:2092695 Forward-Port-Of: odoo/odoo#40929
Before this commit, the export of translations was incorrect for code and model translations: For code translations, the field 'name' was used for the matching while the _() method explicitly use None in the _get_source call to only use the field 'src' for the search. For model translations, the field 'res_id' was not used when searching for a translation. For instance, if a ir.model.fields did not have translated label, exporting the translations was using the translations of the fi
Original PR description
Before this commit, the export of translations was incorrect for code and model translations: For code translations, the field 'name' was used for the matching while the _() method explicitly use None in the _get_source call to only use the field 'src' for the search. For model translations, the field 'res_id' was not used when searching for a translation. For instance, if a ir.model.fields did not have translated label, exporting the translations was using the translations of the first field having the same source. While this could be convient during the import (to be discussed), doing so in an export of translation is clearly an unexpected side-effect. Forward-Port-Of: odoo/odoo#40879
Changing a product type from consumable to storable and and vice versa can make the quantity in stock confusing. As only storable product update the stock quants, the amount on stock moves could be diffenrent that the one on stock quant if the product type has been changed in the past. This commit will make those changes saved in the chatter history in order to easily track inconsistencies opw: 2125124 Description of the issue/feature this PR addresses: Current behavior before PR
Original PR description
Changing a product type from consumable to storable and and vice versa can make the quantity in stock confusing. As only storable product update the stock quants, the amount on stock moves could be diffenrent that the one on stock quant if the product type has been changed in the past. This commit will make those changes saved in the chatter history in order to easily track inconsistencies opw: 2125124 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40933 Forward-Port-Of: odoo/odoo#40653
A customer reported a problem when he deleted a language on the website app. In some cases, if you go on the odoo's generated website as a public user let's imagine the following url: website.com/en_GB The lang is saved in a cookie and sent to the context. If you delete the language from the website languages (without deactivating it) and you go on website.com as a public user, the method will try to use the context or the cookie value which is 'en_GB' and it crashes. This commi
Original PR description
A customer reported a problem when he deleted a language on the website app. In some cases, if you go on the odoo's generated website as a public user let's imagine the following url: website.com/en_GB The lang is saved in a cookie and sent to the context. If you delete the language from the website languages (without deactivating it) and you go on website.com as a public user, the method will try to use the context or the cookie value which is 'en_GB' and it crashes. This commit makes sure that the language is available OPW-2129580 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#40792
- Set the computer TZ so that it is UTC day + 1. For example, set to 'Australia/Adelaide' and perform the tests after 3:00 pm - Go to Account > Customers > Invoices - Set the Invice Date to today in the TZ You receive the warning 'This date is on the future...' The comparison of a UTC date without time `currentDate` is inconsistent with `moment()`, which is not UTC and has a time set. After playing around with `.utc()` and `startOf('d')` with no luck, we decided to give up the id
Original PR description
- Set the computer TZ so that it is UTC day + 1. For example, set to
'Australia/Adelaide' and perform the tests after 3:00 pm
- Go to Account > Customers > Invoices
- Set the Invice Date to today in the TZ
You receive the warning 'This date is on the future...'
The comparison of a UTC date without time `currentDate` is inconsistent
with `moment()`, which is not UTC and has a time set.
After playing around with `.utc()` and `startOf('d')` with no luck, we
decided to give up the idea of making `getTZOffset()` enter the game and
simply compare the string formatted values.
opw-2093186
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#40950Before that, the name of the current company was used. It was plain wrong, as a new company would then never receive its name as default value for this field (while it obviously should have). Forward-port of https://github.com/odoo/enterprise/pull/6827 Forward-Port-Of: odoo/enterprise#6898 Forward-Port-Of: odoo/enterprise#6828
Original PR description
Before that, the name of the current company was used. It was plain wrong, as a new company would then never receive its name as default value for this field (while it obviously should have). Forward-port of https://github.com/odoo/enterprise/pull/6827 Forward-Port-Of: odoo/enterprise#6898 Forward-Port-Of: odoo/enterprise#6828
If the shift was open during a restart the MPD server or a reboot of the terminal, the shift was automatically re-opened but the configuration (language) was lost. Furthermore, we used to check the state before opening/closing, which was useless because EFT_Open and EFT_Close already do it. Forward-Port-Of: odoo/enterprise#6891
Original PR description
If the shift was open during a restart the MPD server or a reboot of the terminal, the shift was automatically re-opened but the configuration (language) was lost. Furthermore, we used to check the state before opening/closing, which was useless because EFT_Open and EFT_Close already do it. Forward-Port-Of: odoo/enterprise#6891
The date set in the exported file should be the batch date, not the creation date. opw-2123257 Forward-Port-Of: odoo/enterprise#6822
Original PR description
The date set in the exported file should be the batch date, not the creation date. opw-2123257 Forward-Port-Of: odoo/enterprise#6822
reproduction steps: -install invoice and ln10_mx_edi modules -(optional step) go to settings>technical>views and find the view named report_document_invoice_mx and remove t-if on "Unit Code" and "Product Code" (this makes the issue obvious) -preview an invoice in html -result: the table cells are shifted by one cell to the left after the third index this issue appears for every child of addons/account/views/report_invoice.xml when they use cell's indexes as xpath selector reason: the
Original PR description
reproduction steps:
-install invoice and ln10_mx_edi modules
-(optional step) go to settings>technical>views and find the view named
report_document_invoice_mx and remove t-if on "Unit Code" and "Product Code"
(this makes the issue obvious)
-preview an invoice in html
-result: the table cells are shifted by one cell to the left after the third index
this issue appears for every child of addons/account/views/report_invoice.xml
when they use cell's indexes as xpath selector
reason: the parent view has an header ("Source Document") with no
associated cell, this shifts every cell's after that index
https://github.com/odoo/odoo/blob/2966ee59cabc2bbae91e4ac4701fc393bc3770ae/addons/account/views/report_invoice.xml#L55
previous behavior:
xml views inheriting report_invoice.xml have layout issues
current behavior:
the layout is set to the proper index
opw-2122066
Forward-Port-Of: odoo/enterprise#6883- Create a BOM with a routing; the routing contains a measure check - Create a MO for 10 units, plan - In the WO, produce 1 unit and measure, record the production It is not possible to change the quantity for the second measure. This is due to the condition `quality_state == 'none'`, which takes into account all checks while it should only take into account the ones matching the `finished_product_sequence`. opw-2127665 Forward-Port-Of: odoo/enterprise#6933
Original PR description
- Create a BOM with a routing; the routing contains a measure check - Create a MO for 10 units, plan - In the WO, produce 1 unit and measure, record the production It is not possible to change the quantity for the second measure. This is due to the condition `quality_state == 'none'`, which takes into account all checks while it should only take into account the ones matching the `finished_product_sequence`. opw-2127665 Forward-Port-Of: odoo/enterprise#6933
- Get a CAMT053 file containing information for 2 bank accounts A & B - In one of the statements (e.g. account B), no transaction is provided - Import the file in account B An error is raised: "This file doesn't contain any transaction" This is confusing for the end user: the file may contain transactions, but for another account. opw-2123057 Forward-Port-Of: odoo/enterprise#6915
Original PR description
- Get a CAMT053 file containing information for 2 bank accounts A & B - In one of the statements (e.g. account B), no transaction is provided - Import the file in account B An error is raised: "This file doesn't contain any transaction" This is confusing for the end user: the file may contain transactions, but for another account. opw-2123057 Forward-Port-Of: odoo/enterprise#6915
[FIX] sale_ebay: fix product image upload Revert 495875153b and actually solve the problem it was trying to solve. Ebay introduced a breaking change: instead of just displaying a warning when uploading a too small image, it started to return an error. The current condition is that images should be of at least 500 pixels on the longest side. Instead of filtering images based on this condition, it broke the image uploading feature by only checking the attachment on the res_field 'ima
Original PR description
[FIX] sale_ebay: fix product image upload Revert 495875153b and actually solve the problem it was trying to solve. Ebay introduced a breaking change: instead of just displaying a warning when…
[FIX] sale_ebay: fix product image upload Revert 495875153b and actually solve the problem it was trying to solve. Ebay introduced a breaking change: instead of just displaying a warning when uploading a too small image, it started to return an error. The current condition is that images should be of at least 500 pixels on the longest side. Instead of filtering images based on this condition, it broke the image uploading feature by only checking the attachment on the res_field 'image', and started to ignore all other attachments. [IMP] sale_ebay: only upload images following ebay guidelines There are more conditions to check for an image to be valid for ebay. We don't implement the check on the size, which is partially redundant with the maximal image size. Heavy lossless images might go above the 7mb limit for images hosted on eBay, but to compute it accurately we need to save the file on disk, so we'll just skip it. opw 2126399 Should be backported for v11 (495875153b appeared in v12) Forward-Port-Of: odoo/enterprise#6896 Forward-Port-Of: odoo/enterprise#6866
Reproduce the issues - Install website calendar & calendar - Create an online appointment for marc demo every day - Create a recurrent event (full day) for every day during 2 months - Add marc demo the to attendees of the event - Go on the online appointment page as any user 500 error By the way there is another issue, when the 500 error is fixed, you can select any day. This should not be possible since we have a recurrent event every day => th
Original PR description
Reproduce the issues - Install website calendar & calendar - Create an online appointment for marc demo every day - Create a recurrent event (full day) for every day during 2 months - Add marc demo…
Reproduce the issues
- Install website calendar & calendar
- Create an online appointment for marc demo every day
- Create a recurrent event (full day) for every day during 2 months
- Add marc demo the to attendees of the event
- Go on the online appointment page as any user
500 error
By the way there is another issue, when the 500 error is fixed,
you can select any day. This should not be possible since we
have a recurrent event every day => there should be 0 day available.
Cause
500 error: we compare string date to datetime
the other issue: when an event is full day, the start hour is fixed
to 8 AM. The others slots (10 AM, etc) are ignored when we compare
the datetimes.
This commit:
- renames `x_dt_string` into `x_dt` because thoses are not strings (misleading)
- converts the strings to datetime when comparing it
- compare date for the events in scope instead of the datetime (the check
for the datetime is done after anyway)
Forward-Port-Of: odoo/enterprise#6910