Daily updates from Odoo
Tuesday, December 10, 2019
38 changes · master
Enhancements to existing features
The project form now places its activity panel below the main content instead of taking up a large side area on wide screens. This gives users more room to view and edit project details, especially since the panel does not support discussions in this context.
Original PR description
Description of the issue/feature this PR addresses: Task: https://www.odoo.com/web?#id=2125078&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.50cea56dd4c2c535cd76f38947ad1ab5 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Inventory adjustment users can once again include products with no remaining quantity, making stock counts more complete when needed. The inventory quantity lookup was also cleaned up for more consistent results, while unused view code was removed.
Original PR description
In the inventory adjustment form, readd (remove in 13.0) the option to include exhausted product. [REM] stock: remove dead code In views of stock inventory line, the view with the id "stock_inventory_line_tree" was not used. Then remove it, and rename the "stock_inventory_line_tree2" into "stock_inventory_line_tree". [REF] stock: remove and refactor quantities fetching In order to clean the fetching of quantities for a inventory, replace SQL query by a read_group. Also, the _computed_outdated and _get_inventory_lines_values use the same read_group to be consistent. task-2115194
Timesheet users can now see the remaining hours next to a task name in relevant views. This makes it easier to quickly understand task status while entering or editing timesheets, without changing task names everywhere in the system.
Original PR description
Show the remaining hours to timesheet on tasks. Allows to quickly evaluate task's state. This is done in the name_get of a task through a context key, because we need this different name on some views, not all. related task #1856139 Description of the issue/feature this PR addresses: We are unable to see the remaining time on a task when editing timesheet in some views Current behavior before PR: Desired behavior after PR is merged: The remaining hours are shown right after the name of the task. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Customers can now group portal tasks by stage, making it easier to see progress across one or multiple projects. The task list also keeps search, sort, filter, and group selections when moving between pages, improving navigation consistency.
Original PR description
A group by stage on the portal would allow the customer to have an overview of his tasks' progress, which is especially useful in a multi-project setting. TASK-ID: 2123814 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Helpdesk settings page now places its activity panel below the main form instead of taking up space on the side. This gives users more room to view and adjust settings, especially on larger screens where the side panel was unnecessary.
Original PR description
Task: https://www.odoo.com/web#id=2125078&action=327&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.50cea56dd4c2c535cd76f38947ad1ab5
This update removes an unnecessary technical setting from the manufacturing work order module. It should not change how users work, but it helps keep the system simpler and easier to maintain.
Original PR description
The fields is a classic Many2one so it's stored by default and do not need an explicit store=True
The demo data for Belgian payroll accounting tests has been improved. This helps ensure sample payroll accounting scenarios are more representative and reliable for validation, with no direct impact on end users.
Original PR description
Such Bilson, Much wow.
Tasks now show how many hours remain to be logged in relevant timesheet, helpdesk, planning, and mobile synchronization views. This helps teams quickly judge task progress and plan work without opening each task for details.
Original PR description
Show the remaining hours to timesheet on tasks. Allows to quickly evaluate task's state. This is done in the name_get of a task through a context key, because we need this different name on some views, not all. related task #1856139
The approval request email text has been rewritten to sound clearer and more natural. This improves the recipient experience by making approval notifications easier to understand and more professional.
Original PR description
Improves the body of the e-mail as it wasn't a very nice sentence.
Resolved issues and error corrections
This update corrects a website editor issue caused by older icon support and prevents hidden editing labels from appearing as browser tooltips. It improves the editing experience and prepares the editor for future snippet behavior without changing the public website experience.
Original PR description
Fontawesome was reverted to 4.7 with 116057b26 in saas-13.1 but some code in master were already using new fonts. Also, the invisible left panel box is improved for future development. Indeed, the new incoming popup snippet will have the possibility to be moved in the footer. In that case, it will be itself an element of getEditabeArea(). Finally, using `Title` as invisible entry had the benefit of being translatable but has the issue to be displayed on mouse over which we don't want. Using `data-title` will fix it and will still be translatable.
This fixes an error that could occur when users opened a product’s on-hand quantities and the system needed to adjust the related action settings. Inventory users can now update or review quantities more reliably without hitting a traceback.
Original PR description
When accessing the quantities on hand of a product, `_get_quants_action` is called to specify the action returned. In some cases, the action context may be updated. This led to a traceback because the context of the action isn't a copy of the current context but a link to the current context frozendict, which cannot be updated. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes missing website course assets by moving required tour files to a browser-accessible location. It helps keep automated website course checks working reliably and prevents failures caused by unavailable images or scripts.
Original PR description
[FIX] website_slides: image no more available
[Nighly Runbot #730241](http://runbot.odoo.com/runbot/build/730241)
[FIX] website_slides: move tours under /static/
All assets have to be loadable directly from the browser, /tests/ is not
accessible, /static/ is.This fixes an issue in the customer portal where moving to another ticket page could reset or change the search bar settings. Users can now browse ticket pages while keeping their chosen search context, making navigation more predictable.
Original PR description
on the portal:
- in Timesheets, the "Group By" selector shouldn't change when going to next page
TASK-ID : 2123814This fix keeps the available task choices on helpdesk tickets consistent when logging timesheets, especially when projects, teams, companies, or customers change. It prevents valid project tasks from disappearing and avoids unnecessarily clearing a selected task in some sales-related helpdesk flows.
Original PR description
Existing static domain on task_id would be immediately swapped out for a dynamic (onchange) version thereof. Use conditional trick to merge the entire thing into the static domain, and remove it from the onchange. Task 2115472
Features or functions removed from Odoo
Payroll payslips were simplified by removing outdated dynamic filtering logic and an unused input field. This reduces unnecessary complexity in the payroll interface and helps keep payslip configuration clearer for users.
Original PR description
Task 2115472
Miscellaneous changes
**[FIX] account: Prevent erasing currency when changing the date** - Create a misc. journal entry. - Add a foreign currency on the line. - Change the date. => The currency is erased because the onchange works only for invoices. **[FIX] account: Fix sequence used by receipts** **[FIX] payment: Display the "register payment" button in receipts** The button attrs has been well fixed in the 'account' module but not in 'payment'. -- I confirm I have signed the CLA and read the PR g
Original PR description
**[FIX] account: Prevent erasing currency when changing the date** - Create a misc. journal entry. - Add a foreign currency on the line. - Change the date. => The currency is erased because the onchange works only for invoices. **[FIX] account: Fix sequence used by receipts** **[FIX] payment: Display the "register payment" button in receipts** The button attrs has been well fixed in the 'account' module but not in 'payment'. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41637
The format of `many2one_reference` was not introduced when the new field type was created, which leads to empty values when the web client is trying to display the value of such fields in form views. Since the value of this field is an ID, it is decided to display it like an integer, which is consistent with previous behavior: the fields that are now `many2one_reference` are still stored as integer and they were already displayed as integer before. This was fixed in list views in comm
Original PR description
The format of `many2one_reference` was not introduced when the new field type was created, which leads to empty values when the web client is trying to display the value of such fields in form views. Since the value of this field is an ID, it is decided to display it like an integer, which is consistent with previous behavior: the fields that are now `many2one_reference` are still stored as integer and they were already displayed as integer before. This was fixed in list views in commit d0c852f50e71bc4c9c2a08230f515fec6909b725 and the current commit fixes it for form views. opw-2127010 closes #38009 Forward-Port-Of: odoo/odoo#41649
task: 1948158 Description of the issue/feature this PR addresses: Current behavior before PR: payment detail is not in electronic invoice Desired behavior after PR is merged: payment detail is added -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#35177
Original PR description
task: 1948158 Description of the issue/feature this PR addresses: Current behavior before PR: payment detail is not in electronic invoice Desired behavior after PR is merged: payment detail is added -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#35177
Fix indentation -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41642
Original PR description
Fix indentation -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41642
When editing the followers, the "pencil" icon that leads to the edition of subtypes should be always be displayed, and not only when "debug" mode is activated. This commit restores this behaviour, as it was not the case any more. opw-2144399 Forward-Port-Of: odoo/odoo#41565
Original PR description
When editing the followers, the "pencil" icon that leads to the edition of subtypes should be always be displayed, and not only when "debug" mode is activated. This commit restores this behaviour, as it was not the case any more. opw-2144399 Forward-Port-Of: odoo/odoo#41565
Related to issue: #41517 https://github.com/odoo/odoo/issues/41517#issue-534741232 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41539
Original PR description
Related to issue: #41517 https://github.com/odoo/odoo/issues/41517#issue-534741232 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41539
Followup of a425695e The terms were back in 12.0 Courtesy of Juan José Scarafía Forward-Port-Of: odoo/odoo#41608 Forward-Port-Of: odoo/odoo#41603
Original PR description
Followup of a425695e The terms were back in 12.0 Courtesy of Juan José Scarafía Forward-Port-Of: odoo/odoo#41608 Forward-Port-Of: odoo/odoo#41603
Edit the liters uom (default in its category) and change its category to unit. You now have two references uom in the unit category. Try to set a third one and now it fails. Forward-Port-Of: odoo/odoo#41414
Original PR description
Edit the liters uom (default in its category) and change its category to unit. You now have two references uom in the unit category. Try to set a third one and now it fails. Forward-Port-Of: odoo/odoo#41414
Fix _get_bar_graph_select_query to correctly compute the residual amount when calculating the values for the graph of a bill or invoice journal. Description of the issue/feature this PR addresses: The bar graph of vendor bills journals and customer invoices journals on the Accounting Dashboard Current behavior before PR: Graph show nothing because they compute the residual amount of the account move lines, balancing moves included, which totals to zero Desired behavior after PR is me
Original PR description
Fix _get_bar_graph_select_query to correctly compute the residual amount when calculating the values for the graph of a bill or invoice journal. Description of the issue/feature this PR addresses: The bar graph of vendor bills journals and customer invoices journals on the Accounting Dashboard Current behavior before PR: Graph show nothing because they compute the residual amount of the account move lines, balancing moves included, which totals to zero Desired behavior after PR is merged: Correctly computes the values to show on the graphs -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41545
Pad:https://pad.odoo.com/p/r.e9fea30f2805f781758cf5e182b294ce Task:https://www.odoo.com/web#id=2144553&action=333&active_id=1251&model=project.task&view_type=form&menu_id=4720 Forward-Port-Of: odoo/odoo#41157
Original PR description
Pad:https://pad.odoo.com/p/r.e9fea30f2805f781758cf5e182b294ce Task:https://www.odoo.com/web#id=2144553&action=333&active_id=1251&model=project.task&view_type=form&menu_id=4720 Forward-Port-Of: odoo/odoo#41157
The date filters sent to servers were being computed in current locale, so in arabic we would get things like this: - "٢٠١٩-١٢-٠٩" instead of "2019-12-09" - "٢٠١٩-١٢-٠٩ ١٦:١٦:١٥" instead of "2019-12-09 16:16:15" which would cause a traceback in backend. opw-2122333 Forward-Port-Of: odoo/odoo#41570
Original PR description
The date filters sent to servers were being computed in current locale, so in arabic we would get things like this: - "٢٠١٩-١٢-٠٩" instead of "2019-12-09" - "٢٠١٩-١٢-٠٩ ١٦:١٦:١٥" instead of "2019-12-09 16:16:15" which would cause a traceback in backend. opw-2122333 Forward-Port-Of: odoo/odoo#41570
Before this commit: If you have not at least the timesheet user right, you can't open project task as a field in not present in the view. After this commit: You can open the task view TaskId: 2148606 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41549
Original PR description
Before this commit: If you have not at least the timesheet user right, you can't open project task as a field in not present in the view. After this commit: You can open the task view TaskId: 2148606 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#41549
In 13.0 if currency_id is not set, we are fallbacking on company_currency_id. This was not taken into account in account.invoice.report view and so when grouping by currency, we would get an "Undefined" grouping which meant "company currency". Now we fallback on company_currency in the view, and if we displayed data for several companies with different currency, this should also remove the amalgamation of different currency in "Undefined" group. opw-2151492 Forward-Port-Of: odoo/odoo#41491
Original PR description
In 13.0 if currency_id is not set, we are fallbacking on company_currency_id. This was not taken into account in account.invoice.report view and so when grouping by currency, we would get an "Undefined" grouping which meant "company currency". Now we fallback on company_currency in the view, and if we displayed data for several companies with different currency, this should also remove the amalgamation of different currency in "Undefined" group. opw-2151492 Forward-Port-Of: odoo/odoo#41491
Forward-Port-Of: odoo/odoo#41555
Original PR description
Forward-Port-Of: odoo/odoo#41555
Commit https://github.com/odoo/odoo/commit/cf5b3e1db5d312133eb1af7ff0d5471db47987e5 fixed a problem by creating another one: the parallax with a given speed appeared broken on page load (which is even more visible in 13.0 with lazy loading). This commit restores the design and solves the original problem. Forward-Port-Of: odoo/odoo#41548
Original PR description
Commit https://github.com/odoo/odoo/commit/cf5b3e1db5d312133eb1af7ff0d5471db47987e5 fixed a problem by creating another one: the parallax with a given speed appeared broken on page load (which is even more visible in 13.0 with lazy loading). This commit restores the design and solves the original problem. Forward-Port-Of: odoo/odoo#41548
— Enabled multi currency; — Create new journal entry; — Add a new line; — Add the column 'amount in currency'; — Select a different currency than the company currency; — Set an amount in 'amount in currency'. Before this commit, the amount in currency is not converted into debit or credit fields. Now, the amount is correctly converted into debit or credit fields. opw-2129294 Forward-Port-Of: odoo/odoo#41445
Original PR description
— Enabled multi currency; — Create new journal entry; — Add a new line; — Add the column 'amount in currency'; — Select a different currency than the company currency; — Set an amount in 'amount in currency'. Before this commit, the amount in currency is not converted into debit or credit fields. Now, the amount is correctly converted into debit or credit fields. opw-2129294 Forward-Port-Of: odoo/odoo#41445
The body of the e-mail was never translated and the sentence was not very nice. This fixes two things: 1. The term is translatable (and added to the `.pot` file) 2. The term has been improved Forward-Port-Of: odoo/enterprise#7181
Original PR description
The body of the e-mail was never translated and the sentence was not very nice. This fixes two things: 1. The term is translatable (and added to the `.pot` file) 2. The term has been improved Forward-Port-Of: odoo/enterprise#7181
Since rev https://github.com/odoo/enterprise/commit/6114fd824320a7e50025e71a2b236bd71ca7fbd9, the image stripe for sidebar icons was changed and few icons were re-arranged in the stripe. The scss was not updated with the changed stripe and so in some cases sidebar displayed wrong icons. This commit makes the required changes in the scss to properly display the icons according to new image stripe. Task : https://www.odoo.com/web#id=2067485&model=project.task&view_type=form&menu_id=5195
Original PR description
Since rev https://github.com/odoo/enterprise/commit/6114fd824320a7e50025e71a2b236bd71ca7fbd9, the image stripe for sidebar icons was changed and few icons were re-arranged in the stripe. The scss was not updated with the changed stripe and so in some cases sidebar displayed wrong icons. This commit makes the required changes in the scss to properly display the icons according to new image stripe. Task : https://www.odoo.com/web#id=2067485&model=project.task&view_type=form&menu_id=5195 Pad : https://pad.odoo.com/p/r.dd8ec245950c2af28ef90d53d17e8026 Forward-Port-Of: odoo/enterprise#5737
At best `('task_id', '=', True)` might be true for task id 1, but otherwise it'd never be true, so the field would never be readonly. I feel the original intent was `('task_id', '!=', False)`: * always allow timesheets on a ticket *not* linked to a task * if a ticket is linked to a task, only allow timesheets if the task is still active & open ping @tivisse @nim-odoo Forward-Port-Of: odoo/enterprise#7165 Forward-Port-Of: odoo/enterprise#7130
Original PR description
At best `('task_id', '=', True)` might be true for task id 1, but otherwise it'd never be true, so the field would never be readonly.
I feel the original intent was `('task_id', '!=', False)`:
* always allow timesheets on a ticket *not* linked to a task
* if a ticket is linked to a task, only allow timesheets if the task is still active & open
ping @tivisse @nim-odoo
Forward-Port-Of: odoo/enterprise#7165
Forward-Port-Of: odoo/enterprise#7130TaskID: 2148606 Forward-Port-Of: odoo/enterprise#7142
Original PR description
TaskID: 2148606 Forward-Port-Of: odoo/enterprise#7142
Fixing the following: - Avoid overlapping of the total amount - If not multiline setting > show '...' in last line - Seq number on same line with date for minipage 2 and 3 Limitation is set to show 1 invoice per line (max 9): if more & multiline setting > add on following page(s) if more & no multiline setting > show 8 & 9th row with '...' if less & multiline / not multiline > no impact. Had to be sure fix is compliant to: https://www.checkdepot.net/checks/laser/Odoo.htm Was n
Original PR description
Fixing the following: - Avoid overlapping of the total amount - If not multiline setting > show '...' in last line - Seq number on same line with date for minipage 2 and 3 Limitation is set to show 1 invoice per line (max 9): if more & multiline setting > add on following page(s) if more & no multiline setting > show 8 & 9th row with '...' if less & multiline / not multiline > no impact. Had to be sure fix is compliant to: https://www.checkdepot.net/checks/laser/Odoo.htm Was nicely tested by customer of ticket & JOV [forwardport up to master] opw-2123856 opw-1941278 of JUC Forward-Port-Of: odoo/enterprise#7090
…m date filter previous behavior: drafted depreciation of posted assets would appear in the assets report even when "posted entries only" was selected when using custom dates current behavior: drafted depreciation of asset only appear if "posted entries only" is unselected even when using custom dates opw-2124831 Forward-Port-Of: odoo/enterprise#6839
Original PR description
…m date filter previous behavior: drafted depreciation of posted assets would appear in the assets report even when "posted entries only" was selected when using custom dates current behavior: drafted depreciation of asset only appear if "posted entries only" is unselected even when using custom dates opw-2124831 Forward-Port-Of: odoo/enterprise#6839
### Issue - Install Accounting - Customers > Follow-up Reports - Select one of them - You can set a summary text or keep the original - Print or Send by email There are too many line breaks ### Cause - PDF: The `\n` in the summary are interpreted by the `white-space: pre-wrap` CSS property - Mail: the `\n` is replaced by a `<br>` - All: when saving the summary, the `\n` are replaced by `<br>\n` ### Solution - PDF: Removing the `white-space: pre-wrap` CSS property
Original PR description
### Issue
- Install Accounting
- Customers > Follow-up Reports
- Select one of them
- You can set a summary text or keep the original
- Print or Send by email
There are too many line breaks
### Cause
- PDF: The `\n` in the summary are interpreted by the `white-space: pre-wrap`
CSS property
- Mail: the `\n` is replaced by a `<br>`
- All: when saving the summary, the `\n` are replaced by `<br>\n`
### Solution
- PDF: Removing the `white-space: pre-wrap` CSS property
- Mail: the `\n` is deleted
- All: when saving the summary, the `\n` are replaced by `<br>`
**OPW-2128174**
Forward-Port-Of: odoo/enterprise#6990