Friday, January 10, 2020
23 changes · master
Enhancements to existing features
This update strengthens the reliability of the Events and CRM areas by cleaning up older code and expanding automated test coverage. It prepares these modules for upcoming improvements while reducing the risk of future regressions in event management and lead conversion workflows.
This change adds dependency management files to make it easier for developers to set up and maintain the project environment with Pipenv. It also includes a contributor license agreement document and adjusts dependency listings, with no expected direct impact on business users.
Original PR description
Description of the issue/feature this PR addresses: Pipenv is recommended in Python 3 documentation, so this PR add the Pipfile Current behavior before PR: Pipfile not exists Desired behavior after PR is merged: Easy dependency management using pipenv -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update clarifies how event-related features depend on each other and reorganizes scheduling-related event components, helping installations behave more predictably. It also improves lead-to-ticket conversion so archived leads trigger the right business logic and keep related scoring information accurate.
Resolved issues and error corrections
This change prevents a sales timesheet test from failing unpredictably when other installed modules add currency exchange rates. It keeps the test focused on timesheet invoicing amounts, improving reliability for future updates without changing customer-facing behavior.
Original PR description
The method 'test_timesheet_delivery' tests the following use case: Test timesheet invoicing with 'invoice on delivery' timetracked products 1. Create SO and confirm it 2. log timesheet 3. create…
The method 'test_timesheet_delivery' tests the following use case:
Test timesheet invoicing with 'invoice on delivery' timetracked products
1. Create SO and confirm it
2. log timesheet
3. create invoice
4. log other timesheet
5. create a second invoice
6. add new SO line (delivered service)
7. And finally check the AMOUNTS
But it could happen, according to the installed modules, that the class
TestSaleTimesheet, which is directly linked to
-> TestCommonSaleTimesheetNoChart (sale_timesheet)
--> TestCommonSaleNoChart (sale)
---> AccountTestNoChartCommon (account)
----> SavepointCaseWithUserDemo (base)
-----> SavepointCase (base)
is influenced by other installed modules, that in our case, introduce
new res.currency.rate values.
In our test, on the sale.order.line 'so_line_ordered_global_project',
we use the product 'product_order_timesheet2', with a price_unit=90.
Then we call manually the onchange method:
``` python3
so_line_ordered_global_project.product_id_change()
```
As the order has a pricelist and a partner, we recompute the price
unit, in case a discount applies:
``` python3
if self.order_id.pricelist_id and self.order_id.partner_id:
vals['price_unit'] = self.env['account.tax']._fix_tax_included_price_company(self._get_display_price(product), product.taxes_id, self.tax_id, self.company_id)
self.update(vals)
```
And then , the call the _get_display_price returns an different amount
that what we expect, as
``` python3
product.with_context(pricelist=self.order_id.pricelist_id.id).price
```
will return the price converted using the related res.currency.rate
at the current date.
As we don't wish to test the conversion into another currency in this
test, we simply unlink all the currency rates, to avoid any external
influence.
TaskID: 2166237Miscellaneous changes
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43020
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43020
This change removes an older web interface adjustment because a better fix is now handled elsewhere. It helps keep the menu behavior consistent without keeping unnecessary code in the main web module.
Original PR description
This commit reverts a previous fix because we found a better one in enterprise. So we don't need this line anymore. opw-2071605 Task ID: 2152160 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an accounting issue where partner-specific account settings could be read using the wrong company context. It helps ensure invoices and accounting entries use the correct company-specific values in multi-company environments.
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The trial balance comparison header now shows periods in the correct order. This prevents confusion when reviewing financial comparisons and helps users interpret report columns accurately.
Original PR description
Periods were reverted in the trial balance table header when comparing
**[FIX] account: Manage group of taxes everytime** Before the merge of account.invoice with account.move, a group of taxes was expanded on journal items and not on invoice lines. Since both are now the same thing, we only get the group of taxes when using the 'tax_ids' field. To correctly handle this new behavior, we need to call 'flatten_taxes_hierarchy' every time we use the 'tax_ids' field to get the children taxes instead of the group of taxes itself. **[FIX] account: Wrong unit p
Original PR description
**[FIX] account: Manage group of taxes everytime** Before the merge of account.invoice with account.move, a group of taxes was expanded on journal items and not on invoice lines. Since both are now…
**[FIX] account: Manage group of taxes everytime** Before the merge of account.invoice with account.move, a group of taxes was expanded on journal items and not on invoice lines. Since both are now the same thing, we only get the group of taxes when using the 'tax_ids' field. To correctly handle this new behavior, we need to call 'flatten_taxes_hierarchy' every time we use the 'tax_ids' field to get the children taxes instead of the group of taxes itself. **[FIX] account: Wrong unit price with included tax and fiscal position** Steps to reproduce the bug: - Let's consider a sale included tax T1 of 10% and a sale excluded tax T2 of 0% - Let's consider a product P with T1 and a sale price of 110€ - Let's consider a fiscal position FP that mappes T1 to T2 - Let's consider a customer C with FP as fiscal position - Create a customer invoice for C - Add P on the first line and T1 is replaced by T2 Bug: The unit price of P was still 110€ instead of 100€ because the included tax was not removed from the base price of P. Same behavior as in 11.0 and 12.0 opw:2150564 co-author: simongoffin (sig@odoo.com) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42926 Forward-Port-Of: odoo/odoo#42188
If the opening entry is balanced, the auto-balance line is unlinked. However, before unlinking we test if it is balanced, which it is not. A solution is removing the line from the move and it will be unlinked automatically. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42930
Original PR description
If the opening entry is balanced, the auto-balance line is unlinked. However, before unlinking we test if it is balanced, which it is not. A solution is removing the line from the move and it will be unlinked automatically. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42930
Revision on https://github.com/odoo/odoo/commit/a55c78836f172dba1cfa6db3df0e927a9c7e6471 Before this commit, marking all messages as read from Discuss inbox did not update the UI correctly, hence requiring a page reload. This bug comes from a typo in the commit above, which passed a list of mail_notification instead of message ids, so that messages were handled as marked as read by the web client. Task-Id 2158452 Forward-Port-Of: odoo/odoo#43088 Forward-Port-Of: odoo/odoo#43030
Original PR description
Revision on https://github.com/odoo/odoo/commit/a55c78836f172dba1cfa6db3df0e927a9c7e6471 Before this commit, marking all messages as read from Discuss inbox did not update the UI correctly, hence requiring a page reload. This bug comes from a typo in the commit above, which passed a list of mail_notification instead of message ids, so that messages were handled as marked as read by the web client. Task-Id 2158452 Forward-Port-Of: odoo/odoo#43088 Forward-Port-Of: odoo/odoo#43030
Activate Multicurrency Create a Journal Entry with default currency (USD) Save Error will trigger because of the sql constraint 'check_amount_currency_balance_sign' The currency_id and company_currency_id are the same while they shouldn't because company_id should be unset if it is the same as the company_currency. Fix to ensure that the unset operation is performed opw-2169523 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Por
Original PR description
Activate Multicurrency Create a Journal Entry with default currency (USD) Save Error will trigger because of the sql constraint 'check_amount_currency_balance_sign' The currency_id and company_currency_id are the same while they shouldn't because company_id should be unset if it is the same as the company_currency. Fix to ensure that the unset operation is performed opw-2169523 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43011
Steps to reproduce: -install contacts and vat number validation -setup your company country to "Netherlands" -go to contacts > add a company > try to add a dutch vat number (NL264077921B03) Previous behavior: proper vat numbers are considered unvalid and raise a ValidationError Current behavior: specific check added for dutch vat numbers opw-2166380 Forward-Port-Of: odoo/odoo#43043 Forward-Port-Of: odoo/odoo#42681
Original PR description
Steps to reproduce: -install contacts and vat number validation -setup your company country to "Netherlands" -go to contacts > add a company > try to add a dutch vat number (NL264077921B03) Previous behavior: proper vat numbers are considered unvalid and raise a ValidationError Current behavior: specific check added for dutch vat numbers opw-2166380 Forward-Port-Of: odoo/odoo#43043 Forward-Port-Of: odoo/odoo#42681
opw-2169164 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43049
Original PR description
opw-2169164 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43049
Some library versions are outdated since the release of Debian Buster. With this commit the required libraries versions will match as close as possible the versions available in the current Debian stable release (Buster). Also, the requirements were tested against a Windows Python 3.7 to ensure that a "pip install -r" can be used without the need of a CPP compiler. This PR should fix issues found during odoo/odoo#40319 Forward-Port-Of: odoo/odoo#40361
Original PR description
Some library versions are outdated since the release of Debian Buster. With this commit the required libraries versions will match as close as possible the versions available in the current Debian stable release (Buster). Also, the requirements were tested against a Windows Python 3.7 to ensure that a "pip install -r" can be used without the need of a CPP compiler. This PR should fix issues found during odoo/odoo#40319 Forward-Port-Of: odoo/odoo#40361
Fix a mixup between `bounced_msg_id` that is sometimes tought as a list of string or directly as a string. Now `bounced_msg_id` is always a list or `False` if there is no bounce. opw-2157793 Forward-Port-Of: odoo/odoo#43084
Original PR description
Fix a mixup between `bounced_msg_id` that is sometimes tought as a list of string or directly as a string. Now `bounced_msg_id` is always a list or `False` if there is no bounce. opw-2157793 Forward-Port-Of: odoo/odoo#43084
When accessing stock_barcode module to validate pickings, is not possible to add floating point quantities for any localizaton which uses ',' as decimal separator. The numeric field is now defined via browser tags <input="numeric"> to make the numeric keyboard popup automatically on mobile devices (commit 8f5840369b28962ab2be9edfce7331a836c3df22) Adding the override to avoid further processing when the input is already anumber opw-2154657 -- I confirm I have signed the CLA and read
Original PR description
When accessing stock_barcode module to validate pickings, is not possible to add floating point quantities for any localizaton which uses ',' as decimal separator. The numeric field is now defined via browser tags <input="numeric"> to make the numeric keyboard popup automatically on mobile devices (commit 8f5840369b28962ab2be9edfce7331a836c3df22) Adding the override to avoid further processing when the input is already anumber opw-2154657 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#42702 Forward-Port-Of: odoo/odoo#42335
Issue - Have firefox - Go to any chatter - Open full editor - Write some "test" words with line breaks - Select one of your "test" words - Drag & drop it somewhere else in the editor Welcome on test.com! (redirected) Cause Summernote doesn't preventDefault on drop event, so firefox think we want to go to another URL. Solution Add the preventDefault manually. This reveals another issue which is solved by importing this PR
Original PR description
Issue
- Have firefox
- Go to any chatter
- Open full editor
- Write some "test" words with line breaks
- Select one of your "test" words
- Drag & drop it somewhere else in the editor
Welcome on test.com! (redirected)
Cause
Summernote doesn't preventDefault on drop event, so firefox
think we want to go to another URL.
Solution
Add the preventDefault manually.
This reveals another issue which is solved by importing
this PR's code https://github.com/summernote/summernote/pull/3327
(with adaptation for our dinosaurus version)
OPW-2158112
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#42755
Forward-Port-Of: odoo/odoo#42470Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43003
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#43003
From the PoV of the customer, there is no difference between an authorized payment and a captured payment; they should get redirected to the confirmation page in both cases. Forward-Port-Of: odoo/odoo#42753
Original PR description
From the PoV of the customer, there is no difference between an authorized payment and a captured payment; they should get redirected to the confirmation page in both cases. Forward-Port-Of: odoo/odoo#42753
If an ir.property created for the import already exists for the company, it shouldn't raise an error. Instead, change the existing one. Forward-Port-Of: odoo/enterprise#7598
Original PR description
If an ir.property created for the import already exists for the company, it shouldn't raise an error. Instead, change the existing one. Forward-Port-Of: odoo/enterprise#7598
Following https://www.agenciatributaria.gob.es/AEAT.sede/procedimientoini/GI28.shtml which is the official Spanish website regarding tax system and opw-2158771. This commit is removing the taxes of the following lines (code): 1/ Importe de las operaciones intracomunitarias (aeat_mod_349_statistics_invoices_total_amount) 2/ Importe de las operaciones intracomunitarias con rectificaciones (aeat_mod_349_statistics_refunds_total_amount) 3/ A. Adquisiciones intracomunitarias sujetas (aeat_mod_
Original PR description
Following https://www.agenciatributaria.gob.es/AEAT.sede/procedimientoini/GI28.shtml which is the official Spanish website regarding tax system and opw-2158771. This commit is removing the taxes of the following lines (code): 1/ Importe de las operaciones intracomunitarias (aeat_mod_349_statistics_invoices_total_amount) 2/ Importe de las operaciones intracomunitarias con rectificaciones (aeat_mod_349_statistics_refunds_total_amount) 3/ A. Adquisiciones intracomunitarias sujetas (aeat_mod_349_acquisitions) 4/ A. Adquisiciones intracomunitarias sujetas (aeat_mod_349_acquisitions_refunds) opw-2158771 Forward-Port-Of: odoo/enterprise#7593 Forward-Port-Of: odoo/enterprise#7589
Before this commit, the user didn't see the result of an action which was below the burger menu which remained open. Now we automatically close the burger menu to be able to see it. Steps to produce: 1. Install and open 'Employees' 2. Open the burger menu 3. Click on 'Preferences' => The burger menu is still open OR 1. Install the Accounting + l10n_be module 2. Open ths burger menu 3. Click on: Configuration -> Payments -> Add a bank account => The burger menu is still open
Original PR description
Before this commit, the user didn't see the result of an action which was below the burger menu which remained open. Now we automatically close the burger menu to be able to see it. Steps to produce: 1. Install and open 'Employees' 2. Open the burger menu 3. Click on 'Preferences' => The burger menu is still open OR 1. Install the Accounting + l10n_be module 2. Open ths burger menu 3. Click on: Configuration -> Payments -> Add a bank account => The burger menu is still open Due to the implementation of the mobile burger menu, we can't trigger up the 'close_o_burger_menu'. It's why we use the bus to provide a way to close the burger menu. opw-2071605 Forward-Port-Of: odoo/enterprise#7359