Monday, February 24, 2020
6 changes
Resolved issues and error corrections
This fixes a checkout issue where the available states could be calculated using a different address type than the country list. Customers should now see matching country and state options when entering billing or shipping details, reducing checkout confusion when delivery features are installed.
Original PR description
Description of the issue/feature this PR addresses: List of states and countries in Payment page may be incorrect when website_sale_delivery is installed Current behavior before PR: List of states is always computed for "shipping" mode, while list of countries [may be billing](https://github.com/odoo/odoo/blob/e19227d3ba9c9296bfc0c221ac70a863a571b9a6/addons/website_sale/controllers/main.py#L656) Desired behavior after PR is merged: Use the same mode for states as for countries -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr @it-projects-llc
This fixes an issue where employee expense analytics information could be erased when no default analytic account was found. It keeps expense entries more reliable and prevents related expense tests from failing when the analytic default integration is installed.
Original PR description
_onchange_product_id used to set hr_expense analytic_account_id & analytic_tag_ids to False if it could not find a default analytic account. Installing account_analytic_default_hr_expense made odoo/addons/hr_expense/tests/test_expenses.py tests fail - changed function name (no need to be a _onchange_product_id override) - removed super() & return - check if account_get() returns something Related to task 2182900
The checkout address form now shows state options based on whether the customer is editing a billing or shipping address. This prevents delivery restrictions from incorrectly hiding billing states or showing unavailable shipping states, helping customers complete checkout with the right address choices.
Original PR description
All states would be listed in shipping mode Only restricted states would be listed in billing mode See commits for more details
This fixes an internal issue in Point of Sale order updates by removing an incorrect marker from the order write process. The change helps ensure POS order changes are handled as intended, reducing the risk of unexpected behavior for users.
Original PR description
Follow-up on 118190f3b3ecde11d7bcb46301af0e016d6ea19f Remove the wrong decorator from the write method. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change removes an incorrect setup marker from the Alipay payment update process. It helps ensure Alipay payment settings can be saved using the intended standard behavior, reducing the risk of unexpected errors for administrators.
Original PR description
Remove the wrong decorator from the write method. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed an issue that caused an error when users grouped timesheets by date in the grid view. Date grouping remains available where it is useful, such as list views, while the grid now avoids the problematic behavior.
Original PR description
Before this commit, when we try to make a group by date in timesheet grid, we have a traceback. This group by date is useless in grid view but very useful for list view. Now, when we make a group by date in the timesheet grid, we don't apply the group_expand. TaskID: 2169272