Saturday, March 7, 2020
4 changes · master
Enhancements to existing features
Website editors now have more convenient controls when configuring forms, including textarea height settings, clearer field labels, and easier link previewing. These changes make form setup smoother and help editors verify links without leaving the editing flow.
Original PR description
Add a height option on textarea Rename some fields Add an icon to redirect on we-urlpicker Add margin on default form Add default option selectAttribute task-2197008 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This fixes how default website color palettes are prepared and reused by themes. Themes can now rely on shared default palette values instead of redefining every website color setting, making theme customization more consistent and easier to maintain.
Original PR description
Before this commit, this was done: 1) Primary variables (app order): (a) web_editor: define palettes (color + theme + gray), only 1 empty one. Mark the first ones as the selected ones. (b) website:…
Miscellaneous changes
5ac269d722f fixed 7e2b0ebe799 that prevented the website menu to actually be visible, since the JS in charge of displaying the menu was 'crashing'. A test was missing to avoid that issue to appear ever again, since it is quite a critical problem. Note that it might look strange that breaking such a mechanism does not make the runbot red, but since the menus are actually considered visible, the tests are able to 'see' it in DOM and click on it. They are actually hidden through an opaci
Original PR description
5ac269d722f fixed 7e2b0ebe799 that prevented the website menu to actually be visible, since the JS in charge of displaying the menu was 'crashing'. A test was missing to avoid that issue to appear ever again, since it is quite a critical problem. Note that it might look strange that breaking such a mechanism does not make the runbot red, but since the menus are actually considered visible, the tests are able to 'see' it in DOM and click on it. They are actually hidden through an opacity 0 & height 0 while the JS process them. task-2093679 Forward-Port-Of: odoo/odoo#47130 Forward-Port-Of: odoo/odoo#46962
Before this commit, this was done:
1) Primary variables (app order):
(a) web_editor: define palettes (color + theme + gray), only 1 empty
one. Mark the first ones as the selected ones.
(b) website: fill all defined palettes with the website-related
color key and values (body, menu, logo-height, etc).
+ define "website values" palette.
2) Secondary variables (reverse app order):
(c) website: merge the user palettes on top of the selected palettes
(so user values overriding values added in (a) and (b)),
the resulting palettes are added in palettes lists and the
selected palette numbers are set to select those ones.
+ final selection of "website values" palette.
(d) web_editor: final selection of the selected color palette amongst
the color palettes.
--
The problem with all of this is that the definition of palettes
in themes (occuring between step (b) and (c)) never received the
website-related color key and values of step (b) and were thus forced
to redefine all of those by themself even if they wanted to use the
default website one.
This commit changes the system so that step (a) and (b) now define
"base" palettes (color, theme, gray, website values) and step (c) and
(d) now merge the final selected palettes with those "base" palettes.
This is in fact theoratically more efficient and allows to not force
themes to define every possible palette value we might introduce.The parsing of dailymotion URL was not done correctly. This made the media dialog duplicate the URL params if such an URL was re-edited. task-2159152 Forward-Port-Of: odoo/odoo#47075 Forward-Port-Of: odoo/odoo#46898
Original PR description
The parsing of dailymotion URL was not done correctly. This made the media dialog duplicate the URL params if such an URL was re-edited. task-2159152 Forward-Port-Of: odoo/odoo#47075 Forward-Port-Of: odoo/odoo#46898