Monday, April 6, 2020
26 changes · master
Enhancements to existing features
Point of Sale managers can now update many configuration options even while a POS session is running. Only settings that could disrupt active sales remain locked, reducing downtime while keeping sessions stable.
Original PR description
Description of the issue/feature this PR addresses: Allow modifying the configuration of a POS while a session is open Current behavior before PR: When a session is open, we're unable to change the pos config. Desired behavior after PR is merged: We're allowed to change some options in the pos config which doesn't lead to bad behavior. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This fixes an internal cache handling issue that could affect how scheduled background jobs identify active databases. The change avoids unsafe cache iteration and uses safer clearing behavior, improving reliability without changing business workflows.
Original PR description
don't.
Miscellaneous changes
On redirection, werkzeug converts locations from relative to absolute URLs. Apparently the specific algorithm when given a relative *path* changed between 0.14 and 0.15, or possibly these paths suddenly became processed whereas before they were interpreted as absolute? So in Werkzeug 0.14, `redirect('foo/bar')` was treated as `redirect('/foo/bar')` but in 0.15 it's first urljoin-ed to the current path before the redirection is effected. This is an issue with slides, because survey's get_st
Original PR description
On redirection, werkzeug converts locations from relative to absolute URLs. Apparently the specific algorithm when given a relative *path* changed between 0.14 and 0.15, or possibly these paths…
On redirection, werkzeug converts locations from relative to absolute URLs. Apparently the specific algorithm when given a relative *path* changed between 0.14 and 0.15, or possibly these paths suddenly became processed whereas before they were interpreted as absolute?
So in Werkzeug 0.14, `redirect('foo/bar')` was treated as `redirect('/foo/bar')` but in 0.15 it's first urljoin-ed to the current path before the redirection is effected.
This is an issue with slides, because survey's get_start_url returns the url `survey/start/<access_token>` without a leading slash.
The result is that where with 0.14 the certification tour would do this:
GET /slides_survey/slide/get_certification_url?slide_id=39&fullscreen=1
GET /survey/start/<id>?answer_token=<token>
with 0.15 or above it does this:
GET /slides_survey/slide/get_certification_url?slide_id=39&fullscreen=1
GET /slides_survey/slide/survey/start/<id>?answer_token=<token>
Which weirdly enough doesn't work at all, and thus the tour fails.
Forward-Port-Of: odoo/odoo#48971Customer emails no longer show a “View Task” button when project privacy settings would prevent portal access. This avoids sending customers to pages they cannot open and keeps communications aligned with project visibility rules.
Original PR description
The "View Task" button was displayed in emails sent to customers even if the privacy settings of the project prevented them from accessing the project on the portal. TaskID: 2230189 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Corrected a typo in the Documents download button text. This improves clarity for users and gives the interface a more polished, professional feel.
PURPOSE Some attribute/fields belong to more than more one tables so add proper reference on it. SPECIFICATIONS we are referencing an attribute or attributes that belong to more than one of the tables we are using in the query, and have not qualified the attribute reference. To do that, we add a proper reference on credit and debit. LINKS PR#48389 Forward-Port-Of: odoo/odoo#48389
Original PR description
PURPOSE Some attribute/fields belong to more than more one tables so add proper reference on it. SPECIFICATIONS we are referencing an attribute or attributes that belong to more than one of the tables we are using in the query, and have not qualified the attribute reference. To do that, we add a proper reference on credit and debit. LINKS PR#48389 Forward-Port-Of: odoo/odoo#48389
Use the company set there: https://github.com/odoo/odoo/blob/12.0/addons/website_sale/data/mail_template_data.xml#L19 opw:2226703 Forward-Port-Of: odoo/odoo#48614
Original PR description
Use the company set there: https://github.com/odoo/odoo/blob/12.0/addons/website_sale/data/mail_template_data.xml#L19 opw:2226703 Forward-Port-Of: odoo/odoo#48614
Oopsy! 0:) Forward-Port-Of: odoo/odoo#48906
Original PR description
Oopsy! 0:) Forward-Port-Of: odoo/odoo#48906
- The payment link generated by using the wizard `payment.link.wizard` are overriden to generate URL linked to sale orders. If so, we want the payment acquirer displayed to be in the same company as the sale order. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#47664
Original PR description
- The payment link generated by using the wizard
`payment.link.wizard` are overriden to generate
URL linked to sale orders.
If so, we want the payment acquirer displayed to
be in the same company as the sale order.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#47664This JS test file has already been moved to enterprise. Upgrade note: updating this template is not mandatory for existing databases, but a nice to have for new ones. Forward-Port-Of: odoo/odoo#48984 Forward-Port-Of: odoo/odoo#48975
Original PR description
This JS test file has already been moved to enterprise. Upgrade note: updating this template is not mandatory for existing databases, but a nice to have for new ones. Forward-Port-Of: odoo/odoo#48984 Forward-Port-Of: odoo/odoo#48975
Go to Accounting / Reporting / Management / Invoices Select Pivot view Add "Due amount" measure expand results adding "invoice #" and product Due amount will be incorrect because it is summing up the value reported from several lines of the query in which the total is taken as the invoice total, so it will display total * # lines. Using the group operator avg to avoid summing up the lines fix the issue. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com
Original PR description
Go to Accounting / Reporting / Management / Invoices Select Pivot view Add "Due amount" measure expand results adding "invoice #" and product Due amount will be incorrect because it is summing up the value reported from several lines of the query in which the total is taken as the invoice total, so it will display total * # lines. Using the group operator avg to avoid summing up the lines fix the issue. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#44854
Before this commit, There was expected singleton tracback on Archiving multiple Coupons at once. With this commit, We are passing single Record to process. Description of the issue/feature this PR addresses: Current behavior before PR:  Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forw
Original PR description
Before this commit, There was expected singleton tracback on Archiving multiple Coupons at once. With this commit, We are passing single Record to process. Description of the issue/feature this PR addresses: Current behavior before PR:  Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#45433
1. Install the Australian Accounting localization pack. 2. Create a Bill, use the existing pre-defined tax, "GST only on imports". 3. See that the subtotal of the line will be changed to 0.01. 4. See that at the bottom there will be a GST 100000000% amount showing. The tax data seem to be faulty. Fixing by editing the data. opw-2226119 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#48700
Original PR description
1. Install the Australian Accounting localization pack. 2. Create a Bill, use the existing pre-defined tax, "GST only on imports". 3. See that the subtotal of the line will be changed to 0.01. 4. See that at the bottom there will be a GST 100000000% amount showing. The tax data seem to be faulty. Fixing by editing the data. opw-2226119 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#48700
Before this commit, the value of the search bar remained when the auto-completion dropdown was closed (via click out or "Escape"). This was inconsistent with the behaviour of the search bar which is supposed to show the auto-completion values related to the search input. Now, the value is cleared when the dropdown closes. Task 2227590 Forward-Port-Of: odoo/odoo#48613
Original PR description
Before this commit, the value of the search bar remained when the auto-completion dropdown was closed (via click out or "Escape"). This was inconsistent with the behaviour of the search bar which is supposed to show the auto-completion values related to the search input. Now, the value is cleared when the dropdown closes. Task 2227590 Forward-Port-Of: odoo/odoo#48613
When we uninstall a payment acquirer, its state should be `disabled` because when we succedingly reinstall it, we want the required_if_provider fields to possibly be unset (which is only possible if the state is not in `enabled` or `test`). opw-2223094 Forward-Port-Of: odoo/odoo#49033
Original PR description
When we uninstall a payment acquirer, its state should be `disabled` because when we succedingly reinstall it, we want the required_if_provider fields to possibly be unset (which is only possible if the state is not in `enabled` or `test`). opw-2223094 Forward-Port-Of: odoo/odoo#49033
- Activate "Product Packagings" in the Sales Settings - Define a package on a storable product with a contained Qty of 1.8 - Sell 5.4 units of this product in an SO and use the package. A warning is raised. This happens because 5.4 % 1.8 = 2.220446049250313e-16 opw-2228859 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/s
Original PR description
- Activate "Product Packagings" in the Sales Settings - Define a package on a storable product with a contained Qty of 1.8 - Sell 5.4 units of this product in an SO and use the package. A warning is raised. This happens because 5.4 % 1.8 = 2.220446049250313e-16 opw-2228859 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49026
In case `carrier_tracking_url` is `False`, a `TypeError` is raised and not catched. opw-2232268 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49064
Original PR description
In case `carrier_tracking_url` is `False`, a `TypeError` is raised and not catched. opw-2232268 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49064
Task:https://www.odoo.com/web#id=2121161&action=333&active_id=1251&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.1cdeba0e837cb8447dd66f56c9be65b0 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#48991 Forward-Port-Of: odoo/odoo#41440
Original PR description
Task:https://www.odoo.com/web#id=2121161&action=333&active_id=1251&model=project.task&view_type=form&menu_id=4720 Pad: https://pad.odoo.com/p/r.1cdeba0e837cb8447dd66f56c9be65b0 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#48991 Forward-Port-Of: odoo/odoo#41440
- Create a website: Free sign up Specific User Account activated - In the backend, create a partner "test@test.com" - Grant him portal access => user is not website-specific - Go to the website, Sign Up with "test@test.com" => user is website-specific At login, an expected singleton error arises at: https://github.com/odoo/odoo/blob/c53f1c6a58b4c8c9e9b3c87f27281c9bfd65a0e1/odoo/addons/base/models/res_users.py#L613 Because this matches both users: https://github.com/odoo/od
Original PR description
- Create a website: Free sign up Specific User Account activated - In the backend, create a partner "test@test.com" - Grant him portal access => user is not website-specific - Go to the website, Sign Up with "test@test.com" => user is website-specific At login, an expected singleton error arises at: https://github.com/odoo/odoo/blob/c53f1c6a58b4c8c9e9b3c87f27281c9bfd65a0e1/odoo/addons/base/models/res_users.py#L613 Because this matches both users: https://github.com/odoo/odoo/blob/c53f1c6a58b4c8c9e9b3c87f27281c9bfd65a0e1/addons/website/models/website.py#L44 When such a case arises, we make sure to always select the most specific user first. opw-2219618 Forward-Port-Of: odoo/odoo#49043 Forward-Port-Of: odoo/odoo#48985
This commit concerns tours executed in onboarding mode (the user manually follows the steps and consumes the tips). Commit [1] changed the default event type to consume a tip from 'mousedown' to 'click'. This caused an issue when a tip was attached to an element that had to be dragged and dropped. The issue has been fixed by [2]. This fix is based on the fact that draggable elements have classname 'ui-draggable-handle'. Kanban records are draggable, but their implementation uses the
Original PR description
This commit concerns tours executed in onboarding mode (the user manually follows the steps and consumes the tips). Commit [1] changed the default event type to consume a tip from 'mousedown' to…
This commit concerns tours executed in onboarding mode (the user manually follows the steps and consumes the tips). Commit [1] changed the default event type to consume a tip from 'mousedown' to 'click'. This caused an issue when a tip was attached to an element that had to be dragged and dropped. The issue has been fixed by [2]. This fix is based on the fact that draggable elements have classname 'ui-draggable-handle'. Kanban records are draggable, but their implementation uses the 'sortable' feature of jQuery instead of the 'draggable' one (the records are also sorted in their column). So [2] isn't enough in this case. For instance, in the crm tour, the tip telling to drag and drop a record to another column can't be consumed. This commit handles the case of sortable elements that have to be dragged and dropped. [1] e5bc2e7306251a55ce90adeef992840517c240e6 [2] 3f458fe06e6a629edc72428eab749068c2eba1ba Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#49041 Forward-Port-Of: odoo/odoo#49022
When `_synchronize_alias` was introduced into crm.team.write, the write method become incompatible with batch writes because `_synchronize_alias` assumes `self` is a recordset of length 1 and performs attribute accesses directly on self, this makes the __get__ crash because it performs a `self.ensure_one()` With this commit, crm.team.write will iterate over the self recordset and call `_synchronize_alias` on every record of the recordset. This also solves a uninstallation problem in s
Original PR description
When `_synchronize_alias` was introduced into crm.team.write, the write method become incompatible with batch writes because `_synchronize_alias` assumes `self` is a recordset of length 1 and performs attribute accesses directly on self, this makes the __get__ crash because it performs a `self.ensure_one()` With this commit, crm.team.write will iterate over the self recordset and call `_synchronize_alias` on every record of the recordset. This also solves a uninstallation problem in sale_crm because a write is performed on crm.team in an uninstall_hook. Forward-Port-Of: odoo/odoo#49058
…hange "payment_method_id" onchange changed payment_method_id value where it should have changed sdd_scheme value. Switching from onchange to compute for better performance Forward-Port-Of: odoo/enterprise#9683
Original PR description
…hange "payment_method_id" onchange changed payment_method_id value where it should have changed sdd_scheme value. Switching from onchange to compute for better performance Forward-Port-Of: odoo/enterprise#9683
This issue was intoduced by https://github.com/odoo/enterprise/commit/dbbe8a4e09dd0ad2f9feb57438470ff04676d780 This rule should be only applied for Settings. This is now correctly scoped. Forward-Port-Of: odoo/enterprise#9682
Original PR description
This issue was intoduced by https://github.com/odoo/enterprise/commit/dbbe8a4e09dd0ad2f9feb57438470ff04676d780 This rule should be only applied for Settings. This is now correctly scoped. Forward-Port-Of: odoo/enterprise#9682
As neither this export button nor the export feature from the action menu are properly supported on mobile, it's better to disable it. Further refactoring of the base "export" feature (even on desktop) will allow to properly re-enable it on mobile. Task ID: 2200099 Forward-Port-Of: odoo/enterprise#9621
Original PR description
As neither this export button nor the export feature from the action menu are properly supported on mobile, it's better to disable it. Further refactoring of the base "export" feature (even on desktop) will allow to properly re-enable it on mobile. Task ID: 2200099 Forward-Port-Of: odoo/enterprise#9621
As neither this export button nor the export feature from the action menu are properly supported on mobile, it's better to disable it. Further refactoring of the base "export" feature (even on desktop) will allow to properly re-enable it on mobile. Task ID: 2200099 Forward-Port-Of: odoo/enterprise#9621
Original PR description
As neither this export button nor the export feature from the action menu are properly supported on mobile, it's better to disable it. Further refactoring of the base "export" feature (even on desktop) will allow to properly re-enable it on mobile. Task ID: 2200099 Forward-Port-Of: odoo/enterprise#9621
JS files' URL should be absolute to allow them to be correctly included when running QUnit tests (and prevent 404 errors). Upgrade note: updating those templates is not mandatory for existing databases, but a nice to have for new ones. Forward-Port-Of: odoo/enterprise#9671 Forward-Port-Of: odoo/enterprise#9644
Original PR description
JS files' URL should be absolute to allow them to be correctly included when running QUnit tests (and prevent 404 errors). Upgrade note: updating those templates is not mandatory for existing databases, but a nice to have for new ones. Forward-Port-Of: odoo/enterprise#9671 Forward-Port-Of: odoo/enterprise#9644