Tuesday, June 16, 2020
35 changes · master
New functionality added to Odoo
Event organizers can now set rules that automatically create CRM leads when people register for events. This helps sales teams follow up faster with attendees or groups of attendees, using details from registrations, orders, and event questions.
Original PR description
# Purpose This new module allows to create rules in order to generate leads from event's registrations. # Specifications A new menu, "Lead Generation", in the configuration tab of an event allows to…
# Purpose This new module allows to create rules in order to generate leads from event's registrations. # Specifications A new menu, "Lead Generation", in the configuration tab of an event allows to create rules. This rules are defined by conditions (event, event categories, domain on registration, ...) and the creation of rule can be done in 2 ways : - Per Attendee, which creates a lead for each registration (B2C) - Per Order, which creates a lead for a set of registrations (B2B) (visible only when event_sale or website_event is installed) The flow of creation is as follow: When registrations are created we will check if any rules applies to them. To be applied : - The rule must be active - If the company is set on the rule, it must match - If the event category and the event aren't specified, it's always OK - If only one of them is set, it must match - If both of them are set, one must match - If a domain on the registration is set, it must match When the conditions are matched, it will create the lead with information based on the rule (lead type, salesperson, sales team, tags) and the registration (name, contact_name, email, ...) Once a lead is created for an event registration, a stat button displays the number of leads created for the event of the registration and on the lead form, a stat button displays all registrations linked to the lead. See sub commit for more detail. Task ID : 2166679
Enhancements to existing features
The SMS composer now recalculates message details while users edit fields, including validating phone numbers as they type. This makes the send/confirm flow smoother and prevents the confirm button from moving unexpectedly during interaction.
Resolved issues and error corrections
This fixes an issue where manually entered time off allocation durations could be overwritten with a default value after saving. Allocations entered in days or hours now keep the intended amount, helping HR teams avoid incorrect leave balances.
Original PR description
Purpose: - Purpose of this commit is to should not be change the duration automatically in time off allocation. Task: 2275933 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
ACLs on the wizard lines should match that of the wizard, otherwise ERP managers can see the action but get an error as soon as they open the wizard. Since ERP managers have write access on arbitrary users, that's probably the right group to use. Task 2275134 Forward-Port-Of: odoo/odoo#52974
Original PR description
ACLs on the wizard lines should match that of the wizard, otherwise ERP managers can see the action but get an error as soon as they open the wizard. Since ERP managers have write access on arbitrary users, that's probably the right group to use. Task 2275134 Forward-Port-Of: odoo/odoo#52974
The main Odoo release version has been updated to 13.5. This helps keep product versioning accurate for upcoming releases and related planning, with no direct change to day-to-day functionality.
Original PR description
Bump version
Warehouse users can now use Put in Pack when processing immediate transfers that start from detailed move lines. This prevents these transfers from getting stuck without the packaging action, improving package handling in stock operations.
Original PR description
PURPOSE Allow the 'PUT IN PACK' button in case they did not have a stock move. SPECIFICATIONS When creating an immediate transfer for an operation type which has "show detailed" selected, you directly have to enter an SML. When doing so, the transfer remains in a draft state, cannot be confirmed, so the 'PUT IN PACK' button doesn't appear. The Button does not appear in draft state because they restricted by the condition of the state. To do that, we change the state of picking 'draft' to 'ready' if picking doesn't have a stock move so the 'PUT IN PACK' button appears. LINKS PR #44565 Task 2184131 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Lunch product categories can now be archived, include a default image, and better support products without their own images. Company-specific visibility was improved so lunch products and categories are shown appropriately in multi-company setups.
Original PR description
Purpose ======= Improve the lunch categories and mutli-company environment. Specifications ============ - Able to archive a product category - add a default image for lunch categories - Adapt the size of the default image, currently it's too big - Add a company field on the Product categories (it's already there but it should be visible on the view form) Task: 2200002 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Changing an activity type now only replaces the activity summary when that type has a default summary configured. This prevents users' manually entered summaries from being accidentally cleared when they choose an activity type without a default.
Original PR description
PURPOSE Currently, there is an on-change to set an activity summary to the default summary of an activity type. This can be useful if types are properly configured. The problem is, the activity summary will be updated even if there isn't any default summary on the type. Meaning that it simply removing a relevant custom summary the user might have already entered. SPECIFICATIONS When triggering the on-change on activity_type_id, only update the activity summary to the default summary if there is a default summary defined on the activity type. LINKS Task-2254825 PR https://github.com/odoo/odoo/pull/51373 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr https://www.odoo.com/web#id=2254825&action=327&model=project.task&view_type=form&cids=1&menu_id=4720
Calendar event popovers now display the responsible person using an avatar instead of a plain link, while keeping the profile clickable. This makes event ownership easier to recognize at a glance and also includes a Google Calendar sync fix to avoid duplicate syncs when one partner is linked to multiple users.
Original PR description
Description of the issue/feature this PR addresses: Taskid: 2263837 - calendar: Use the avatar widget on event popover Current behavior before PR: On event popover, the responsible of an event appeared as a simple link. Desired behavior after PR is merged: On event popover, the responsible of an event will now appear through the avatar widget, and still be clickable. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix automatically keeps the maximum reorder quantity at least equal to the minimum quantity when users edit stock replenishment rules. It helps avoid confusing inventory settings while preserving existing scheduler behavior.
Original PR description
**Description of the issue/feature this PR addresses:** Before this commit an user can write `product_max_qty` bellow than `product_min_qty`, it is not an issue for stock scheduler because https://github.com/odoo/odoo/blob/master/addons/stock/models/stock_orderpoint.py#L253. But for the user, it can source of misunderstanding. This PR add an onchange to set the `product_max_qty` same as `product_min_qty` if needed. @sle-odoo -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Steps to reproduce: - install crm - go to crm > configuration > settings > activate leads - go to a contact > click the "opportunity" smart button > create an opportunity > select the newly created opportunity > click the "meetings" smart button Previous behavior: meetings are filtered with 'search_default_opportunity_id' set to active_id. active_id is referring to the partner_id in this case. this leads to a cache miss error. Current behavior: meetings are filtered by the right o
Original PR description
Steps to reproduce: - install crm - go to crm > configuration > settings > activate leads - go to a contact > click the "opportunity" smart button > create an opportunity > select the newly created opportunity > click the "meetings" smart button Previous behavior: meetings are filtered with 'search_default_opportunity_id' set to active_id. active_id is referring to the partner_id in this case. this leads to a cache miss error. Current behavior: meetings are filtered by the right opportunity (current id). opw-2272325 Forward-Port-Of: odoo/odoo#52947
- Create flexible BOM for product P - Create a MO for 5 units - Produce 3 units - Post the inventory - Cancel the MO The MO remains 'In Progress'. In case of a flexible BOM, the quantity produced is compared to the quantity to produce to know whether the MO should be done. In this specific case, however, the MO should be closed. It's not possible to rely on the move states in this case, so we introduce a context key when canceling. opw-2270279 Description of the issue/featu
Original PR description
- Create flexible BOM for product P - Create a MO for 5 units - Produce 3 units - Post the inventory - Cancel the MO The MO remains 'In Progress'. In case of a flexible BOM, the quantity produced is compared to the quantity to produce to know whether the MO should be done. In this specific case, however, the MO should be closed. It's not possible to rely on the move states in this case, so we introduce a context key when canceling. opw-2270279 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#52887
Steps to reproduce the bug: - Let's consider a storable product P with automatic inventory valuation and re-invoicing policy at cost - Create a SO with P, generate an invoice I and validate I Bug: A new line was added in the SO (related to the anglo saxon move line) PS: In 12.0, no line was added on the SO when I was validated. opw:2247915 Forward-Port-Of: odoo/odoo#52873
Original PR description
Steps to reproduce the bug: - Let's consider a storable product P with automatic inventory valuation and re-invoicing policy at cost - Create a SO with P, generate an invoice I and validate I Bug: A new line was added in the SO (related to the anglo saxon move line) PS: In 12.0, no line was added on the SO when I was validated. opw:2247915 Forward-Port-Of: odoo/odoo#52873
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53008
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53008
current expression implies that any payment of a quote from the portal (/my/quotes) will try to save a token whenever the user says they want the customer to pay online, which seems bizarre. Normally you'd only want that for quotes with subscription products, and there is an override of that method in sale_subscription for that specific case. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#52896
Original PR description
current expression implies that any payment of a quote from the portal (/my/quotes) will try to save a token whenever the user says they want the customer to pay online, which seems bizarre. Normally you'd only want that for quotes with subscription products, and there is an override of that method in sale_subscription for that specific case. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#52896
PURPOSE Fix various issues spotted in 13.3 when testing event. Notably computation of 2many fields coming from template. SPECIFICATIONS When updating template on an event, one2many fields should be better managed. Previous heuristic was * if event type uses o2m configuration (use_ticket / _schedule / _question) and has lines * erase existing lines; * create new lines based on old one; This has the drawback of loosing information of what is sent (mail) or sold (
Original PR description
PURPOSE Fix various issues spotted in 13.3 when testing event. Notably computation of 2many fields coming from template. SPECIFICATIONS When updating template on an event, one2many fields should be…
PURPOSE
Fix various issues spotted in 13.3 when testing event. Notably
computation of 2many fields coming from template.
SPECIFICATIONS
When updating template on an event, one2many fields should be better managed.
Previous heuristic was
* if event type uses o2m configuration (use_ticket / _schedule / _question)
and has lines
* erase existing lines;
* create new lines based on old one;
This has the drawback of loosing information of what is sent (mail) or
sold (tickets) or answered( questions). Another drawback is that only
types having line are synchronized. This means that if updating several
times the event type you could end up with an XMas configuration with
lines coming from different event types, depending on their o2m configuration.
We choose a better heuristic that should solve this issue
* every time we change type, independently of its use_* field that is used
mainly for UX on the type itself:
* erase existing lines that have not been used yet (no mail sent, no
ticket linked to registrations, no answer linked to registrations)
* create new lines based on old one; if type has no lines, event will
have its old empty line erased as well;
It means that we try to synchronize more the type to the event while keeping
configuration line already used in some registrations.
Also provide some other fixes like deletion restrictions or better domain
for UX purpose. See sub commits for more details.
LINKS
Task ID 2244487
PR odoo/odoo#52923
Forward-Port-Of: odoo/odoo#52998
Forward-Port-Of: odoo/odoo#52923Configure a catchall address in Odoo, send an email to that very address, it should bounce back to the user asking him not to send any email to the catchall but the email is never sent. Internally, Odoo reply to the user using the `To` header of the original email as `From` of the bounced email. It should never use the catchall address as it is not a valid email to send email from. Task: 2277661 Forward-Port-Of: odoo/odoo#52967
Original PR description
Configure a catchall address in Odoo, send an email to that very address, it should bounce back to the user asking him not to send any email to the catchall but the email is never sent. Internally, Odoo reply to the user using the `To` header of the original email as `From` of the bounced email. It should never use the catchall address as it is not a valid email to send email from. Task: 2277661 Forward-Port-Of: odoo/odoo#52967
Steps to reproduce: - install contacts - go to any 2 contacts and add a message and an activity to the chatter - go to the list view > select the 2 contacts > action > merge - click on the remaining contact Previous behavior: messages from the merged contact are not displayed and the "show older messages" button does nothing on click the activities have not been merged Current behavior: activities are merged messages are added if they do not belong to the same document and displa
Original PR description
Steps to reproduce: - install contacts - go to any 2 contacts and add a message and an activity to the chatter - go to the list view > select the 2 contacts > action > merge - click on the remaining contact Previous behavior: messages from the merged contact are not displayed and the "show older messages" button does nothing on click the activities have not been merged Current behavior: activities are merged messages are added if they do not belong to the same document and displayed opw-2263853 Forward-Port-Of: odoo/odoo#52597
Coding error opw:2276815 Forward-Port-Of: odoo/odoo#52963
Original PR description
Coding error opw:2276815 Forward-Port-Of: odoo/odoo#52963
task-2269440 Forward-Port-Of: odoo/odoo#53025
Original PR description
task-2269440 Forward-Port-Of: odoo/odoo#53025
This PR replaces #42550, and holds all these improvements, that previously has been linked to 13.0_dev commit. The summary of modifications is the following: [FIX] l10n_cl: (format vat) create booleans for conditions of country (for current company and partner) [FIX] prevent errors with domain of available documents in invoice view [IMP] Add several constrains and selection of documents [IMP] add on_change to clean the docs when changing journals [FIX] l10n_cl: - remove constrain for Te
Original PR description
This PR replaces #42550, and holds all these improvements, that previously has been linked to 13.0_dev commit. The summary of modifications is the following: [FIX] l10n_cl: (format vat) create…
This PR replaces #42550, and holds all these improvements, that previously has been linked to 13.0_dev commit. The summary of modifications is the following: [FIX] l10n_cl: (format vat) create booleans for conditions of country (for current company and partner) [FIX] prevent errors with domain of available documents in invoice view [IMP] Add several constrains and selection of documents [IMP] add on_change to clean the docs when changing journals [FIX] l10n_cl: - remove constrain for Tesorería (another documents could be managed by now in tesorería, but DIN is only intended for tesorería). - order the condition in constraint (removed else) [FIX] allow to select document types when partner is empty [ADD] l10n_cl: add ILA taxes (purchase) [ADD] l10n_cl: add ILA taxes (sale) and assign account to taxes [ADD] l10n_cl: add fiscal position exempt for purchases and sales [IMP] l10n_cl: configure accounts used in inventory valuation [I18N] l10n_cl: add Spanish translation [FIX] l10n_cl: solve expected singleton [FIX] l10n_cl prevent to put unneeded sales documents in sales journal [FIX] l10n_cl modify document domain to override l10n_latam_invoice_document domain definition [FIX] l10n_cl limit revision of document types and partner constrains only for sale and purchase journals [FIX] l10n_cl: add country_id to account.account.tag [FIX] l10n_cl: add extra validation to know whether there is a latam_document_type_code selected [ADD] l10n_cl: add document type '801' Orden de compra [FIX] l10n_cl: apply group_operator false to taxes to prevent sum in a group by tree view [WIP] add tag to costo de ventas account [FIX] l10n_cl: fiscal position templates: fix supermarket tax [FIX] l10n_cl: change order for boletas [IMP] l10n_cl: provide a formatting for chilean VAT -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#52995 Forward-Port-Of: odoo/odoo#51740
When we print a ticket status with a thermal printer we need printer's device-id But if we add manually a printer this device-id doesn't exist So now we update de devices list with a supported = True if printer are manually added Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53043
Original PR description
When we print a ticket status with a thermal printer we need printer's device-id But if we add manually a printer this device-id doesn't exist So now we update de devices list with a supported = True if printer are manually added Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53043
Fix singleton error when trying to backorder several MO task-2278147 Forward-Port-Of: odoo/odoo#53065
Original PR description
Fix singleton error when trying to backorder several MO task-2278147 Forward-Port-Of: odoo/odoo#53065
Usecase to reproduce: - Create 2 table(MTO) - Produce 1 and use BO button Traceback due to a reference to enterprise field. Forward-Port-Of: odoo/odoo#53055
Original PR description
Usecase to reproduce: - Create 2 table(MTO) - Produce 1 and use BO button Traceback due to a reference to enterprise field. Forward-Port-Of: odoo/odoo#53055
task-2272510 Forward-Port-Of: odoo/odoo#53030
Original PR description
task-2272510 Forward-Port-Of: odoo/odoo#53030
task-2276039 Forward-Port-Of: odoo/odoo#53076
Original PR description
task-2276039 Forward-Port-Of: odoo/odoo#53076
- restore "solid" icon - restore muted style when no notification - opportunity is taken to fix off-pixel of activity menu task-2278416 Forward-Port-Of: odoo/odoo#53069
Original PR description
- restore "solid" icon - restore muted style when no notification - opportunity is taken to fix off-pixel of activity menu task-2278416 Forward-Port-Of: odoo/odoo#53069
task-2224442 Forward-Port-Of: odoo/odoo#53090
Original PR description
task-2224442 Forward-Port-Of: odoo/odoo#53090
- change name to ref in DCN_1 and ORC_1 Task: https://www.odoo.com/web#id=2268148&action=327&model=project.task&view_type=form&cids=&menu_id=4720 Forward-Port-Of: odoo/enterprise#10872
Original PR description
- change name to ref in DCN_1 and ORC_1 Task: https://www.odoo.com/web#id=2268148&action=327&model=project.task&view_type=form&cids=&menu_id=4720 Forward-Port-Of: odoo/enterprise#10872
A community code call an enterprise variable Forward-Port-Of: odoo/enterprise#11185
Original PR description
A community code call an enterprise variable Forward-Port-Of: odoo/enterprise#11185
- Install Sales (sale_management) and DHL Express Shipping (delivery_dhl) - Go to Sales > Configuration > Shipping Methods - Select a DHL delivery method (e.g. DHL USA) and activate "Dutiable Material" option - Go to Sales and create a quotation - Add a product with a Weight and a Volume - Click on the "ADD SHIPPING" button - On the wizard, select the modified DHL delivery method and click on "GET RATE" button The following error is triggered: AttributeError: 'str' object has no attribut
Original PR description
- Install Sales (sale_management) and DHL Express Shipping (delivery_dhl) - Go to Sales > Configuration > Shipping Methods - Select a DHL delivery method (e.g. DHL USA) and activate "Dutiable Material" option - Go to Sales and create a quotation - Add a product with a Weight and a Volume - Click on the "ADD SHIPPING" button - On the wizard, select the modified DHL delivery method and click on "GET RATE" button The following error is triggered: AttributeError: 'str' object has no attribute 'name' opw-2263982 Forward-Port-Of: odoo/enterprise#11178 Forward-Port-Of: odoo/enterprise#11155
Partial revert of 478da63084c638b850e365439ba6fc4b017432b0 Before this commit, there was negative value in the mod 111 tax report ('[03] Importe de las retenciones'). Now, the value is positive. opw-2209079 Forward-Port-Of: odoo/enterprise#11174 Forward-Port-Of: odoo/enterprise#11153
Original PR description
Partial revert of 478da63084c638b850e365439ba6fc4b017432b0
Before this commit, there was negative value in the mod 111 tax report
('[03] Importe de las retenciones').
Now, the value is positive.
opw-2209079
Forward-Port-Of: odoo/enterprise#11174
Forward-Port-Of: odoo/enterprise#11153Steps to reproduce the bug: 1. Install l10n_in_hr_payroll 2. Navigate to All Payslips 3. Select an employee 4. Print 'PaySlip Details' Bug: A traceback was raised Inspired from https://github.com/odoo/odoo/commit/dc6240775f089c50a9083fab06afc3b394ec3137 opw:2272276 Forward-Port-Of: odoo/enterprise#11097
Original PR description
Steps to reproduce the bug: 1. Install l10n_in_hr_payroll 2. Navigate to All Payslips 3. Select an employee 4. Print 'PaySlip Details' Bug: A traceback was raised Inspired from https://github.com/odoo/odoo/commit/dc6240775f089c50a9083fab06afc3b394ec3137 opw:2272276 Forward-Port-Of: odoo/enterprise#11097
- Install industry_fsm_report - Go to Field Service > Configuration > Settings and activate "Worksheet Templates" - Go to Sales > Configuration > Settings and activate "Lock Confirmed Sales" - Create a new product: * Product type: Service In Invoice section of Sales tab: * Service Tracking: Create a task in an existing project * Project: Field Service - Create a new Quotation and add the created Service product - Confirm the quotation - Click on Tasks smart button - Click on W
Original PR description
- Install industry_fsm_report - Go to Field Service > Configuration > Settings and activate "Worksheet Templates" - Go to Sales > Configuration > Settings and activate "Lock Confirmed Sales" - Create…
- Install industry_fsm_report - Go to Field Service > Configuration > Settings and activate "Worksheet Templates" - Go to Sales > Configuration > Settings and activate "Lock Confirmed Sales" - Create a new product: * Product type: Service In Invoice section of Sales tab: * Service Tracking: Create a task in an existing project * Project: Field Service - Create a new Quotation and add the created Service product - Confirm the quotation - Click on Tasks smart button - Click on Worksheet smart button - Write a comment and save - Go back to SO - Click on Tasks smart button - The "SIGN REPORT" and "SEND REPORT" actions are now available - Click on one of them The following error message appears : "It is forbidden to modify the following fields in a locked order: Quantity" As introduced by this commit https://github.com/odoo/enterprise/commit/d04b48b5a27d30e63149ebf6783641a07c5d65ea, when generating the Worksheet report, if the SO line is a task with timesheets, the value of the ordered quantity is updated with the value of the delivered quantity, which generates an error because the SO is locked. This has been done because the Worksheet report only displays ordered quantities but should display delivered quantities for timesheets on tasks. This is a weird behavior because generating a report should not modify the SO. That is why this behavior has been removed. Instead of updating the SO lines, the report template has been modified to display delivered quantities when the SO line is a task with timesheets and ordered quantities otherwise. opw-2242790 Forward-Port-Of: odoo/enterprise#11086 Forward-Port-Of: odoo/enterprise#10987
- The `sale.subscription.line` records have a foreign-key to the `sale.subscription` that wasn't set to `ON DELETE CASCADE`. This would let the possiblity to have orphan subscription lines which has no sense. The field should also be required but it will be done in master as we do not consider this as a stable change. Forward-Port-Of: odoo/enterprise#11144 Forward-Port-Of: odoo/enterprise#10863
Original PR description
- The `sale.subscription.line` records have a foreign-key to the `sale.subscription` that wasn't set to `ON DELETE CASCADE`. This would let the possiblity to have orphan subscription lines which has no sense. The field should also be required but it will be done in master as we do not consider this as a stable change. Forward-Port-Of: odoo/enterprise#11144 Forward-Port-Of: odoo/enterprise#10863