Monday, July 6, 2020
20 changes · master
Enhancements to existing features
This change removes an obsolete Canadian HST 14% tax template that has not applied since the rate changed to 15% in 2016. It helps keep Canadian localization tax setup aligned with current official GST/HST rates and avoids outdated tax options in configurations.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update refines how translated text is handled across several Odoo areas, reducing unnecessary translation entries and making messages more natural in context. Users benefit from clearer wording in their language, while translation maintenance becomes simpler and more accurate.
Original PR description
* Avoid translating multiple strings when not needed * Insert values directly into the translated string, without string concatenation -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
Updates Canadian localization settings so Prince Edward Island uses the current 15% HST rate instead of the outdated 14% rate. This helps businesses apply the correct provincial tax and avoid incorrect tax calculations.
Original PR description
Description of the issue/feature this PR addresses: HST 14% tax was replaced with 15% tax in October 2016 as per [GST/HST provincial rates table](https://www.canada.ca/en/revenue-agency/services/tax/businesses/topics/gst-hst-businesses/charge-collect-which-rate/calculator.html#rt) Current behavior before PR: Incorrect fiscal position for Prince Edward Island Desired behavior after PR is merged: Update Fiscal position for Prince Edward Island Remove 14% tax -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54060 Forward-Port-Of: odoo/odoo#54049
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54060 Forward-Port-Of: odoo/odoo#54049
This fix addresses an issue where opening a conversation thread in Discuss did not work as expected. It helps users reliably access their messages and reduces disruption in day-to-day communication.
Original PR description
See also odoo/enterprise#11684 task-2282273
Transparency previews now use a shared checkerboard background instead of duplicated styling across website editing areas. This keeps visual behavior consistent, removes an incorrect dependency between apps, and fixes a layout issue in the color picker.
Original PR description
*: website The style to achieve the chess-like bg result was duplicated at many places. The 'web' app was also actually using an image from the 'web_editor' app (we can live with it in stable as web_editor always comes with web in auto_install but this was still a mistake). Also: fix some layout issue in the colorpicker widget.
This fixes an issue where planning chart labels could display incorrectly when the forecasting feature was installed. Users now see clearer and more consistent labels in scheduling views, reducing confusion when reviewing planned work.
Original PR description
…ecast is installed
This change adds automated checks to ensure expanding a chat window works as expected in the enterprise mail app. It helps prevent regressions in the messaging experience, reducing the risk of users encountering broken or inconsistent chat behavior.
Original PR description
See also odoo/odoo#54141 task-2282273
Belgian CODA bank statement import messages now translate at the right time instead of during server startup, when no user language is available. This ensures users see the correct localized wording and avoids unnecessary translation work during restarts.
Original PR description
All those strings were translated at server start, but at this step, there is no language defined anyway... Thus, all those strings were never translated... Through the use of the lazy translation method, we avoid useless attempts of translation at server (re)starts, and we ensure that the strings are correctly translated when necessary. Linked with https://github.com/odoo/odoo/pull/54118
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53974
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53974
These field combinations [1] are actually secondary keys. They are unique and represent the record identity. Marking them as modified had a nasty side-effect: on some models, there is a m2o to an ir.model and a stored related to ir.model/model that will be recomputed at each model reflection. This can take some time on big tables. Moreover, some other stored fields may depend on those ir.model/model related store, which adds useless time lost at recomputing unchanged values. [1] ir.model/model
Original PR description
These field combinations [1] are actually secondary keys. They are
unique and represent the record identity.
Marking them as modified had a nasty side-effect: on some models, there
is a m2o to an ir.model and a stored related to ir.model/model that will
be recomputed at each model reflection. This can take some time on big
tables.
Moreover, some other stored fields may depend on those ir.model/model
related store, which adds useless time lost at recomputing unchanged
values.
[1] ir.model/model, ir.model.fields/{model,name} and
ir.model.selection/{field_id,name}
Forward-Port-Of: odoo/odoo#54115### Issue - Go to Accounting / Customers / Invoices - Pick any invoice not paid - Action: Generate a Payment Link - Open the link - Refresh the page having Javascript disabled - Click the Pay Now button Traceback ### Cause If JS is not loaded, the values in the form fields are not bound as expected. It can also happen with slow connections and fast click on the button at the loading. Before the JS is entirely loaded (as it is lazy-loaded). ### Solution B
Original PR description
### Issue - Go to Accounting / Customers / Invoices - Pick any invoice not paid - Action: Generate a Payment Link - Open the link - Refresh the page having Javascript disabled - Click the Pay Now button Traceback ### Cause If JS is not loaded, the values in the form fields are not bound as expected. It can also happen with slow connections and fast click on the button at the loading. Before the JS is entirely loaded (as it is lazy-loaded). ### Solution Button disabled by default, wait the page to be loaded and then activate the button **OPW-2255760** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53904
In case a field is limited to specific groups on the model, those fields are discarded from `fields_view_get()` but can still be referenced by some filters on the search view causing a traceback (see #53797) Model: ```python class MyModel(models.Model): my_field = fields.Char(groups='base.group_system') ``` Search views: ```xml <search string="My Model"> <filter name="group_myfield" context="{'group_by': 'my_field'}"/> </search> ``` This commit ensure those filt
Original PR description
In case a field is limited to specific groups on the model, those fields
are discarded from `fields_view_get()` but can still be referenced by some
filters on the search view causing a traceback (see #53797)
Model:
```python
class MyModel(models.Model):
my_field = fields.Char(groups='base.group_system')
```
Search views:
```xml
<search string="My Model">
<filter name="group_myfield" context="{'group_by': 'my_field'}"/>
</search>
```
This commit ensure those filter are correctly discarded.
OPW-2284621
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#53887
Forward-Port-Of: odoo/odoo#53867…ograde IoT Box When we upgrade the IoT we wait that the version of box match with the last version of IoT Box before to refresh. We make a request to '/hw_proxy/get_version' to get the actual version. In Jinja this response give a float. We compare this value with a string using '===' who want that the format match. So we doesn't compare the format of values but only the value by putting only '=='. Description of the issue/feature this PR addresses: Current behavior before PR:
Original PR description
…ograde IoT Box When we upgrade the IoT we wait that the version of box match with the last version of IoT Box before to refresh. We make a request to '/hw_proxy/get_version' to get the actual version. In Jinja this response give a float. We compare this value with a string using '===' who want that the format match. So we doesn't compare the format of values but only the value by putting only '=='. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54121
task-2280151 Forward-Port-Of: odoo/odoo#53980
Original PR description
task-2280151 Forward-Port-Of: odoo/odoo#53980
Before this commit, when clicking on reply in inbox would send a message whatever the subtype of message the reply is linked to. This commit makes sure that if the message which we want to reply to is a note (resp. comment), then the reply will be a note (resp. comment) task-2282363 Forward-Port-Of: odoo/odoo#53976
Original PR description
Before this commit, when clicking on reply in inbox would send a message whatever the subtype of message the reply is linked to. This commit makes sure that if the message which we want to reply to is a note (resp. comment), then the reply will be a note (resp. comment) task-2282363 Forward-Port-Of: odoo/odoo#53976
Before this commit, the subtype was displayed if a description was present. After this commit, this will be hidden for Direct Message and Channel and a line break is added for the other cases. Steps to reproduce: * Configure a description in the Discussion Subtype. * Activate OCN * Login with a Mobile App (User A) * Send a DM with user B to user A Forward-Port-Of: odoo/enterprise#11666
Original PR description
Before this commit, the subtype was displayed if a description was present. After this commit, this will be hidden for Direct Message and Channel and a line break is added for the other cases. Steps to reproduce: * Configure a description in the Discussion Subtype. * Activate OCN * Login with a Mobile App (User A) * Send a DM with user B to user A Forward-Port-Of: odoo/enterprise#11666
In v13.0 get_fiscal_position return an id, in saas-13.3 it returns a recordset, the create crash if it doesn't receive an id. Forward-Port-Of: odoo/enterprise#11603
Original PR description
In v13.0 get_fiscal_position return an id, in saas-13.3 it returns a recordset, the create crash if it doesn't receive an id. Forward-Port-Of: odoo/enterprise#11603
This test now uses its own bank.statement because the one created in the mother class no longer exists after a refactor. Forward-Port-Of: odoo/enterprise#11636
Original PR description
This test now uses its own bank.statement because the one created in the mother class no longer exists after a refactor. Forward-Port-Of: odoo/enterprise#11636
Before this commit: When a portal user (or someone who gets an email to sign) validate the document to sign, he has an error. After this commit: No more error Forward-Port-Of: odoo/enterprise#11573
Original PR description
Before this commit: When a portal user (or someone who gets an email to sign) validate the document to sign, he has an error. After this commit: No more error Forward-Port-Of: odoo/enterprise#11573