Thursday, July 30, 2020
31 changes · master
Security fixes and vulnerability patches
This fixes permissions so Expense Team Approvers only have the access needed for expense approvals, rather than broad accounting capabilities. It reduces the risk of users viewing or changing accounting data outside their role.
Original PR description
1. Apply same logic for sale and purchase user. 2. The group Expense Team Approuver can write/create/unlink, it is opposite than https://github.com/odoo/odoo/blob/13.0/addons/hr_expense/security/ir.model.access.csv#L15 and https://github.com/odoo/odoo/blob/13.0/addons/hr_expense/security/ir.model.access.csv#L16 opw:2275116
Enhancements to existing features
Odoo now supports application-level menus that both open a default action and contain submenus. This restores a valid menu setup for apps and prevents configuration rules from rejecting these root menus.
Original PR description
Reported by VFE, odoo/odoo#54564 missed one of the use cases in menus: normally a menu can have *either* sub-menus or an actions (aka only "leaf" menu items can have actions), however there's an exception for root menus ("application" menu): those can have an action, which is the action executed when entering the application itself.
Since there was already a special case for root menus (allowing a web_icon), expand this to allow both submenus and an action.
For the two alternatives (submenu items or menuitems with a parent attribute), extract the old pattern and reuse it.Resolved issues and error corrections
This fixes an issue that prevented users from cancelling and deleting bank statements linked to previously posted journal entries. The system now properly resets the posting information when a statement is moved back to draft, while preserving numbering to avoid gaps in accounting records.
Original PR description
When we tried to cancel a bank statement, we had to reset the statement to new, then delete the linked journal entries. We couldn't do so because the entries have been posted before and kept their sequence number. In order to allow the deletion of a statement, we completely reset the posted information of the linked journal items when we reset the statement to draft. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Code cleanup and technical improvements
This change restores the color setting for event tracks after a previous update removed or altered it. It helps keep event pages visually consistent and easier for visitors to scan.
Original PR description
Partial revert of bd61b6cd386ebeb9f8b375fff7ad430a2e4c39b5
Miscellaneous changes
- Install Contacts and Repairs - Go to Contacts and configure Payment Terms of Contact X (i.e. 2 Months) - Go to Repairs and create a Repair Order: * Select Contact X as Customer * Select "Before Repair" as Invoice Method * Add Parts or Operations - Confirm Repair and Create invoice The Payment Terms of the created invoice is the default one and not the Payment Terms of Customer. opw-2304818 Description of the issue/feature this PR addresses: Current behavior before PR:
Original PR description
- Install Contacts and Repairs - Go to Contacts and configure Payment Terms of Contact X (i.e. 2 Months) - Go to Repairs and create a Repair Order: * Select Contact X as Customer * Select "Before Repair" as Invoice Method * Add Parts or Operations - Confirm Repair and Create invoice The Payment Terms of the created invoice is the default one and not the Payment Terms of Customer. opw-2304818 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55118
Website editors can now add and configure Google Maps directly from the page editor, including API key setup, pin location, layout support, and optional descriptions. This makes it easier to create polished location sections without relying on theme-specific features or developer help.
Original PR description
This merges two commits: **[IMP] website: various improvements to the google map snippet** * the snippet works with columns * the API key can directly be added through the snippet * the pin location option has been moved out of a modal to the snippet options * the description can be toggled on and off **[MOV] website: moves google map snippet from themes to community** This commit moves the google map snippet from design-themes/theme_common to website. see: https://github.com/odoo/design-themes/pull/231 task-2091396
This update polishes several accounting workflows based on consultant feedback, including chart of accounts, demo data, journal sequence numbers, payment status, and bank statements. These refinements should make day-to-day accounting setup and review clearer and more consistent for business users.
Original PR description
Clean various feedbacks reported by consultants WTA/CTH. It concerns namely : - CoA - DEMO DATA - SEQUENCE NUMBER ON JOURNALS - PAYMENT STATUS - BANK STATEMENTS Task ID: #2300936 Enterprise PR : [11995](https://github.com/odoo/enterprise/pull/11995) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update improves how a stock validation error is shown to users. The clearer message helps warehouse staff understand the issue faster and take the right action without confusion.
Original PR description
Before this commit, This validation message was not displayed properly. (See https://nimb.ws/zYBLvh ) Now we are displaying validation error Properly. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The website builder’s snippet library now has refreshed thumbnail images and clearer snippet names across several website-related apps. This makes it easier for users to recognize building blocks and choose the right content elements when creating pages or emails.
Original PR description
New thumbs for the snippets library -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The website editor now uses clearer SVG icons and icon-based controls for layout, alignment, shadow, size, and positioning options. This makes editing website pages more visual and easier to understand while keeping the interface consistent with existing button styles.
Original PR description
Add new SVG icons for the website editor UI. Task: 2157252 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Website editors can now add a Google font by pasting the font page link, instead of having to find and copy the embed code. This makes font customization simpler while still accepting embed codes for users who already have them.
Original PR description
Before this commit users needs to link an embed code provided by Google. But it became less obvious to find this code so we now ask for the link of the font page. But we still keep the possibility to link an embed code if ever a user is wrong. task-2304075 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Expense receipt scanning now stores the detected category in its own field instead of putting it into the description. This helps product prediction use cleaner data while keeping expense descriptions available for their intended purpose.
Original PR description
before this commit: - the expense extract module returns the category and set it as description and the predict product use this field to set the product. after this commit: - a new field 'category' is now set by the OCR and used by the predict product to set the product.
Updated the Belgian payroll accounting test setup to reflect consultant feedback on accounting setup, demo data, journal numbering, payment status, and bank statements. This improves the reliability and realism of payroll accounting validation without changing day-to-day business workflows.
Original PR description
Clean various feedbacks reported by consultants WTA/CTH. It concerns namely : - CoA - DEMO DATA - SEQUENCE NUMBER ON JOURNALS - PAYMENT STATUS - BANK STATEMENTS Task ID: #2300936 Community PR : [54874](https://github.com/odoo/odoo/pull/54874)
Reordering images in the website image wall no longer causes the editing options to flicker. This makes arranging gallery images feel smoother and less distracting for website editors.
Original PR description
Before this commit, reordering the images in the image wall was causing a flicker of the snippet options. It was caused by a forced deselection of the snippet (image) that is not necessary since 17e7e75 task-2307083
This fix restores the correct process for registering tracked components during subcontracted manufacturing. It helps businesses keep accurate traceability for both finished products and the components provided to subcontractors, reducing inventory and compliance errors.
Original PR description
After the odoo/odoo#52949 , the registering of tracked component, in case of subcontracting, was broken. Fix and try to mimic the same flow than before. The produce wizard has been replaced by a clean MO form to register component and use backorder mechanisme of MO to manage tracked finished product + tracked component. task-2278147 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
- Configure a Product Category Automated + FIFO - Create a product in this category - Create a PO for 10 units, receive the units, bill the PO and pay - Sell 1 unit of the product and deliver it - Create an invoice for the order - Without paying the invoice, create a credit note with the option 'Full refund and draft invoice' - Post new invoice The anglo-saxon lines are counted twice. This happens because the lines already exist in the newly created draft invoice. opw-2300536
Original PR description
- Configure a Product Category Automated + FIFO - Create a product in this category - Create a PO for 10 units, receive the units, bill the PO and pay - Sell 1 unit of the product and deliver it - Create an invoice for the order - Without paying the invoice, create a credit note with the option 'Full refund and draft invoice' - Post new invoice The anglo-saxon lines are counted twice. This happens because the lines already exist in the newly created draft invoice. opw-2300536 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55136 Forward-Port-Of: odoo/odoo#55106
Steps to reproduce the bug: - Create a new company C with country = Sweden - Install app l10n_se - Go to Accounting/Configuration/Setting/Fiscal Localization Package, select Swedish Chart of Account and then save Bug: The sweddish fiscal positions were not loaded. opw:2302926 Forward-Port-Of: odoo/odoo#55138
Original PR description
Steps to reproduce the bug: - Create a new company C with country = Sweden - Install app l10n_se - Go to Accounting/Configuration/Setting/Fiscal Localization Package, select Swedish Chart of Account and then save Bug: The sweddish fiscal positions were not loaded. opw:2302926 Forward-Port-Of: odoo/odoo#55138
Issue - Install "Point of Sale" module - Edit POS (e.g.: Shop) settings - Enable "Header & Footer" feature - Add a footer with multiple breaklines and save - Start a session with the current POS - Make an order Receipt footer not well formated Solution Add 'white-space:pre-line' style to avoid escaping breaklines; inspired on text-field css class. opw-2300889 Forward-Port-Of: odoo/odoo#55161 Forward-Port-Of: odoo/odoo#55061
Original PR description
Issue - Install "Point of Sale" module - Edit POS (e.g.: Shop) settings - Enable "Header & Footer" feature - Add a footer with multiple breaklines and save - Start a session with the current POS - Make an order Receipt footer not well formated Solution Add 'white-space:pre-line' style to avoid escaping breaklines; inspired on text-field css class. opw-2300889 Forward-Port-Of: odoo/odoo#55161 Forward-Port-Of: odoo/odoo#55061
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54834
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54834
opw-2305873 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55124 Forward-Port-Of: odoo/odoo#55088
Original PR description
opw-2305873 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55124 Forward-Port-Of: odoo/odoo#55088
task-2296856 See odoo/enterprise#12095 Forward-Port-Of: odoo/odoo#54653
Original PR description
task-2296856 See odoo/enterprise#12095 Forward-Port-Of: odoo/odoo#54653
By specifying the with_company at a higher level: 1) The risk of multi-company conflicts decreases 2) We allow customizations to use _prepare_* methods to potentially create records in other companies when needed. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54887
Original PR description
By specifying the with_company at a higher level: 1) The risk of multi-company conflicts decreases 2) We allow customizations to use _prepare_* methods to potentially create records in other companies when needed. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54887
Forward-Port-Of: odoo/odoo#55198 Forward-Port-Of: odoo/odoo#55125
Original PR description
Forward-Port-Of: odoo/odoo#55198 Forward-Port-Of: odoo/odoo#55125
Partial revert of bd61b6cd386ebeb9f8b375fff7ad430a2e4c39b5 Forward-Port-Of: odoo/odoo#55215
Original PR description
Partial revert of bd61b6cd386ebeb9f8b375fff7ad430a2e4c39b5 Forward-Port-Of: odoo/odoo#55215
Partial revert of bd61b6cd386ebeb9f8b375fff7ad430a2e4c39b5 Forward-Port-Of: odoo/odoo#55214
Original PR description
Partial revert of bd61b6cd386ebeb9f8b375fff7ad430a2e4c39b5 Forward-Port-Of: odoo/odoo#55214
In livechat, chat_post was called without notifying user has stopped typing as done in new way of handling it in new mail module. This commit handles the legacy by calling notify_typing rpc as needed. task-2282271 task-2299331 Forward-Port-Of: odoo/odoo#55205
Original PR description
In livechat, chat_post was called without notifying user has stopped typing as done in new way of handling it in new mail module. This commit handles the legacy by calling notify_typing rpc as needed. task-2282271 task-2299331 Forward-Port-Of: odoo/odoo#55205
Some errors occur when modules are uninstalled after unchecking some group in the settings. Excecute method should not be overriden in res.config.settings. TaskID: 2282427 Forward-Port-Of: odoo/enterprise#12106
Original PR description
Some errors occur when modules are uninstalled after unchecking some group in the settings. Excecute method should not be overriden in res.config.settings. TaskID: 2282427 Forward-Port-Of: odoo/enterprise#12106
Issue - Install "Sales" & "Subscription Management" modules - Create a quotation and add one Subscription Product - Confirm sale (ensure there is a subscription created) - Cancel the sale, set it to quotation and confirm again. - Check subcription Wrong quantity in subscription line. Cause If the sale order has an order line with the same data (product_id, uom_id & price_unit) as the related subscription line, it will append the quantity to this last one. Solution
Original PR description
Issue - Install "Sales" & "Subscription Management" modules - Create a quotation and add one Subscription Product - Confirm sale (ensure there is a subscription created) - Cancel the sale, set it to quotation and confirm again. - Check subcription Wrong quantity in subscription line. Cause If the sale order has an order line with the same data (product_id, uom_id & price_unit) as the related subscription line, it will append the quantity to this last one. Solution To avoid ambiguous case, if a sale order is cancelled and has subscriptions linked to it, prevent user to set quotation/sale to draft. Instead, must create a new quotation. opw-2302254 Forward-Port-Of: odoo/enterprise#12093
- type renamed to move_type in account.move - tests inherit from AccountTestInvoicingCommon - The last change introduce an error: since no iap.account exists, one is created under a new cursor which cannot fetch data created in AccountTestInvoicingCommon. Forward-Port-Of: odoo/enterprise#11947 Forward-Port-Of: odoo/enterprise#11874
Original PR description
- type renamed to move_type in account.move - tests inherit from AccountTestInvoicingCommon - The last change introduce an error: since no iap.account exists, one is created under a new cursor which cannot fetch data created in AccountTestInvoicingCommon. Forward-Port-Of: odoo/enterprise#11947 Forward-Port-Of: odoo/enterprise#11874
By specifying the with_company at a higher level: * The risk of multi-company conflicts decreases * We allow customizations to use `_prepare_*` methods to potentially create records in other companies when needed. E.g. to create invoices for subscriptions in other companies through the `_prepare_invoice` call. Enterprise counterpart of https://github.com/odoo/odoo/pull/54887 Forward-Port-Of: odoo/enterprise#11998
Original PR description
By specifying the with_company at a higher level: * The risk of multi-company conflicts decreases * We allow customizations to use `_prepare_*` methods to potentially create records in other companies when needed. E.g. to create invoices for subscriptions in other companies through the `_prepare_invoice` call. Enterprise counterpart of https://github.com/odoo/odoo/pull/54887 Forward-Port-Of: odoo/enterprise#11998
mail introduces message_type usage in the domain needed to filter messages displayed on a chatter. As documents module defines all models in tests data and do not define message_type field for mail.message, tests was failing when loading messages in chatter. task-2296856 see odoo/odoo#54653 Forward-Port-Of: odoo/enterprise#12095
Original PR description
mail introduces message_type usage in the domain needed to filter messages displayed on a chatter. As documents module defines all models in tests data and do not define message_type field for mail.message, tests was failing when loading messages in chatter. task-2296856 see odoo/odoo#54653 Forward-Port-Of: odoo/enterprise#12095