Monday, August 10, 2020
38 changes · master
Enhancements to existing features
When SMS records are copied, any existing error message will no longer be carried over to the new copy. This avoids confusing users with outdated failure information on duplicated SMS entries.
Original PR description
Error message should not be copied for obvious reason. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update strengthens accounting period controls by guiding users to resolve blocking items and limiting resequencing to authorized accounting roles. It also improves French FEC exports by adding a test export option and automatically locking the fiscal year when an official file is requested, supporting compliance and reducing mistakes.
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Canned replies in Mail now appear immediately but are not automatically selected, reducing accidental use. Users can choose replies more predictably with keyboard navigation or mouse clicks, and can still send a plain colon message when no canned reply is selected.
Original PR description
PURPOSE: - remove the active class from the canned response and delay, once the user presses the any key (tab, key down, and key up) then it should add active class for it's desired behavior and it…
PURPOSE:
- remove the active class from the canned response and delay, once the user presses the
any key (tab, key down, and key up) then it should add active
class for it's desired behavior and it should work like cancel.
user should send message if the message is : and none of canned response selected.
SPECIFICATION:
- Don't add focus on the 1st element for canned mention
- The user who wants to use the canned answer need to select it, using:
- TAB (start from the top of the list)
- Mouse click to select the one that he wants
- ARROW UP: Start from the last one on the popup
- ARROW DOWN: Start from the first one on the popup
- Dropdown selection should work like cycle
- Remove delay in displaying canned response
- send : as message in case of canned when there is no response is selected
- "shift + tab" to focus previous element in dropdown
- prevent re-rendering of dropdown process on keys like: shift, ctrl, alt, capslock.
LINKS:
PR https://github.com/odoo/odoo/pull/46825
Task 48686
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prUpdated the wording shown in CRM onboarding tours and first-use screens to make early setup steps clearer and more engaging. The sales upsell orders help text was also improved so users better understand how to use the view.
Original PR description
Terms improvement for the tour -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The translation list now shows which module each translation belongs to, making it easier for translators to understand where text comes from. This small usability improvement helps translators work more efficiently and reduces confusion when reviewing translations.
Original PR description
Description of the issue/feature this PR addresses: It is a little inconvenient as a translator not to see the module in translation tree... @qrtl -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Uruguay localization module description was updated to better explain what the module provides. This helps users and administrators more easily understand the module's purpose when reviewing or installing it.
Original PR description
Task: https://www.odoo.com/web#id=2316493&action=4043&model=project.task&view_type=form&cids=2&menu_id=4720
The Colombia localization app description and icon were refreshed to better represent the module in Odoo. This improves how the app appears to users when browsing or installing localization features, without changing business functionality.
Original PR description
Task: https://www.odoo.com/web#id=2316486&action=4043&model=project.task&view_type=form&cids=2&menu_id=4720
This update adds missing visual previews for several website editor options, making it easier for users to understand how changes will look before applying them. It improves the editing experience for website content, blog snippets, charts, and website forms without changing the published site behavior.
Original PR description
Add previews on some snippets options that don't have one. For the option transition of the tabs snippet I had to replace the css transition with css animation to activate the preview more easily. task-2280397 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The asset and deferred expense screens now use clearer labels and tooltips, making them easier for finance users to understand. The related purchases tab has also been simplified by renaming a date column and preventing new purchases from being created there, reducing accidental entries in the wrong place.
Original PR description
Inverse expense account & deferred exepense account label in deferred expense model tree view. Change some tooltips. Rename column depreciation date into date for related purchase tab in assets. Remove the possibility to create a purchase in purchase tab in assets. **Task ID: 2310293**
Resolved issues and error corrections
Clicking your own avatar now opens an OdooBot conversation instead of showing a dead-end warning. This gives users immediate guidance on how to start chats with other people and improves the avatar chat experience.
Original PR description
**PURPOSE** Currently, if a user clicks on its own m2o_avatar_user, he'll receive a notification letting him know that he can't chat with himself. so it will lead to the dead-end for the user what to do next. **SPEC** Instead of that, once any user clicks on their own avatar or odoobot then, we just pop out the odoobot chatbox and display message that Chat with any other user simply by clicking on his avatar. So user can chat with the odoobot and get the next steps or help from the odoobot. We have called one method called message_comment which is creating the mail.message record for the auther id of Odoobot and notify the user using bus mechanism. Task: 2280440
Miscellaneous changes
When switching to offline-mode, an "ReferenceError: requestCopy is not defined" error is thrown in `service-worker.js`. This commit fixes a variable left to its original name after extraction to the `matchCache` method (see commit odoo/odoo@f538a551b1463b36a728ee161a6c898252a2eb79 ). Forward-Port-Of: odoo/odoo#55657
Original PR description
When switching to offline-mode, an "ReferenceError: requestCopy is not defined" error is thrown in `service-worker.js`. This commit fixes a variable left to its original name after extraction to the `matchCache` method (see commit odoo/odoo@f538a551b1463b36a728ee161a6c898252a2eb79 ). Forward-Port-Of: odoo/odoo#55657
This update replaces an outdated internal action used in Argentine localization demo data. It prevents unnecessary warning messages in system logs, making demonstrations and testing cleaner without changing business workflows.
Original PR description
task 348
---
### Description of the issue/feature this PR addresses:
Change references of deprecated method in demo data to avoid WARNING message in
odoo log
### Current behavior before PR:
```sh
... WARNING ar py.warnings: ... DeprecationWarning: RedirectWarning method 'post()' is a deprecated alias
to 'action_post()' or _post() DeprecationWarning
```
### Desired behavior after PR is merged:
No error warning message
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prTax audit amounts now follow the same handling as tax reports for Point of Sale return transactions. This keeps financial audit details consistent with reported tax totals, reducing confusion during reconciliation and reporting.
Original PR description
https://github.com/odoo/enterprise/pull/12091 changed the way the tax report computes its totals wit account moves resulting for return operations in pos. This commit does the same on tax_audit field, so that it stays consistent with the report. X-original-commit: 67b3d70c8425dee17731e7b94bcb4797d4b06a97
The invoice form now displays Latin American document type and document number fields with their labels and proper spacing. This makes invoice details easier to read and reduces confusion during invoice entry or review.
Original PR description
task 349 --- ### Description of the issue/feature this PR addresses: Fix look and feel of invoice form view ### Current behavior before PR: The latam documents used for document type an document number are not showed correctly in the view, they displaying to close side by side and the related labels are not show.  ### Desired behavior after PR is merged: After this PR this has been fixed and now we have the labels and the proper separation of the fields in the invoice form view.  -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Documents onboarding guide has been repaired after a prior interface change caused it to stop working. This helps new users complete the guided introduction to Documents and related accounting document flows without getting stuck.
Original PR description
Currenttly, the documents onborading tour is broken because of data-id which is removed during searchpanel refactoring. So in this commit, Fix the onboarding tour and use eq for element selection instead of data-id and data-value-id as both are removed from searchpanel and there is other specific selector for particular element. TaskID: 2313883 Closes: #12318
The Argentina reports module has been fixed so it can be installed without errors. This resolves a setup issue related to the VAT report data view, helping affected businesses enable the module successfully.
Original PR description
Module was not installable due to the way we created the account_ar_vat_line view Task: 324
Point of Sale returns that do not create an invoice are now treated as refunds in tax reports. This prevents tax totals from being overstated and helps businesses report more accurate refund-related tax amounts.
Original PR description
Before that, the tax report did not apply a -1 multiplier on the total amount for those move lines (even though the refund tags were properly assigned). We fix that by introducing a hook function into account_reports, and overriding it in a new pos_account_reports module, so that those lines are properply detected as coming from a credit note. opw 2238358 X-original-commit: 1433f70b99a3653718117ce54f475012cbe37143
Following this commit: https://github.com/odoo/odoo/commit/72e4652983d9c781fd1da8acf3e4b5d7b9acbd4a Forgot to add this context. See opw-2272262 Forward-Port-Of: odoo/odoo#54236
Original PR description
Following this commit: https://github.com/odoo/odoo/commit/72e4652983d9c781fd1da8acf3e4b5d7b9acbd4a Forgot to add this context. See opw-2272262 Forward-Port-Of: odoo/odoo#54236
Create two expenses: - E1 with positive amount (i.e. 100) - E2 with negative amount (i.e. -10) While still in E2 form view, create the report, add as expense also E1. Submit the expense and proceed with the full flow including payment. Expense will be not marked as paid. This occur because the payment condition is detected with a check on the cash basis matched percentage which will not be accurate when negative amounts are involved. The percentage will be greater than 1, thus failin
Original PR description
Create two expenses: - E1 with positive amount (i.e. 100) - E2 with negative amount (i.e. -10) While still in E2 form view, create the report, add as expense also E1. Submit the expense and proceed with the full flow including payment. Expense will be not marked as paid. This occur because the payment condition is detected with a check on the cash basis matched percentage which will not be accurate when negative amounts are involved. The percentage will be greater than 1, thus failing the check, even if the expense was fully paid. Moreover the same issue apply when the payment is greater than the move amount, causing the check to fail because of the greater payment amount Modify the condition to detect just <1 percentages (not fully paid) fix the issue opw-2308203 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55566 Forward-Port-Of: odoo/odoo#55448
with an additonnal context The following commit https://github.com/odoo/odoo/commit/b3d9647695065ea582e4a6b0603f3ebf9fde6976 added the possibility to provide addtionnal context to RedirectWarningHandler. Unfortunately the RedirectWarning python function does not handle the new argument and crashes. This commit handle the addtionnal argument. taskid: 2286999 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#5
Original PR description
with an additonnal context The following commit https://github.com/odoo/odoo/commit/b3d9647695065ea582e4a6b0603f3ebf9fde6976 added the possibility to provide addtionnal context to RedirectWarningHandler. Unfortunately the RedirectWarning python function does not handle the new argument and crashes. This commit handle the addtionnal argument. taskid: 2286999 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53803
Before this commit, the "fields" object given to the control panel was altered by the view (e.g. dashboard populates it with its aggregates). As a result the control panel and its subcomponents had an altered object with more or less fields than expected. Now, the initial "fields" object is given to avoid such problems. Task [2312074](https://www.odoo.com/web#id=2312074&action=333&active_id=133&model=project.task&view_type=form&cids=1&menu_id=4720) Enterprise PR: https://github.com/odo
Original PR description
Before this commit, the "fields" object given to the control panel was altered by the view (e.g. dashboard populates it with its aggregates). As a result the control panel and its subcomponents had an altered object with more or less fields than expected. Now, the initial "fields" object is given to avoid such problems. Task [2312074](https://www.odoo.com/web#id=2312074&action=333&active_id=133&model=project.task&view_type=form&cids=1&menu_id=4720) Enterprise PR: https://github.com/odoo/enterprise/pull/12255 Forward-Port-Of: odoo/odoo#55536
Python 3 before 3.8 has a bug that causes the email.policy classes to incorrectly fold and RFC2047-encode "identification fields" in email messages. This mainly applies to Message-Id, References, and In-Reply-To fields. We are impacted by this bug since odoo/odoo#35929 where we switched to using the "modern" `email.message` API. RFC2047 section 5 clearly states that those headers/fields are not to be encoded, and that would violate RFC5322. Further, such a folded Message-Id is considere
Original PR description
Python 3 before 3.8 has a bug that causes the email.policy classes to incorrectly fold and RFC2047-encode "identification fields" in email messages. This mainly applies to Message-Id, References, and…
Python 3 before 3.8 has a bug that causes the email.policy classes to incorrectly fold and RFC2047-encode "identification fields" in email messages. This mainly applies to Message-Id, References, and In-Reply-To fields. We are impacted by this bug since odoo/odoo#35929 where we switched to using the "modern" `email.message` API. RFC2047 section 5 clearly states that those headers/fields are not to be encoded, and that would violate RFC5322. Further, such a folded Message-Id is considered non-RFC-conformant by popular MTAs (GMail, Outlook), which will then generate *another* Message-Id field, causing the original threading information to be lost. Replies to such a modified message will reference the new, unknown Message-Id, and won't be attached to the original thread. The solution we adopt here is to monkey-patch the SMTP policies to special-case those identification fields and deactivate the automatic folding, until the bug is properly and fully fixed in the standard lib. Some considerations taken into account for this patch: - `email.policy.SMTP` is being monkey-patched globally to make sure we fix all possible places where Messages are being encoded/folded - the fix is **not** made version-specific, considering that even in Python 3.8 the official bugfix only applies to Message-Id, but still fails to protect other identification fields, like *References* and *In-Reply-To*. The author specifically noted that shortcoming [2]. The fix wouldn't break anything on Python 3.8 anyway. - the `noFoldPolicy` trick for preventing folding is done with no max line length at all. RFC5322, section 2.1.1 states [3] that the maximum length is 998 due to legacy implementations, but there is no provision to wrap identification fields that are longer than that. Wrapping at 998 chars would corrupt the header anyway. We'll just count on the fact that we don't usually need 1k+ chars in those headers. The invalid folding/encoding in action on Python 3.6 (in Python 3.8 only the second header gets folded): ```py >>> msg = email.message.EmailMessage(policy=email.policy.SMTP) >>> msg['Message-Id'] = '<929227342217024.1596730490.324691772460938-example-30661-some.reference@test-123.example.com>' >>> msg['In-Reply-To'] = '<92922734221723.1596730568.324691772460444-another-30661-parent.reference@test-123.example.com>' >>> print(msg.as_string()) Message-Id: =?utf-8?q?=3C929227342217024=2E1596730490=2E324691772460938-exam?= =?utf-8?q?ple-30661-some=2Ereference=40test-123=2Eexample=2Ecom=3E?= In-Reply-To: =?utf-8?q?=3C92922734221723=2E1596730568=2E324691772460444-anot?= =?utf-8?q?her-30661-parent=2Ereference=40test-123=2Eexample=2Ecom=3E?= ``` and the expected result after the fix: ```py >>> msg = email.message.EmailMessage(policy=email.policy.SMTP) >>> msg['Message-Id'] = '<929227342217024.1596730490.324691772460938-example-30661-some.reference@test-123.example.com>' >>> msg['In-Reply-To'] = '<92922734221723.1596730568.324691772460444-another-30661-parent.reference@test-123.example.com>' >>> print(msg.as_string()) Message-Id: <929227342217024.1596730490.324691772460938-example-30661-some.reference@test-123.example.com> In-Reply-To: <92922734221723.1596730568.324691772460444-another-30661-parent.reference@test-123.example.com> ``` [1] bpo-35805: https://bugs.python.org/issue35805 [2] https://github.com/python/cpython/pull/13397#issuecomment-493618544 [3] https://tools.ietf.org/html/rfc5322#section-2.1.1 Forward-Port-Of: odoo/odoo#55655 Forward-Port-Of: odoo/odoo#55609
PURPOSE Archived/deleted users are still listed under the members of a channel. This means that those users could potentially still receive internal communications. In addition, as the list of members is not automatically updated, it does not reflect the current members of a given team. SPECIFICATIONS When a user is archived/deleted, remove him from the members of the channels he was part of. Task - 2276681 -- I confirm I have signed the CLA and read the PR guidelines at w
Original PR description
PURPOSE Archived/deleted users are still listed under the members of a channel. This means that those users could potentially still receive internal communications. In addition, as the list of members is not automatically updated, it does not reflect the current members of a given team. SPECIFICATIONS When a user is archived/deleted, remove him from the members of the channels he was part of. Task - 2276681 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#54371
…graph view before this commit, when change view from graph view to pivot view and come back to graph view, Measures button disappear. it's only appearing if we refresh the page after this commit, restore previous view state when switching back task - 2250051 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Po
Original PR description
…graph view before this commit, when change view from graph view to pivot view and come back to graph view, Measures button disappear. it's only appearing if we refresh the page after this commit, restore previous view state when switching back task - 2250051 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55635 Forward-Port-Of: odoo/odoo#51323
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55309
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55309
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55310
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55310
task-2314240 Forward-Port-Of: odoo/odoo#55618
Original PR description
task-2314240 Forward-Port-Of: odoo/odoo#55618
- focus feedback textarea on open - close popover on ESCAPE task-2250472 Forward-Port-Of: odoo/odoo#55141
Original PR description
- focus feedback textarea on open - close popover on ESCAPE task-2250472 Forward-Port-Of: odoo/odoo#55141
task 245 Forward-Port-Of: odoo/odoo#54923 Forward-Port-Of: odoo/odoo#50882
Original PR description
task 245 Forward-Port-Of: odoo/odoo#54923 Forward-Port-Of: odoo/odoo#50882
`action_generate_analytic_account()` iterates on the records in the recordset but used `self` in place of `vehicle` inside the loop, causing `ValueError: Expected singleton` errors. This will allow batch generation of accounts, e.g. for bootstrapping an existing fleet. Forward-Port-Of: odoo/odoo#55685
Original PR description
`action_generate_analytic_account()` iterates on the records in the recordset but used `self` in place of `vehicle` inside the loop, causing `ValueError: Expected singleton` errors. This will allow batch generation of accounts, e.g. for bootstrapping an existing fleet. Forward-Port-Of: odoo/odoo#55685
need to be merge with https://github.com/odoo/odoo/pull/50882 Forward-Port-Of: odoo/enterprise#12021 Forward-Port-Of: odoo/enterprise#10450
Original PR description
need to be merge with https://github.com/odoo/odoo/pull/50882 Forward-Port-Of: odoo/enterprise#12021 Forward-Port-Of: odoo/enterprise#10450
Steps to reproduce: - Make a quotation with a referrer and with a commission > 0 - Confirm and invoice - As customer, pay invoice from the portal Bug: - The customer is following the generated commission purchase order Fix: - Use superuser to create the purchase order Reason: Customers should not be notified about the commissions their integrators earn. Forward-Port-Of: odoo/enterprise#12136
Original PR description
Steps to reproduce: - Make a quotation with a referrer and with a commission > 0 - Confirm and invoice - As customer, pay invoice from the portal Bug: - The customer is following the generated commission purchase order Fix: - Use superuser to create the purchase order Reason: Customers should not be notified about the commissions their integrators earn. Forward-Port-Of: odoo/enterprise#12136
Pager has been coded in owl. So the code using the pager in MPS has to be adapted. Forward-Port-Of: odoo/enterprise#12300 Forward-Port-Of: odoo/enterprise#12290
Original PR description
Pager has been coded in owl. So the code using the pager in MPS has to be adapted. Forward-Port-Of: odoo/enterprise#12300 Forward-Port-Of: odoo/enterprise#12290
l10n_co_edi: The vat number has been done in the proper format The account_id field has been removed from account.move l10n_mx_edi: The partner bank is created with account number 123456789 is created in account test common here https://github.com/odoo/odoo/blob/master/addons/account/tests/common.py#L228 also partner bank is created with same account number 123456789 in l10n_mx_edit test common so change that number to 123456798 so duplication error does not occur in account.move
Original PR description
l10n_co_edi: The vat number has been done in the proper format The account_id field has been removed from account.move l10n_mx_edi: The partner bank is created with account number 123456789 is created in account test common here https://github.com/odoo/odoo/blob/master/addons/account/tests/common.py#L228 also partner bank is created with same account number 123456789 in l10n_mx_edit test common so change that number to 123456798 so duplication error does not occur in account.move type field is renamed with move_type l10n_mx_edi_landing: button_validate instead of action_done Manual Forward-Port-Of: #11025 Forward-Port-Of: odoo/enterprise#12257
task 331 Forward-Port-Of: odoo/enterprise#12048
Original PR description
task 331 Forward-Port-Of: odoo/enterprise#12048
With l10n_mx accounting set up Enable and setup cash rounding for POS Open POS, add an item that will be rounded, checkout and create the invoice An error will raise on the invoice because cash rounding in POS add an invoice line without product. This is not well handled by the accounting module when generating the xml to send for synchronization (PAC/SAT status) "The cfdi generated is not valid" A solution is to hardcode default values that will be used for the rounding line 01
Original PR description
With l10n_mx accounting set up Enable and setup cash rounding for POS Open POS, add an item that will be rounded, checkout and create the invoice An error will raise on the invoice because cash rounding in POS add an invoice line without product. This is not well handled by the accounting module when generating the xml to send for synchronization (PAC/SAT status) "The cfdi generated is not valid" A solution is to hardcode default values that will be used for the rounding line 01010101 is the sat product code for 'No existe en el catálogo' H87 is the sat uom code for 'Pieza' opw-2301498 Forward-Port-Of: odoo/enterprise#12192 Forward-Port-Of: odoo/enterprise#12138
Before this commit, the "fields" object given to the control panel was altered by the view (e.g. dashboard populates it with its aggregates). As a result the control panel and its subcomponents had an altered object with more or less fields than expected. Now, the initial "fields" object is given to avoid such problems. Task [2312074](https://www.odoo.com/web#id=2312074&action=333&active_id=133&model=project.task&view_type=form&cids=1&menu_id=4720) Community PR: https://github.com/odoo
Original PR description
Before this commit, the "fields" object given to the control panel was altered by the view (e.g. dashboard populates it with its aggregates). As a result the control panel and its subcomponents had an altered object with more or less fields than expected. Now, the initial "fields" object is given to avoid such problems. Task [2312074](https://www.odoo.com/web#id=2312074&action=333&active_id=133&model=project.task&view_type=form&cids=1&menu_id=4720) Community PR: https://github.com/odoo/odoo/pull/55536 Forward-Port-Of: odoo/enterprise#12255
Have an Employee with a contract end date day less than the start date day ex (start on 18/02/20, end on 08/04/20) Reach the report Employees>Reporting>Contracts The "Departure Employee" column should show a "1" for each employee that have an active contract anymore. This occur because we check the termination against a sequence with 'month' stepping that will halt too soon when such condition is met. Selectively adding an extra month fix the issue opw-2272291 Forward-Port-Of: od
Original PR description
Have an Employee with a contract end date day less than the start date day ex (start on 18/02/20, end on 08/04/20) Reach the report Employees>Reporting>Contracts The "Departure Employee" column should show a "1" for each employee that have an active contract anymore. This occur because we check the termination against a sequence with 'month' stepping that will halt too soon when such condition is met. Selectively adding an extra month fix the issue opw-2272291 Forward-Port-Of: odoo/enterprise#12184