Tuesday, August 25, 2020
40 changes · master
Enhancements to existing features
Event website visitors now see a dedicated offline page when their connection is lost or cached content cannot be used. This improves the experience for attendees by clearly handling connectivity issues and automatically refreshing content once the connection returns.
Original PR description
This page will be used in case of lost connection. The web page will be automatically fetched when you are back online. We also use this page when it's not possible to use the cache due to a redirection. X-original-commit: a7c5cadc7467bd2c2423cd3e803cad3677961521
The IoT app now uses a clearer and more consistent name for device display links, while removing an unused box field. This reduces internal clutter and helps keep future IoT setup and maintenance simpler without changing the user workflow.
Original PR description
Remove unused screen_url field from iot.box and rename screen_url to display_url for consistency. TaskID: 1973956
Resolved issues and error corrections
The administrator setting for access to private addresses is now only shown in debug mode. This keeps a technical permission out of regular user setup screens, reducing confusion for everyday administrators.
Original PR description
Currently, the access to private addresses group show in the non debug mode and debug mode So in this commit, the access to private addresses group only show in the debug mode. LINKS PR: #56456 Task-Id: 2318509 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
- Go to Inventory > Master Data > Products and create a Product with Tracking "By Lot" - Go to Inventory > Configuration > Operation Types - Edit Receipts: * Activate "Show Detailed Operations" * Activate "Create New Lots/Serial Numbers" * Deactivate "Use Existing Lots/Serial Numbers" - Go to Inventory > Overview and open Receipts - Create a Receipt operation In the Detailed Operations tab, if a Product tracked by lot is added, an existing lot can be selected although it is disabl
Original PR description
- Go to Inventory > Master Data > Products and create a Product with Tracking "By Lot" - Go to Inventory > Configuration > Operation Types - Edit Receipts: * Activate "Show Detailed Operations" *…
- Go to Inventory > Master Data > Products and create a Product with Tracking "By Lot" - Go to Inventory > Configuration > Operation Types - Edit Receipts: * Activate "Show Detailed Operations" * Activate "Create New Lots/Serial Numbers" * Deactivate "Use Existing Lots/Serial Numbers" - Go to Inventory > Overview and open Receipts - Create a Receipt operation In the Detailed Operations tab, if a Product tracked by lot is added, an existing lot can be selected although it is disabled in Operation configuration. Once saved, the selected lot disappears. "Lot/Serial Number" column is replaced by "Lot/Serial Number Name" column. A lot name can be entered manually. (It will create the lot at the validation) But after validation, the lot associated to the Product is the existing lot that has been selected during the operation creation, not the one that should have been created from the lot name entered manually. opw-2323093 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56302
The Calendar month view now shows each event's time and title on one line, with the time first and longer titles shortened as needed. This makes busy calendars easier to scan without changing how events work.
Original PR description
When visiting the Month view of the Calendar App, events titles and time will be displayed inline, showing first the time of the event and then, the event title, truncated when needed, at the right of the container. Task 2200233 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change prevents manufacturing stock moves from incorrectly losing their unit factor during inventory posting. It helps ensure reserved quantities remain accurate when production moves are split and validated, reducing the risk of incorrect manufacturing inventory updates.
Original PR description
This reverts commit 96b17a82cf1ea1287e0a52c52c78166ef817ce7b. The issue appears at post inventory. As the reservation on the stock_move is updated (because the move are split to set some quantity done), The reserved quantity on quant are so. This is done via a savepoint. The savepoint will flush the current snapshot. This flush will recompute all the computed field. This is the unwanted behavior because all the stock move ready to be validated will have their unit factor set to 0. This commit is not exactly the original revert because of the flexible consumption feature (896352e53b77df2f42de39c0fed897d10ae947b0) Task : 2212001 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The user access setting for the allocated time percentage Gantt view has been moved to the correct category. This makes the option appear in the expected place when managing user permissions, reducing confusion for administrators.
Original PR description
Currently, the administration access rights are under the technical groups that are only visible in debug mode Steps to reproduce: Go to Settings > Users So in this commit, the allocated time percentage Gantt group shows under the extra rights that are only visible in debug mode. LINKS PR: #12637 Task-Id: 2318509
The printed status should not be kept when duplicating a picking. opw-2320680 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56416 Forward-Port-Of: odoo/odoo#56398
Original PR description
The printed status should not be kept when duplicating a picking. opw-2320680 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56416 Forward-Port-Of: odoo/odoo#56398
`device_name` and `scanner_name` were defined outside of the scope of the function where they were used in. We move them and try to simplify the logic a bit. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56399
Original PR description
`device_name` and `scanner_name` were defined outside of the scope of the function where they were used in. We move them and try to simplify the logic a bit. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56399
**PURPOSE** In o_colorpicker popup, "Hide in Kanban" checkbox label is not aligned with the checkbox. **SPEC** we have aligned the label by giving top 3px of padding. Task : 2277254 Forward-Port-Of: odoo/odoo#53003
Original PR description
**PURPOSE** In o_colorpicker popup, "Hide in Kanban" checkbox label is not aligned with the checkbox. **SPEC** we have aligned the label by giving top 3px of padding. Task : 2277254 Forward-Port-Of: odoo/odoo#53003
This commit reverts 0c075552f70381872d177f900ed00fbfab39be0e Task [2306265](https://www.odoo.com/web#id=2306265&action=333&active_id=967&model=project.task&view_type=form&cids=1&menu_id=4720) This had the side effect of blocking the group by label in the Journal Entry list view. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55046
Original PR description
This commit reverts 0c075552f70381872d177f900ed00fbfab39be0e Task [2306265](https://www.odoo.com/web#id=2306265&action=333&active_id=967&model=project.task&view_type=form&cids=1&menu_id=4720) This had the side effect of blocking the group by label in the Journal Entry list view. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55046
On instances with a lot of coupons programs, performance issue arise while using eccommerce (adding item in basket ant opening it in particular). In the client case, he have ~2000 of them. Opening the basket with 1 product take: Before this commit: ~10s After this commit: ~2s ( pyflame is available in the ticket attachment ) `_get_valid_products` use the v13 `filtered_domain` method Average execution time: Before change: 0.001 s After change: 0.0001 s => 10x times gained
Original PR description
On instances with a lot of coupons programs, performance issue arise while using eccommerce (adding item in basket ant opening it in particular). In the client case, he have ~2000 of them. Opening the basket with 1 product take: Before this commit: ~10s After this commit: ~2s ( pyflame is available in the ticket attachment ) `_get_valid_products` use the v13 `filtered_domain` method Average execution time: Before change: 0.001 s After change: 0.0001 s => 10x times gained The average execution time of `_is_valid_product` is 0.002 s (20 times slower than `_get_valid_products` for the same result). => All use of `_is_valid_product` were replaced by `_get_valid_products` OPW-2323599 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56424 Forward-Port-Of: odoo/odoo#56324
This commit makes use of _origin.id instead of .id into mrp.workorder.name_get(). name_get() can be called from a compute method (via _plan_workorders) which implies virtual ids. Searching amongst real ids with a virtual one was not possible back then. Task : 2278147 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr F
Original PR description
This commit makes use of _origin.id instead of .id into mrp.workorder.name_get(). name_get() can be called from a compute method (via _plan_workorders) which implies virtual ids. Searching amongst real ids with a virtual one was not possible back then. Task : 2278147 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55879
task-2321970 Forward-Port-Of: odoo/odoo#56076
Original PR description
task-2321970 Forward-Port-Of: odoo/odoo#56076
task-2323230 Forward-Port-Of: odoo/odoo#56227
Original PR description
task-2323230 Forward-Port-Of: odoo/odoo#56227
ir_sequence is currently broken when trying to view the list of sequences (if there are any in the system) and when trying to create one: During the sql-thingie, I prepared the `params` local to differentiate the params to provide in both cases of a conditional, then promptly forgot to do that, so no parameter is provided when one is needed, which breaks... on every pg >= 10 (which at this point is probably all of them). Correct this error. Furthermore, the "computes are onchange"
Original PR description
ir_sequence is currently broken when trying to view the list of sequences (if there are any in the system) and when trying to create one: During the sql-thingie, I prepared the `params` local to differentiate the params to provide in both cases of a conditional, then promptly forgot to do that, so no parameter is provided when one is needed, which breaks... on every pg >= 10 (which at this point is probably all of them). Correct this error. Furthermore, the "computes are onchange" was not impacted on `_get_number_next_actual`. On creation, this leads to trying to format a NewId as a number. If that is just defaulted, we will then try and `_predict_nextval` for a sequence which doesn't exist in the database. Just yield `0` if the sequence hasn't been created yet. Reported-By: @youring Forward-Port-Of: odoo/odoo#56397
The Wysiwyg editor put `<p><br></p>` even without a note on the activity. To reduce the size in the UI, We compute the note to replace these almost empty note by an actual empty value. task-2282324 Forward-Port-Of: odoo/odoo#55564
Original PR description
The Wysiwyg editor put `<p><br></p>` even without a note on the activity. To reduce the size in the UI, We compute the note to replace these almost empty note by an actual empty value. task-2282324 Forward-Port-Of: odoo/odoo#55564
The POS showed an error message even when the print succeeded because `send_printing_job` didn't have any return value so it was considered falsy. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56463
Original PR description
The POS showed an error message even when the print succeeded because `send_printing_job` didn't have any return value so it was considered falsy. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56463
task-2282385 ---- # Forward-Port-Of: odoo/odoo#55553
Original PR description
task-2282385 ---- # Forward-Port-Of: odoo/odoo#55553
The new randomly occurring runbot errors in pos/* can be reproduced by performing quick successive clicks in numpad widget with the following form: 1. Press 'Price' button. 2. A number input. 3. Press 'Qty' button. 4. A number input. The goal of the above steps is to set the price of the selected orderline followed by setting the quantity. The result however is that the price isn't changed but the quantity is changed to combined digits of the price and quantity input
Original PR description
The new randomly occurring runbot errors in pos/* can be reproduced by performing quick successive clicks in numpad widget with the following form: 1. Press 'Price' button. 2. A number input. 3.…
The new randomly occurring runbot errors in pos/* can be reproduced by
performing quick successive clicks in numpad widget with the following form:
1. Press 'Price' button.
2. A number input.
3. Press 'Qty' button.
4. A number input.
The goal of the above steps is to set the price of the selected orderline
followed by setting the quantity. The result however is that the price
isn't changed but the quantity is changed to combined digits of the price
and quantity inputs. This is due to the implementation of the `NumberBuffer`
singleton which is used to abstract and take into account different sources of
user inputs -- via numpad widget, keyboard and barcode scanner.
Barcode scanner performs fast successive keyboard presses. To differentiate it
from normal keyboard input, we used `eventsBuffer` field of `NumberBuffer`
and store keyboard events there. Fast keyboard presses that stores more than
2 in the events are neglected by the buffer and is considered a barcode input.
In this commit, we save the `handler` that handles the keyboard events saved
in the `eventsBuffer`, then instead of only letting it to be invoked by the
setTimeout object, we allow the manual invoking of `handler` using the introduced
`capture` method. This method is called when the numpad mode is changed
(pressing Price, Discount or Qty button).
Additionally, we remove the use of 'useState' to prevent unnecessary rerender
of the component that uses the `NumberBuffer`.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#56464The Six TIM API considers all round amounts to be in minor units while decimal amounts are considered actual amounts. In #odoo/odoo@df01c71, we changed all payments to minor units, but we still had problems with floating point precision. E.g. Starting a payment of 4.60€ was converted to 460 in minor units but due to floating point precision, the actual amount sent to TIM was 460.00000000005. The terminal then started a payment of 460€ instead of 4.60€. -- I confirm I have sign
Original PR description
The Six TIM API considers all round amounts to be in minor units while decimal amounts are considered actual amounts. In #odoo/odoo@df01c71, we changed all payments to minor units, but we still had problems with floating point precision. E.g. Starting a payment of 4.60€ was converted to 460 in minor units but due to floating point precision, the actual amount sent to TIM was 460.00000000005. The terminal then started a payment of 460€ instead of 4.60€. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56459
- Split driver.py to multiple files - Remove hw_proxy module as most of its routes were not used and move remaining routes to a controller in hw_drivers - Add missing coding and license lines at the beginning of files - Reorder imports and remove unused ones - Rename device_id to device_identifier for clarity - Rename screen to display for consistency - Other minors improvements TaskID: 1973956 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/subm
Original PR description
- Split driver.py to multiple files - Remove hw_proxy module as most of its routes were not used and move remaining routes to a controller in hw_drivers - Add missing coding and license lines at the beginning of files - Reorder imports and remove unused ones - Rename device_id to device_identifier for clarity - Rename screen to display for consistency - Other minors improvements TaskID: 1973956 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#51528
Steps to reproduce Enable optional products in sale order Make a sale order with optional products for a portal customer with taxcloud fiscal position. Validate the order. Tax will be calculated on the sol. Access the sale order as the portal user. Add the optional product, verify the order and pay. The optional product will get the taxcloud data AFTER the order has been verified and possibly paid. As this should not occur this add the override to calculate taxcloud data right aft
Original PR description
Steps to reproduce Enable optional products in sale order Make a sale order with optional products for a portal customer with taxcloud fiscal position. Validate the order. Tax will be calculated on the sol. Access the sale order as the portal user. Add the optional product, verify the order and pay. The optional product will get the taxcloud data AFTER the order has been verified and possibly paid. As this should not occur this add the override to calculate taxcloud data right after adding the optional product opw-2310614 Co-authored-by: agr-odoo <agr@odoo.com> Forward-Port-Of: odoo/odoo#56083 Forward-Port-Of: odoo/odoo#56037
This is unfortunately replacing old hacks by new ones but using SCSS variables for this is more consistent with the rest of our website customization possibilities. The hack here is for the UI which is controlling two SCSS variables at the same time (body-image and body-image-type). This has to be improved. Forward-Port-Of: odoo/odoo#56420
Original PR description
This is unfortunately replacing old hacks by new ones but using SCSS variables for this is more consistent with the rest of our website customization possibilities. The hack here is for the UI which is controlling two SCSS variables at the same time (body-image and body-image-type). This has to be improved. Forward-Port-Of: odoo/odoo#56420
when user create a report using basic layout and at download time, it gives warning that the template doesn't contain the attributes 'data-oe-model' and 'data-oe-id' on the div with the 'article class name so this issue is fixed in this commit. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53855
Original PR description
when user create a report using basic layout and at download time, it gives warning that the template doesn't contain the attributes 'data-oe-model' and 'data-oe-id' on the div with the 'article class name so this issue is fixed in this commit. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#53855
before this commit, on adding fields from the dropdown, dropdown change its actual position this commit fixes the issue by appending div after the last header of the table. so the dropdown should always be correctly positioned on the right side of the list, just below the dropdown icon (toggler). task 2307248 Forward-Port-Of: odoo/odoo#56490 Forward-Port-Of: odoo/odoo#55263
Original PR description
before this commit, on adding fields from the dropdown, dropdown change its actual position this commit fixes the issue by appending div after the last header of the table. so the dropdown should always be correctly positioned on the right side of the list, just below the dropdown icon (toggler). task 2307248 Forward-Port-Of: odoo/odoo#56490 Forward-Port-Of: odoo/odoo#55263
PURPOSE Do not resize quick create form in kanban column on window resize SPEC Function '_applyFormSizeClass' should be overriden in QuickCreateFormRenderer to do nothing. TASK 2317807 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55841
Original PR description
PURPOSE Do not resize quick create form in kanban column on window resize SPEC Function '_applyFormSizeClass' should be overriden in QuickCreateFormRenderer to do nothing. TASK 2317807 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55841
This PR attempts to enable multi-edit option on crm tree views to make some fields editable in batch mode. Editable fields : - Contact (res.partner) : base.view_partner_tree phone email company_id city state_id country_id category_id date_review_next grade_id user_id (set if from invisible to optional default hidden - Opportunities (crm.lead) : crm.crm_case_tree_view_oppo partner_id email_from phone city state_id
Original PR description
This PR attempts to enable multi-edit option on crm tree views to make some fields editable in batch mode. Editable fields : - Contact (res.partner) : base.view_partner_tree phone email company_id…
This PR attempts to enable multi-edit option on crm tree views to make some fields editable in batch mode.
Editable fields :
- Contact (res.partner) : base.view_partner_tree
phone
email
company_id
city
state_id
country_id
category_id
date_review_next
grade_id
user_id (set if from invisible to optional default hidden
- Opportunities (crm.lead) : crm.crm_case_tree_view_oppo
partner_id
email_from
phone
city
state_id
country_id
stage_id
probability
partner_assigned_id
user_id
team_id
planned_revenue
company_id
campaign_id
medium_id
source_id
tag_ids
priority
- Opportunities (crm.lead) : crm.crm_case_tree_view_leads
contact_name
partner_name
email_from
phone
city
state_id
country_id
partner_assigned_id
user_id
team_id
company_id
probability
campaign_id
medium_id
source_id
tag_ids
priority
- Sales Teams (crm.team) : crm.team.tree
user_id
company_id
- Activity Types (mail.activity.type) : mail.mail_activity_type_view_tree
summary
delay_count
delay_unit
delay_from
- Stages (crm.stage) View : crm.crm_stage_tree
is_won
team_id
In this PR, the following changes have been made :
1- Add multi-edit attribute on tree views to make targeted fields editable.
2- Add readonly attribute on : [other fields + onchange-based fields].
3- Add domain on user_id fields to prevent selecting portal users as Salesperson/Team leader from list views.
This update was made taking in consideration :
- "multi-edit" mode will be added to all modules using these views. (non onchange-based fields will be editable on base res.partner view & all views inheriting from it or using its action in other modules)
- Some fields can't be multi-editable (for now) because they're part of an onchange :
1- in base/res.partner:
- parent_id
- country_id
- state_id
- company_id
IMPORTANT :
- In crm.lead, onchange is only used to get formatted phone numbers when their values changed or when country_id & company_id updated. this behaviour will only work in from views.
- multi-edit option enabled on email field (in base/res.partner) since onchange is used to get gravatar from email field value.
task-2200674
Forward-Port-Of: odoo/odoo#56378task-2280172 ---- # Forward-Port-Of: odoo/odoo#55576
Original PR description
task-2280172 ---- # Forward-Port-Of: odoo/odoo#55576
The commit [1] bypassed the query if self was empty, but it makes sense to do the query if `all_partners` is `True` (for search on status and for the cron) [1] https://github.com/odoo/enterprise/commit/5129b0369cdf375934337d82a3ae48c01a572f32 Forward-Port-Of: odoo/enterprise#12653
Original PR description
The commit [1] bypassed the query if self was empty, but it makes sense to do the query if `all_partners` is `True` (for search on status and for the cron) [1] https://github.com/odoo/enterprise/commit/5129b0369cdf375934337d82a3ae48c01a572f32 Forward-Port-Of: odoo/enterprise#12653
SPECIFICATION New 'barchart_total' boolean attribute on grid view (default=false) When barchart_total=true, the footer is displayed as a barchart, similarly to what option 'total_row' currently does in the Gantt view task-2261846 Forward-Port-Of: odoo/enterprise#12217
Original PR description
SPECIFICATION New 'barchart_total' boolean attribute on grid view (default=false) When barchart_total=true, the footer is displayed as a barchart, similarly to what option 'total_row' currently does in the Gantt view task-2261846 Forward-Port-Of: odoo/enterprise#12217
No app can add things in footer templates otherwise they would break their full-edition. Also since they are many templates, xpathing only one does not make sense. Note: this should ideally be done in stable... Forward-Port-Of: odoo/enterprise#12615
Original PR description
No app can add things in footer templates otherwise they would break their full-edition. Also since they are many templates, xpathing only one does not make sense. Note: this should ideally be done in stable... Forward-Port-Of: odoo/enterprise#12615
when user create a report using basic layout through web studio and at download time, it gives warning that the template doesn't contain the attributes 'data-oe-model' and 'data-oe-id' on the div with the 'article class name so this issue is fixed in this commit. Forward-Port-Of: odoo/enterprise#11540
Original PR description
when user create a report using basic layout through web studio and at download time, it gives warning that the template doesn't contain the attributes 'data-oe-model' and 'data-oe-id' on the div with the 'article class name so this issue is fixed in this commit. Forward-Port-Of: odoo/enterprise#11540
- Split iot.js into different files per widget - driver.py has been split in different files in Community PR, so we change the import paths. - Extract IrActionReport and PublisherWarrantyContract from iot.py - Remove iot.css as the only style defined is not used. - Remove `screen_url` from the IoT Box as it's defined on the device now. - Move assets to separate files - Add ondelete='cascade' to iot_id in iot.device - In IoTLongpolling, Rename device_id to device_identifier for clari
Original PR description
- Split iot.js into different files per widget - driver.py has been split in different files in Community PR, so we change the import paths. - Extract IrActionReport and PublisherWarrantyContract…
- Split iot.js into different files per widget - driver.py has been split in different files in Community PR, so we change the import paths. - Extract IrActionReport and PublisherWarrantyContract from iot.py - Remove iot.css as the only style defined is not used. - Remove `screen_url` from the IoT Box as it's defined on the device now. - Move assets to separate files - Add ondelete='cascade' to iot_id in iot.device - In IoTLongpolling, Rename device_id to device_identifier for clarity - Rename `iot_wizard.xml` to `add_iot_box_views.xml` - Remove unused classes from pos_iot/**/pos.css - Rename `Iot` to `IoT` in JS Widgets names for consistency. Both existed but we never knew which one to use. - Add Missing lines add the end of files - Add missing coding and license lines at the beginning of files. - Order imports alphabetically and delete unused ones. - Rewrite names, summaries et descriptions in manifest files. - Rename 'screen' to 'display' for consistency TaskID: 1973956 Forward-Port-Of: odoo/enterprise#10660
Forward-Port-Of: odoo/enterprise#12392
Original PR description
Forward-Port-Of: odoo/enterprise#12392
Task [2306265](https://www.odoo.com/web#id=2306265&action=333&active_id=967&model=project.task&view_type=form&cids=1&menu_id=4720) Forward-Port-Of: odoo/enterprise#12066
Original PR description
Task [2306265](https://www.odoo.com/web#id=2306265&action=333&active_id=967&model=project.task&view_type=form&cids=1&menu_id=4720) Forward-Port-Of: odoo/enterprise#12066
<b>Purpose:</b> In the report editor, saved as an attachment doesn't do anything so to solve this issue by set attachment field on 'ir.action.report.record' through the report controller when we marked as 'reload from attachment in the studio. task- 2283928 Forward-Port-Of: odoo/enterprise#11526
Original PR description
<b>Purpose:</b> In the report editor, saved as an attachment doesn't do anything so to solve this issue by set attachment field on 'ir.action.report.record' through the report controller when we marked as 'reload from attachment in the studio. task- 2283928 Forward-Port-Of: odoo/enterprise#11526
There are cases in which it is not necessary to add the addenda node so the node should be empty. eg: Fresko (out_refund invoices) To support this case, an `if` statement is added in the addenda template, which allows us to only render the addenda if the invoice is "out_invoice"  Currently this causes an error since this case is not supported by the module.  To support this case, an `if` statement is added in the addenda template, which allows us to only render the addenda if the invoice is "out_invoice"  Currently this causes an error since this case is not supported by the module.  To avoid this error, this change is added, where it is ensured to obtain some value in the addenda node before trying to add it to the CFDI. Forward-Port-Of: odoo/enterprise#12619 Forward-Port-Of: odoo/enterprise#12129
Steps to reproduce Enable optional products in sale order Make a sale order with optional products for a portal customer with taxcloud fiscal position. Validate the order. Tax will be calculated on the sol. Access the sale order as the portal user. Add the optional product, verify the order and pay. The optional product will get the taxcloud data AFTER the order has been verified and possibly paid. As this should not occur this add the override
Original PR description
Steps to reproduce
Enable optional products in sale order
Make a sale order with optional products for a portal customer
with taxcloud fiscal position. Validate the order.
Tax will be calculated on the sol.
Access the sale order as the portal user.
Add the optional product, verify the order and pay.
The optional product will get the taxcloud data
AFTER the order has been verified and possibly paid. As this should not
occur this add the override to calculate taxcloud data right after
adding the optional product
opw-2310614
Co-authored-by: agr-odoo <agr@odoo.com>
Forward-Port-Of: odoo/enterprise#12499
Forward-Port-Of: odoo/enterprise#12474As stated by the customer, it's not displayed that the two reminders (employee & manager) are company specific. Let's make sure that it will be now. The commit are adding the building icon company-specific and tooltip "Values set here are company-specific" opw-2279681 Forward-Port-Of: odoo/enterprise#12449
Original PR description
As stated by the customer, it's not displayed that the two reminders (employee & manager) are company specific. Let's make sure that it will be now. The commit are adding the building icon company-specific and tooltip "Values set here are company-specific" opw-2279681 Forward-Port-Of: odoo/enterprise#12449