Thursday, September 3, 2020
30 changes · master
Enhancements to existing features
This update makes it easier for developers to adapt how invoices are created from Point of Sale orders. Businesses benefit from more flexible customization options with minimal direct impact on day-to-day users.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Expense app now shows updated helper messages in several reporting and approval menus. This makes it easier for users to understand what each expense report view is for and what actions they can take there.
Original PR description
The helper message has been changed in the following menus: -My reports -Expense Reports To Approve -All Expense Reports -Expenses Analysis Task-2320205 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
On mobile screens, the bottom control area no longer takes up space when it has no content. This gives users more usable screen space and avoids awkward empty gaps in the interface.
Original PR description
PURPOSE purpose of this task when o_cp_bottom class is not filled, it should not take place in mobile. LINKS PR: #57008 Task-2319534 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The timesheet grid now gives managers a clearer view of how many hours employees have recorded per task. This makes it easier to review workload and time tracking directly from the grid without opening extra details.
Adds a visual weekly hours indicator in the timesheet grid so managers can quickly see whether employees have logged enough time for the selected period. The indicator highlights missing hours in red for past periods and stays muted when hours are complete or not yet due.
This update improves helper messages shown in Helpdesk and Expense analysis screens, making guidance clearer when there is no data to display. It also adjusts the related empty-list behavior so the updated messages appear correctly.
Resolved issues and error corrections
Odoobot-related user interface settings were adjusted so the assistant is handled within the Mail area. This keeps messaging behavior organized in the right place and helps avoid configuration issues for users.
Original PR description
task-2282334
Miscellaneous changes
- Go to Contacts > Configuration > Country Group - Open Europe United Kingdom is still in the group, but should not. opw-2328125 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56963 Forward-Port-Of: odoo/odoo#56922
Original PR description
- Go to Contacts > Configuration > Country Group - Open Europe United Kingdom is still in the group, but should not. opw-2328125 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56963 Forward-Port-Of: odoo/odoo#56922
This commit fixes the reminder button classes to enable/disable the right ones as it's being clicked. (We also fix a css rule for event colors). Task ID 2325327 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56523 Forward-Port-Of: odoo/odoo#56515
Original PR description
This commit fixes the reminder button classes to enable/disable the right ones as it's being clicked. (We also fix a css rule for event colors). Task ID 2325327 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56523 Forward-Port-Of: odoo/odoo#56515
Before this commit, the end users were unable to click on the kanban image to see document's preview. To fix this we removed lines from a previous fix which is no longer useful in 13.0 because we now use kanban views for many2X fields instead of list views. See original commit: https://github.com/odoo/odoo/commit/26c62cbb4401bffb72ce77fee481ca84b77a8143 So for mobile phones it's working fine. For iPads, this rule is no longuer necessary since iPadOS. See "Accelerated Scrolling on iO
Original PR description
Before this commit, the end users were unable to click on the kanban image to see document's preview. To fix this we removed lines from a previous fix which is no longer useful in 13.0 because we now…
Before this commit, the end users were unable to click on the kanban image to see document's preview. To fix this we removed lines from a previous fix which is no longer useful in 13.0 because we now use kanban views for many2X fields instead of list views. See original commit: https://github.com/odoo/odoo/commit/26c62cbb4401bffb72ce77fee481ca84b77a8143 So for mobile phones it's working fine. For iPads, this rule is no longuer necessary since iPadOS. See "Accelerated Scrolling on iOS and iPadOS": https://webkit.org/blog/9674/new-webkit-features-in-safari-13/ For previous versions it still works because the DOM has changed. Steps to reproduce: - Go to Document - Click on "o_kanban_image" => Your're stuck on a grayed page. opw-2260101 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56901 Forward-Port-Of: odoo/odoo#56894
PURPOSE Clean view definitions and coherency SPECIFICATIONS Remove dead code and files. Remove duplicate fields in tree views Remove duplicate field in kanban views, especially when dealing with preface / templates sections. Enforce currency presence for monetary widgets and fields. Use existing state values for state-based conditions in views More details in sub commits. Heuristics used to detect those issues will land in master as this merge targets a stable version.
Original PR description
PURPOSE Clean view definitions and coherency SPECIFICATIONS Remove dead code and files. Remove duplicate fields in tree views Remove duplicate field in kanban views, especially when dealing with preface / templates sections. Enforce currency presence for monetary widgets and fields. Use existing state values for state-based conditions in views More details in sub commits. Heuristics used to detect those issues will land in master as this merge targets a stable version. LINKS Task ID-2329114 PR odoo/odoo#56946 PR odoo/enterprise#12893 Forward-Port-Of: odoo/odoo#56946
fixes #56982 [FIX] l10n_cl: allow to generate document type "boleta" for foreign customers -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56983
Original PR description
fixes #56982 [FIX] l10n_cl: allow to generate document type "boleta" for foreign customers -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56983
task-2329538 Forward-Port-Of: odoo/odoo#56925
Original PR description
task-2329538 Forward-Port-Of: odoo/odoo#56925
Currently, 200+ country flags are stored in ALL db's as ir_attachment's (thus in the filestore), and also duplicated at each backup, ... To reduce the footprint of Odoo databases (and their backups), the country flags are now considered as static images and accessed as such, without storing their references in database. ##### New widget for static image URL's A new `image_url` widget is added (frontend & backend), to allow specification of a static URL in Char fields, enabling the acces
Original PR description
Currently, 200+ country flags are stored in ALL db's as ir_attachment's (thus in the filestore), and also duplicated at each backup, ... To reduce the footprint of Odoo databases (and their backups),…
Currently, 200+ country flags are stored in ALL db's as ir_attachment's (thus in the filestore), and also duplicated at each backup, ... To reduce the footprint of Odoo databases (and their backups), the country flags are now considered as static images and accessed as such, without storing their references in database. ##### New widget for static image URL's A new `image_url` widget is added (frontend & backend), to allow specification of a static URL in Char fields, enabling the access and display of `res.country` flags through their static urls : `/base/static/img/country_flags/<country_code>.png`. ##### Restriction of countries creation & deletion To ensure no inconsistency can be introduced because the flags are now static, we now restrict the creation and deletion of countries. Countries are nearly static data, they shouldn't ever be deleted... This prevents common database inconsistencies, bugs and feature disabling. Manually created countries can easily be wrongly configured, won't behave as expected and/or will crash with Odoo integration (delivery carriers, taxes, VAT validation/formatting). Therefore, creation/deletion of countries is limited to admins, supposed to know what they are doing... LINKS Task ID-2325371 Backport of #52774 (upgrade: https://github.com/odoo/upgrade/pull/1338) COM PR: #56997 (upgrade will be backported in https://github.com/odoo/upgrade/pull/1735) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56997
When we are creating invoices from a pos order, we should be able to extend the values used to create the invoices, when you have custom fields or module extention. This was possible in versio 13.0 and accidentally removed in the following commit. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo
Original PR description
When we are creating invoices from a pos order, we should be able to extend the values used to create the invoices, when you have custom fields or module extention. This was possible in versio 13.0 and accidentally removed in the following commit. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57011 Forward-Port-Of: odoo/odoo#56993
After clicking a table, ProductScreen should show, not FloorScreen. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57009
Original PR description
After clicking a table, ProductScreen should show, not FloorScreen. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57009
The document layout preview is a complete different simplified template with its own css that replicates at best the different styles. It does not have the external layout features and lack of fidelity. The new preview actually use the real documents templates and put the result in an iframe. It now has a high fidelity, though not perfect. The goal is for a better onboarding, where clients see easely how documents will look if they had an app to generate them. Of course, the data on t
Original PR description
The document layout preview is a complete different simplified template with its own css that replicates at best the different styles. It does not have the external layout features and lack of fidelity. The new preview actually use the real documents templates and put the result in an iframe. It now has a high fidelity, though not perfect. The goal is for a better onboarding, where clients see easely how documents will look if they had an app to generate them. Of course, the data on the document is a false invoice. Refactor all this from base to web. Task ID 2304177 Forward-Port-Of: odoo/odoo#56415
When we make a request to /hw_proxy/sanner there are a timeout of 7,5 sec After this timeout we wait for 5 sec before send another request. And we clean the queue of barcode in IoT Box after 5 sec. So if a cashier scan a product between this "gap" the product is not added to the POS With this commit we remove the delay before send another request. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I c
Original PR description
When we make a request to /hw_proxy/sanner there are a timeout of 7,5 sec After this timeout we wait for 5 sec before send another request. And we clean the queue of barcode in IoT Box after 5 sec. So if a cashier scan a product between this "gap" the product is not added to the POS With this commit we remove the delay before send another request. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56973
Task-2322857 Forward-Port-Of: odoo/odoo#56163
Original PR description
Task-2322857 Forward-Port-Of: odoo/odoo#56163
Also allow meta+enter task-2296863 Forward-Port-Of: odoo/odoo#56216
Original PR description
Also allow meta+enter task-2296863 Forward-Port-Of: odoo/odoo#56216
Python 3.8 changed the equality rules for bound methods to be based on the *identity* of the receiver (`__self__`) rather than its *equality*. This means that in 3.7, methods from different instances will compare (and hash) equal, thereby landing in the same map "slot", but that isn't the case in 3.8. While it's usually not relevant, it's an issue for `GroupCalls` which is indexed by a function: in 3.7, that being a method from recordsets comparing equal will deduplicate them, but not a
Original PR description
Python 3.8 changed the equality rules for bound methods to be based on the *identity* of the receiver (`__self__`) rather than its *equality*. This means that in 3.7, methods from different instances…
Python 3.8 changed the equality rules for bound methods to be based on
the *identity* of the receiver (`__self__`) rather than its *equality*.
This means that in 3.7, methods from different instances will compare
(and hash) equal, thereby landing in the same map "slot", but that isn't
the case in 3.8.
While it's usually not relevant, it's an issue for `GroupCalls` which is
indexed by a function: in 3.7, that being a method from recordsets
comparing equal will deduplicate them, but not anymore in 3.8, leading
to duplicated callbacks (exactly the thing GroupCalls aims to avoid).
Also, the API of `GroupCalls` turned out to be unusual and weird. The
bug above is fixed by using a plain list for callbacks, thereby avoiding
comparisons between registered functions. The API is now:
callbacks.add(func) # add func to callbacks
callbacks.run() # run all callbacks in addition order
callbacks.clear() # remove all callbacks
In order to handle aggregated data, the `callbacks` object provides a
dictionary `callbacks.data` that any callback function can freely use.
For the sake of consistency, the `callbacks.data` dict is automatically
cleared upon execution of callbacks.
Discovered by @william-andre
Related to odoo#56583
References:
* https://bugs.python.org/issue1617161
* python/cpython#7848
* https://docs.python.org/3/whatsnew/changelog.html#python-3-8-0-alpha-1
(no direct link because individual entries are not linkable, look for
bpo-1617161)
Forward-Port-Of: odoo/odoo#56990
Forward-Port-Of: odoo/odoo#56748It was only possible to print the tip receipts through an IoT Box. If no IoT Box is configured, we now show the browser's dialog. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56899
Original PR description
It was only possible to print the tip receipts through an IoT Box. If no IoT Box is configured, we now show the browser's dialog. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#56899
…timezone Co-authored-by: PierreCourt <pco@odoo.com> Description of the issue/feature this PR addresses: opw-2329027 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57026
Original PR description
…timezone Co-authored-by: PierreCourt <pco@odoo.com> Description of the issue/feature this PR addresses: opw-2329027 Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57026
Since 69ccabb212d83bfee60c7dade36ca4b06f9f2f12, the permissions for users to create emails has been removed. We need to make sure that even non admins can send the receipt by email. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57039
Original PR description
Since 69ccabb212d83bfee60c7dade36ca4b06f9f2f12, the permissions for users to create emails has been removed. We need to make sure that even non admins can send the receipt by email. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57039
Companion of https://github.com/odoo/odoo/pull/56748 Forward-Port-Of: odoo/enterprise#12914 Forward-Port-Of: odoo/enterprise#12763
Original PR description
Companion of https://github.com/odoo/odoo/pull/56748 Forward-Port-Of: odoo/enterprise#12914 Forward-Port-Of: odoo/enterprise#12763
* Fix evaluation loop when async formulas are in error * Fix range adaptation Forward-Port-Of: odoo/enterprise#12924
Original PR description
* Fix evaluation loop when async formulas are in error * Fix range adaptation Forward-Port-Of: odoo/enterprise#12924
taskID 2323997 Forward-Port-Of: odoo/enterprise#12682
Original PR description
taskID 2323997 Forward-Port-Of: odoo/enterprise#12682
PURPOSE Clean view definitions and coherency SPECIFICATIONS Remove dead code and files. Remove duplicate fields in tree views Remove duplicate field in kanban views, especially when dealing with preface / templates sections. Enforce currency presence for monetary widgets and fields. Use existing state values for state-based conditions in views More details in sub commits. Heuristics used to detect those issues will land in master as this merge targets a stable version.
Original PR description
PURPOSE Clean view definitions and coherency SPECIFICATIONS Remove dead code and files. Remove duplicate fields in tree views Remove duplicate field in kanban views, especially when dealing with preface / templates sections. Enforce currency presence for monetary widgets and fields. Use existing state values for state-based conditions in views More details in sub commits. Heuristics used to detect those issues will land in master as this merge targets a stable version. LINKS Task ID-2329114 PR odoo/odoo#56946 PR odoo/enterprise#12893 Forward-Port-Of: odoo/enterprise#12893
Task- https://www.odoo.com/web#id=2320842&action=4043&model=project.task&view_type=form&cids=2&menu_id=4720 Forward-Port-Of: odoo/enterprise#12724 Forward-Port-Of: odoo/enterprise#12584
Original PR description
Task- https://www.odoo.com/web#id=2320842&action=4043&model=project.task&view_type=form&cids=2&menu_id=4720 Forward-Port-Of: odoo/enterprise#12724 Forward-Port-Of: odoo/enterprise#12584
Before this commit, the end users were unable to click on the kanban image to see document's preview. To fix this we removed lines from a previous fix which is no longer useful in 13.0 because we now use kanban views for many2X fields instead of list views. See original commit: https://github.com/odoo/enterprise/commit/8a1ddb68820db45f4aedabf78562c108652c7d3f So for mobile phones it's working fine. For iPads, this rule is no longuer necessary since iPadOS. See "Accelerated Scrolling
Original PR description
Before this commit, the end users were unable to click on the kanban image to see document's preview. To fix this we removed lines from a previous fix which is no longer useful in 13.0 because we now use kanban views for many2X fields instead of list views. See original commit: https://github.com/odoo/enterprise/commit/8a1ddb68820db45f4aedabf78562c108652c7d3f So for mobile phones it's working fine. For iPads, this rule is no longuer necessary since iPadOS. See "Accelerated Scrolling on iOS and iPadOS": https://webkit.org/blog/9674/new-webkit-features-in-safari-13/ For previous versions it still works because the DOM has changed. Steps to reproduce: - Go to Document - Click on "o_kanban_image" => Your're stuck on a grayed page. opw-2260101 Forward-Port-Of: odoo/enterprise#12864 Forward-Port-Of: odoo/enterprise#12855