Friday, September 4, 2020
13 changes
Enhancements to existing features
This update removes outdated internal code from the SEPA Direct Debit area after the related payment logic was moved elsewhere. It should not change day-to-day behavior, but it reduces maintenance risk and keeps the accounting payment code aligned with the current system design.
Original PR description
The method get_batch_payment_methods_list() has been removed from the base model but is still overriden in the account_sepa_direct_debit module account_journal inherit. It seems like this functionnality is now implemented in the account_batch_payment model. This commit will remove the unused override. Task id #2285915
The Belgian reports module has been cleaned up by removing an outdated customization that no longer connects to the main reporting system. This reduces maintenance risk and helps keep the module aligned with the latest platform behavior, with no expected change for end users.
Original PR description
The method _get_vat_report_action_to_open() has been removed from the base model but is still overriden in the l10n_be_reports module. This commit will remove the override. Task id #2285933
An unused follow-up processing method was removed from the snail mail account follow-up area because the underlying account follow-up model no longer uses it. This is a minor cleanup that reduces maintenance risk without changing expected user-facing behavior.
Original PR description
The method _execute_followup_partner() has been removed from the base account_followup_report model but is still redefined in the one in snailmail_account_followup. This commit will thus remove it. Task id #2285947
Resolved issues and error corrections
Batch payments now correctly leave out cancelled payments when users choose payments to include. This helps prevent invalid or already-cancelled payments from being added to a batch, reducing processing mistakes.
Original PR description
The domain for the payment_ids is wrong and does not filter cancelled payments. This commit fix this issue. Task id #2322898
Miscellaneous changes
Before this commit: In voip, if we try to refuse an incoming call, the call stops but starts again one second after. If we refuse a second time this call, the call stops. So to refuse an incoming call, we must click twice on cancel button. After this commit: Click once on the cancel button is enough to refuse an incoming call. Technically, when rejecting the call, we send status code 603 (‘Decline’) instead of 480 (‘Temporarily Unavailable’). More details: https://tools.ietf.org/html/
Original PR description
Before this commit: In voip, if we try to refuse an incoming call, the call stops but starts again one second after. If we refuse a second time this call, the call stops. So to refuse an incoming call, we must click twice on cancel button. After this commit: Click once on the cancel button is enough to refuse an incoming call. Technically, when rejecting the call, we send status code 603 (‘Decline’) instead of 480 (‘Temporarily Unavailable’). More details: https://tools.ietf.org/html/rfc3261#section-21.6.2 TaskID 2309518 Forward-Port-Of: odoo/enterprise#12952 Forward-Port-Of: odoo/enterprise#12536
Without this decorator, message_post return a string mail.message(ID,) via RPC. Discuss need the message ID to scroll chat window. Forward-Port-Of: odoo/enterprise#12969 Forward-Port-Of: odoo/enterprise#12944
Original PR description
Without this decorator, message_post return a string mail.message(ID,) via RPC. Discuss need the message ID to scroll chat window. Forward-Port-Of: odoo/enterprise#12969 Forward-Port-Of: odoo/enterprise#12944
Due to timing change in how messages are fetched in task-2310623, the naive next tick approach is no longer enough. Forward-Port-Of: odoo/enterprise#12936 Forward-Port-Of: odoo/enterprise#12869
Original PR description
Due to timing change in how messages are fetched in task-2310623, the naive next tick approach is no longer enough. Forward-Port-Of: odoo/enterprise#12936 Forward-Port-Of: odoo/enterprise#12869
purpose purpose of this task to solve error that occurred when create when online appointment after this task preventing the slug performs before the record saved. because of the slug cannot perform on a non-existent record Forward-Port-Of: odoo/enterprise#12960
Original PR description
purpose purpose of this task to solve error that occurred when create when online appointment after this task preventing the slug performs before the record saved. because of the slug cannot perform on a non-existent record Forward-Port-Of: odoo/enterprise#12960
- Go to Accounting > Configuration > Chart of Accounts - Create an Account: * Name: Deferred Revenues * Type: Current Liabilities * Automate Deferred Revenue: Create and validate * Deferred Revenue Model: select/create one (make sure all its mandatory fields are filled) - Go to Accounting > Customers > Invoices and create a new invoice: * add an Invoice Line and select created "Deferred Revenues" as Account - Post the invoice Deferred Revenue is not created. It can be checked
Original PR description
- Go to Accounting > Configuration > Chart of Accounts - Create an Account: * Name: Deferred Revenues * Type: Current Liabilities * Automate Deferred Revenue: Create and validate * Deferred Revenue Model: select/create one (make sure all its mandatory fields are filled) - Go to Accounting > Customers > Invoices and create a new invoice: * add an Invoice Line and select created "Deferred Revenues" as Account - Post the invoice Deferred Revenue is not created. It can be checked in Accounting > Accounting > Deferred Revenues. opw-2326653 Forward-Port-Of: odoo/enterprise#12941 Forward-Port-Of: odoo/enterprise#12919
[opw-2322107](https://www.odoo.com/web#active_id=2322107&cids=1&id=2322107&model=project.task&menu_id=) [opw-2319791](https://www.odoo.com/web#active_id=2319791&cids=1&id=2319791&menu_id=&model=project.task) The computed condition to know in which column display the values was nonsense and based on depreciations instead of being based on the asset configuration. Forward-Port-Of: odoo/enterprise#12814 Forward-Port-Of: odoo/enterprise#12556
Original PR description
[opw-2322107](https://www.odoo.com/web#active_id=2322107&cids=1&id=2322107&model=project.task&menu_id=) [opw-2319791](https://www.odoo.com/web#active_id=2319791&cids=1&id=2319791&menu_id=&model=project.task) The computed condition to know in which column display the values was nonsense and based on depreciations instead of being based on the asset configuration. Forward-Port-Of: odoo/enterprise#12814 Forward-Port-Of: odoo/enterprise#12556
OPW 2326583 Forward-Port-Of: odoo/enterprise#12868 Forward-Port-Of: odoo/enterprise#12846
Original PR description
OPW 2326583 Forward-Port-Of: odoo/enterprise#12868 Forward-Port-Of: odoo/enterprise#12846
On a fresh db, in debug=0 go to settings, change the paper format Save Before this commit, the HomeMenu was briefly displayed before returning back to the settings view. This was because when saving the url state changes, triggering the handler for hashchange multiple times. The DropPrevious handling the loading of the menus rejected, which made the HomeMenu display After this commit, the HomeMenu does not appear during a transition from action to action. taskid 2301277 Forward-
Original PR description
On a fresh db, in debug=0 go to settings, change the paper format Save Before this commit, the HomeMenu was briefly displayed before returning back to the settings view. This was because when saving the url state changes, triggering the handler for hashchange multiple times. The DropPrevious handling the loading of the menus rejected, which made the HomeMenu display After this commit, the HomeMenu does not appear during a transition from action to action. taskid 2301277 Forward-Port-Of: odoo/enterprise#12925
Usecase to reproduce: - Start a new database and install quality_control module Crash because finished_lot_id is in the view but not in the model. finished_lot_id is defined in mrp_workorder. This fix move the definition in the wrong view to mrp_workorder that define the field. Also move lot_id since it's mainly used by mrp Task: 2330107 Forward-Port-Of: odoo/enterprise#12901
Original PR description
Usecase to reproduce: - Start a new database and install quality_control module Crash because finished_lot_id is in the view but not in the model. finished_lot_id is defined in mrp_workorder. This fix move the definition in the wrong view to mrp_workorder that define the field. Also move lot_id since it's mainly used by mrp Task: 2330107 Forward-Port-Of: odoo/enterprise#12901