Sunday, September 20, 2020
2 changes · master
Resolved issues and error corrections
This fix ensures that attachments linked to specific fields are included when moving or converting attachment storage. It helps prevent missing files after a storage migration, reducing the risk of incomplete business records.
Original PR description
Description of the issue/feature this PR addresses:
This change is necessary to migrate attachment which are assigned to a field. Otherwise the `_search `method would filter all of those attachments.
```python
if not any(arg[0] in ('id', 'res_field') for arg in args):
args.insert(0, ('res_field', '=', False))
```
Current behavior before PR:
Only attachment not related to a field will be migrated.
Desired behavior after PR is merged:
All attachments are migrated.
@mart-e I had a PR open for this put since the other changes in this PR are not needed anymore I closed it and opened this one.
https://github.com/odoo/odoo/pull/35614
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prMiscellaneous changes
Issue - Activate DHL connector - Create client with France address WITH an invalid post code - Create a quotation with the client just created (France Address) - Add any product - Click on "Add shipping", select "DHL USA" and click on "Get rate" Traceback is raised. Cause Not all 'condition code' are checked in response, therefore '_rate_shipment_vals' function returns nothing including the shipping price that is needed by 'rate_shipment' function who raised the error.
Original PR description
Issue - Activate DHL connector - Create client with France address WITH an invalid post code - Create a quotation with the client just created (France Address) - Add any product - Click on "Add shipping", select "DHL USA" and click on "Get rate" Traceback is raised. Cause Not all 'condition code' are checked in response, therefore '_rate_shipment_vals' function returns nothing including the shipping price that is needed by 'rate_shipment' function who raised the error. Solution Add management of these 3 following condition code: 420504 The origin location is invalid. Please check the data. 420505 The destination location is invalid. Please check the data. 420506 Postcode not found. Expected formats: <country specific post code format> DHL Documentation ref.: https://ecom.dhlexpress.pl/files/DHL%20EXPRESS%20-MyDHL%20API%20-%20Developer%20Guide%20-%20v1.4.pdf Forward-Port-Of: odoo/enterprise#13332 Forward-Port-Of: odoo/enterprise#13316