Monday, September 28, 2020
65 changes · master
Miscellaneous changes
This is an extract from #51637 It intend to give an alternative where I'll push the module `l10n_ch_isrb` to OCA/l10n-switzerland ### Description of the issue/feature this PR addresses: It gives a variant with only the hooks and necessary fixes. Add hooks to be able to tweak the Bank customer ID number for ISR-B Those hooks will allow to not use of the field `l10n_ch_postal` for multiple purposes. Fixes conditions on which the reference is generated. It shouldn't be always gene
Original PR description
This is an extract from #51637 It intend to give an alternative where I'll push the module `l10n_ch_isrb` to OCA/l10n-switzerland ### Description of the issue/feature this PR addresses: It gives a…
This is an extract from #51637
It intend to give an alternative where I'll push the module `l10n_ch_isrb` to OCA/l10n-switzerland
### Description of the issue/feature this PR addresses:
It gives a variant with only the hooks and necessary fixes.
Add hooks to be able to tweak the Bank customer ID number for ISR-B
Those hooks will allow to not use of the field `l10n_ch_postal` for
multiple purposes.
Fixes conditions on which the reference is generated.
It shouldn't be always generated if l10n_ch_postal is set.
Only if a `l10n_ch_subscription_xxx` is set.
### Current behavior before PR:
Following unit tests are failing:
``` python
odoo/src/addons/l10n_ch/tests/test_gen_isr_reference.py FF.F...
=============================================== FAILURES ================================================
_____________________________________ TestGenISRReference.test_isr ______________________________________
self = <odoo.addons.l10n_ch.tests.test_gen_isr_reference.TestGenISRReference testMethod=test_isr>
def test_isr(self):
inv_form = self.new_form()
inv_form.invoice_partner_bank_id = self.bank_acc_isr
invoice = inv_form.save()
invoice.name = "INV/01234567890"
expected_isr = "000000000000000012345678903"
expected_optical_line = (
"0100000494004>000000000000000012345678903+ 010001628>"
)
> self.assertEqual(invoice.l10n_ch_isr_number, expected_isr)
E AssertionError: False != '000000000000000012345678903'
odoo/src/addons/l10n_ch/tests/test_gen_isr_reference.py:62: AssertionError
______________________________ TestGenISRReference.test_isr_long_reference ______________________________
self = <odoo.addons.l10n_ch.tests.test_gen_isr_reference.TestGenISRReference testMethod=test_isr_long_reference>
def test_isr_long_reference(self):
inv_form = self.new_form()
inv_form.invoice_partner_bank_id = self.bank_acc_isr
invoice = inv_form.save()
invoice.name = "INV/123456789012345678901234567890"
expected_isr = "567890123456789012345678901"
expected_optical_line = (
"0100000494004>567890123456789012345678901+ 010001628>"
)
> self.assertEqual(invoice.l10n_ch_isr_number, expected_isr)
E AssertionError: False != '567890123456789012345678901'
odoo/src/addons/l10n_ch/tests/test_gen_isr_reference.py:87: AssertionError
_________________ TestGenISRReference.test_missing_isr_subscription_num_in_wrong_field __________________
self = <odoo.addons.l10n_ch.tests.test_gen_isr_reference.TestGenISRReference testMethod=test_missing_isr_subscription_num_in_wrong_field>
def test_missing_isr_subscription_num_in_wrong_field(self):
self.bank_acc_isr.l10n_ch_isr_subscription_chf = False
self.bank_acc_isr.l10n_ch_postal = ISR_SUBS_NUMBER
inv_form = self.new_form()
inv_form.invoice_partner_bank_id = self.bank_acc_isr
invoice = inv_form.save()
> self.assertFalse(invoice.l10n_ch_isr_number)
E AssertionError: '011628000000000000000000009' is not false
odoo/src/addons/l10n_ch/tests/test_gen_isr_reference.py:106: AssertionError
======================================== short test summary info ========================================
FAILED odoo/src/addons/l10n_ch/tests/test_gen_isr_reference.py::TestGenISRReference::test_isr - Assert...
FAILED odoo/src/addons/l10n_ch/tests/test_gen_isr_reference.py::TestGenISRReference::test_isr_long_reference
FAILED odoo/src/addons/l10n_ch/tests/test_gen_isr_reference.py::TestGenISRReference::test_missing_isr_subscription_num_in_wrong_field
============================== 3 failed, 4 passed, 111 warnings in 15.61s ===============================
```
### Desired behavior after PR is merged:
Handling of the generation of the ISR is corrected. And the 3 unit test pass.
Unit test `test_isr` check is standard expected configuration for ISR (not ISR-B).
Unit test `test_isr_long_reference` a long reference won't be likely to apear soon but it's worth testing.
Unit test `test_isr_missing_isr_subscription_in_wrong_field` checks the main issue that this PR fixes. The user is expected to fill at least `l10n_ch_isr_subscription_chf` not `l10n_ch_postal`.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#58351
Forward-Port-Of: odoo/odoo#58027Steps to reproduce the bug: - Let's consider a service product P with Service Tracking = 'Create a task in an existing project' and Project = PT - Create a lead L and set a tag T on it - Mark L as won and create a new quotation Q from L - Add P on Q and confirm it Bug: An error was raised because the tag T didn't exsit on model project.task PS: Confirming an order can trigger the creation of many records in different models and the generic field tag_ids is defined on many models
Original PR description
Steps to reproduce the bug: - Let's consider a service product P with Service Tracking = 'Create a task in an existing project' and Project = PT - Create a lead L and set a tag T on it - Mark L as won and create a new quotation Q from L - Add P on Q and confirm it Bug: An error was raised because the tag T didn't exsit on model project.task PS: Confirming an order can trigger the creation of many records in different models and the generic field tag_ids is defined on many models. So keeping it in the context when confirming an order can lead to many issues. opw:2338764 Forward-Port-Of: odoo/odoo#58402
Before this commit :The notification message is not being sent when a message that should be moderated is posted After this commit:The notification message will be sent when a message that should be moderated is posted LINKS Task-2282596 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#5
Original PR description
Before this commit :The notification message is not being sent when a message that should be moderated is posted After this commit:The notification message will be sent when a message that should be moderated is posted LINKS Task-2282596 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58511
Some of the TOTP-related forms contained an attempt at making a centered modal pop-up, using a bootstrap `card` that would also serve to emphasize that the interaction was sensitive and security-related. Some of the "footer buttons" were moved inside the form to make it more obvious that they were part of the interaction flow. However some of this caused breakages of responsiveness and did not yield a really satisfactory result anyway. This commit switches back to using regular non-center
Original PR description
Some of the TOTP-related forms contained an attempt at making a centered modal pop-up, using a bootstrap `card` that would also serve to emphasize that the interaction was sensitive and security-related. Some of the "footer buttons" were moved inside the form to make it more obvious that they were part of the interaction flow. However some of this caused breakages of responsiveness and did not yield a really satisfactory result anyway. This commit switches back to using regular non-centered forms. It looks quite ugly because the content is better suited for a narrow modal, but it means less surprises in terms of layout and less responsiveness issues. Forward-Port-Of: odoo/odoo#58541
* Prior to this commit the dynamic snippet was flickering (destroy followed by init) because the parallax option triggers a _refreshPublicWidgets in the onFocus. As such each time the user clicks somewhere in the snippet the snippet desapears and reappears which can be confusing for the user. * After this commit, the parallax option will only trigger a refresh on snippets that are using parallax. This commit also prevent the user from selecting an element of the dynamic snippet
Original PR description
* Prior to this commit the dynamic snippet was flickering (destroy followed by init) because the parallax option triggers a _refreshPublicWidgets in the onFocus. As such each time the user clicks somewhere in the snippet the snippet desapears and reappears which can be confusing for the user. * After this commit, the parallax option will only trigger a refresh on snippets that are using parallax. This commit also prevent the user from selecting an element of the dynamic snippet as it is not customizable. task-2339246 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57693
* Prior to this commit, the auto scroll is triggered when dragging items over the right panel (if the dragged item is close to bottom or top). * After this commit the auto scroll is is no more triggered as long as the dragged item is over the right panel area. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58470
Original PR description
* Prior to this commit, the auto scroll is triggered when dragging items over the right panel (if the dragged item is close to bottom or top). * After this commit the auto scroll is is no more triggered as long as the dragged item is over the right panel area. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58470
Before this commit the layout of the off-canvas menu was broken with an affixed header. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57442
Original PR description
Before this commit the layout of the off-canvas menu was broken with an affixed header. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57442
Remove the scrollValue variable because we don't need it anymore. It was used before the code was reviewed in a previous commit. Fix the scroll when the snippet is dynamic because it didnt work as we tried to get the offset of element with d-none class. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Original PR description
Remove the scrollValue variable because we don't need it anymore. It was used before the code was reviewed in a previous commit. Fix the scroll when the snippet is dynamic because it didnt work as we tried to get the offset of element with d-none class. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58486
Forward-Port-Of: odoo/odoo#58474
Original PR description
Forward-Port-Of: odoo/odoo#58474
When a company is created, a note is added with all the additional info retrieved from the IAP. Just like when autocomplete is enabled. Forward-Port-Of: odoo/odoo#58526
Original PR description
When a company is created, a note is added with all the additional info retrieved from the IAP. Just like when autocomplete is enabled. Forward-Port-Of: odoo/odoo#58526
After this commit, if an url with trailing slash is not found we fallback to the url without the slash with a redirect to respect seo. With this change we have the same behavior that controllers. We continue to support trailing slash if page explicitely created with / via backend e.g. and for retrocompatibility. task-2346185 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed t
Original PR description
After this commit, if an url with trailing slash is not found we fallback to the url without the slash with a redirect to respect seo. With this change we have the same behavior that controllers. We continue to support trailing slash if page explicitely created with / via backend e.g. and for retrocompatibility. task-2346185 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58450
When creating an event through the quickcreate, the user creating the event was not set as attendee. This fix introduces an increase of queries when validating a leave because a calendar.attendee is created for each leave. TaskID: 2334943 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#5
Original PR description
When creating an event through the quickcreate, the user creating the event was not set as attendee. This fix introduces an increase of queries when validating a leave because a calendar.attendee is created for each leave. TaskID: 2334943 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57793
Before this commit, the colors of the navbar in the table of content menu were not adapted to the color combinations system. With navbar in top position, the background and the colors of the links were in the same color. After this commit, the colors of the list-group-item links are also adapted with color combinations. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have
Original PR description
Before this commit, the colors of the navbar in the table of content menu were not adapted to the color combinations system. With navbar in top position, the background and the colors of the links were in the same color. After this commit, the colors of the list-group-item links are also adapted with color combinations. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57949
This commit improves the performance of the 'sale_price_subtotal' field of event.event by refactoring the way it's computed. The previous naive implementation looped on sale.order.lines linked to the event and performed a currency conversion for every single line. This could lead up to thousands of requests to fetch the conversion rate and sum up everything. This new implementation groups the amounts by currency and performs a single conversion per currency (factored by the number of
Original PR description
This commit improves the performance of the 'sale_price_subtotal' field of event.event by refactoring the way it's computed. The previous naive implementation looped on sale.order.lines linked to the…
This commit improves the performance of the 'sale_price_subtotal' field of event.event by refactoring the way it's computed. The previous naive implementation looped on sale.order.lines linked to the event and performed a currency conversion for every single line. This could lead up to thousands of requests to fetch the conversion rate and sum up everything. This new implementation groups the amounts by currency and performs a single conversion per currency (factored by the number of events in 'self'). It has the default of using 'today' to fetch conversion rates instead of the previous implementation that used the date of the related sale.order. We consider that as an acceptable trade-off to increase performances. Task 2335287 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57396
Expense header was displayed in all tree & kanban views. This commit removes the header in other views than 'My Expenses' menus because the expense header should only be visible in the 'My Expenses' menu Task id: 2341766 Forward-Port-Of: odoo/odoo#58023
Original PR description
Expense header was displayed in all tree & kanban views. This commit removes the header in other views than 'My Expenses' menus because the expense header should only be visible in the 'My Expenses' menu Task id: 2341766 Forward-Port-Of: odoo/odoo#58023
Calling a compute method on 1M records inevitably brings a worst case in cache prefetching: the code that determines which records to fetch has time complexity O(N²). We avoid this situation by calling the compute method on maximum 1K records. Each computed batch has a "prefetch set" of maximum 1K records too, which avoids the worst-case scenario above. Forward-Port-Of: odoo/odoo#57865
Original PR description
Calling a compute method on 1M records inevitably brings a worst case in cache prefetching: the code that determines which records to fetch has time complexity O(N²). We avoid this situation by calling the compute method on maximum 1K records. Each computed batch has a "prefetch set" of maximum 1K records too, which avoids the worst-case scenario above. Forward-Port-Of: odoo/odoo#57865
### Task 376 Description of the issue/feature this PR addresses: The method get_fiscal_position was missing the @api.model decorator. The original method have the decorator, but the inheritance in l10n_ar does not, it was giving us trouble when we call it by api. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58029
Original PR description
### Task 376 Description of the issue/feature this PR addresses: The method get_fiscal_position was missing the @api.model decorator. The original method have the decorator, but the inheritance in l10n_ar does not, it was giving us trouble when we call it by api. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58029
When registering payment, we display now the date + time instead just the date. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58037
Original PR description
When registering payment, we display now the date + time instead just the date. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58037
# Purpose Fix margin for kanban view that was displaying a horizontal scrollbar. task-2346202 Forward-Port-Of: odoo/odoo#58499
Original PR description
# Purpose Fix margin for kanban view that was displaying a horizontal scrollbar. task-2346202 Forward-Port-Of: odoo/odoo#58499
Purpose of the retro-compatibility route was to redirect the old to the new one. And not redirec to themself and create a loop Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58632
Original PR description
Purpose of the retro-compatibility route was to redirect the old to the new one. And not redirec to themself and create a loop Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58632
# Purpose Visual bug on the trophy icon background on certification survey # Specifications linear-gradient is available in safari for version 6.1 or later. By adding the prefix "-webkit-", this allows to works on version 5.1 or later. The 5.1 version is last version available on Windows devices. This commit add also the variation for firefox and opera browsers. task-2334731 Forward-Port-Of: odoo/odoo#58292
Original PR description
# Purpose Visual bug on the trophy icon background on certification survey # Specifications linear-gradient is available in safari for version 6.1 or later. By adding the prefix "-webkit-", this allows to works on version 5.1 or later. The 5.1 version is last version available on Windows devices. This commit add also the variation for firefox and opera browsers. task-2334731 Forward-Port-Of: odoo/odoo#58292
Fix traceback when creating a new contact by checking the id list is not empty. Task ID : 2302578 Forward-Port-Of: odoo/odoo#58555
Original PR description
Fix traceback when creating a new contact by checking the id list is not empty. Task ID : 2302578 Forward-Port-Of: odoo/odoo#58555
The kanban view was not properly using the custom javascript class. TaskID: 2340951 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58476
Original PR description
The kanban view was not properly using the custom javascript class. TaskID: 2340951 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58476
In a multi-company environment it can be difficult to see which journal is from which company on the dashboard, when multiple company have been selected. This commit will update the dashboard to show the company names on the journals in those cases Task id #2337719 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57640
Original PR description
In a multi-company environment it can be difficult to see which journal is from which company on the dashboard, when multiple company have been selected. This commit will update the dashboard to show the company names on the journals in those cases Task id #2337719 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57640
Purpose of the task is, the default view is the list view. In this commit , the default view is the graph followed by pivot view. task-id: 2337224 PR: 57513 Forward-Port-Of: odoo/odoo#57513
Original PR description
Purpose of the task is, the default view is the list view. In this commit , the default view is the graph followed by pivot view. task-id: 2337224 PR: 57513 Forward-Port-Of: odoo/odoo#57513
User settings (Calendar) the token was too long to be kept on one line. TaskID: 2335303 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57704
Original PR description
User settings (Calendar) the token was too long to be kept on one line. TaskID: 2335303 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57704
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58518
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58518
Currently, the chat icon is displayed underneath the name when employees record is in edit mode. So in this commit, when employee record is in edit mode the chat icon should be hidden. Links PR #58341 TaskID: 2344588 Forward-Port-Of: odoo/odoo#58341
Original PR description
Currently, the chat icon is displayed underneath the name when employees record is in edit mode. So in this commit, when employee record is in edit mode the chat icon should be hidden. Links PR #58341 TaskID: 2344588 Forward-Port-Of: odoo/odoo#58341
This PR fixes issues in project with the alias and the display on the portal Task : 2299286 PR enterprise : https://github.com/odoo/enterprise/pull/13407 Forward-Port-Of: odoo/odoo#58200
Original PR description
This PR fixes issues in project with the alias and the display on the portal Task : 2299286 PR enterprise : https://github.com/odoo/enterprise/pull/13407 Forward-Port-Of: odoo/odoo#58200
When opening automatic entries on a group of entries which sum equals to zero, a division by zero occurs which cause a traceback. This commit will fix the issue. task id #2334872 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57641
Original PR description
When opening automatic entries on a group of entries which sum equals to zero, a division by zero occurs which cause a traceback. This commit will fix the issue. task id #2334872 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57641
I tested the issue in 12 and 13 **Description of the issue/feature this PR addresses:** You can see here that only delivery address matters: https://github.com/odoo/odoo/blob/f9da0a6c80ae68283f4ef9af736253352ff4e1d4/addons/account/models/partner.py#L158-L162 **Current behavior before PR:** The hint is confusing **Desired behavior after PR is merged:** The hint is correct -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forw
Original PR description
I tested the issue in 12 and 13 **Description of the issue/feature this PR addresses:** You can see here that only delivery address matters: https://github.com/odoo/odoo/blob/f9da0a6c80ae68283f4ef9af736253352ff4e1d4/addons/account/models/partner.py#L158-L162 **Current behavior before PR:** The hint is confusing **Desired behavior after PR is merged:** The hint is correct -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#57991
Description of the issue/feature this PR addresses: Map to right URL's Current behavior before PR: Some URL's point to 13.0 Desired behavior after PR is merged: The URL's point to 14.0 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58610
Original PR description
Description of the issue/feature this PR addresses: Map to right URL's Current behavior before PR: Some URL's point to 13.0 Desired behavior after PR is merged: The URL's point to 14.0 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58610
When a record has a lot of x2m linked records displayed in a form view, a snapshot is done record by record to compare previous and current data. Without prefetching, each record is read one by one in the database. Some testing with `account.move` and the relation `invoice_line_ids`: For 335 invoice lines, changing the value of a field in the invoice lines took about 1.9s with 1415 queries. Now, it takes about 1.1s and 82 queries. -- I confirm I have signed the CLA and read the
Original PR description
When a record has a lot of x2m linked records displayed in a form view, a snapshot is done record by record to compare previous and current data. Without prefetching, each record is read one by one in the database. Some testing with `account.move` and the relation `invoice_line_ids`: For 335 invoice lines, changing the value of a field in the invoice lines took about 1.9s with 1415 queries. Now, it takes about 1.1s and 82 queries. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58622 Forward-Port-Of: odoo/odoo#58340
This commit aim to improve the algorithm to select the next talk suggestion after a track has ended, in order to support small interact between two longer talks. Idea: - all talks that begin less than 10 minutes before (all at same ordering level whatever actual time) - then talks beginning in a near future Task ID: 2344522 Forward-Port-Of: odoo/odoo#58617 Forward-Port-Of: odoo/odoo#58305
Original PR description
This commit aim to improve the algorithm to select the next talk suggestion after a track has ended, in order to support small interact between two longer talks. Idea: - all talks that begin less than 10 minutes before (all at same ordering level whatever actual time) - then talks beginning in a near future Task ID: 2344522 Forward-Port-Of: odoo/odoo#58617 Forward-Port-Of: odoo/odoo#58305
The invoicing tour suggests to change the invoice number manualy but it is not doable with l10n_ar because of the document number mechanism. The partner needs the AFIP responsability to be set in order to generate the number. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58661
Original PR description
The invoicing tour suggests to change the invoice number manualy but it is not doable with l10n_ar because of the document number mechanism. The partner needs the AFIP responsability to be set in order to generate the number. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#58661
Forward-Port-Of: odoo/odoo#58690
Original PR description
Forward-Port-Of: odoo/odoo#58690
Forward-Port-Of: odoo/odoo#58538
Original PR description
Forward-Port-Of: odoo/odoo#58538
*: website As the text editor is still the summernote one, this improvement was made possible through a series of hack. It has to be reviewed once the new editor is ready. This makes the text tools only appear in the style tab by switching to it as soon as the summernote tools are updated. To prevent flickering, css and js hacks had to be made. This also moves the undo/redo buttons in the top bar with another hack: those simulates click on the hidden summernote ones. Forward-Port-Of
Original PR description
*: website As the text editor is still the summernote one, this improvement was made possible through a series of hack. It has to be reviewed once the new editor is ready. This makes the text tools only appear in the style tab by switching to it as soon as the summernote tools are updated. To prevent flickering, css and js hacks had to be made. This also moves the undo/redo buttons in the top bar with another hack: those simulates click on the hidden summernote ones. Forward-Port-Of: odoo/odoo#58638
Current behavior before PR: Currently, traceback occurring while going to click on the contact icon once the call connected (new number) Desired behavior after PR is merged: While going to click on the contact icon once the call connected (new number) it will be redirected to the specific contacts view without any traceback LINKS PR-https://github.com/odoo/enterprise/pull/12490 task-2321014 Forward-Port-Of: odoo/enterprise#12490
Original PR description
Current behavior before PR: Currently, traceback occurring while going to click on the contact icon once the call connected (new number) Desired behavior after PR is merged: While going to click on the contact icon once the call connected (new number) it will be redirected to the specific contacts view without any traceback LINKS PR-https://github.com/odoo/enterprise/pull/12490 task-2321014 Forward-Port-Of: odoo/enterprise#12490
Bug === When the name of a social account is long, it can break the view. Task-2302570 Forward-Port-Of: odoo/enterprise#13538
Original PR description
Bug === When the name of a social account is long, it can break the view. Task-2302570 Forward-Port-Of: odoo/enterprise#13538
[FIX] account_consolidation: allow deleting a consolidation chart if it is still used by groups, deleting the groups as well Consolidation chart object is central to the the consolidation module. If it is deleted, all the depending objects also must be, including groups. The only exception to this is consolidation entries (whose model is named consolidation.journal). We don't want to cascade on them when deleting a chart, as it could be and error and would lead to data loss. If the user re
Original PR description
[FIX] account_consolidation: allow deleting a consolidation chart if it is still used by groups, deleting the groups as well Consolidation chart object is central to the the consolidation module. If it is deleted, all the depending objects also must be, including groups. The only exception to this is consolidation entries (whose model is named consolidation.journal). We don't want to cascade on them when deleting a chart, as it could be and error and would lead to data loss. If the user really wants to delete the chart in this case, she'll have to delete all the entries first. [IMP] account_consolidation: don't redirect to dashboard when clicking 'periods' stat button of consolidation chart This is a usability improvement. Although it displays the same information, going back to the dashboard was confusing. We new apply the same action as if the user had gone through configuration -> periods. Forward-Port-Of: odoo/enterprise#13575
The subtotal wasn't being displayed correctly on the customer report. Task : 2299286 PR community : https://github.com/odoo/odoo/pull/58200 Forward-Port-Of: odoo/enterprise#13407
Original PR description
The subtotal wasn't being displayed correctly on the customer report. Task : 2299286 PR community : https://github.com/odoo/odoo/pull/58200 Forward-Port-Of: odoo/enterprise#13407
Fix bug where employee could edit the manager feedback on the appraisal form. Task ID: 2337975 Related to odoo/enterprise#13234 Forward-Port-Of: odoo/enterprise#13331
Original PR description
Fix bug where employee could edit the manager feedback on the appraisal form. Task ID: 2337975 Related to odoo/enterprise#13234 Forward-Port-Of: odoo/enterprise#13331
Lower the sequence of Internal to ensure it is the default folder of the documents Apps (it is required for the onboarding tour). Task ID: 2346789 Forward-Port-Of: odoo/enterprise#13562
Original PR description
Lower the sequence of Internal to ensure it is the default folder of the documents Apps (it is required for the onboarding tour). Task ID: 2346789 Forward-Port-Of: odoo/enterprise#13562
Before this commit: Boolean has_bicycle is displayed between amount of kilometers (between work and home) and the unit 'km'. After this commit: Boolean has_bicycle is below (on a new line). Forward-Port-Of: odoo/enterprise#13559
Original PR description
Before this commit: Boolean has_bicycle is displayed between amount of kilometers (between work and home) and the unit 'km'. After this commit: Boolean has_bicycle is below (on a new line). Forward-Port-Of: odoo/enterprise#13559
This seems not necessary. Forward-Port-Of: odoo/enterprise#13558
Original PR description
This seems not necessary. Forward-Port-Of: odoo/enterprise#13558
Remove the "Select Internal Workspace" step of the onboarding tour as it is now the default workspace. Task ID: 2346581 Forward-Port-Of: odoo/enterprise#13553
Original PR description
Remove the "Select Internal Workspace" step of the onboarding tour as it is now the default workspace. Task ID: 2346581 Forward-Port-Of: odoo/enterprise#13553
Changing expected payment date is currently causing a traceback, this commit will fix it. task id #2343805 Forward-Port-Of: odoo/enterprise#13443
Original PR description
Changing expected payment date is currently causing a traceback, this commit will fix it. task id #2343805 Forward-Port-Of: odoo/enterprise#13443
Currently, when translation for buttons is long(mainly in french) then it will display long button at bottom left of the card and due to that kanban view is broken. So in this commit, Fix the bottom left height as 50% and truncate the text of button to display the bottom right properly instead of overlap with each other. LINKS PR: #13334 TaskID: 2335292 Forward-Port-Of: odoo/enterprise#13334
Original PR description
Currently, when translation for buttons is long(mainly in french) then it will display long button at bottom left of the card and due to that kanban view is broken. So in this commit, Fix the bottom left height as 50% and truncate the text of button to display the bottom right properly instead of overlap with each other. LINKS PR: #13334 TaskID: 2335292 Forward-Port-Of: odoo/enterprise#13334
This commit fixes a traceback when lookup returns an error by checking that the result of endpoint request is valid dictionary without any errors. Task - 2295079 Forward-Port-Of: odoo/enterprise#12439
Original PR description
This commit fixes a traceback when lookup returns an error by checking that the result of endpoint request is valid dictionary without any errors. Task - 2295079 Forward-Port-Of: odoo/enterprise#12439
After this commit: Planning manager can see all shifts (even if linked to private project) Planning user can only see shifts linked to project that he can see (if project is private and he is not follower of this project, he can't see this shift even he is assigned on this shift.) Works in back end and in portal. Task ID 2202941 Forward-Port-Of: odoo/enterprise#11633
Original PR description
After this commit: Planning manager can see all shifts (even if linked to private project) Planning user can only see shifts linked to project that he can see (if project is private and he is not follower of this project, he can't see this shift even he is assigned on this shift.) Works in back end and in portal. Task ID 2202941 Forward-Port-Of: odoo/enterprise#11633
This commit introduces a dummy register payment wizard used for the sample receipts. No accounting entries are generated. TaskID: 2337285 Forward-Port-Of: odoo/enterprise#13515
Original PR description
This commit introduces a dummy register payment wizard used for the sample receipts. No accounting entries are generated. TaskID: 2337285 Forward-Port-Of: odoo/enterprise#13515
When trying to install sale_renting app on existing databases with a lot of existing orders, the installation may crash or take a lot of time. This was due to some computed fields which were computed on existing Orders & lines, taking a lot of time. This commit makes it so that those problematic fields are computed in SQL instead of Python, to reduce installation time (and avoid installation crash on large databases). There is no need to set the values of the columns with an `UPDATE`
Original PR description
When trying to install sale_renting app on existing databases with a lot of existing orders, the installation may crash or take a lot of time. This was due to some computed fields which were computed on existing Orders & lines, taking a lot of time. This commit makes it so that those problematic fields are computed in SQL instead of Python, to reduce installation time (and avoid installation crash on large databases). There is no need to set the values of the columns with an `UPDATE` SQL command because all those fields are falsy (NULL) on non-rental sale orders (e.g. existing orders before rental module installation). opw-2334712 Same logic as for https://github.com/odoo/odoo/pull/57850 Forward-Port-Of: odoo/enterprise#13509
PURPOSE Remove the schedule later part of the tour and post directly instead with the Post button LINK Task ID : 2345843 Forward-Port-Of: odoo/enterprise#13556
Original PR description
PURPOSE Remove the schedule later part of the tour and post directly instead with the Post button LINK Task ID : 2345843 Forward-Port-Of: odoo/enterprise#13556
Views ===== The border of the social post preview card are inconsistent (sometimes we have a rounded border, sometimes there's no border). So, we unify the border style of the social post preview. Website user do not have the access right to read the website page (and some other models). So we hide the visitors' menu item in that case. Task-2302570 Forward-Port-Of: odoo/enterprise#13539
Original PR description
Views ===== The border of the social post preview card are inconsistent (sometimes we have a rounded border, sometimes there's no border). So, we unify the border style of the social post preview. Website user do not have the access right to read the website page (and some other models). So we hide the visitors' menu item in that case. Task-2302570 Forward-Port-Of: odoo/enterprise#13539
Forward-Port-Of: odoo/enterprise#13546
Original PR description
Forward-Port-Of: odoo/enterprise#13546
Task [2341157](https://www.odoo.com/web#id=2341157&action=333&active_id=967&model=project.task&view_type=form&cids=1&menu_id=4720) The receivable lines of the Invoice and Bill between the US company and BE company were set as invoice lines instead of move entry line. We also remove the created company as one is already created in l10n_be; we should use that one. Forward-Port-Of: odoo/enterprise#13505
Original PR description
Task [2341157](https://www.odoo.com/web#id=2341157&action=333&active_id=967&model=project.task&view_type=form&cids=1&menu_id=4720) The receivable lines of the Invoice and Bill between the US company and BE company were set as invoice lines instead of move entry line. We also remove the created company as one is already created in l10n_be; we should use that one. Forward-Port-Of: odoo/enterprise#13505
Link to the release: https://github.com/odoo/o-spreadsheet/releases/tag/1.0.0 Here is the list of changes: Improvements ============ - evaluation: Don't evaluate out of bounds ranges - chart: some small options adjustments Fixes ===== - grid: correctly update viewport after sheet switching - grid: Set focus when sheet changed - avoid memory leak - merge: autofill a merge outside the grid - autofill: autofill outside the grid - menu: fix sub-menu position on small screen -
Original PR description
Link to the release: https://github.com/odoo/o-spreadsheet/releases/tag/1.0.0 Here is the list of changes: Improvements ============ - evaluation: Don't evaluate out of bounds ranges - chart: some small options adjustments Fixes ===== - grid: correctly update viewport after sheet switching - grid: Set focus when sheet changed - avoid memory leak - merge: autofill a merge outside the grid - autofill: autofill outside the grid - menu: fix sub-menu position on small screen - chart: async formula in label support Forward-Port-Of: odoo/enterprise#13543
This commit prevents the 'droppable' hover animation from happening if hovering a record over the "All" selector in the search panel. This also fixes the check that prevents dropping a record in it. Forward-Port-Of: odoo/enterprise#13540
Original PR description
This commit prevents the 'droppable' hover animation from happening if hovering a record over the "All" selector in the search panel. This also fixes the check that prevents dropping a record in it. Forward-Port-Of: odoo/enterprise#13540
The sample receipts were sent for digitization, the UI was blocked for a few seconds needlessly. The restaurant receipt had the wrong amount as well. TaskID: 2346137 Forward-Port-Of: odoo/enterprise#13520
Original PR description
The sample receipts were sent for digitization, the UI was blocked for a few seconds needlessly. The restaurant receipt had the wrong amount as well. TaskID: 2346137 Forward-Port-Of: odoo/enterprise#13520
PURPOSE Improve the quality of spreadsheet thumbnails SPECIFICATION Currently, the squared thumbnail spanq the whole height of the grid (header row/column included) With this commit, the squared thumbnail will span around 25 standard-height rows, and starting at cell A1 (headers not included) also, improve the resolution of the thumbnail to a reasonable level of details task-id:2328535 Forward-Port-Of: odoo/enterprise#13048
Original PR description
PURPOSE Improve the quality of spreadsheet thumbnails SPECIFICATION Currently, the squared thumbnail spanq the whole height of the grid (header row/column included) With this commit, the squared thumbnail will span around 25 standard-height rows, and starting at cell A1 (headers not included) also, improve the resolution of the thumbnail to a reasonable level of details task-id:2328535 Forward-Port-Of: odoo/enterprise#13048
* do not crash and instead correctly display attendees of chosen event; * apply default filtering on unconfirmed or confirmed attendees; Forward-Port-Of: odoo/enterprise#13545
Original PR description
* do not crash and instead correctly display attendees of chosen
event;
* apply default filtering on unconfirmed or confirmed attendees;
Forward-Port-Of: odoo/enterprise#13545Task-ID #2325191 Forward-Port-Of: odoo/enterprise#13482
Original PR description
Task-ID #2325191 Forward-Port-Of: odoo/enterprise#13482
Forward-Port-Of: odoo/enterprise#13536
Original PR description
Forward-Port-Of: odoo/enterprise#13536
This fix allows to install voip in a database that contains approximately 400K res.partner records. Before the fix => timeout or MemoryError After the fix => installation runs in ~6 min opw-[2328605](https://www.odoo.com/web?debug=1#id=2328605&action=333&active_id=49&model=project.task&view_type=form&cids=&menu_id=4720) Forward-Port-Of: odoo/enterprise#13381
Original PR description
This fix allows to install voip in a database that contains approximately 400K res.partner records. Before the fix => timeout or MemoryError After the fix => installation runs in ~6 min opw-[2328605](https://www.odoo.com/web?debug=1#id=2328605&action=333&active_id=49&model=project.task&view_type=form&cids=&menu_id=4720) Forward-Port-Of: odoo/enterprise#13381