This fix prevents expense analytic accounts and tags from being reset when a product is changed if the user has already selected values. It keeps existing expense details intact and resolves test failures when the analytic defaults feature is installed.

_onchange_product_id() used to always (re)set hr_expense analytic_account_id & analytic_tag_ids to default values.
Or set those to false if no default values are found.
Installing account_analytic_default_hr_expense made odoo/addons/hr_expense/tests/test_expenses.py tests fail

- changed function name (no need to be a _onchange_product_id override)
- removed super() & return
- only set default value to var if var is False

Task: 2205544

In this commit, we restore the following behavior from v13: when search resulted to a single product and 'Enter' key is pressed, the product is added to the order and the search field is cleared. This works for both manual keyboard input and barcode input. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59742

In this commit, we restore the following behavior from v13: when search
resulted to a single product and 'Enter' key is pressed, the product is
added to the order and the search field is cleared. This works for both
manual keyboard input and barcode input.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#59742

…ntity Enable discounts on sales order lines Create a service type product with invoicing based on timesheet and task in sales order's project Create so for 6 hours and deliver 8 hours. Create 2 invoices: One for 6 hours with the regular price and 2 hours h 100% discount. Invoice status of the order will be Fully Invoiced Go to Sales>Reporting>Sales Analysis report will show the untaxed amount associated with 2nd invoice as still to invoice which is incorrect This occur because w

…ntity

Enable discounts on sales order lines
Create a service type product with invoicing based on timesheet and
task in sales order's project
Create so for 6 hours and deliver 8 hours.
Create 2 invoices: One for 6 hours with the regular price and 2 hours
h 100% discount.
Invoice status of the order will be Fully Invoiced

Go to Sales>Reporting>Sales Analysis report will show the untaxed amount
associated with 2nd invoice as still to invoice which is incorrect

This occur because when saving the invoice the untaxed amount is
calculated on the amount invoice after discount

opw-2338564


--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#58908

As described here: https://www.estv.admin.ch/estv/fr/home/mehrwertsteuer/fachinformationen/steuerpflicht/unternehmens-identifikationsnummer--uid-.html The "new" (since 2014) vat number has to be displayed as: CHE 9 numeric digits plus TVA/MWST/IVA e.g.: CHE-123.456.788 TVA This commit removes the previous 6 digits vat number check and regex, and provide accurate examples on the error message displayed if the vatnumber given is wrong. opw-2291581 Description of the issue/feature

As described here:
https://www.estv.admin.ch/estv/fr/home/mehrwertsteuer/fachinformationen/steuerpflicht/unternehmens-identifikationsnummer--uid-.html

The "new" (since 2014) vat number has to be displayed as:
CHE 9 numeric digits plus TVA/MWST/IVA
e.g.: CHE-123.456.788 TVA

This commit removes the previous 6 digits vat number check and regex,
and provide accurate examples on the error message displayed if the
vatnumber given is wrong.

opw-2291581

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#59723

Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59640

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#59640

Previously, editing a ribbon in the options panel had no preview inside of the page until the change was validated. This commit fixes that issue by making the real ribbon invisible, and making the ribbon dummy visible. The preview still only affects the current ribbon being edited until it is validated. Unvalidated changes are discarded when clicking elsewhere in the page. task-2339986 Forward-Port-Of: odoo/odoo#59782 Forward-Port-Of: odoo/odoo#59072

Previously, editing a ribbon in the options panel had no preview inside
of the page until the change was validated. This commit fixes that issue
by making the real ribbon invisible, and making the ribbon dummy
visible. The preview still only affects the current ribbon being edited
until it is validated. Unvalidated changes are discarded when clicking
elsewhere in the page.

task-2339986

Forward-Port-Of: odoo/odoo#59782
Forward-Port-Of: odoo/odoo#59072

This reverts commit [1] which was fixed the right way and generically with [2]. [1]: f011c9aacf3a3010c436d4e4f408cd9ae265de1b [2]: https://github.com/odoo/odoo/commit/9c08e119b125b82e2c42dc944920dd8a96789e25 Forward-Port-Of: odoo/odoo#59787

This reverts commit [1] which was fixed the right way and generically
with [2].

[1]: f011c9aacf3a3010c436d4e4f408cd9ae265de1b
[2]: https://github.com/odoo/odoo/commit/9c08e119b125b82e2c42dc944920dd8a96789e25

Forward-Port-Of: odoo/odoo#59787

Because the barcode app bypasses the detailed operations for receipts (with default settings set), an error was being thrown when doing "put in pack" when a carrier is set (saving during the delivery package wizard) because the picking move lines are incorrectly selected. This commit adds in a check for when the wizard is accessed via the barcode app so that the error does not occur and the same behavior as when no carrier is assigned is followed. Related Enterprise PR: odoo/enterprise#

Because the barcode app bypasses the detailed operations for receipts
(with default settings set), an error was being thrown when doing "put
in pack" when a carrier is set (saving during the delivery package
wizard) because the picking move lines are incorrectly selected. This
commit adds in a check for when the wizard is accessed via the barcode
app so that the error does not occur and the same behavior as when no
carrier is assigned is followed.

Related Enterprise PR: odoo/enterprise#9808
Task: 2039720

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#59737

Description of the issue/feature this PR addresses: Test file does not work correctly on systems with symlinked addons in addons_path. E.g. `/opt/odoo/auto/addons` is in the addons_path and we symlink `my_addon` into it. * Upon start the addons_path is normalized (has no effect) but when installing the account addon's path is not normalized so the addon gets installed as `/opt/odoo/auto/addons/my_addon`. * When running a single test e.g. `/opt/odoo/auto/addons/my_addon/tests/my_test.py` the

Description of the issue/feature this PR addresses:
Test file does not work correctly on systems with symlinked addons in addons_path.
E.g. `/opt/odoo/auto/addons` is in the addons_path and we symlink `my_addon` into it.
* Upon start the addons_path is normalized (has no effect) but when installing the account addon's path is not normalized so the addon gets installed as `/opt/odoo/auto/addons/my_addon`.
* When running a single test e.g. `/opt/odoo/auto/addons/my_addon/tests/my_test.py` the path gets normalized to `/opt/odoo/custom/src/my_addons_repo/my_addon/tests/my_test.py` and checked if the file can be found:
```
2020-08-17 10:32:42,563 1 INFO devel odoo.service.server: loading test file /opt/odoo/custom/src/my_addons_repo/my_addon/tests/my_test.py
```
* In load_test_file_py the correct addon `my_addon` is found by
```
for mod in [m for m in get_modules() if '/%s/' % m in test_file]:
```
* But the test_file is discarded because the normalized path does not match the path of the installed module in:
```
if test_path == mod_path:
```

By getting rid of the normalization for test_file we put the responsibiliy for giving the correct path to the developer / tester but enable using test_file in the above scenario where addons are symlinked into a directory that is itself not a symlink.

Current behavior before PR:
When using `--test-file=...` on an Odoo installation where the addon is symlinked test_file does *not run* the tests in the given test file.

Desired behavior after PR is merged:
When using `--test-file=...` on an Odoo installation where the addon is symlinked test_file does *run* the tests in the given test file.


Info @wt-io-it

FYI @Yajo one cannot use `--test-file=...` in doodba for Odoo 13.0 because of this.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#59751
Forward-Port-Of: odoo/odoo#55986

When a product is set on a line and we change product with the product configurator wizard, we will use the attributes values of the previous product. But then since the attributes are the ones of wrong product, not attribute is selected and if eg. we have radio button with one option and custom value, it will never be selectable (because the radio button is hidden and unselected). In this commit, we do not use the current variant values when we change product in the product configur

When a product is set on a line and we change product with the product
configurator wizard, we will use the attributes values of the previous
product.

But then since the attributes are the ones of wrong product, not
attribute is selected and if eg. we have radio button with one option
and custom value, it will never be selectable (because the radio button
is hidden and unselected).

In this commit, we do not use the current variant values when we change
product in the product configurator wizard.

note: this commit also increases the limit of (custom values) inside the
product configurator wizard, for an arbitrary 10000 limit. Without this
change, each opening of the wizard would only keep 40 customs values and
discard the other ones.

opw-2333091

Forward-Port-Of: odoo/odoo#59768
Forward-Port-Of: odoo/odoo#59016

Steps to reproduce the bug: - Enable Multi-Currencies and Multi-Companies - Create a vendor bill - Remove the default journal - Set an other currencies Bug: A traceback was raised opw:2350490 Forward-Port-Of: odoo/odoo#59469

Steps to reproduce the bug:

- Enable Multi-Currencies and Multi-Companies
- Create a vendor bill
- Remove the default journal
- Set an other currencies

Bug:

A traceback was raised

opw:2350490

Forward-Port-Of: odoo/odoo#59469

Issue - Install `Manufacture` and `Purchase` - Go to `Manufacture` - Enable Studio - Create new rules - Select `Purchase Order` model - Try to select autocomplete proposition with `Deliver to` field Traceback raised. Cause The _search function does not return indexable value. Solution Cast _search to a list. PS: search can be used (instead of _search) to get iterable value. opw-2357391 Forward-Port-Of: odoo/odoo#59812

Issue

    - Install `Manufacture` and `Purchase`
    - Go to `Manufacture`
    - Enable Studio
    - Create new rules
    - Select `Purchase Order` model
    - Try to select autocomplete proposition with `Deliver to` field

    Traceback raised.

Cause

    The _search function does not return indexable value.

Solution

    Cast _search to a list.
    PS: search can be used (instead of _search) to get iterable value.


opw-2357391

Forward-Port-Of: odoo/odoo#59812

PURPOSE We want to send the digest tips 2 hours after the database creation. It can not be done directly on the digest itself because its field is a date and not a datetime. So we change the "Next Run Date" of the digest to now, and we run the digest CRON 2 hours after its creation. LINKS Task 2351561 Internal odoo/internal/pull/1051 Forward-Port-Of: odoo/odoo#59474

PURPOSE

We want to send the digest tips 2 hours after the database creation.
It can not be done directly on the digest itself because its field
is a date and not a datetime.

So we change the "Next Run Date" of the digest to now, and we run
the digest CRON 2 hours after its creation.

LINKS

Task 2351561
Internal odoo/internal/pull/1051

Forward-Port-Of: odoo/odoo#59474

Before this commit, the menu direction of header dropdowns was related to the window width but it was wrong because of the right panel. We also enable it in editor mode. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59783

Before this commit, the menu direction of header dropdowns was
related to the window width but it was wrong because of the right
panel. We also enable it in editor mode.

task-2312878

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#59783

Issue - Install `Point of Sale` - Enable `QR Cod`" in `Invoicing` - Open new POS session - Set random customer - Try to send the invoice by email Cause The `qr_code_urls` doesnt exist in the dictionary. Solution Add `qr_code_urls` with all generated qr code urls to the dictionary in `report.point_of_sale.report_invoice` opw-2357088 Forward-Port-Of: odoo/odoo#59669

Issue

    - Install `Point of Sale`
    - Enable `QR Cod`" in `Invoicing`
    - Open new POS session
    - Set random customer
    - Try to send the invoice by email

Cause

    The `qr_code_urls` doesnt exist in the dictionary.

Solution

    Add `qr_code_urls` with all generated qr code urls to the dictionary in `report.point_of_sale.report_invoice`

opw-2357088

Forward-Port-Of: odoo/odoo#59669

-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#59426

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#59426

To reproduce the issue before this fix: 1. Create accounts ACC TAX A, ACC TAX B, with reconcile = True, internal_type = other 2. Create Tax B, with tax_exigibilty = on_payment and account_id = ACC TAX B and cash_basic_account_id = ACC TAX A, 20% 3. Create invoice B, account_id = Tax B, unit_price = 1000, Valide invoice, 4. Register a payment of 600 for invoice B (so, that's half the invoice, when including the taxes). The cash basis tax creates a miscellaneous operation MISC A, conta

To reproduce the issue before this fix:

1. Create accounts ACC TAX A, ACC TAX B, with reconcile = True, internal_type = other

2. Create Tax B, with tax_exigibilty = on_payment and account_id = ACC TAX B and cash_basic_account_id = ACC TAX A, 20%

3. Create invoice B, account_id = Tax B, unit_price = 1000, Valide invoice,

4. Register a payment of 600 for invoice B (so, that's half the invoice, when including the taxes). The cash basis tax creates a miscellaneous operation MISC A, containing a line on ACC TAX A.

5. Create a mis operation MISC TVA, like this:
line 1 : account_id = ACC TAX A, credit = 100
line 2 : account_id = 401100, debit = 100

6. Reconcile the following move lines:
line of MISC A with account ACC TAX A (100)
line of MISC TVA with account ACC TAX A (100)

==> The lines should be fully reconciled

To solve that without breaking the fix made here https://github.com/odoo/odoo/commit/c43acc34b873dc70cf792675fe1d58d8b0e116b1 , we rely on the tax_exigible field of account move lines. When all the reconcile lines are exigible, it means we're not reconciling the transition line of a cash basis entry, and so we can directly full reconcile.


Fixes https://github.com/odoo/odoo/issues/58996
OPW 2350494

Forward-Port-Of: odoo/odoo#59670
Forward-Port-Of: odoo/odoo#59126

To investigate a bit. Sometimes a few extra queries are generated. Forward-Port-Of: odoo/odoo#59821

To investigate a bit. Sometimes a few extra queries are generated.

Forward-Port-Of: odoo/odoo#59821

Make sure to assign a value to the computed fields `mobile_blacklisted` and `phone_blacklisted` in their compute method for all record included in `self` Otherwise, not assigning a value for one record included in `self` can result in a cache missing error. ``` Traceback (most recent call last): File "/tmp/tmp3l14ain7/migrations/base/tests/test_mock_crawl.py", line 143, in crawl_menu self.mock_action(action_vals) File "/tmp/tmp3l14ain7/migrations/base/tests/test_mock_crawl.p

Make sure to assign a value to the computed fields
`mobile_blacklisted` and `phone_blacklisted`
in their compute method for all record included in `self`

Otherwise, not assigning a value for one record included
in `self` can result in a cache missing error.

```
Traceback (most recent call last):
  File "/tmp/tmp3l14ain7/migrations/base/tests/test_mock_crawl.py", line 143, in crawl_menu
    self.mock_action(action_vals)
  File "/tmp/tmp3l14ain7/migrations/base/tests/test_mock_crawl.py", line 212, in mock_action
    mock_method(model, view, fields_list, domain, group_by)
  File "/tmp/tmp3l14ain7/migrations/base/tests/test_mock_crawl.py", line 238, in mock_view_form
    [data] = record.read(fields_list)
  File "/home/odoo/src/odoo/14.0/odoo/models.py", line 3001, in read
    return self._read_format(fnames=fields, load=load)
  File "/home/odoo/src/odoo/14.0/odoo/models.py", line 3021, in _read_format
    vals[name] = convert(record[name], record, use_name_get)
  File "/home/odoo/src/odoo/14.0/odoo/models.py", line 5620, in __getitem__
    return self._fields[key].__get__(self, type(self))
  File "/home/odoo/src/odoo/14.0/odoo/fields.py", line 980, in __get__
    raise ValueError("Compute method failed to assign %s.%s" % (record, self.name))
ValueError: Compute method failed to assign crm.lead(974,).phone_blacklisted
```

Forward-Port-Of: odoo/odoo#59827

Description of the issue/feature this PR addresses: The problem here is before this changes, the fiscal position only take into account if them has "auto_apply" True, and for the cases that the partner has their property fiscal position configurate for a company this is not taking into account. Current behavior before PR: For argentinian localization, if the partner has a fiscal position configurate for a company, when you call for the method to retrieve the fiscal position for an invoi

Description of the issue/feature this PR addresses:

The problem here is before this changes, the fiscal position only take into account if them has "auto_apply" True, and for the cases that the partner has their property fiscal position configurate for a company this is not taking into account.

Current behavior before PR:

For argentinian localization, if the partner has a fiscal position configurate for a company, when you call for the method to retrieve the fiscal position for an invoice for instance, the fiscal position it's not found if this has not "auto apply".

Desired behavior after PR is merged:

After this changes we evaluate for the property fiscal position for the partner and then if non result we seek a fiscal position with the auto apply and the responsability of AFIP.

So this the same as the original method do.



--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#59553
Forward-Port-Of: odoo/odoo#58914

The goal of this PR is to prevent the theme install/update loader from inheriting the opacity property from container by setting a background-color with level of transparency. task-2312878 Forward-Port-Of: odoo/odoo#58489

The goal of this PR is to prevent the theme install/update loader
from inheriting the opacity property from container by setting
a background-color with level of transparency.

task-2312878

Forward-Port-Of: odoo/odoo#58489

Forward-Port-Of: odoo/enterprise#13939

Forward-Port-Of: odoo/enterprise#13939

Issue - Install `Accounting` - Go to `Accounting` => `Accounting` - Press `Bank and Cash` - Select two elements and press `Reconcile` - Go to `Manual Operations` tab - Account => `101402 Bank` - Journal => `Vendor Bills` - To Check => `True` - Press `Reconcile` Cause The `amount_residual` element does not exist in `self`. Solution Take `move_lines` instead of `self` opw-2357271 Forward-Port-Of: odoo/enterprise#140

Issue

    - Install `Accounting`
    - Go to `Accounting` => `Accounting`
    - Press `Bank and Cash`
    - Select two elements and press `Reconcile`
    - Go to `Manual Operations` tab
        - Account => `101402 Bank`
        - Journal => `Vendor Bills`
        - To Check => `True`
    - Press `Reconcile`

Cause

    The `amount_residual` element does not exist in `self`.

Solution

    Take `move_lines` instead of `self`

opw-2357271

Forward-Port-Of: odoo/enterprise#14000

Forward-Port-Of: odoo/enterprise#13915 Forward-Port-Of: odoo/enterprise#13481

Forward-Port-Of: odoo/enterprise#13915
Forward-Port-Of: odoo/enterprise#13481

Steps to reproduce the bug: - Have 20+ confirmed SO for the same customer (A) (make sure they have a delivered quantity) - Select them - Action -> Create invoices -> Create and view invoice - Post the invoice - Go to Accounting -> Customers -> Follow-up Reports - Select the follow-up for customer (A) - Print letter + Send by email Bug: The Source Document column is so large that the columns on the right are invisible. opw:2352436 Forward-Port-Of: odoo/enterprise#13990

Steps to reproduce the bug:
- Have 20+ confirmed SO for the same customer (A) (make sure they have a delivered quantity)
- Select them
- Action -> Create invoices -> Create and view invoice
- Post the invoice
- Go to Accounting -> Customers -> Follow-up Reports
- Select the follow-up for customer (A)
- Print letter + Send by email

Bug:
The Source Document column is so large that the columns on the right are invisible.

opw:2352436

Forward-Port-Of: odoo/enterprise#13990

# Purpose Fix the broken design when we are in mobile in the confirmation view when we register to an appointment type. task-2302663 Forward-Port-Of: odoo/enterprise#13408

# Purpose

Fix the broken design when we are in mobile in the confirmation view
when we register to an appointment type.

task-2302663

Forward-Port-Of: odoo/enterprise#13408