Wednesday, October 21, 2020
35 changes · master
New functionality added to Odoo
The website theme selection experience now includes animated screenshots. This makes themes feel more dynamic and helps users better preview the look and feel before choosing one.
Original PR description
task-2256659 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Enhancements to existing features
This update reorders the carousel style options in the website editor, making the list more intuitive for users building pages. It is a small usability improvement that helps editors find the right carousel look more quickly without changing website behavior.
Original PR description
Part of #55857 task-2318526 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
Double-clicking a pictogram in the web editor now opens the media selection window directly on the pictogram tab. This saves users from manually switching tabs and makes editing visual content more predictable.
Original PR description
Prior to this fix, the media modal would not open in the picto tab when double clicking a pictogram. Jabberwock PR: https://github.com/odoo-dev/jabberwock/pull/448 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Steps to reproduce the bug: - Activate Margins in Sales > Settings - Go to the pivot view of quotations - In Measures, click Margin (%) Bug: Margin percentages are aggregated by computing the sum of the margin sub-percentages instead of using the data of the aggregated row (i.e. agg. margin / agg. total). Explanation: This is one of the flaws of the pivot view. The best way to solve this would be to create a custom aggregation in PostgreSQL. This commit is just hiding the measure for
Original PR description
Steps to reproduce the bug: - Activate Margins in Sales > Settings - Go to the pivot view of quotations - In Measures, click Margin (%) Bug: Margin percentages are aggregated by computing the sum of the margin sub-percentages instead of using the data of the aggregated row (i.e. agg. margin / agg. total). Explanation: This is one of the flaws of the pivot view. The best way to solve this would be to create a custom aggregation in PostgreSQL. This commit is just hiding the measure for now. opw:2349896 Forward-Port-Of: odoo/odoo#60297 Forward-Port-Of: odoo/odoo#60290
Mail attachments now use Odoo's standard navigation service instead of directly controlling the browser location. This keeps navigation behavior more consistent across the application and reduces the risk of inconsistent user experiences.
Original PR description
task-2171884
This fixes an automated signing test so it waits for the signing screen to finish loading before trying to add a signature. The change helps prevent false test failures and supports more dependable quality checks for the Sign app.
State to reproduce the bug: - Let's consider a 2 steps delivery setting - Create a SO with a product P and a quantity Q and confirm it - Pick: Deliver a smaller quantity than Q, don't create a backorder but duplicate the Pick and validate it with the remaining quantity. - Out: the initial delivery order OUT P1 does not allow the reservation, so cancel it and duplicate it (let's call it P2). - Click on Mark to do on P2 Bug: The initial picking OUT P1 was changed in state Ready i
Original PR description
State to reproduce the bug: - Let's consider a 2 steps delivery setting - Create a SO with a product P and a quantity Q and confirm it - Pick: Deliver a smaller quantity than Q, don't create a…
State to reproduce the bug: - Let's consider a 2 steps delivery setting - Create a SO with a product P and a quantity Q and confirm it - Pick: Deliver a smaller quantity than Q, don't create a backorder but duplicate the Pick and validate it with the remaining quantity. - Out: the initial delivery order OUT P1 does not allow the reservation, so cancel it and duplicate it (let's call it P2). - Click on Mark to do on P2 Bug: The initial picking OUT P1 was changed in state Ready instead of keeping in state Cancelled PS: When ducplicating the initial picking OUT P1, the stock move linked to it was also duplicated with the same procure_method set to 'make_to_order' (let's call it SM1). So when clicking on button 'Mark to do', the function _action_confirm was triggered and a new stock move SM2 was created (implying to set SM1 in state 'waiting'). And in function _compute_state, P2 was set to 'waiting' because the relevant_move_state was in state 'waiting'. opw:2339217 Forward-Port-Of: odoo/odoo#60270
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55860
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55860
Depending of the configuration, on the portal, anchor do not consider the header, so a part of the text is hidden by the navbar. task-2290213 Forward-Port-Of: odoo/odoo#59596
Original PR description
Depending of the configuration, on the portal, anchor do not consider the header, so a part of the text is hidden by the navbar. task-2290213 Forward-Port-Of: odoo/odoo#59596
Issue - Install "Calender" - Install "Google Calendar" - Try to sync google in "Calendar" Every created events will trigger the sending mail to attendees even if the event date is past Cause 'events' was not filtered Solution Filter 'events' to get all the events that have not yet happened opw-2358123 Forward-Port-Of: odoo/odoo#60379
Original PR description
Issue
- Install "Calender"
- Install "Google Calendar"
- Try to sync google in "Calendar"
Every created events will trigger the sending mail to attendees
even if the event date is past
Cause
'events' was not filtered
Solution
Filter 'events' to get all the events that have not yet happened
opw-2358123
Forward-Port-Of: odoo/odoo#60379Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60154
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60154
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60406
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60406
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60055
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60055
The feature was actually not working as expected. It has been fixed, and a test now ensures it does work as expected. This commit also fixes some invalid parameters, hopefully nothing critical. Forward-Port-Of: odoo/odoo#60402
Original PR description
The feature was actually not working as expected. It has been fixed, and a test now ensures it does work as expected. This commit also fixes some invalid parameters, hopefully nothing critical. Forward-Port-Of: odoo/odoo#60402
task-2318526 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55857
Original PR description
task-2318526 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#55857
This commit gives to o_Dialog the same z-index as modals, before this commit, the dialog could be hidden or partially obstructed by other elements. part of task-2171884 Forward-Port-Of: odoo/odoo#60162
Original PR description
This commit gives to o_Dialog the same z-index as modals, before this commit, the dialog could be hidden or partially obstructed by other elements. part of task-2171884 Forward-Port-Of: odoo/odoo#60162
Before this commit, we executed the request even when creating a new badge. And it thrown a traceback. After this commit, we return default values before executing the request if this is a new badge. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60347
Original PR description
Before this commit, we executed the request even when creating a new badge. And it thrown a traceback. After this commit, we return default values before executing the request if this is a new badge. task-2312878 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60347
The package.py script is moving the addons in odoo/addons which is not more necessary for the Debian package as it's made at the Debian packaging level. So package.py will not do that anymore. Forward-Port-Of: odoo/odoo#60421
Original PR description
The package.py script is moving the addons in odoo/addons which is not more necessary for the Debian package as it's made at the Debian packaging level. So package.py will not do that anymore. Forward-Port-Of: odoo/odoo#60421
The bottom of long receipts was missing when printing through the browser printing dialog. opw-2362522 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60375
Original PR description
The bottom of long receipts was missing when printing through the browser printing dialog. opw-2362522 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60375
Issue - Install "Website" app - Go to "Contact us" page on website - Edit Page, then click on submit button to edit form style - Alter 'Recipient Email' then save - Edit Page and click on submit button 'Recipient Email' have default value. Cause If a field is required, the default value is set without checking if a value is already set. Solution Set current value if available, else default value. opw-2361169 Forward-Port-Of: odoo/odoo#60374
Original PR description
Issue - Install "Website" app - Go to "Contact us" page on website - Edit Page, then click on submit button to edit form style - Alter 'Recipient Email' then save - Edit Page and click on submit button 'Recipient Email' have default value. Cause If a field is required, the default value is set without checking if a value is already set. Solution Set current value if available, else default value. opw-2361169 Forward-Port-Of: odoo/odoo#60374
Finetuning of #59467 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60417
Original PR description
Finetuning of #59467 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60417
Issue - Change country to Mexico - Install 'CRM' - Install 'l10n_mx_edi' - Try to open any lead in 'CRM' The same error is present in l10n_pe Cause 'l10n_mx_edi' and 'l10n_pe' use 'res.partner' in 'ir.ui.view' Solution Adding a condition to prevent '_fields_view_get_address' in 'format.address.mixin' from rewritting the model and let ir.ui.view determine it opw-2361875 Forward-Port-Of: odoo/odoo#60329
Original PR description
Issue
- Change country to Mexico
- Install 'CRM'
- Install 'l10n_mx_edi'
- Try to open any lead in 'CRM'
The same error is present in l10n_pe
Cause
'l10n_mx_edi' and 'l10n_pe' use 'res.partner' in 'ir.ui.view'
Solution
Adding a condition to prevent '_fields_view_get_address' in 'format.address.mixin'
from rewritting the model and let ir.ui.view determine it
opw-2361875
Forward-Port-Of: odoo/odoo#60329Issue - Install "Website" app - Go to "Contact us" page on website - Edit Page, then click on submit button to edit form style - Alter 'Recipient Email' by selecting a value from 'autocomplete' values Other input text options are also altered. Cause Due to chrome autocomplete, others text input fields are also altered (like it will do with a form address). In this case, the error was obvious since it alter also the 'Labels Width' who break the layout. Solution
Original PR description
Issue - Install "Website" app - Go to "Contact us" page on website - Edit Page, then click on submit button to edit form style - Alter 'Recipient Email' by selecting a value from 'autocomplete' values Other input text options are also altered. Cause Due to chrome autocomplete, others text input fields are also altered (like it will do with a form address). In this case, the error was obvious since it alter also the 'Labels Width' who break the layout. Solution Disable autocomplete on `<input type='text'/>` options elements. opw-2361169 Forward-Port-Of: odoo/odoo#60470 Forward-Port-Of: odoo/odoo#60453
Courtesy of sts Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60434
Original PR description
Courtesy of sts Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#60434
Due to XML standards, the company name cannot contain some special characters like '&' that needs to be escaped. We should remove these characters to avoid having XML files rejected afterwards. opw-2361061 Forward-Port-Of: odoo/enterprise#14274 Forward-Port-Of: odoo/enterprise#14221
Original PR description
Due to XML standards, the company name cannot contain some special characters like '&' that needs to be escaped. We should remove these characters to avoid having XML files rejected afterwards. opw-2361061 Forward-Port-Of: odoo/enterprise#14274 Forward-Port-Of: odoo/enterprise#14221
When the service type "ELECTRONIC_TRADE_DOCUMENTS" is added, it is possible that there is no object 'SpecialServicesRequested' on the shipment, that'll lead to a traceback. So we are now adding the object 'SpecialServicesRequested' at the begining of shipment and just append the needed 'SpecialServiceTypes' when needed. OPW-2359344 Forward-Port-Of: odoo/enterprise#14288
Original PR description
When the service type "ELECTRONIC_TRADE_DOCUMENTS" is added, it is possible that there is no object 'SpecialServicesRequested' on the shipment, that'll lead to a traceback. So we are now adding the object 'SpecialServicesRequested' at the begining of shipment and just append the needed 'SpecialServiceTypes' when needed. OPW-2359344 Forward-Port-Of: odoo/enterprise#14288
TLDR: a sort of race condition in UI STEPS: * in l10n_ar_edi/controllers/main.py add a sleep in /l10n_ar_edi/download_csr controller: import time; time.sleep(5) * restart odoo * install l10n_ar_edi * open Settings >> Accounting * activate developer mode * remove values for "Private Key" in "Certificate" fields in Argentina Localization section * click "=> Generate Request" BEFORE: after 5 seconds ther certificate is downloaded, but field "Private Key" is not set; however,
Original PR description
TLDR: a sort of race condition in UI STEPS: * in l10n_ar_edi/controllers/main.py add a sleep in /l10n_ar_edi/download_csr controller: import time; time.sleep(5) * restart odoo * install l10n_ar_edi *…
TLDR: a sort of race condition in UI STEPS: * in l10n_ar_edi/controllers/main.py add a sleep in /l10n_ar_edi/download_csr controller: import time; time.sleep(5) * restart odoo * install l10n_ar_edi * open Settings >> Accounting * activate developer mode * remove values for "Private Key" in "Certificate" fields in Argentina Localization section * click "=> Generate Request" BEFORE: after 5 seconds ther certificate is downloaded, but field "Private Key" is not set; however, if you reload page field "Private Key" is actuatlly set AFTER: in less than 5 seconds, settings values are reloaded and you see "Private key" is set EXPLANATION: * To reproduce the issue without time.sleep, you may need a good internet connection. Also, it seems easy to reproduce in odoo 14, rather than odoo 13 * This is how it works without this commit: _generate_afip_private_key is called inside /l10n_ar_edi/download_csr controller https://github.com/odoo/enterprise/blob/facabd57e61fcbb9ae65f2a6de167791a6075dad/l10n_ar_edi/models/res_company.py#L188-L189 --- opw-2351017 Forward-Port-Of: odoo/enterprise#14277 Forward-Port-Of: odoo/enterprise#14247
The current code would not allow a partner part of a company* to use the sdd payment acquirer. The main issue being that a mandate is supposed to be delivered by the company* rathar tnat one of its employees. This commit ensures that we always assign the mandate to the `partner.commercial_partner_id` and that we properly manage the pament tokens related to these mandates. * read: partner with a parent and that is not of type company. opw-2270613 Forward-Port-Of: odoo/enterprise#142
Original PR description
The current code would not allow a partner part of a company* to use the sdd payment acquirer. The main issue being that a mandate is supposed to be delivered by the company* rathar tnat one of its employees. This commit ensures that we always assign the mandate to the `partner.commercial_partner_id` and that we properly manage the pament tokens related to these mandates. * read: partner with a parent and that is not of type company. opw-2270613 Forward-Port-Of: odoo/enterprise#14257 Forward-Port-Of: odoo/enterprise#14211
Since https://github.com/odoo/odoo/commit/62d0c9e47bbf5abcdb1ef20370c18c4c1e3d6e68 the invocie date is context dependent, but the create_date is not; therefore the comparison fails at some hours. Forward-Port-Of: odoo/enterprise#14163
Original PR description
Since https://github.com/odoo/odoo/commit/62d0c9e47bbf5abcdb1ef20370c18c4c1e3d6e68 the invocie date is context dependent, but the create_date is not; therefore the comparison fails at some hours. Forward-Port-Of: odoo/enterprise#14163
Companion of https://github.com/odoo/odoo/pull/60402. Forward-Port-Of: odoo/enterprise#14273
Original PR description
Companion of https://github.com/odoo/odoo/pull/60402. Forward-Port-Of: odoo/enterprise#14273
Before this commit, the cfdi:Impuestos part of the cfdi document wasn't created if the invoice have Tax 0%. This error occurs because in the case of Tax 0%, total_tax_details_transferred will be 0. So the condition to create the Impuestos part of the document wasn't fulfilled. Now, the cfdi:Impuestos part is correctly filled with the information of the Tax 0% opw-2357680 Forward-Port-Of: odoo/enterprise#14170
Original PR description
Before this commit, the cfdi:Impuestos part of the cfdi document wasn't created if the invoice have Tax 0%. This error occurs because in the case of Tax 0%, total_tax_details_transferred will be 0. So the condition to create the Impuestos part of the document wasn't fulfilled. Now, the cfdi:Impuestos part is correctly filled with the information of the Tax 0% opw-2357680 Forward-Port-Of: odoo/enterprise#14170
We have been warned by the Chrome Web Store that the application doesn't use cookies. Their security policy having changed, it is mandatory to modify this to avoid to be deleted from the store. Note that this extension is generated from 11.0 for historical reasons. Some work must be done in more recent version to avoid this. Task-ID: 2345852 Forward-Port-Of: odoo/enterprise#14187
Original PR description
We have been warned by the Chrome Web Store that the application doesn't use cookies. Their security policy having changed, it is mandatory to modify this to avoid to be deleted from the store. Note that this extension is generated from 11.0 for historical reasons. Some work must be done in more recent version to avoid this. Task-ID: 2345852 Forward-Port-Of: odoo/enterprise#14187
This fix updates a comment to clarify that the custom values applied to a document created from a message come from the share, not from the alias defaults (even though it is normally the same thing, since the alias defaults is synchronized from the share on update). It also adds a test to verify that the values are copied from the share when creating a new document from a mail attachment. There is no change in the behavior of the application itself. opw-2352486 Forward-Port-Of: odoo/en
Original PR description
This fix updates a comment to clarify that the custom values applied to a document created from a message come from the share, not from the alias defaults (even though it is normally the same thing, since the alias defaults is synchronized from the share on update). It also adds a test to verify that the values are copied from the share when creating a new document from a mail attachment. There is no change in the behavior of the application itself. opw-2352486 Forward-Port-Of: odoo/enterprise#14165 Forward-Port-Of: odoo/enterprise#14156
This commit truncates the slot note to 200 characters, the popover was not appearing when the note was too long. TaskID: 2348608 Forward-Port-Of: odoo/enterprise#13687
Original PR description
This commit truncates the slot note to 200 characters, the popover was not appearing when the note was too long. TaskID: 2348608 Forward-Port-Of: odoo/enterprise#13687
- Create 2 companies A & B - Set the `__system__` user in company B - Create the following bank accounts for partner A: Account B, Sequence N, Company B Account A, Sequence N+1, Company A - Create a subscription in company A, start - Wait for the cron to create the invoice The bank account chosen is Account B instead of Account A. This happens because although the `company` is the correct one (A), the record rules do not apply since the user is the superuser. Therefore, the fir
Original PR description
- Create 2 companies A & B - Set the `__system__` user in company B - Create the following bank accounts for partner A: Account B, Sequence N, Company B Account A, Sequence N+1, Company A - Create a subscription in company A, start - Wait for the cron to create the invoice The bank account chosen is Account B instead of Account A. This happens because although the `company` is the correct one (A), the record rules do not apply since the user is the superuser. Therefore, the first account is selected, which is B in this case. As a solution, we filter out accounts in the wrong company. opw-2359812 opw-2366360 Forward-Port-Of: odoo/enterprise#14246 Forward-Port-Of: odoo/enterprise#14227