Thursday, November 12, 2020
12 changes · master
Resolved issues and error corrections
Several labels and terms were updated to remove ambiguous English wording across calendar, events, recruitment, and web editing areas. This helps translators choose the right meaning and gives users clearer text in translated versions of Odoo.
Original PR description
WHY: odoo translation framework still cannot properly handle terms that have different translations, so we need to avoid english terms with double meaning. Also, this improves term understanding for translators. --- Discussion: #60765 #61272 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
- Allow online payments for invoices - Create an invoice and assign it to Joel Willis. Post the invoice. - Connect as Joel Willis and pay the invoice In the `/my/invoices` view, the invoice is set as 'Paid' and 'Reversed'. It should not be labeled as reversed. The issue is probably a wrong copy-paste of the line above: https://github.com/odoo/odoo/blob/478ebc74554f6609a1414726ee1f35fe5dcd6a81/addons/account_payment/views/account_portal_templates.xml#L28 Indeed, the `last_tx.stat
Original PR description
- Allow online payments for invoices - Create an invoice and assign it to Joel Willis. Post the invoice. - Connect as Joel Willis and pay the invoice In the `/my/invoices` view, the invoice is set as 'Paid' and 'Reversed'. It should not be labeled as reversed. The issue is probably a wrong copy-paste of the line above: https://github.com/odoo/odoo/blob/478ebc74554f6609a1414726ee1f35fe5dcd6a81/addons/account_payment/views/account_portal_templates.xml#L28 Indeed, the `last_tx.state` has no impact on the fact that the payment is reversed. opw-2373146 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61595
An error showed when sucessfully printing receipts with the IoT Box in Community. Closes odoo/odoo#59059 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61636
Original PR description
An error showed when sucessfully printing receipts with the IoT Box in Community. Closes odoo/odoo#59059 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61636
This reverts commit fbd30f4266d86b53aa4b13b72a93bccee0d7eb69. Indeed kwargs are used to build a link, meaning message value are given to some links when using message_notify. A better fix will be provided soon. Reverting to avoid issues in stable. Forward-Port-Of: odoo/odoo#61604 Forward-Port-Of: odoo/odoo#61591
Original PR description
This reverts commit fbd30f4266d86b53aa4b13b72a93bccee0d7eb69. Indeed kwargs are used to build a link, meaning message value are given to some links when using message_notify. A better fix will be provided soon. Reverting to avoid issues in stable. Forward-Port-Of: odoo/odoo#61604 Forward-Port-Of: odoo/odoo#61591
Description of the issue/feature this PR addresses: Missing VAT label for French Polynesia -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr https://github.com/odoo/odoo/pull/39359 Forward-Port-Of: odoo/odoo#39916
Original PR description
Description of the issue/feature this PR addresses: Missing VAT label for French Polynesia -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr https://github.com/odoo/odoo/pull/39359 Forward-Port-Of: odoo/odoo#39916
the custom field with an invalid depends raise error through a transitive dependency. The loading of the registry completely fails, because the loading of the field custom_field raises a `KeyError` exception in `def transitive_dependencies` @ `dependencies[field]` it happens here because the custom_field was skipped at `dependencies[field] = set(field.resolve_depends(model))` task - 2366502 Forward-Port-Of: odoo/odoo#60899
Original PR description
the custom field with an invalid depends raise error through a transitive dependency. The loading of the registry completely fails, because the loading of the field custom_field raises a `KeyError` exception in `def transitive_dependencies` @ `dependencies[field]` it happens here because the custom_field was skipped at `dependencies[field] = set(field.resolve_depends(model))` task - 2366502 Forward-Port-Of: odoo/odoo#60899
In the case of none of the conditions is fulfilled, the stock page level will have not a state. This will raise an error when it's open. opw-2375250 Forward-Port-Of: odoo/odoo#61633
Original PR description
In the case of none of the conditions is fulfilled, the stock page level will have not a state. This will raise an error when it's open. opw-2375250 Forward-Port-Of: odoo/odoo#61633
Title and tooltip had no sense since every star would have its own tooltip "One star" instead of having a single tooltip on the whole star container which could show the exact rating "5 stars on 5". Plus, one of the title were set on a t-foreach which does nothing. Closes #51743 task-2369420 Forward-Port-Of: odoo/odoo#60633
Original PR description
Title and tooltip had no sense since every star would have its own tooltip "One star" instead of having a single tooltip on the whole star container which could show the exact rating "5 stars on 5". Plus, one of the title were set on a t-foreach which does nothing. Closes #51743 task-2369420 Forward-Port-Of: odoo/odoo#60633
- Create a DB without demo data - Install `account` - Install l10n_bo The tax report loading fails. This is caused by the missing country. opw-2378095 opw-2379117 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61670
Original PR description
- Create a DB without demo data - Install `account` - Install l10n_bo The tax report loading fails. This is caused by the missing country. opw-2378095 opw-2379117 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#61670
When the layout background color was reset using the colorpicker of the countdown option, a traceback occurred. This was because the countdown widget relies on having a set color. The text and progress bar colors were working with unset colors but with inconsistent behavior. This commit fixes the traceback and makes the widget consistent: using the reset button on any color tells the countdown widget "use the color you want" and our countdown widget will simply set it to black. Thanks t
Original PR description
When the layout background color was reset using the colorpicker of the countdown option, a traceback occurred. This was because the countdown widget relies on having a set color. The text and progress bar colors were working with unset colors but with inconsistent behavior. This commit fixes the traceback and makes the widget consistent: using the reset button on any color tells the countdown widget "use the color you want" and our countdown widget will simply set it to black. Thanks to dwa-odoo and jpr-odoo for original investigation. task-2227149 Forward-Port-Of: odoo/odoo#61657 Forward-Port-Of: odoo/odoo#61639
Prevent crash if no Outbound Payment Methods is defined, which can happen if no CoA is installed. opw-2373810 Forward-Port-Of: odoo/enterprise#14709
Original PR description
Prevent crash if no Outbound Payment Methods is defined, which can happen if no CoA is installed. opw-2373810 Forward-Port-Of: odoo/enterprise#14709
- Configure Mexican electronic invoicing; - Create an invoice for Azure Interior; - Make sure that Azure Interior don't have any bank assigned; - Make sure the invoice is PPD by having payment terms with more than one line assigned on it; - Validate and 'Send Now' to get a Folio Fiscal / CFDI number; - Register a payment, with 'Transferencia electrónica de fondos' as Payment Way; - Go to the payment and 'Send Now' to get the CFDI number; Before this commit, an error was raised: 'E
Original PR description
- Configure Mexican electronic invoicing; - Create an invoice for Azure Interior; - Make sure that Azure Interior don't have any bank assigned; - Make sure the invoice is PPD by having payment terms with more than one line assigned on it; - Validate and 'Send Now' to get a Folio Fiscal / CFDI number; - Register a payment, with 'Transferencia electrónica de fondos' as Payment Way; - Go to the payment and 'Send Now' to get the CFDI number; Before this commit, an error was raised: 'El campo NomBancoOrdExt se debe registrar'. This issue occurs because the field RfcEmisorCtaOrd (emitter_vat_ord) was filled with the vat : "XEXX010101000". The vat "XEXX010101000" is a generic value to be use as vat when and only when the user is not Mexican, and in that case the NomBancoOrdExt must be filled. opw-2363916 opw-2378274 Forward-Port-Of: odoo/enterprise#14693