Friday, December 18, 2020
11 changes · master
Resolved issues and error corrections
Internal users can now more clearly distinguish unpublished events from published ones in the website events list. Unpublished event cards are shown with reduced opacity while keeping the “Unpublished” label prominent, reducing confusion when managing event visibility.
Original PR description
Description of the issue/feature this PR addresses:
In event section, there was no difference between published
and non-published events view(UI). Both published and un-published events looks similar, except
that there is extra tag"Unpublished" with red background, shows that event
is unpublished.
Current behavior before PR:
both publish and non-publish events has same look.
Desired behavior after PR is merged:
Improve the management of non-published things for internal users.
To make different look between that events,
**opacity will apply for each un-published events**. Opacity is applied to
whole unpublished event' UI **except for the tag "Unpublished".**
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prMiscellaneous changes
in a cron run frequently. The cron "calendar.ir_cron_scheduler_alarm", when `calendar_sms` is installed, stores its last run datetime in an `ir.config.parameter`. Since modifying config parameters cleans the cache, the cron clears the cache every 30 minutes, unless modified... As the cache is used to improve global system performance, clearing it frequently should be avoided as much as possible. Since v13, ir.cron records now store their lastcall datetime, there is no need to keep
Original PR description
in a cron run frequently. The cron "calendar.ir_cron_scheduler_alarm", when `calendar_sms` is installed, stores its last run datetime in an `ir.config.parameter`. Since modifying config parameters…
in a cron run frequently. The cron "calendar.ir_cron_scheduler_alarm", when `calendar_sms` is installed, stores its last run datetime in an `ir.config.parameter`. Since modifying config parameters cleans the cache, the cron clears the cache every 30 minutes, unless modified... As the cache is used to improve global system performance, clearing it frequently should be avoided as much as possible. Since v13, ir.cron records now store their lastcall datetime, there is no need to keep the information in a config parameter anymore. This commit uses this lastcall information instead, as it was done for the calendar module: See https://github.com/odoo/odoo/commit/52645a7b43be157be0782674a0f6b38359293f21 Fixes #63354 for 13+ versions. For earlier versions (12.0), it cannot be "fixed" since the lastcall information isn't available (note that the cache clear also happens in the base calendar method in 12.0). -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63549 Forward-Port-Of: odoo/odoo#63439
`t-raw` is too slow due to parsing the HTML in JS, converting it to VDOM and comparing to existing VDOM. Here we can make a custom comparison based on actual string, and directly replace in DOM if needed. Part of task-2399731 Forward-Port-Of: odoo/odoo#63505
Original PR description
`t-raw` is too slow due to parsing the HTML in JS, converting it to VDOM and comparing to existing VDOM. Here we can make a custom comparison based on actual string, and directly replace in DOM if needed. Part of task-2399731 Forward-Port-Of: odoo/odoo#63505
Trying to improve the resources used by the challenge update cron operation. Before this commit some count-based goals and all sum-based goals were computed with one select count or sum per user. After this commit each count or sum based goal is computed in a single select for all users. The goal form now also allows to enable batch mode for sum computations. Other changes include: - adding an index on the challenge_id of goals after verifying the positive impact of such an index on
Original PR description
Trying to improve the resources used by the challenge update cron operation. Before this commit some count-based goals and all sum-based goals were computed with one select count or sum per user. After this commit each count or sum based goal is computed in a single select for all users. The goal form now also allows to enable batch mode for sum computations. Other changes include: - adding an index on the challenge_id of goals after verifying the positive impact of such an index on high volumes on a staging server - introducing additional intermediary commits to allow massive crons to catch up over several attempts. task-internal Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63030
Create a promotion program with the "Minimum Purchase Of" right field left as blank It won't be taken into account in SO when clicking on 'Promotions' When the field is left as blank `rule_minimum_amount_tax_inclusion` value is `False` and thus break the check. opw-2392546 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/sub
Original PR description
Create a promotion program with the "Minimum Purchase Of" right field left as blank It won't be taken into account in SO when clicking on 'Promotions' When the field is left as blank `rule_minimum_amount_tax_inclusion` value is `False` and thus break the check. opw-2392546 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63151
Before this commit the theme tours had no step during the shape or color selection After this commit the theme tours have an additional step during the shape or color selection task-2390579 odoo/design-themes#428 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63534 Forward-Port-Of: odo
Original PR description
Before this commit the theme tours had no step during the shape or color selection After this commit the theme tours have an additional step during the shape or color selection task-2390579 odoo/design-themes#428 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63534 Forward-Port-Of: odoo/odoo#62176
If a POS has more than 5 payment methods, the display is not correct: the list is full width when it should be on left (as long as the screen is large enough). This fix ensures the display is the same as the previous version, see (from v13): https://github.com/odoo/odoo/blob/732ba5ca51e628b9d9a7427acd30d01d83e85068/addons/point_of_sale/static/src/css/pos.css#L1213-L1215 So, if the screen is larger than 768px, the width of the list will be limited to 34% of the display area. OPW-24
Original PR description
If a POS has more than 5 payment methods, the display is not correct: the list is full width when it should be on left (as long as the screen is large enough). This fix ensures the display is the same as the previous version, see (from v13): https://github.com/odoo/odoo/blob/732ba5ca51e628b9d9a7427acd30d01d83e85068/addons/point_of_sale/static/src/css/pos.css#L1213-L1215 So, if the screen is larger than 768px, the width of the list will be limited to 34% of the display area. OPW-2400629 Forward-Port-Of: odoo/odoo#63363
Previously, double clicking an arrow to change the order of images in the image-gallery snippet would cause the loading effect to permanently stay and block the snippet editor completely. This was caused by the fact that when clicking the arrow, the gallery snippet rebuilds itself from scratch. After a snippet option is used (in this case, the reordering arrow), we update the snippet overlay, and destroy snippet-editors whose target is no longer in the DOM. When double clicking, by the ti
Original PR description
Previously, double clicking an arrow to change the order of images in the image-gallery snippet would cause the loading effect to permanently stay and block the snippet editor completely. This was…
Previously, double clicking an arrow to change the order of images in the image-gallery snippet would cause the loading effect to permanently stay and block the snippet editor completely. This was caused by the fact that when clicking the arrow, the gallery snippet rebuilds itself from scratch. After a snippet option is used (in this case, the reordering arrow), we update the snippet overlay, and destroy snippet-editors whose target is no longer in the DOM. When double clicking, by the time we handle the second click, the target of the option has been removed from the DOM, and the widget has been destroyed. However, when we try to apply the option anyway, we trigger_up some events (eg to refresh the public widgets) and wait for the trigger_up to call back. Since the widget is already destroyed, it no longer has a parent and trigger_up fails silently, never calling us back, and blocking the mutex. This commit fixes that by checking whether the widget is destroyed before trying to apply the option, bailing immediately if it is the case, and unlocking the mutex. opw-2394953 Forward-Port-Of: odoo/odoo#63532
Journal entries coming from PoS are based in UTC instead of local time. This commit is an improvement over 23d3856f2a4323097f51254b5e32c517d45bfe66 to add the timezone info opw-2371863 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63026
Original PR description
Journal entries coming from PoS are based in UTC instead of local time. This commit is an improvement over 23d3856f2a4323097f51254b5e32c517d45bfe66 to add the timezone info opw-2371863 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#63026
Since 6ef622772f7, all modal have top property set. But since modals can be set as bottom modal, that top margin will make those go offscreen. Before  After  Forward-Port-Of: odoo/odoo#63407
Original PR description
Since 6ef622772f7, all modal have top property set. But since modals can be set as bottom modal, that top margin will make those go offscreen. Before  After  Forward-Port-Of: odoo/odoo#63407
The `createrepo` Debian package is not available in Ubuntu Focal anymore, this can cause problems on Ubuntu based build systems. In order to solve that once and for all, with this commit the rpm repo is generated from a Docker container. Fixes #63419 Forward-Port-Of: odoo/odoo#63570
Original PR description
The `createrepo` Debian package is not available in Ubuntu Focal anymore, this can cause problems on Ubuntu based build systems. In order to solve that once and for all, with this commit the rpm repo is generated from a Docker container. Fixes #63419 Forward-Port-Of: odoo/odoo#63570