Daily updates from Odoo
Navigate
Branch
Thursday, January 7, 2021
12 changes
Code cleanup and technical improvements
This update reorganizes internal lead conversion and merging code so the official sales APIs are clearer and easier to maintain. It prepares future improvements around sales team membership and lead assignment without changing day-to-day user workflows.
Original PR description
Tools method should be private by default to indicate those are not part of official convert or merge API for leads. Update enterprise addons accordingly. LINKS Task ID-2086889 Community PR odoo/odoo# 48422 Enterprise PR odoo/enterprise# 9499 Upgrade PR odoo/upgrade# 996
Miscellaneous changes
Steps to reproduce the bug: - Let's consider an helpdesk team HT with timesheet enabled - Go to HT and select a ticket T - Click on start and stop and save the timesheet Bug: A traceback was raised due to this commit: https://github.com/odoo/enterprise/commit/faa7cfc2dbb34bed99d4bf5aff7251add157ce70 opw:2426973 Forward-Port-Of: odoo/enterprise#15622
Original PR description
Steps to reproduce the bug: - Let's consider an helpdesk team HT with timesheet enabled - Go to HT and select a ticket T - Click on start and stop and save the timesheet Bug: A traceback was raised due to this commit: https://github.com/odoo/enterprise/commit/faa7cfc2dbb34bed99d4bf5aff7251add157ce70 opw:2426973 Forward-Port-Of: odoo/enterprise#15622
Steps to reproduce the bug: - Let's consider a company C with TaxCloud setup - Create a sale order SO with a customer C - Click on update taxes Bug: Odoo sent the information to TaxCloud without the customer ID. This was a problem, because, if the customer C had an exemption certificate, TaxCloud ignored that, as it couldn't match the ID, it charged the full tax and fees as well. opw:2422962 Forward-Port-Of: odoo/enterprise#15621
Original PR description
Steps to reproduce the bug: - Let's consider a company C with TaxCloud setup - Create a sale order SO with a customer C - Click on update taxes Bug: Odoo sent the information to TaxCloud without the customer ID. This was a problem, because, if the customer C had an exemption certificate, TaxCloud ignored that, as it couldn't match the ID, it charged the full tax and fees as well. opw:2422962 Forward-Port-Of: odoo/enterprise#15621
When the mobile QUnit test suite is ran in debug mode, the test "dialog is closable with backbutton event" throws a "This listener was already registered." error. Since commit 96beff3 the BackButtonEventMixin (via its BackButtonManager) prevents from registering multiple times the same Widget/Components's instance as a listener for the "backbutton" event (available in the mobile app). But it raises a hidden error present in the original implementation of the "backbutton" event suppor
Original PR description
When the mobile QUnit test suite is ran in debug mode, the test "dialog is closable with backbutton event" throws a "This listener was already registered." error. Since commit 96beff3 the BackButtonEventMixin (via its BackButtonManager) prevents from registering multiple times the same Widget/Components's instance as a listener for the "backbutton" event (available in the mobile app). But it raises a hidden error present in the original implementation of the "backbutton" event support for the Dialog widget : the `on_attach_callback` method can be called multiple times due to its call being made in the `opened()` function instead of the internal `_opened` property. This commit fixes it by ensuring that the `on_attach_callback` is called only when the `_opened` promise is resolved and not every time we try to access it via the `opened` function. Forward-Port-Of: odoo/enterprise#15618
What are the steps to reproduce your issue ? 1. Open Helpdesk 2. Edit an existing Helpdesk Team; Enable "Ratings on Tickets" and "Display Rating on Customer Portal". The error occurs whether or not the team has ratings 3. Click Save 4. Click "View this team's rating" What is currently happening ? 500: Internal Server Error What are you expecting to happen ? See the website page Why is this happening ? The view tries to access the elem
Original PR description
What are the steps to reproduce your issue ?
1. Open Helpdesk
2. Edit an existing Helpdesk Team; Enable "Ratings on Tickets" and "Display Rating on Customer Portal".
The error occurs whether or not the team has ratings
3. Click Save
4. Click "View this team's rating"
What is currently happening ?
500: Internal Server Error
What are you expecting to happen ?
See the website page
Why is this happening ?
The view tries to access the element `10` of `stats` but it is undefined in this case
How to fix the bug ?
Change the view to use the three elements specified in the `mail_template_data_project_task`
template and in` action_open_rating`: 1, 3 and 5 instead of 1, 5, and 10
opw-2424071
Forward-Port-Of: odoo/enterprise#15581When we try to get handlers from the DB we use 'get_module_filetree' But if module is loaded only in database, like the module loaded in studio, there aren't filetree. The function return only a 'bool' a so without items. Now we verify if the filetree exist. opw-2424350 Forward-Port-Of: odoo/enterprise#15586
Original PR description
When we try to get handlers from the DB we use 'get_module_filetree' But if module is loaded only in database, like the module loaded in studio, there aren't filetree. The function return only a 'bool' a so without items. Now we verify if the filetree exist. opw-2424350 Forward-Port-Of: odoo/enterprise#15586
Have a first followup level to send mail in auto execute (the default 'First reminder email' will do) Have a list of partners in need of action in the followup menu One of the partner need to have the email field empty (no email) Let the scheduled action 'Account Report Followup; Execute followup' process the followups via scheduler or run manually. No mail will be sent even if all other partners data is correct. This occur because the scheduler action is run in a method which will rai
Original PR description
Have a first followup level to send mail in auto execute (the default 'First reminder email' will do) Have a list of partners in need of action in the followup menu One of the partner need to have the email field empty (no email) Let the scheduled action 'Account Report Followup; Execute followup' process the followups via scheduler or run manually. No mail will be sent even if all other partners data is correct. This occur because the scheduler action is run in a method which will raise on any error, aborting the execution. opw-2379650 Forward-Port-Of: odoo/enterprise#15543
Steps to reproduce the bug: - Let's consider an helpdesk team HT with alias A - Let's consider a portal user PU with email E - Send an email with E to A Bug: Ticket: Reception Acknowledgment was not sent to E PS: In function _notify_compute_recipients, the author of a message cannot be notified without 'mail_notify_author' in the context. opw:2419371 Forward-Port-Of: odoo/enterprise#15575
Original PR description
Steps to reproduce the bug: - Let's consider an helpdesk team HT with alias A - Let's consider a portal user PU with email E - Send an email with E to A Bug: Ticket: Reception Acknowledgment was not sent to E PS: In function _notify_compute_recipients, the author of a message cannot be notified without 'mail_notify_author' in the context. opw:2419371 Forward-Port-Of: odoo/enterprise#15575
Bug === Since e049686592007983fbad6b434acec8af5ecaca2b we added a new module "Event Social Facebook". In d1637e2b799465c9e4165f056721fbf122048f3d the module was removed because Facebook depreciate the endpoint we used. But we forgot to update the permission in Social Facebook itself. Forward-Port-Of: odoo/enterprise#15600
Original PR description
Bug === Since e049686592007983fbad6b434acec8af5ecaca2b we added a new module "Event Social Facebook". In d1637e2b799465c9e4165f056721fbf122048f3d the module was removed because Facebook depreciate the endpoint we used. But we forgot to update the permission in Social Facebook itself. Forward-Port-Of: odoo/enterprise#15600
STEPS: * install social_push_notifications * go to Settings * activate option ``[x] activate Enable push notifications and configure this website's notifications permission request`` * activate second language * open website, switch to the language BEFORE: * the buttons in popup are not translated AFTER: * the buttons in popup are translated WHY: * By default only modules started with "website_" are translated: https://github.com/odoo/odoo/blob/8df6340e58f87eecbc7cff35525448
Original PR description
STEPS: * install social_push_notifications * go to Settings * activate option ``[x] activate Enable push notifications and configure this website's notifications permission request`` * activate second language * open website, switch to the language BEFORE: * the buttons in popup are not translated AFTER: * the buttons in popup are translated WHY: * By default only modules started with "website_" are translated: https://github.com/odoo/odoo/blob/8df6340e58f87eecbc7cff35525448f3eeb78572/addons/website/models/ir_http.py#L232 --- opw-2424008 Forward-Port-Of: odoo/enterprise#15570
When suspense_balance was equal to 0, a ZeroDivisionError was raised. opw:2425452 Forward-Port-Of: odoo/enterprise#15589
Original PR description
When suspense_balance was equal to 0, a ZeroDivisionError was raised. opw:2425452 Forward-Port-Of: odoo/enterprise#15589
…ency When reconciling using the manual reconciliation widget using a foreign currency and adding a writeoff, the generated writeoff journal entry was wrong because the journal items got an invalid amount_currency sign regarding the balance. Indeed, if balance is >= 0 (resp. <=), amount_currency must be >= 0 (resp. <=). Before this commit, having an invoice and a payment with these journal items: | | Account | Amount Curr | Balance | | ------------ | ---------
Original PR description
…ency When reconciling using the manual reconciliation widget using a foreign currency and adding a writeoff, the generated writeoff journal entry was wrong because the journal items got an invalid…
…ency When reconciling using the manual reconciliation widget using a foreign currency and adding a writeoff, the generated writeoff journal entry was wrong because the journal items got an invalid amount_currency sign regarding the balance. Indeed, if balance is >= 0 (resp. <=), amount_currency must be >= 0 (resp. <=). Before this commit, having an invoice and a payment with these journal items: | | Account | Amount Curr | Balance | | ------------ | ------------- | ------------- | ------------- | | Invoice | Receivable | 1000 EUR | 500 USD | | Payment | Receivable | -800 EUR | - 400 USD | Was generating these write-off lines in the manual reconciliation widget: | Account | Amount Curr | Balance | | ------------- | ------------- | ------------- | | Receivable | 200 EUR | 100 USD | <- should be -200 | Write-off | -200 EUR | 100 USD | <- should be 200 Of course, such journal items trigger the sql constraint on account.move.line leading to a UserError returned to the user. task: 2425638 Forward-Port-Of: odoo/enterprise#15541