Odoo Changelog — 2021-02-15

Monday, February 15, 2021

43 changes · master

New Features(1)

New functionality added to Odoo

[MERGE] *: Add support for native JS modules and sourcemaps

Coremasterbasewebbase_importlunchMedium

Odoo now supports writing browser code with modern JavaScript modules while still packaging it for Odoo’s dynamic app system. This improves developer productivity through better editor assistance, easier refactoring, and sourcemaps that keep debugging practical in asset debug mode.

Original PR description

Because of the way Odoo works at its core, we do not know before hand which files will be loaded as an asset in the browser, because it depends on the installed Odoo addons. This is why it is…

Because of the way Odoo works at its core, we do not know before hand
which files will be loaded as an asset in the browser, because it
depends on the installed Odoo addons.  This is why it is historically
difficult to integrate Odoo with standard JS tooling, and this is why
Odoo needs to use a custom javascript module system.

However, there is a way to use native JS modules (and gain all the
benefits from it: IDE autocompletion, ease of refactoring, intellisense,
...): we can write JS as native JS modules, but convert them at runtime
into Odoo custom modules. This is exactly the strategy applied by this
PR.

This has a lot of benefits, but there is a downside: we can no longer
serve statically JS files in debug=assets.  This would be a dealbreaker,
if we did not have sourcemaps.

So, this PR introduces

- support for native JS modules
- add a specific asset controller `/web/assets/`
- generate sourcemaps (for debug=assets mode)

Note that part of the complexity of this work is cause by the debug=assets mode, where we need to have a fixed route for the debug asset bundle (so we do not lose breakpoints when debugging), but we still need to safely regenerate the bundles whenever the JS code is modified.

#javascript#assets#developer-tools#sourcemaps

Improvements(10)

Enhancements to existing features

[IMP] account: Allow tax to not be affected by a previous one

PR #58803

Coremasteraccountaccount_tax_pythonMedium

This update lets accounting teams choose whether a tax should be influenced by taxes calculated before it. This improves support for jurisdictions or business cases where taxes must remain independent from earlier tax amounts, reducing manual workarounds and calculation errors.

Original PR description

task: 2343958

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#taxes#accounting#configuration

Bug Fixes(4)

Resolved issues and error corrections

horizontal scrollbar in for without sheet

PR #63961

Coremasterweb

Forms that do not use a sheet layout now display correctly when they include a button box or notebook section. This removes an unnecessary horizontal scrollbar, improving usability and visual polish without changing business behavior.

Original PR description

PURPOSE
Form without sheet tag and Button Box or Notebook should not have unnecessary horizontal scrollbar.

SPEC
If formview does not have sheet tag and form contains Button Box or Notebook tag then form should be displayed without unncessary horizontal scrollbar.

TASK 2411627



--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#form-view#scrollbar#user-interface

Removals(1)

Features or functions removed from Odoo

[REM] qweb: internal html escaping function

PR #65720

Coremasterbase

An old internal option for skipping HTML escaping in QWeb field formatting has been removed because it is no longer used. This simplifies the underlying page rendering code with minimal expected impact on users or business workflows.

Original PR description

QWeb fields formatting would go to its own `html_escape` function which could skip escaping depending on an option This option is completely unused. This is some proto-html-field thing from the early days (added in 2013) kept alive through the darkest of magics, it's unclear that it's ever been used.

#qweb#cleanup#html-rendering

Other(27)

Miscellaneous changes

[FW][FIX] sale_stock: consider state on qty_at_date widget update

PR #66101

Coremastersale_stock

Original PR description

When adding a line to a new SO, if the delivery date is in the future, and even though the quantity will be sufficient at that time, the symbol of the quantity remains red ("Not available"). To…

When adding a line to a new SO, if the delivery date is in the future,
and even though the quantity will be sufficient at that time, the
symbol of the quantity remains red ("Not available").

To reproduce the error:
1. Create a storable product P
2. Create + Confirm a RfQ
    - Add 1 x P
    - Set the receipt date in the future (e.g., today + 7 days)
    - (! Do not receive the product)
3. Create a SO
    - Add 1 x P
    - (In Other Info) Set the delivery date after the receipt date
(e.g., today + 8 days)
4. Save & Go back to order lines

Error: The chart next to the requested quantity is always red. This is
not true since the delivery is scheduled after the product reception. If
you click on the chart, the forecasted stock on delivery date is 1.
Therefore, the chart should be green.

This fix improves #60054: the latter updates the computation of
`will_be_fulfilled` using `free_qty_today` because there was an issue
when the SO is confirmed. However, the initial widget behaviour was
correct when the SO is not confirmed.

OPW-2440724

Forward-Port-Of: odoo/odoo#65989
Forward-Port-Of: odoo/odoo#65926

Because of the way Odoo works at its core, we do not know before hand which files will be loaded as an asset in the browser, because it depends on the installed Odoo addons. This is why it is historically difficult to integrate Odoo with standard JS tooling, and this is why Odoo needs to use a custom javascript module system. However, there is a way to use native JS modules (and gain all the benefits from it: IDE autocompletion, ease of refactoring, intellisense, ...): we can write JS as native JS modules, but convert them at runtime into Odoo custom modules. This is exactly the strategy applied by this PR. This has a lot of benefits, but there is a downside: we can no longer serve statically JS files in debug=assets. This would be a dealbreaker, if we did not have sourcemaps. So, this PR introduces - support for native JS modules - add a specific asset controller `/web/assets/` - generate sourcemaps (for debug=assets mode) Note that part of the complexity of this work is cause by the debug=assets mode, where we need to have a fixed route for the debug asset bundle (so we do not lose breakpoints when debugging), but we still need to safely regenerate the bundles whenever the JS code is modified.

task: 2343958 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

PURPOSE Form without sheet tag and Button Box or Notebook should not have unnecessary horizontal scrollbar. SPEC If formview does not have sheet tag and form contains Button Box or Notebook tag then form should be displayed without unncessary horizontal scrollbar. TASK 2411627 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

QWeb fields formatting would go to its own `html_escape` function which could skip escaping depending on an option This option is completely unused. This is some proto-html-field thing from the early days (added in 2013) kept alive through the darkest of magics, it's unclear that it's ever been used.

When adding a line to a new SO, if the delivery date is in the future, and even though the quantity will be sufficient at that time, the symbol of the quantity remains red ("Not available"). To reproduce the error: 1. Create a storable product P 2. Create + Confirm a RfQ - Add 1 x P - Set the receipt date in the future (e.g., today + 7 days) - (! Do not receive the product) 3. Create a SO - Add 1 x P - (In Other Info) Set the delivery date after the receipt date (e.g., today + 8 days) 4. Save & Go back to order lines Error: The chart next to the requested quantity is always red. This is not true since the delivery is scheduled after the product reception. If you click on the chart, the forecasted stock on delivery date is 1. Therefore, the chart should be green. This fix improves #60054: the latter updates the computation of `will_be_fulfilled` using `free_qty_today` because there was an issue when the SO is confirmed. However, the initial widget behaviour was correct when the SO is not confirmed. OPW-2440724 Forward-Port-Of: odoo/odoo#65989 Forward-Port-Of: odoo/odoo#65926

When synced, if the user has an event on Microsoft Calendar and if this user is not the organizer (he is only an attendee), he will have to enable "Everybody's calendars" on Odoo Calendar to see this event. To reproduce the error: (Need one Google/Microsoft account A01 and one Microsoft account A02) 1. With A01, on Google/Microsoft calendar, create an event and invite A02 2. On Odoo, enable the sync with Microsoft - See [instructions](https://www.odoo.com/documentation/user/14.0/general/calendars/outlook/outlook_calendar.html) 3. Go to Odoo Calendar, click on "Sync With Outlook" - ! The sync must be done with A02 Error: The event is not displayed. The user must enable "Everybody's calendars" to see it. The problem comes from the attendees creation: it uses Microsoft attendees' email address to link a partner with the event. However, nothing ensures or requires that A02's email address is the same than current partner's one. As a result, it is possible that the current partner is not among the attendees. Moreover, Microsoft does not say which attendee is the synced one. Thus, this fix always adds the current partner to the attendees, so he will no longer need to enable "Everybody's calendars". OPW-2439189 Forward-Port-Of: odoo/odoo#65387

…atement Line with no Partner - Go to Accounting > Configuration > Reconciliation Models - Create a Reconciliation Model: * Type: Suggest counterpart values * Amount Nature: Amount Paid/Received * Label: Contains test * Counterpart Values: [Add a line with "Percentage of balance" as Amount Type and 100 as Amount, for example] - Create a Bank Statement of any amount with "test" as Label and no Partner - Post Bank Statement and Reconcile it Created Bank Statement matches conditions of Reconciliation Model but Counterpart Values are not suggested. No counterpart values are suggested if there is no Partner on Bank Statement During preparation of reconciliation, reconciliation is skipped because an open balance has to be created but no receivable/payable account is retrieved as there is no Partner on Bank Statement. If no Partner is set, receivable/payable account is retrieved from company. opw-2441484 opw-2442491 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#65829

[IMP] payment_sepa_direct_debit: better error message when reusing a res.partner.bank When paying a web order using SEPA Direct Debit, if the IBAN account entered by the user already existed in the database, an error message was displayed to the user, directly telling an account only can belong to one partner ( https://github.com/odoo/odoo/blob/14.0/odoo/addons/base/models/res_bank.py#L92 ) . This was pretty obscure, so we replace it by something more user-friendly. We ask the user to login, as it is very likely the error occurs simply because he already had an account and is recreating it entirely instead of reusing his existing account. [FIX] payment_sepa_direct_debit: only search for an existing mandate on the current company You don't expect a mandate given to company A to be usable for operations of company B. A new mandate must then be created. [FIX] account_batch_payment: fix batch payment validation for reconciled and sent payments Before the payments refactoring, 'sent' and 'reconciled' were states on account.payment. Payments now have an inherits link to an account.move, and are reusing its fields. 'sent' and 'reconciled' states have been replaced by dedicated fields. [FIX] account_sepa_direct_debit, account_sepa: fix filters after payments refactoring Forward-Port-Of: odoo/enterprise#16208

This commit fixes the post-cell-edit glitch issue by updating value in the model state before rpc call. The issue can be described as follow : the edited value disappear during a while when the user has updated a value and is then re-rendered. On large databases, the glitch can last a longer time and is more visible. Previous behaviour : The previous value of the update cell is shown the time between the two rpc calls (adjust_grid, read_group) because the rendering is done just after adjust_grid with editMode not set and the cell value not updated in the model rendered. - User triggers _onUpdateValue by writing a new value (let's say : (new : 42, old : 0)) - The rendering is updated during the call to rpc in the grid_controller.js _adjust method. -> As the state.editMode to render the web_grid.CellValue is false, the rendering is a div with the cell.value user, which is the previous state value : 0. - The rendering is updated once again after the result of read_group => Cell value = new_value : 42. Expected Behaviour : Between the two rpc calls, the editMode is still true, which allows the web_grid.CellValue template to render an input cell with the currentInput value : 42. The user get not troubled by the value changes and the behaviour is more smooth regarding UX. task-2389731 Forward-Port-Of: odoo/enterprise#16006

New Features(1)

[MERGE] *: Add support for native JS modules and sourcemaps

Improvements(10)

[IMP] account: Allow tax to not be affected by a previous one

Bug Fixes(4)

horizontal scrollbar in for without sheet

Removals(1)

[REM] qweb: internal html escaping function

Other(27)

[FW][FIX] sale_stock: consider state on qty_at_date widget update

New Features(1)

[MERGE] *: Add support for native JS modules and sourcemaps

Improvements(10)

[IMP] account: Allow tax to not be affected by a previous one

Bug Fixes(4)

horizontal scrollbar in for without sheet

Removals(1)

[REM] qweb: internal html escaping function

Other(27)

[FW][FIX] sale_stock: consider state on qty_at_date widget update

[IMP] website_membership: privatize method

[IMP] stock: improve product moves report

[IMP] account_edi: merge account_edi_extended

[IMP] sale_timesheet: allow easier xpath expressions

[IMP] web_editor: introduce many2one userValueWidget for reuse

Add customization options for Banner and Cover

[IMP] website: set lead class font-size to match editor value

[IMP] uses the new names web.ActionModel and web.searchPanelModelExtension

[IMP] l10n_pe_edi: changed depency from account_edi_extended to accou…

[FIX] tsconfig: add missing command name attribute

horizontal scrollbar in form without sheet

[FIX] web_studio: renaming menu item should rename the window action

[FW][FIX] microsoft_calendar: add current partner to attendees

[FW][FIX] account: don't return recordset on action_post

[FW][FIX] website_sale : minor ui fixes

[FW][FIX] web: ensure o_status is well displayed

[FW][FIX] crm: repositioning the tour bubble

[FW][REV] account: revert commit 08f3d2b90e3d48daa26ab48872b9cfd4d8db981f

[FW][FIX] purchase: correctly display category and note in portal

[FW][CLA] huakkai signs Odoo's CLA

[FW][FIX] purchase: avoid broken domains

[FW][FIX] account: fix counterpart values of Reconciliation Models for St…

[FW][IMP] l10n_ar: suggest search by company in account invoice report

[FW]Reference field nameGets batched multiEdit (manual ForwardPort)

[FW][FIX] hr_work_entry: Adapt work entry name on modification

[FW][FIX] website: open navbar dropdown to right place

[FW][FIX] calendar: currency in popover fullcalendar V4

[FW][FIX] l10n_ar: fix pre-printed invoice report

[FW][FIX] l10n_pe_edi: avoid problems at module installation

[FW][FIX] l10n_be_hr_payroll: Fix holiday attests

[FW]payment_sepa_direct_debit: improvement and fixes

[FW][FIX] web_studio: Show Invisible Elements Issue

[FW][FIX] l10n_co_reports: report save

[FW][REV] account_reports: revert community commit 08f3d2b90e3d48daa26ab48872b9cfd4d8db981f

[FW][FIX] l10n_co_reports: Certificado de Retención en ICA

[FW][FIX] web_enterprise: ensure o_status is well displayed

[FW]studio edit menu do not respect rtl direction

[FW][FIX] web_grid: fix post-cell-edit glitch