Friday, February 19, 2021
26 changes · master
Enhancements to existing features
CSS files are now bundled with source maps in asset debugging mode, matching the existing approach for JavaScript. This keeps the same troubleshooting experience for developers while greatly reducing server requests and improving page load times during development.
Original PR description
[IMP] base: add sourcemap support for CSS files. Improve the development experience in debug=assets mode by reducing the number of requests to the server. We are adapting the solution used for the JS files to the CSS files. This solution consists of no longer sending all the files separately, but sending only the bundles associated with their sourcemap. This allows us to keep the same debugging experience while drastically reducing the number of requests to the server. Benchmark: saas 14.2 917 requests domcontentloaded after 3.76s master (bundling du js) 299 requests domcontentloaded after 2.03s branch (bundling js+css) 36 requests domcontentloaded after 1.01s Task id : 2463840
The Appraisal app now guides new users through onboarding so they can understand key workflows more quickly. Feedback from employees and managers is automatically published when deadlines pass, and HR users can step in to edit feedback when needed.
Original PR description
1. Create an onboarding tour to help new users understand the app. 2. Automatically publish employee and manager's feedback once the deadline is reached. 3. Admin or HR Officer can force edit the user's feedback. TaskID: 2274970 Co-authored-by: Aurélien (avd) <avd@odoo.com>
Resolved issues and error corrections
This fixes an issue where JavaScript changes were not picked up when using the asset debugging mode without restarting the server. Developers can now refresh the browser and see updated code more reliably, reducing wasted time during troubleshooting and customization work.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Documentation and clarification updates
This pull request adds a contributor's signed Contributor License Agreement record. It supports legal compliance for accepting contributions and has no direct impact on product features or users.
Original PR description
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
- Install sale_timesheet and hr_expense - Create a Service Product with "Create a task in sales order's project" as Service Tracking (i.e. Service X) - Create a Product with "Can be Expensed" and "At cost" as "Re-Invoice Expenses" (i.e. Expense X) - Create a SO with Service X (i.e. Unit Price: 50.0) and confirm it - Go to Expenses and create an Expense: * Product: Expense Y * Unit Price: 25.0 * Customer to Reinvoice: [select the created SO] - Create Report, Approve and Post journal
Original PR description
- Install sale_timesheet and hr_expense - Create a Service Product with "Create a task in sales order's project" as Service Tracking (i.e. Service X) - Create a Product with "Can be Expensed" and "At…
- Install sale_timesheet and hr_expense - Create a Service Product with "Create a task in sales order's project" as Service Tracking (i.e. Service X) - Create a Product with "Can be Expensed" and "At cost" as "Re-Invoice Expenses" (i.e. Expense X) - Create a SO with Service X (i.e. Unit Price: 50.0) and confirm it - Go to Expenses and create an Expense: * Product: Expense Y * Unit Price: 25.0 * Customer to Reinvoice: [select the created SO] - Create Report, Approve and Post journal entries - From SO, create an Invoice (Service Y + Expense Y) and confirm it In Project Overview, the expense is computed in Other Revenues and Re-invoiced costs. Therefore, the amount of the expense is added twice in the Profitability total. In Project > Reporting > Project Costs and Revenues, for Project linked to SO, Untaxed Amount Invoiced and Untaxed Amount Re-Invoiced are also computed in Other Revenues. opw-2444237 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66186
This update corrects spelling mistakes in Odoo documentation and a few core messages, making guidance and user-facing text clearer and more professional. It also records an individual contributor license agreement signature related to the change.
Original PR description
Found via `codespell` Note: I hereby relinquish any ownership of this PR an the fixes within. Please cherrypick this commit. I need no attributions associated with odoo.
Odoo now lets its image tools load every image format supported by the underlying image library, instead of only a small preset list. This helps customers and partners work with formats such as WebP without extra workarounds.
Original PR description
Description of the issue/feature this PR addresses: I'm developing an addon which uses the PIL library to convert images in the WebP format but the current implementation restricts PIL from preloading all the available formats. Current behavior before PR: PIL is initialized with only a few formats (BMP, GIF, PNG, JPEG, TIFF and PPM) Desired behavior after PR is merged: PIL preloads all the supported formats of the library -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#66439
Original PR description
Forward-Port-Of: odoo/odoo#66439
When genrating an attachment in a mail message (e.g. the pdf attached to a confirmation email), the filename was not translated into the language of the recipient (unlink the email content). The variable `template` has the contact language in the context while `self` contains the language of the user executing the action. Fixes odoo/odoo#66420 Forward-Port-Of: odoo/odoo#66441
Original PR description
When genrating an attachment in a mail message (e.g. the pdf attached to a confirmation email), the filename was not translated into the language of the recipient (unlink the email content). The variable `template` has the contact language in the context while `self` contains the language of the user executing the action. Fixes odoo/odoo#66420 Forward-Port-Of: odoo/odoo#66441
Scenario: - start cropping of an image - press TAB key - do CTRL + Z => now the image cropping tool are inside the page and there is no way to remove them. Why: The image crop tool was added inside the editable elemnt, so if we did an action that changed history the cropping tools are saved in the snapshot and going back to it will add them without any code handling their removal. opw-2394877 opw-2423445 Forward-Port-Of: odoo/odoo#66462
Original PR description
Scenario: - start cropping of an image - press TAB key - do CTRL + Z => now the image cropping tool are inside the page and there is no way to remove them. Why: The image crop tool was added inside the editable elemnt, so if we did an action that changed history the cropping tools are saved in the snapshot and going back to it will add them without any code handling their removal. opw-2394877 opw-2423445 Forward-Port-Of: odoo/odoo#66462
Adapt [1] to be a bit more robust. [1]: https://github.com/odoo/odoo/commit/eb9373522628fa01c3503fa802ded23adc1cbe1f Forward-Port-Of: odoo/odoo#66501
Original PR description
Adapt [1] to be a bit more robust. [1]: https://github.com/odoo/odoo/commit/eb9373522628fa01c3503fa802ded23adc1cbe1f Forward-Port-Of: odoo/odoo#66501
For odoo-master Transifex project, no demo data Forward-Port-Of: odoo/odoo#66472
Original PR description
For odoo-master Transifex project, no demo data Forward-Port-Of: odoo/odoo#66472
The function was wrongly imported and used, and it was hidden by a generic catching of all exceptions. The return value and some legit exceptions were also badly handled: * The return value was always thruthy as it returns an object containing information about the check. * Exceptions can be raised if the format is not correct. In that case, we don't want to go to the simple vat check. Fixes #64897 opw-[2451951](https://www.odoo.com/web#id=2451951&model=project.task&view_type=form&cids
Original PR description
The function was wrongly imported and used, and it was hidden by a generic catching of all exceptions. The return value and some legit exceptions were also badly handled: * The return value was always thruthy as it returns an object containing information about the check. * Exceptions can be raised if the format is not correct. In that case, we don't want to go to the simple vat check. Fixes #64897 opw-[2451951](https://www.odoo.com/web#id=2451951&model=project.task&view_type=form&cids=1&menu_id=) -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66155 Forward-Port-Of: odoo/odoo#65771
Were not removed when the module was removed (bad forward port?) Forward-Port-Of: odoo/odoo#66519
Original PR description
Were not removed when the module was removed (bad forward port?) Forward-Port-Of: odoo/odoo#66519
Forward-Port-Of: odoo/odoo#66461
Original PR description
Forward-Port-Of: odoo/odoo#66461
Go to Website Go to conatct us form Switch in Edit mode Click on “send” (or "submit") click on edit link A js traceback will apper. This occur because we refocus an elements which may not be the correct one. In this case $editable will contain all the contact form instead of just the relevant div of the submit button opw-2439090 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have
Original PR description
Go to Website Go to conatct us form Switch in Edit mode Click on “send” (or "submit") click on edit link A js traceback will apper. This occur because we refocus an elements which may not be the correct one. In this case $editable will contain all the contact form instead of just the relevant div of the submit button opw-2439090 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66081
Description of the issue/feature this PR addresses: Fixes the display of the quotation amount in the sales teams pipeline overview kanban. Current behavior before PR: The quotation amount is overflowing the kanban card. Desired behavior after PR is merged: The quotation amount is truncated to prevent overflowing the kanban card.  -- I confirm I have signed the CLA and rea
Original PR description
Description of the issue/feature this PR addresses: Fixes the display of the quotation amount in the sales teams pipeline overview kanban. Current behavior before PR: The quotation amount is overflowing the kanban card. Desired behavior after PR is merged: The quotation amount is truncated to prevent overflowing the kanban card.  -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66254
The support for "active_test" context key has been introduced in the mock server with c2918c1 However, the context key is ignored in many mocked ORM methods (if not all). This commit adds support for the `search` and `search_read` methods. Note: this is done to easily write some tests in odoo/enterprise#16363 and it might be usefull to test futures features (or fixes) using this context key. Description of the issue/feature this PR addresses: Current behavior before PR: Desired
Original PR description
The support for "active_test" context key has been introduced in the mock server with c2918c1 However, the context key is ignored in many mocked ORM methods (if not all). This commit adds support for the `search` and `search_read` methods. Note: this is done to easily write some tests in odoo/enterprise#16363 and it might be usefull to test futures features (or fixes) using this context key. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66190
Issue - Install "Accounting" module - Create a new bill : - Set vendor - Set no payment reference - Set a bill reference - Add products to bill - Confirm and click on Register Payment Memo field has no value. Cause The memo field is based on lines name. Lines name is computed in `_onchange_payment_reference` and depends only on payment_referecence. Solution If no `payment_reference`, fallback on `ref` to set line name. opw-2440389 co-author: nboulif <b
Original PR description
Issue - Install "Accounting" module - Create a new bill : - Set vendor - Set no payment reference - Set a bill reference - Add products to bill - Confirm and click on Register Payment Memo field has no value. Cause The memo field is based on lines name. Lines name is computed in `_onchange_payment_reference` and depends only on payment_referecence. Solution If no `payment_reference`, fallback on `ref` to set line name. opw-2440389 co-author: nboulif <bon@odoo.com> -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66158 Forward-Port-Of: odoo/odoo#66032
Scenario: - start editing background position - press TAB key - press CTRL + Z => traceback Why: Restoring a snapshot with CTRL Z can send a click event with target not wrapped in a jQuery object which was not expected by the code. reported in https://github.com/odoo/odoo/pull/66462#issuecomment-782025417 opw-2423445 Forward-Port-Of: odoo/odoo#66540
Original PR description
Scenario: - start editing background position - press TAB key - press CTRL + Z => traceback Why: Restoring a snapshot with CTRL Z can send a click event with target not wrapped in a jQuery object which was not expected by the code. reported in https://github.com/odoo/odoo/pull/66462#issuecomment-782025417 opw-2423445 Forward-Port-Of: odoo/odoo#66540
Forward-Port-Of: odoo/odoo#66552 Forward-Port-Of: odoo/odoo#65875
Original PR description
Forward-Port-Of: odoo/odoo#66552 Forward-Port-Of: odoo/odoo#65875
If you print 5 payslip reports, you will print each payslip 5 times. Also because of the structure (several web.html_container inside one web.html_container) the edition in studio doesn't work. opw-2423574 Forward-Port-Of: odoo/enterprise#16515 Forward-Port-Of: odoo/enterprise#16495
Original PR description
If you print 5 payslip reports, you will print each payslip 5 times. Also because of the structure (several web.html_container inside one web.html_container) the edition in studio doesn't work. opw-2423574 Forward-Port-Of: odoo/enterprise#16515 Forward-Port-Of: odoo/enterprise#16495
In the pivot view, group projects by customer. Even if a customer is archived, it will appear in the pivot view since the project itself is not archived. When this pivot is inserted in a spreadsheet, the group with this customer won't appear because we perfom a distinct `search_read` to order groups (based on group values). If we group by a relational field, we must ensure we retrieve the record, event if it's archived. opw 2454906 Forward-Port-Of: odoo/enterprise#16363
Original PR description
In the pivot view, group projects by customer. Even if a customer is archived, it will appear in the pivot view since the project itself is not archived. When this pivot is inserted in a spreadsheet, the group with this customer won't appear because we perfom a distinct `search_read` to order groups (based on group values). If we group by a relational field, we must ensure we retrieve the record, event if it's archived. opw 2454906 Forward-Port-Of: odoo/enterprise#16363
…ge change Steps to reproduce: - Insert a pivot in a spreadsheet - Create a global filter with 'month' as time range and a default value of 'this_month' - Edit this filter and set the time range as 'year'. - Close - Open the spreadsheet => traceback opw-2459763 Forward-Port-Of: odoo/enterprise#16525
Original PR description
…ge change Steps to reproduce: - Insert a pivot in a spreadsheet - Create a global filter with 'month' as time range and a default value of 'this_month' - Edit this filter and set the time range as 'year'. - Close - Open the spreadsheet => traceback opw-2459763 Forward-Port-Of: odoo/enterprise#16525
For odoo-master Transifex project, no demo data Enterprise part of odoo/odoo#66472 Forward-Port-Of: odoo/enterprise#16489
Original PR description
For odoo-master Transifex project, no demo data Enterprise part of odoo/odoo#66472 Forward-Port-Of: odoo/enterprise#16489
Issue - Change date_format of the current language. - Install "Sign" module - Upload a pdf to sign and add a "Date" item - Click on "Sign Document" - Click on the "Date" item Default date have 'MM/DD/YYYY' format instead of the user language date_format preferences. Same issue in kanban view with 'create_date' field. Cause Dates are formated with 'L' format. Solution Format date using user language date_format preferences. opw-2449315 Forward-Port-Of: odoo/e
Original PR description
Issue - Change date_format of the current language. - Install "Sign" module - Upload a pdf to sign and add a "Date" item - Click on "Sign Document" - Click on the "Date" item Default date have 'MM/DD/YYYY' format instead of the user language date_format preferences. Same issue in kanban view with 'create_date' field. Cause Dates are formated with 'L' format. Solution Format date using user language date_format preferences. opw-2449315 Forward-Port-Of: odoo/enterprise#16434