Tuesday, March 2, 2021
23 changes · master
Enhancements to existing features
The “Select Quantity” customization setting now applies consistently across the online store. When disabled, customers can no longer change quantities on the product page, in the cart, or in the product configuration pop-up, reducing confusion and ensuring store settings behave as expected.
Original PR description
Purpose of this commit is, To make the customize option "Select Quantity" work. So far, it's only disabled from the product page. If you disabled it, it's still active on the cart and on the product config modal. After this commit, If the user decide to disable the "Select Quantity", disable it everywhere (cart, product config modal, product itself) task- 2008472
Accounting code ownership checks are disabled on the main development branch to reduce unnecessary review notifications. They remain active in stable versions and will be restored during each release freeze, so day-to-day business functionality is not affected.
Original PR description
We keep the codeownership in stable versions but disable it in master to reduce the spam. Will be added back at each freeze. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Duplicating a mailing list now keeps each contact’s opt-out status, helping prevent people who unsubscribed from being re-added to copied campaigns. The update also makes unsubscribe dates and copied list names more consistent, reducing accidental mailing mistakes.
Original PR description
…t duplication before this commit, on duplication, the contacts who opted-out from the original list have the opt-out field set to False on the duplicated list. after this commit,on duplication, for a contact who has opted-out from the original list,the opt-out field will be set to True on the duplicated list, because, when a recepient opt-out from a mailing list, chances are high that he does not want to be included in the new duplicated list. Task-2431383 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The messaging dropdown in the top menu now adapts its height to the user's screen, allowing more chat conversations to be visible at once. This reduces scrolling and makes it easier for users to review recent messages quickly.
Original PR description
**PURPOSE** The goal of this task to increase the height of the systray message dropdown to simply allow more messages to be displayed at once for better readability. **SPECIFICATION** We have changed the height of the dropdown menu based on the view port. **Task : 2428779**
The contact merge wizard now shows each contact's database ID next to its name in the destination contact field. This helps users distinguish between contacts with identical names and choose the correct record when merging.
Original PR description
PURPOSE if we are merging multiple contacts with the same name, the destination contact field might be confusing as it just says the name and does not include the id, or other identifier to make it clear the exact contact you are setting as the destination. SPECIFICATIONS so in this commit we will add the partner ids along with its name in destination contact field which will avoid the confusion while merging contacts. LINKS PR #66026 Task 2323060
Financial reports now handle column widths and shortened text more reliably, making long labels easier to read without manual tooltip setup. The update also improves dropdown alignment, column spacing, and removes duplicate or redundant display elements for a cleaner reporting experience.
Original PR description
Better management of the width of columns with ellispis in the reports. To do that, we: * add a div with computed width but 0 height to allow the browser estimate the best width for each column, evn though it can't deduce it from the displayed span/div with an ellipsis * remove the tooltips, and show the full div instead. This removes the need for the dev to manage that, and the risk of errors * Display the carret of dropdown menus correctly on the right of the title again * Correctly use the colspan parameter again Also related misc improvements: * Remove the entry's name from the description when it is displayed in another column * Remove duplicated link to css sheets * Correct unfoldable title row level/margin because of overlap with the carret * Display the margins of columns with gray background Task [2389670](https://www.odoo.com/web#id=2389670&action=333&active_id=967&model=project.task&view_type=form&cids=1&menu_id=4720)
Resolved issues and error corrections
This fix makes error details generated in Firefox easier for Odoo to read and display correctly. It helps support and technical teams diagnose template-related issues more reliably without changing normal user workflows.
Original PR description
In Firefox, the error stack generated by anonymous code (example: erroneous code in a template) is not compatible with the stacktrace lib. The error stack could contain lines like : "anonymous…
In Firefox, the error stack generated by anonymous code (example:
erroneous code in a template) is not compatible with the stacktrace lib.
The error stack could contain lines like :
"anonymous web.assets_common.js line 9786 > Function:442".
In order to make it usable by the stacktrace lib, we will remove
the words "lines", ">", "Function:442" to get:
"anonymous owl.js:1695".
Traceback:
Before:
Error: QWeb error: Invalid loop expression
anonymous web.assets_common.js line 9786 > Function:442
fn owl.js:1567
render owl.js:1617
renderFn owl.js:4595
__render owl.js:4391
__prepareAndRender owl.js:4379
__prepare owl.js:4325
anonymous web.assets_common.js line 9786 > Function:175
...
After:
Error: QWeb error: Invalid loop expression
anonymous owl.js:1695
fn owl.js:1567
render owl.js:1617
renderFn owl.js:4595
__render owl.js:4391
__prepareAndRender owl.js:4379
__prepare owl.js:4325
anonymous owl.js:1695
...Miscellaneous changes
Since this old commit 735924878f8, the files that are packaged are chosen by a list of allowed extensions. This list have to be maintained each time that a developer adds a new kind of file in a module. This is error prone [0] as most developer are not aware of that and it's difficult to monitor. Moreover, there is no reason to have a different list of installed files when one install from the git repo instead of the source package. With this commit, all odoo sources files are include
Original PR description
Since this old commit 735924878f8, the files that are packaged are chosen by a list of allowed extensions. This list have to be maintained each time that a developer adds a new kind of file in a module. This is error prone [0] as most developer are not aware of that and it's difficult to monitor. Moreover, there is no reason to have a different list of installed files when one install from the git repo instead of the source package. With this commit, all odoo sources files are included in the source packaging and the only thing to maintain is a small black-list of file extensions like for Python bytecode files and for version control files. [0] see commit d33c05b62a9c6 that fix `.json` missing files. Forward-Port-Of: odoo/odoo#66996
This fix improves how error details are shown when developers investigate problems in debug assets mode. Failed background actions now keep the original error information, making issues easier to diagnose and resolve faster.
Original PR description
A previous commit (934e0896160272542dd00) modified QUnit to make sure we can display better tracebacks in debug=assets mode. However, this commit did not apply to errors coming from failing promises. To fix this, we can simply keep a reference to the error in that specific case. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes a problem where error reporting could get stuck in a repeated failure loop on non-Chrome browsers. This helps keep the web interface stable when errors occur, instead of potentially causing the browser to crash.
Original PR description
The formatTraceback function relies on _t to add the error message to tracebacks, it was recently moved around while refactoring but it seems that its dependency was forgotten and not imported. This causes the attempt to call _t to crash, which will try to format the error, which will again try to call _t and crash, until the browser itself crashes. This commit fixes that issue by adding the required import.
Cf commit messages, courtesy of Erwin van der Ploeg Forward-Port-Of: odoo/odoo#66940 Forward-Port-Of: odoo/odoo#66790
Original PR description
Cf commit messages, courtesy of Erwin van der Ploeg Forward-Port-Of: odoo/odoo#66940 Forward-Port-Of: odoo/odoo#66790
The field partner_id on model payment.transaction is not required So in some cases if the field partner_id was not in the values It raised a traceback. opw:2467971 Forward-Port-Of: odoo/odoo#66980
Original PR description
The field partner_id on model payment.transaction is not required So in some cases if the field partner_id was not in the values It raised a traceback. opw:2467971 Forward-Port-Of: odoo/odoo#66980
Since 14.0, 'currency_id' and 'amount_currency' should always be filled when creating account.move.lines. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67023
Original PR description
Since 14.0, 'currency_id' and 'amount_currency' should always be filled when creating account.move.lines. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67023
Tests are crashing when the number of months between the data date and today is higher than 18 months due to the 'past_months_limit' field on account.reconcile.model. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67033
Original PR description
Tests are crashing when the number of months between the data date and today is higher than 18 months due to the 'past_months_limit' field on account.reconcile.model. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67033
**Description of the issue/feature this PR addresses:** The condition on computation of `l10n_ch_isr_number_spaced` was not in line anymore with `l10n_ch_isr_number` computation. With fixes on the ISR number the use of `l10n_ch_isr_postal` is rightly not mandatory anymore. This lead to an empty field, visible on the ISR report. **Current behavior before PR:** On the print of the ISR, Reference is empty.  **Desired behavior after PR is merged:** On the print of the ISR, Reference is shown.  -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66921 Forward-Port-Of: odoo/odoo#66854
**PURPOSE** When we search for a name in the chat window having a very long name of the user will overflowing the screen. The autocomplete dropdown list is overflowing and rendering out of the screen. **SPECIFICATION** we have resized the width of autocomplete dropdown list with the width of the outer element's width as it's standard behavior. **Task : 2449115** Forward-Port-Of: odoo/odoo#66238
Original PR description
**PURPOSE** When we search for a name in the chat window having a very long name of the user will overflowing the screen. The autocomplete dropdown list is overflowing and rendering out of the screen. **SPECIFICATION** we have resized the width of autocomplete dropdown list with the width of the outer element's width as it's standard behavior. **Task : 2449115** Forward-Port-Of: odoo/odoo#66238
Previously, when we find out subcontracted productions of moves, we get all production_id from the origin moves of the moves. When user use multple steps manufacturing, moves may also have their move_orig_ids. In this case, we will consider its production_id as subcontracted production. To fix, we filered the moves, consider only move that is_subcontract is true. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67
Original PR description
Previously, when we find out subcontracted productions of moves, we get all production_id from the origin moves of the moves. When user use multple steps manufacturing, moves may also have their move_orig_ids. In this case, we will consider its production_id as subcontracted production. To fix, we filered the moves, consider only move that is_subcontract is true. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67066
Problem ------- Since https://github.com/odoo/odoo/commit/d3b18979bfb5496fa4370fdf03a806c469127730, when a visitor register for an event, the fields in the POST are checked against a list of allowed fields. The list is hardcoded inside the method _process_attendees_form. Solution -------- Move this list in a specific method that can be easily overidden by another module -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-O
Original PR description
Problem ------- Since https://github.com/odoo/odoo/commit/d3b18979bfb5496fa4370fdf03a806c469127730, when a visitor register for an event, the fields in the POST are checked against a list of allowed fields. The list is hardcoded inside the method _process_attendees_form. Solution -------- Move this list in a specific method that can be easily overidden by another module -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#66757
The `clicks_ratio` field was computed outside of its compute method, this is illegale as the ORM cannot protect the field from being included in the "towrite" structure. Backport of 7acc035 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67062 Forward-Port-Of: odoo/odoo#67043
Original PR description
The `clicks_ratio` field was computed outside of its compute method, this is illegale as the ORM cannot protect the field from being included in the "towrite" structure. Backport of 7acc035 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67062 Forward-Port-Of: odoo/odoo#67043
This is used in mail and sale_timesheet but wasn't an openerp-web translation there. Similar to 5caa0f0cc2c9025bef Courtesy of Erwin van der Ploeg Forward-Port-Of: odoo/odoo#67096
Original PR description
This is used in mail and sale_timesheet but wasn't an openerp-web translation there. Similar to 5caa0f0cc2c9025bef Courtesy of Erwin van der Ploeg Forward-Port-Of: odoo/odoo#67096
When a floating value is entered in the integer field in the customize your salary, it will be given a warning message. STEPS: * fill salary simulator form with float value in integer field * submit AFTER: show error TaskID: 2410285 Forward-Port-Of: odoo/enterprise#15797
Original PR description
When a floating value is entered in the integer field in the customize your salary, it will be given a warning message. STEPS: * fill salary simulator form with float value in integer field * submit AFTER: show error TaskID: 2410285 Forward-Port-Of: odoo/enterprise#15797
Go to Inventory>Configuration>Operations Types Select the `<Current Company>`: Receipts - Uncheck Create New Lots/Serial Numbers - Uncheck Use Existing Lots/Serial Numbers - Check Show Detailed Operations - Check Pre-fill Detailed Operations Add a barcode on a [DEMO] prod, tracked by SN Create a purchase order for [DEMO], confirm Open barcode app to receive the product Scan the barcode. The system will prompt the user to 'Scan the serial or lot number of the product' Even
Original PR description
Go to Inventory>Configuration>Operations Types Select the `<Current Company>`: Receipts - Uncheck Create New Lots/Serial Numbers - Uncheck Use Existing Lots/Serial Numbers - Check Show Detailed Operations - Check Pre-fill Detailed Operations Add a barcode on a [DEMO] prod, tracked by SN Create a purchase order for [DEMO], confirm Open barcode app to receive the product Scan the barcode. The system will prompt the user to 'Scan the serial or lot number of the product' Even if creating serial numbers was disabled opw-2423146 Forward-Port-Of: odoo/enterprise#16384 Forward-Port-Of: odoo/enterprise#15850
Cf commit messages, courtesy of Erwin van der Ploeg Forward-Port-Of: odoo/enterprise#16723 Forward-Port-Of: odoo/enterprise#16663
Original PR description
Cf commit messages, courtesy of Erwin van der Ploeg Forward-Port-Of: odoo/enterprise#16723 Forward-Port-Of: odoo/enterprise#16663