Daily updates from Odoo
Navigate
Branch
Thursday, March 18, 2021
6 changes
Code cleanup and technical improvements
The Appointments module has been reorganized internally by splitting large model, view, template, data, and asset files into clearer dedicated files. This does not change how users schedule or manage appointments today, but it makes future improvements easier and safer to deliver.
Original PR description
PURPOSE Purpose of this merge is to prepare website_calendar (Appointments) future improvements by cleaning its structure and organization. SPECIFICATIONS Split models into separate python files, split views according to their main model. Split templates by main use to avoid having large files holding hundreds of QWeb lines. Correctly organize data and assets. Functionally this merge should not change anything as it contains only code move. See sub commits for more details. LINKS Prepares Task ID-2190526 (overhaul) Prepares Task ID-2223519 (improve communication) Prepares Task ID-2287846 (easier scheduling) ENT PR odoo/enterprise#17168
Miscellaneous changes
A bug was introduced in the following PR: https://github.com/odoo/enterprise/pull/16020 where we tried to fix the display when we use "Group By" in the Helpdesk Overview. But on mobile, users weren't able to click on "Tickets" From the dashboard... To fix this we now use the right property: "sticky". opw-2479945 closes odoo/enterprise#17111 X-original-commit: 52061cf20f2f760df5dbeabaa51c7203d08aa5f7 Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com> Signed-of
Original PR description
A bug was introduced in the following PR: https://github.com/odoo/enterprise/pull/16020 where we tried to fix the display when we use "Group By" in the Helpdesk Overview. But on mobile, users weren't able to click on "Tickets" From the dashboard... To fix this we now use the right property: "sticky". opw-2479945 closes odoo/enterprise#17111 X-original-commit: 52061cf20f2f760df5dbeabaa51c7203d08aa5f7 Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com> Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com> Forward-Port-Of: odoo/enterprise#17162
Main = [FIX] l10n_mx_reports: Closing Journal Entry must be excluded from selected range in l10n_mx Standard Trial Balance. OPW = * 2451608 * 2475942 Explanation = Trial balance must avoid journal items from closing moves in the selected period. Wrapper will allow l10n_mx to leverage on `account.report.coa` without resorting to lengthy modification. This will allow to ask all the accounts from: - The beginning of the fy, excluding all the Journal
Original PR description
Main = [FIX] l10n_mx_reports: Closing Journal Entry must be excluded from selected range in l10n_mx Standard Trial Balance. OPW = * 2451608 * 2475942 Explanation = Trial balance must avoid journal…
Main
=
[FIX] l10n_mx_reports: Closing Journal Entry must be excluded from selected range in l10n_mx Standard Trial Balance.
OPW
=
* 2451608
* 2475942
Explanation
=
Trial balance must avoid journal items from closing moves in the
selected period.
Wrapper will allow l10n_mx to leverage on `account.report.coa`
without resorting to lengthy modification. This will allow to ask all
the accounts from:
- The beginning of the fy, excluding all the Journal Items with a
Journal Entry set as `Closing Move` within the range selected by the
user. Closing Move should not be displayed in the `l10n_mx Trial
Balance`. Only in `13th Month Trial Balance`.
- The beginning of times up to the last_date of previous fiscal-year
selected by the user. Including the Closing Move as them will avoid
`Unaffected Earnings` from building up if Closing Moves are present,
and will build up if not present.
Initial Settings
=
Let us have the following Journal Entries as depicted below:
<img width="1006" alt="Screen Shot 2021-02-01 at 23 17 57" src="https://user-images.githubusercontent.com/7598010/106556065-62552380-64e4-11eb-9166-ea2d501a939b.png">
Current Behavior
=
* 2019
* 2020
* 2021
Expected Behavior
=
* 2019
* 2020
* 2021
Analysis
=
As we can see in the `2021` and `2020` Reports the current behavior provides reports that are unbalanced, because the current_years_earnings account is being miscomputed. And the closing values from the `2020` is being placed in the values for the `2021`. This is happening when the previous fiscalyear has a closing move in it. We can check that `2019` does not show this behavior because there is no previous fiscalyear to that one. After fixing this bug with this PR we can assert that the values for all the initial balances and values for the periods selected are correct. And the Trial Balances for each year are balanced.
Forward-Port-Of: odoo/enterprise#16993
Forward-Port-Of: odoo/enterprise#16066We saw that the balance sheet had not been updated and checked for a long time and a lot of accounts were missing. Here we completely revise the balance sheet fr balance sheet. Forward-Port-Of: odoo/enterprise#17051
Original PR description
We saw that the balance sheet had not been updated and checked for a long time and a lot of accounts were missing. Here we completely revise the balance sheet fr balance sheet. Forward-Port-Of: odoo/enterprise#17051
Before this commit, many2one fields tried to open an autocomplete popup when quick editing instead of a modal. Forward-Port-Of: odoo/enterprise#17124
Original PR description
Before this commit, many2one fields tried to open an autocomplete popup when quick editing instead of a modal. Forward-Port-Of: odoo/enterprise#17124
…mparison The default date inside the simulated Form is stored as a string whereas the lock date is stored as a datetime.date. This resulted in a traceback when trying to compare them. Converting the default date to a datetime.date solves the issue. opw #2485263 Forward-Port-Of: odoo/enterprise#17109
Original PR description
…mparison The default date inside the simulated Form is stored as a string whereas the lock date is stored as a datetime.date. This resulted in a traceback when trying to compare them. Converting the default date to a datetime.date solves the issue. opw #2485263 Forward-Port-Of: odoo/enterprise#17109