Odoo Changelog — 2021-03-19

Friday, March 19, 2021

14 changes · master

Improvements(3)

Enhancements to existing features

[IMP] web: tune cond. to render optional col dropdown

Coremasterweb

This update lets Odoo better decide when to show the optional column dropdown in list views. It gives implementers more control over the interface, helping keep screens cleaner and more relevant for users.

Original PR description

This commit aims to allow ones to customize the condition whether the
optional column dropdown should be rendered or not.

PR enterprise : odoo/enterprise#15205
task-2392303

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#list views#optional columns#user interface

[IMP] tools: simplify and modernize file_open()

PR #68043

CoremasterbaseMedium

This update simplifies how Odoo opens internal files by removing outdated options and old zip-module support. It also adds controls to limit which file types can be opened, reducing the risk of exposing unintended addon files.

Original PR description

- Remove legacy arguments (`subdir`, `pathinfo`) of `file_open()`,
  they were not used anymore and made the code more complicated

- Add the possibility to filter allowed file extensions, in order to
  avoid opening up access to arbitrary addons files, such as .py files,
  depending on the context of use

- Drop the long-deprecated support for files inside zip archives,
  considering that zipped modules were discontinued a long time ago:
  278ed718e9805edf088642ba10d3b7c4e5716c31

- Remove the redundant `_file_open()` method, that should never have been
  called directly anyway

- Split up the verification of the file path, to make it accessible
  without actually opening the file, as a separate `file_path()` function.


-------

### TODO

- [x] update the tests

#file-access#security-hardening#maintenance

[IMP] web_enterprise : 'add custom field' in optional fields dropdown

PR #15205

Enterprisemasterweb_enterpriseweb_studioMedium

Users can now find an Add Custom Field option directly in the optional columns menu of list views. This makes Odoo Studio easier to discover and lets administrators install or open Studio from the same workflow when they want to customize lists.

Original PR description

This PR aims to add a button which opens studio from the optional
column dropdown menu.

The goal is to let the user now he can add custom fields to a listview with Odoo Studio,
and to promote Odoo Studio when not installed.

If studio is not yet installed, this button opens a dialog which
promotes studio with the studio youtube video. System admin can choose
to install studio directly by clicking the Install Studio button.

By clicking on this button, studio will be installed, a value will be
set in the localStorage and the page will be reloaded. The purpose of
the value set in the localStorage is to open the page in studio mode
directly after page reload and to mimify the user experience described
here after.

When Studio is installed, the buttons only toggle studio mode as the
systray button do.

PR community : odoo/odoo#66979

task-2392303

#studio#custom fields#list views#optional columns

Bug Fixes(2)

Resolved issues and error corrections

[FIX] web: correctly set current_company_id in BasicModel

PR #68025

CoremasterwebMedium

This fixes an issue where Odoo could use the wrong active company in web views for users with access to multiple companies. It helps ensure multi-company users see and work with data under the correct company, and adds safeguards to prevent the issue from returning.

Original PR description

This commit fix a bug introduced in #66551 where a mismatch has been done between
session.user_context.allowed_company_ids and session.user_companies.allowed_companies.

This commit also adds the following tests:

- a JS test in order to prevent future unwanted issues regarding multi company
  in BasicModel.
- a Python test in order to ensure that session_info['user_companies'] is not
  involuntarily changed.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#multi-company

Other(9)

Miscellaneous changes

[FW]web_editor: fix selector exclusion rule

PR #68093

Coremasterweb_editor

Original PR description

The current rules would allow through a selector of the form

    :not(sel1, sel2)

then because the matcher thing just splits on `,` it would store the
incorrect sections

    :not sel1(

and

    sel2)

as separate selectors in the rules cache, raising an exception when
matching against elements.

Move all the rules to a single regex, and add a rule to exclude any
situation where a comma or an open parenthesis is inside of an open
parenthesis pair.

Although maybe this should straight up just exclude any rule containing a pseudo-class and pseudo-element? There's no real explanation and it's all part of a big commit, but it tries to exclude all pseudo-elements (::) except it only excludes *some* of the legacy ones (:before and :after, but not :first-letter) and the pseudo-class exclusion also seems somewhat arbitrary e.g. why :active but not :focus?

Is the intent there to exclude rules which can never match because they're "live" rules? (in that case the exclusion I add is not really correct, but that means this thing needs a much more advanced rules parsing in order to handle the case of a multi-parameter `:not`).

Forward-Port-Of: odoo/odoo#68050

This commit aims to allow ones to customize the condition whether the optional column dropdown should be rendered or not. PR enterprise : odoo/enterprise#15205 task-2392303 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

- Remove legacy arguments (`subdir`, `pathinfo`) of `file_open()`, they were not used anymore and made the code more complicated - Add the possibility to filter allowed file extensions, in order to avoid opening up access to arbitrary addons files, such as .py files, depending on the context of use - Drop the long-deprecated support for files inside zip archives, considering that zipped modules were discontinued a long time ago: 278ed718e9805edf088642ba10d3b7c4e5716c31 - Remove the redundant `_file_open()` method, that should never have been called directly anyway - Split up the verification of the file path, to make it accessible without actually opening the file, as a separate `file_path()` function. ------- ### TODO - [x] update the tests

This PR aims to add a button which opens studio from the optional column dropdown menu. The goal is to let the user now he can add custom fields to a listview with Odoo Studio, and to promote Odoo Studio when not installed. If studio is not yet installed, this button opens a dialog which promotes studio with the studio youtube video. System admin can choose to install studio directly by clicking the Install Studio button. By clicking on this button, studio will be installed, a value will be set in the localStorage and the page will be reloaded. The purpose of the value set in the localStorage is to open the page in studio mode directly after page reload and to mimify the user experience described here after. When Studio is installed, the buttons only toggle studio mode as the systray button do. PR community : odoo/odoo#66979 task-2392303

This commit fix a bug introduced in #66551 where a mismatch has been done between session.user_context.allowed_company_ids and session.user_companies.allowed_companies. This commit also adds the following tests: - a JS test in order to prevent future unwanted issues regarding multi company in BasicModel. - a Python test in order to ensure that session_info['user_companies'] is not involuntarily changed. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

The current rules would allow through a selector of the form :not(sel1, sel2) then because the matcher thing just splits on `,` it would store the incorrect sections :not sel1( and sel2) as separate selectors in the rules cache, raising an exception when matching against elements. Move all the rules to a single regex, and add a rule to exclude any situation where a comma or an open parenthesis is inside of an open parenthesis pair. Although maybe this should straight up just exclude any rule containing a pseudo-class and pseudo-element? There's no real explanation and it's all part of a big commit, but it tries to exclude all pseudo-elements (::) except it only excludes *some* of the legacy ones (:before and :after, but not :first-letter) and the pseudo-class exclusion also seems somewhat arbitrary e.g. why :active but not :focus? Is the intent there to exclude rules which can never match because they're "live" rules? (in that case the exclusion I add is not really correct, but that means this thing needs a much more advanced rules parsing in order to handle the case of a multi-parameter `:not`). Forward-Port-Of: odoo/odoo#68050

Improvements(3)

[IMP] web: tune cond. to render optional col dropdown

[IMP] tools: simplify and modernize file_open()

[IMP] web_enterprise : 'add custom field' in optional fields dropdown

Bug Fixes(2)

[FIX] web: correctly set current_company_id in BasicModel

Other(9)

[FW]web_editor: fix selector exclusion rule

Improvements(3)

[IMP] web: tune cond. to render optional col dropdown

[IMP] tools: simplify and modernize file_open()

[IMP] web_enterprise : 'add custom field' in optional fields dropdown

Bug Fixes(2)

[FIX] web: correctly set current_company_id in BasicModel

Other(9)

[FW]web_editor: fix selector exclusion rule

[FIX] base: View error reporting can lack a context

[FW][FIX] mail: fix display of message in inbox while using full composer

[FW][FIX] web_editor: fix incorrectly translated template literal

[FW]base: allow using another postgres schema than public

[FW][FIX] mrp_subcontracting: fix subcontracting + MTO

[FW][FIX] web: fix incorrect translation of template literals

[FW][FIX] tools: support malformed more malformed pdf

[FW][FIX] helpdesk: ensure padding is applied on dashboard

[FW][FIX] account_reports_cash_flow: translate account names