Wednesday, March 24, 2021
16 changes · master
Enhancements to existing features
Live survey hosts now see an indication when their survey has no questions, helping them understand why the session cannot proceed. Participants also see a more appropriate message telling them there are no questions yet and to come back later, instead of being prompted to edit the survey.
Original PR description
PURPOSE Before this commit, the survey host had no indication that his survey has no questions. After this commit, he will be displayed with that indication. Before this commit, someone who took the survey had a message implying him to modify the survey to add questions. After this commit the message will say 'No question yet, come back later'. LINKS Task ID : 2456372 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Manufacturing users get clearer operation and work center lists with more useful fields, grouping options, and easier bulk editing. Work center records now also provide quick access to related operations, helping teams review production setup faster.
Original PR description
Some changes/improvements in the list/form views of `mrp.workcenter` and `mrp.routing.workcenter`. task-2382256
This update adds a reusable test helper that makes it easier to confirm scheduled job triggers are created at the right time. It reduces duplicated test logic across areas like calendar and mass mailing, improving maintainability without changing customer-facing behavior.
Original PR description
When testing cron triggers, it is common to get the newly created triggers in order to validate they exist and are scheduled are the right moment. This new helper is a context manager that capture all triggers or triggers created for a specific cron. The created triggers are accessible via the context's object `triggers` recordset attribute. The various tests have been updated so they use that new helper.
Event email and SMS schedules now show clearer progress, including whether messages are scheduled, running, or sent, plus how many attendees have been contacted. The scheduling logic was also streamlined to improve performance and make communication tracking more reliable for event teams.
Original PR description
PURPOSE Improve event mail scheduled communications: add a state and a contacted count. Improve performances and code readability. SPECIFICATIONS: STATE Instead of the checkbox "sent", an event mail…
PURPOSE
Improve event mail scheduled communications: add a state and a contacted
count. Improve performances and code readability.
SPECIFICATIONS: STATE
Instead of the checkbox "sent", an event mail can have 3 values
1. Sent, if all the mails has been sent;
2. Scheduled, if scheduled but no attendee have been contacted;
3. Running, if not all attendees have been contacted;
Note that communication targeting "after registration" are always considered
as being "running" as any new registration triggers a new communication.
A new widget is added that displays an icon depending on the state.
A new field holding contact count is added. When scheduler send emails it is
updated to keep a count of sent communications.
SPECIFICATIONS: MAIL COMPUTATION IMPROVEMENT
Purpose of this merge is to remove the "done" field computation. Indeed
it is based on either
* mail_sent field if scheduler is global to the event (before or after
event). This computation is light as this field changes only once
when emails are scheduled and sent;
* status of event registrations compared to all sent communication on
those registrations. This is costly as adding a new registration changes
In this merge we therefore
* rename ``done`` to ``mail_done`` to ease grep and understanding;
* remove ``mail_sent`` as it is integrated within ``done``;
* manually update ``mail_done`` when updating schedulers instead of doing
it through a compute method;
Some code cleaning is performed to make it clearer and easier to understand.
LINKS
Task ID-2414658
COM PR odoo/odoo#63093
UPG PR odoo/upgrade#2014Users can now mark products as favorites, filter to see favorite products, and sort product lists by favorites or alphabetically. This makes it faster for teams to find and work with frequently used products in the Product app.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The manufacturing accounting list view now shows the hourly cost account field directly. This makes it easier for users to review and manage cost account settings without opening each record individually.
Original PR description
task-2382256
Resolved issues and error corrections
This fix keeps HR skills page styling limited to the HR skills area so it no longer changes the appearance of unrelated Odoo screens. It also preserves the intended remove-button color in list views by moving that shared style to the web module.
Original PR description
Before this commit, hr_skills module defined a few css rules but weren't enclosed in a custom class to make them only for hr skills so these rules leaked everywhere in odoo. This commit encloses these css rules to not leak them and move a rule which changes the color of list's remove button into web module to keep the color.
Miscellaneous changes
Currently we automatically check reordering rules when a product cannot be completely reserved, which allows to have a replenishment document for the product without needing to run scheduler. This is unwanted for some users. In this commit, we allow to disable this by adding a parameter to ir.config_parameter. To disable it, set a parameter with name "stock.no_auto_scheduler". opw 2458507 Description of the issue/feature this PR addresses: Current behavior before PR: Desired beh
Original PR description
Currently we automatically check reordering rules when a product cannot be completely reserved, which allows to have a replenishment document for the product without needing to run scheduler. This is unwanted for some users. In this commit, we allow to disable this by adding a parameter to ir.config_parameter. To disable it, set a parameter with name "stock.no_auto_scheduler". opw 2458507 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68203
This fix ensures automated tests clean up the temporary screen-blocking state created when simulating the Studio installation flow. It reduces the chance that one test affects another, making test results more reliable without changing normal user behavior.
Original PR description
The PromoteStudioDialog blocks UI when the user clicks on "Install Studio". The UI is then automatically unblocked as the webclient is reloaded. In tests, we mock the reload, but we didn't unblock the UI (i.e. the class o_ui_blocked remained on the body). This is a side-effect and we don't want tests to have side-effects, as it might influence other tests. In this case, a web_tour test failed if it was executed after those tests.
Before this commit, when delivered qty. for a product tracked by serial numbers and then create a returns for this product, as the move is linked to its original returned move, when the detailed operations will be displayed, it will hide `lot_name` field and display the `lot_id`. The issue is it will still show the "Assign Serial Numbers" feature. As this feature is for the creation of new SN only (not for assign existing ones), it should be hidden in this case because it will lead to attempt
Original PR description
Before this commit, when delivered qty. for a product tracked by serial numbers and then create a returns for this product, as the move is linked to its original returned move, when the detailed…
Before this commit, when delivered qty. for a product tracked by serial numbers and then create a returns for this product, as the move is linked to its original returned move, when the detailed operations will be displayed, it will hide `lot_name` field and display the `lot_id`. The issue is it will still show the "Assign Serial Numbers" feature. As this feature is for the creation of new SN only (not for assign existing ones), it should be hidden in this case because it will lead to attempt to create already existing. How to reproduce: - Create a product tracked by serial numbers; - Add at least two qty. on hand for this product and create as many serial numbers, following by numbers (ex.: sn01, sn02, sn03, ...); - Make a delivery for at least two of this product and proceed it; - When it's done, make a return for this delivery; - Open the delivery's return and display the detailed operations, then use the "Assign Serial Numbers" to try to reassign the delivery SN. --> First, we will not see the SN on the move line (as `lot_id` is visible but `lot_name` is invisible). --> Second, you can't mark as done the return as it will try to create the SN but they already exist. To fix the issue, we can simply hide this feature when we hide the `lot_name` field. task-2474919 opw-2455971 Forward-Port-Of: odoo/odoo#67093
…fiscal positions opw-2447155 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67218 Forward-Port-Of: odoo/odoo#67084
Original PR description
…fiscal positions opw-2447155 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#67218 Forward-Port-Of: odoo/odoo#67084
This reverts commit 170729ee58b199041d7545e7789ac9474e86f998, per discussion with @thd on https://www.odoo.com/web#id=2422438 opw-2422438 Forward-Port-Of: odoo/odoo#64841
Original PR description
This reverts commit 170729ee58b199041d7545e7789ac9474e86f998, per discussion with @thd on https://www.odoo.com/web#id=2422438 opw-2422438 Forward-Port-Of: odoo/odoo#64841
[FIX] website: avoid overlap around blog's paragraph Fixing anchor selector to pick only section and div elements. task-2449620 Forward-Port-Of: odoo/odoo#68258 Forward-Port-Of: odoo/odoo#67060
Original PR description
[FIX] website: avoid overlap around blog's paragraph Fixing anchor selector to pick only section and div elements. task-2449620 Forward-Port-Of: odoo/odoo#68258 Forward-Port-Of: odoo/odoo#67060
One might design a custom field widget to display/interact with a one2many field. Before this commit, if this field widget triggered a field_changed event to update a related record, it crashed, because the code assumed that there was a view associated with the field. opw~2468238 Co-authored-by: Aaron Bohy <aab@odoo.com> Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the
Original PR description
One might design a custom field widget to display/interact with a one2many field. Before this commit, if this field widget triggered a field_changed event to update a related record, it crashed, because the code assumed that there was a view associated with the field. opw~2468238 Co-authored-by: Aaron Bohy <aab@odoo.com> Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#68294 Forward-Port-Of: odoo/odoo#68276
Correct small typo that the module when exporting translations as CSV file might have been the wrong module because we used variable from previous loop. This did not seem to cause any issue since in this given case in import we got the module from the part before . in XML ID ({module}.{name}) that was right. found when working on opw-2439029 Forward-Port-Of: odoo/odoo#68284
Original PR description
Correct small typo that the module when exporting translations as CSV
file might have been the wrong module because we used variable from
previous loop.
This did not seem to cause any issue since in this given case in import
we got the module from the part before . in XML ID ({module}.{name})
that was right.
found when working on opw-2439029
Forward-Port-Of: odoo/odoo#68284Statement lines added to an existing posted statement should have their move posted automatically because, after adding new transactions, we open the reconciliation widget with those newly added lines and it is not possible to reconcile a statement line which has its associated move in draft. Automatically posting the newly fetched transactions means that a sequence number will be taken even if the transaction is a duplicate but we consider that it is not much of a problem as we can hav
Original PR description
Statement lines added to an existing posted statement should have their move posted automatically because, after adding new transactions, we open the reconciliation widget with those newly added lines and it is not possible to reconcile a statement line which has its associated move in draft. Automatically posting the newly fetched transactions means that a sequence number will be taken even if the transaction is a duplicate but we consider that it is not much of a problem as we can have holes in sequence number within the bank journal. Forward-Port-Of: odoo/enterprise#17268