Monday, May 24, 2021
1 change · master
Miscellaneous changes
Previously: When trying to add a menu link 2 errors could occur : a QWeb template error and if the user did not properly fill the Link Dialog, they would get a Traceback instead of a simple indication that they did not fill all the fields Reason: Because of a refactor done in #69183, linkWidget was missing an XML dependency. It was also trying to save even if the content was invalid. Fix: Combining XML dependencies instead of overwriting them, checking if the final_data is set befo
Original PR description
Previously: When trying to add a menu link 2 errors could occur : a QWeb template error and if the user did not properly fill the Link Dialog, they would get a Traceback instead of a simple indication that they did not fill all the fields Reason: Because of a refactor done in #69183, linkWidget was missing an XML dependency. It was also trying to save even if the content was invalid. Fix: Combining XML dependencies instead of overwriting them, checking if the final_data is set before trying to save it. This commit also adds tests to make sure the edit menu feature works. task-2513588 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#70150