Friday, July 2, 2021
29 changes · master
Enhancements to existing features
When a business configures its website with appointment scheduling as the main goal and the calendar feature is available, key call-to-action buttons now invite visitors to schedule an appointment. This directs visitors to the calendar page, making it easier to convert interest into booked appointments.
Original PR description
If user selects 'schedule appointments' as main objective in the configurator and if the website_calendar module is installed then the Call To Action of snippets s_banner, s_cover and s_call_to_action is changed to 'Schedule an appointment' and redirect user to '/calendar' on click. task-2518565 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The date range picker now shows selected start and end dates with slightly rounder corners. This small visual refinement makes selected dates easier to distinguish and improves overall clarity for users.
Original PR description
PURPOSE Increase the roundness of the start/end dates in the daterange picker for clarity. SPEC Increase start/end dates roundness from 4px to 8px. TASK 2413932 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Duplicated emails will no longer carry over the failure reason from the original email. This prevents copied draft emails from incorrectly appearing as if they had already failed to send.
Original PR description
The Failure Reason should not be copied for obvious reasons. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update corrects minor details in how Odoo communicates with Ingenico payment terminals, including message labels, response type, keepalive timing, and message length handling. These changes are not expected to affect current users, but they help keep the integration ready for future terminal firmware behavior.
Original PR description
* Typo in IncomingIngenicoMessage class name * HelloResponse had the wrong message type, which the terminal ignores * A 5005 instead of 5 second keepalive interval was specified to the terminal, which it also ignores. * The message length is a hex field, not a BCD one. The BCD to int function converted a hex field instead of a BCD field, so it was wrong but worked. None of these have a functional impact at the moment, hence it's an IMP for master. The second and third points might become a problem in stable if the Ingenico terminal firmware updates to actually read those fields.
When a business chooses scheduling appointments as its main website goal and the calendar app is installed, key website sections now show a clear “Schedule an appointment” call to action. Visitors are sent directly to the calendar page, making it easier for them to book appointments and helping businesses drive the intended action.
Original PR description
If user selects 'schedule appointments' as main objective in the configurator and if the website_calendar module is installed then the Call To Action of snippets s_banner, s_cover and s_call_to_action is changed to 'Schedule an appointment' and redirect user to '/calendar' on click. task-2518565
Resolved issues and error corrections
The command palette now shows keyboard shortcuts in the intended format. This makes shortcuts easier for users to read and helps them discover faster ways to navigate the system.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Features or functions removed from Odoo
This change removes a duplicate or unnecessary menu entry from the HR Contract area. It helps employees and HR users navigate the system more clearly by reducing menu clutter.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Currently, a traceback is generated on removing a groupby when adding a line from the list view. It happens because the state doesn't get the updated value of groupby. after this commit, removing the groupby when adding a line from the list view will not generate any errors. TaskID-2518527 Forward-Port-Of: odoo/odoo#70236
Original PR description
Currently, a traceback is generated on removing a groupby when adding a line from the list view. It happens because the state doesn't get the updated value of groupby. after this commit, removing the groupby when adding a line from the list view will not generate any errors. TaskID-2518527 Forward-Port-Of: odoo/odoo#70236
- Enable Margin analysis - Have a product [TEST] in a category with - FIFO and Automated Valuation. - Kit BOM with 3 items (A,B,C) - Create a SO with [TEST] and confirm. - Modify the BOM and remove C from the kit. - Back to the SO, cancel it. Traceback will show, because there no more a bom_line associated with the move opw-2541674 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm
Original PR description
- Enable Margin analysis - Have a product [TEST] in a category with - FIFO and Automated Valuation. - Kit BOM with 3 items (A,B,C) - Create a SO with [TEST] and confirm. - Modify the BOM and remove C from the kit. - Back to the SO, cancel it. Traceback will show, because there no more a bom_line associated with the move opw-2541674 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72601
Following https://github.com/odoo/odoo/commit/bdcb3d192be1e01e1141aa09c60027337009a67b Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72717
Original PR description
Following https://github.com/odoo/odoo/commit/bdcb3d192be1e01e1141aa09c60027337009a67b Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72717
After the new editor was merged, custom event 'request_editable' triggered by the ColorPaletteWidget to retrieve custom colors from the editable was not processed. Now, we pass the editable in the options when we init the ColorPaletteWidget. task-2476601 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72294
Original PR description
After the new editor was merged, custom event 'request_editable' triggered by the ColorPaletteWidget to retrieve custom colors from the editable was not processed. Now, we pass the editable in the options when we init the ColorPaletteWidget. task-2476601 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72294
When the color palette for the text was open, opening the background color options was not closing it. The click event was stopped at the snippet level, where it should only be the case if the click was done inside the colorpicker. task-2476601 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72539
Original PR description
When the color palette for the text was open, opening the background color options was not closing it. The click event was stopped at the snippet level, where it should only be the case if the click was done inside the colorpicker. task-2476601 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72539
Currently if public user has a `country_id`, following traceback is throw when URL `/shop` is open: ``` Traceback (most recent call last): File "/.repo_requirements/odoo/odoo/addons/base/models/qweb.py", line 331, in _compiled_fn return compiled(self, append, new, options, log) File "<template>", line 1, in template_website_sale_products_item_306 File "/.repo_requirements/odoo/addons/website_sale/models/product.py", line 294, in _get_combination_info fpos = self.env['account.fiscal.posi
Original PR description
Currently if public user has a `country_id`, following traceback is throw when URL `/shop` is open: ``` Traceback (most recent call last): File…
Currently if public user has a `country_id`, following traceback is throw when URL `/shop` is open:
```
Traceback (most recent call last):
File "/.repo_requirements/odoo/odoo/addons/base/models/qweb.py", line 331, in _compiled_fn
return compiled(self, append, new, options, log)
File "<template>", line 1, in template_website_sale_products_item_306
File "/.repo_requirements/odoo/addons/website_sale/models/product.py", line 294, in _get_combination_info
fpos = self.env['account.fiscal.position'].get_fiscal_position(partner.id).sudo()
File "/.repo_requirements/odoo/addons/account/models/partner.py", line 184, in get_fiscal_position
fp = self._get_fpos_by_region(delivery.country_id.id, delivery.state_id.id, delivery.zip, vat_required)
File "/.repo_requirements/odoo/addons/account/models/partner.py", line 141, in _get_fpos_by_region
fpos = self.search(domain_country + state_domain + zip_domain, limit=1)
File "/.repo_requirements/odoo/odoo/models.py", line 1708, in search
res = self._search(args, offset=offset, limit=limit, order=order, count=count)
File "/.repo_requirements/odoo/odoo/models.py", line 4485, in _search
model.check_access_rights('read')
File "/.repo_requirements/odoo/odoo/models.py", line 3331, in check_access_rights
return self.env['ir.model.access'].check(self._name, operation, raise_exception)
File "<decorator-gen-33>", line 2, in check
File "/.repo_requirements/odoo/odoo/tools/cache.py", line 90, in lookup
value = d[key] = self.method(*args, **kwargs)
File "/.repo_requirements/odoo/odoo/addons/base/models/ir_model.py", line 1792, in check
raise AccessError(msg)
odoo.exceptions.AccessError: You are not allowed to access 'Fiscal Position' (account.fiscal.position) records.
This operation is allowed for the following groups:
- Accounting/Advisor
- User types/Internal User
- User types/Portal
Contact your administrator to request access if necessary.
Error to render compiling AST
AccessError: You are not allowed to access 'Fiscal Position' (account.fiscal.position) records.
This operation is allowed for the following groups:
- Accounting/Advisor
- User types/Internal User
- User types/Portal
Contact your administrator to request access if necessary.
Template: website_sale.products_item
Path: /t/t[2]
Node: <t t-set="combination_info" t-value="product._get_combination_info(only_template=True, add_qty=add_qty or 1, pricelist=pricelist)"/>
```
Above was tested and reproduced in an instance of odoo runbot v14.0:
https://youtu.be/GgUnyna_EX8
That is due to public user has not permission to read model `account.fiscal.position` and in fact in ACL, name permission contains 'public' but is setting `group_portal`.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#70566Issue: For purchase user, which doesn't have the "Contact Creation" can't create a purchase, get a AccessError. The fields `receipt_reminder_email` and `reminder_date_before_receipt` should be writable also for purchase user which doesn't have access to write and create `res.partner`. close odoo/odoo#64135 Forward-Port-Of: odoo/odoo#64319
Original PR description
Issue: For purchase user, which doesn't have the "Contact Creation" can't create a purchase, get a AccessError. The fields `receipt_reminder_email` and `reminder_date_before_receipt` should be writable also for purchase user which doesn't have access to write and create `res.partner`. close odoo/odoo#64135 Forward-Port-Of: odoo/odoo#64319
**Description of the issue/feature this PR addresses:** - Adds address format and vat label to Honduras res.country data - Improve HNL currency setup **Current behavior before PR:** - Missing address format and vat label - Wrong HNL currency position and unit label **Desired behavior after PR is merged:** - Honduras address format and vat label comes as part of Honduras country data - Have a correct HNL currency setup -- I confirm I have signed the CLA and read the PR g
Original PR description
**Description of the issue/feature this PR addresses:** - Adds address format and vat label to Honduras res.country data - Improve HNL currency setup **Current behavior before PR:** - Missing address format and vat label - Wrong HNL currency position and unit label **Desired behavior after PR is merged:** - Honduras address format and vat label comes as part of Honduras country data - Have a correct HNL currency setup -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#69764
Issue - Install 'Accounting' module - Switch to "My Company (Chicago)" - Create an invoice - Set invoice date to 1/1/21 and - Set Due date to 1/3/21 - Add any product and 'Confirm' invoice - Go to customer profile - Click on 'Due' stat button - Click on 'Send by mail' In received email, logo display is of "My Company (San Francisco)". Cause Env company not used. Instead, logo of customer.company is used if mail type have company_id field, else will fallback on
Original PR description
Issue - Install 'Accounting' module - Switch to "My Company (Chicago)" - Create an invoice - Set invoice date to 1/1/21 and - Set Due date to 1/3/21 - Add any product and 'Confirm' invoice - Go to customer profile - Click on 'Due' stat button - Click on 'Send by mail' In received email, logo display is of "My Company (San Francisco)". Cause Env company not used. Instead, logo of customer.company is used if mail type have company_id field, else will fallback on user.company_id Also, if customer.company_id is null, it will fallback on '0': /logo.png?company=%s' % (company.id or 0) Solution Add field company_id to kwargs when calling message_post in case want to force company_id. opw-2474114 Forward-Port-Of: odoo/odoo#73070 Forward-Port-Of: odoo/odoo#68660
PURPOSE Form view keeps local state even when form view is switched to other view due to which when form view is opened again it shows last active notebook tab. SPEC Reset local state of renderer which stores information like a currently active notebook page etc. when form view is switched to other view. TASK 2466057 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72912 Forward-Port-Of: odoo/odoo#67241
Original PR description
PURPOSE Form view keeps local state even when form view is switched to other view due to which when form view is opened again it shows last active notebook tab. SPEC Reset local state of renderer which stores information like a currently active notebook page etc. when form view is switched to other view. TASK 2466057 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72912 Forward-Port-Of: odoo/odoo#67241
The commit fixes the display of custom colors in the color picker. It improves previous fix from #72294, which was not returning all editables from the editor, thus only the custom colors of the target were displayed. For that the request_editable event is reintroduced at the SnippetsMenu level. task-2476601 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72978
Original PR description
The commit fixes the display of custom colors in the color picker. It improves previous fix from #72294, which was not returning all editables from the editor, thus only the custom colors of the target were displayed. For that the request_editable event is reintroduced at the SnippetsMenu level. task-2476601 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#72978
[FIX] l10n_eu_service: don't duplicate OSS taxes on refresh of an existing rate To reproduce: 1) Install an European CoA and make sure the OSS mapping for its taxes has been generated (either installing l10n_eu_service before, or clikcing the "refresh tax mapping" button, in the settings) 2) Create a new tax with the same rate as one of your original taxes 3) Click on "refresh tax mapping" ===> Instead of reusing the OSS tax mapped with the other tax having the same rate, a new ta
Original PR description
[FIX] l10n_eu_service: don't duplicate OSS taxes on refresh of an existing rate To reproduce: 1) Install an European CoA and make sure the OSS mapping for its taxes has been generated (either installing l10n_eu_service before, or clikcing the "refresh tax mapping" button, in the settings) 2) Create a new tax with the same rate as one of your original taxes 3) Click on "refresh tax mapping" ===> Instead of reusing the OSS tax mapped with the other tax having the same rate, a new tax with the same name has been created. [FIX] l10n_eu_service: fix computation of l10n_eu_services_eu_country This field should be true when the company is subject to VAT in Europe, so the fiscal country should be used instead of the country. Forward-Port-Of: odoo/odoo#73094 Forward-Port-Of: odoo/odoo#73078
https://github.com/odoo/odoo/pull/71872 made country_id readonly in every circumstance. This made it impossible to create an account.account.tag targetting taxes from scratch in the UI. We only want to prevent edition of this field when the tag has been generated by a tax.report.line. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/
Original PR description
https://github.com/odoo/odoo/pull/71872 made country_id readonly in every circumstance. This made it impossible to create an account.account.tag targetting taxes from scratch in the UI. We only want to prevent edition of this field when the tag has been generated by a tax.report.line. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#73100 Forward-Port-Of: odoo/odoo#72809
Move the odoo server parameters into the odoo.conf file instead of being placed as the service command line argument Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#73014 Forward-Port-Of: odoo/odoo#72904
Original PR description
Move the odoo server parameters into the odoo.conf file instead of being placed as the service command line argument Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#73014 Forward-Port-Of: odoo/odoo#72904
> Issue: In l10n_co_reports the report Certificado de Retencion (ReportCertificationReportIva) has too restrictive domain so user created accounts on top of the CoA template are not in the report. This pr brings the following changes: in `Certificado de Retenciòn en IVA` - Change `Base amount for Account 236705` to `Base amount for Account 2367*` - Change `Balance amount for Account 240810` to `Base amount for Account 2408*` - Change `Balance amount for Account 236705` t
Original PR description
> Issue: In l10n_co_reports the report Certificado de Retencion (ReportCertificationReportIva) has too restrictive domain so user created accounts on top of the CoA template are not in the report.
This pr brings the following changes:
in `Certificado de Retenciòn en IVA`
- Change `Base amount for Account 236705` to `Base amount for Account 2367*`
- Change `Balance amount for Account 240810` to `Base amount for Account 2408*`
- Change `Balance amount for Account 236705` to `Balance amount for Account 2367*`
opw-2536868
Forward-Port-Of: odoo/enterprise#19257When package's UoM is different from dimensions' UoM used in UPS request, the values are incorrect To reproduce the error: 1. Sales > Configuration > Shipping Methods 2. Open UPS US > UPS Package/customer supplied - Dimensions are 10 x 10 x 10 meters 3. Create a SO 4. Add Shipping: UPS US Error: Here is part of the request sent to the UPS server: ```xml <ns0:Package> <ns0:PackagingType> <ns0:Code>02</ns0:Code> </ns0:PackagingType> <ns0:Dimensions>
Original PR description
When package's UoM is different from dimensions' UoM used in UPS request, the values are incorrect To reproduce the error: 1. Sales > Configuration > Shipping Methods 2. Open UPS US > UPS…
When package's UoM is different from dimensions' UoM used in UPS
request, the values are incorrect
To reproduce the error:
1. Sales > Configuration > Shipping Methods
2. Open UPS US > UPS Package/customer supplied
- Dimensions are 10 x 10 x 10 meters
3. Create a SO
4. Add Shipping: UPS US
Error: Here is part of the request sent to the UPS server:
```xml
<ns0:Package>
<ns0:PackagingType>
<ns0:Code>02</ns0:Code>
</ns0:PackagingType>
<ns0:Dimensions>
<ns0:UnitOfMeasurement>
<ns0:Code>IN</ns0:Code>
</ns0:UnitOfMeasurement>
<ns0:Length>10</ns0:Length>
<ns0:Width>10</ns0:Width>
<ns0:Height>10</ns0:Height>
</ns0:Dimensions>
```
The dimensions are 10 x 10 x 10 inches, which are incorrect. The values
must be converted.
This commit allows the conversion to `CM` and `IN` since these are the
two UoM available:
https://github.com/odoo/enterprise/blob/cb13edb79209f15409734488d499e78158a3ba08/delivery_ups/models/delivery_ups.py#L44
OPW-2523952
Forward-Port-Of: odoo/enterprise#19402
Forward-Port-Of: odoo/enterprise#19378Currently, when go to helpdesk > configuration > helpdesk teams > enable 'timesheets on tickets' and 'time reinvoicing' then create a ticket > set a customer > save > remove the selected the customer then the customer is set again and can not be unselected due to recursive compute of sale_order_id and commercial_partner_id on ticket. TaskID: 2535773 Forward-Port-Of: odoo/enterprise#19384 Forward-Port-Of: odoo/enterprise#19091
Original PR description
Currently, when go to helpdesk > configuration > helpdesk teams > enable 'timesheets on tickets' and 'time reinvoicing' then create a ticket > set a customer > save > remove the selected the customer then the customer is set again and can not be unselected due to recursive compute of sale_order_id and commercial_partner_id on ticket. TaskID: 2535773 Forward-Port-Of: odoo/enterprise#19384 Forward-Port-Of: odoo/enterprise#19091
Description of the issue/feature this PR addresses: 1: When processing shipment for UPS with at least two packs and generating return labels for the shipment, the UPS API returned an error. Said error was never displayed to the user, instead only showing "None" where the traceback is supposed to be. Desired behavior after PR is merged: The error message from the UPS API is correctly displayed instead of "None". OPW: 2464071 -- I confirm I have signed the CLA and read the PR guideline
Original PR description
Description of the issue/feature this PR addresses: 1: When processing shipment for UPS with at least two packs and generating return labels for the shipment, the UPS API returned an error. Said error was never displayed to the user, instead only showing "None" where the traceback is supposed to be. Desired behavior after PR is merged: The error message from the UPS API is correctly displayed instead of "None". OPW: 2464071 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/enterprise#19281
with this commit we remove many2many_avatar_employee related test statements as to test many2many_avatar_employee we require hr modules, so if web_studio is installed alone then test case will fail, so removing it. Forward-Port-Of: odoo/enterprise#19246
Original PR description
with this commit we remove many2many_avatar_employee related test statements as to test many2many_avatar_employee we require hr modules, so if web_studio is installed alone then test case will fail, so removing it. Forward-Port-Of: odoo/enterprise#19246
When adding payments to a batch payment, we show all payments, including those having a zero amount. This is useless since we check afterward that there are no zero amount payments. We should adapt the domain instead to hide these payments from the list. opw-2465360 Forward-Port-Of: odoo/enterprise#19290 Forward-Port-Of: odoo/enterprise#19182
Original PR description
When adding payments to a batch payment, we show all payments, including those having a zero amount. This is useless since we check afterward that there are no zero amount payments. We should adapt the domain instead to hide these payments from the list. opw-2465360 Forward-Port-Of: odoo/enterprise#19290 Forward-Port-Of: odoo/enterprise#19182
Have a loyalty program with rules defined to accumulate point, i.e. 1 point per quantity on all products Open POS, select customer, add product, select a negative quantity No points will be drawn from the user account, because of a filter on the reward, which select the greatest amount among all rules, with a lower bound of 0 opw-2566360 Forward-Port-Of: odoo/enterprise#19187
Original PR description
Have a loyalty program with rules defined to accumulate point, i.e. 1 point per quantity on all products Open POS, select customer, add product, select a negative quantity No points will be drawn from the user account, because of a filter on the reward, which select the greatest amount among all rules, with a lower bound of 0 opw-2566360 Forward-Port-Of: odoo/enterprise#19187
… character X-original-commit: 8dd54e69f6f8c99b91eda6c7c16ffdf10d67fa15 Forward-Port-Of: odoo/enterprise#18791
Original PR description
… character X-original-commit: 8dd54e69f6f8c99b91eda6c7c16ffdf10d67fa15 Forward-Port-Of: odoo/enterprise#18791