Tuesday, November 2, 2021
27 changes · master
Enhancements to existing features
Timesheet reports are clearer and easier to use, with updated column names, better placement of descriptions, and a reusable report layout. Project timesheet entries can now be reported more directly, and internal project names are clearer for users working across multiple companies.
Original PR description
Purpose of this commit to improve ux for
timesheet app.
So, In this commit done following changes:
- make name field of account.analytic.line model
translatable by user.
- changes in report of timesheet:
- make generic table templete for timesheet.
- changes label for employee_id field column
'responsible' into 'employee' and unit_
amount field column 'time spent (hours)'
into 'hours spent' and 'time spent (days)'
into 'days spent'.
- move name(description) field column right of
the task column.
- add timesheet entry report for project.
- change internal project name when user has
access to multiple companies.
Task Id: 2604773
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis update adds pager support to Odoo’s newer web interface framework and improves related control panel behavior. It also fixes a focus issue and adds supporting utilities and tests, making navigation in web views more reliable and consistent.
Helpdesk team visibility has been adjusted so portal and internal users receive read access in a way that matches other Odoo apps such as Project. This makes access behavior more predictable and consistent for users working across modules.
Original PR description
The purpose: The way portal and internal users are granted the reading access to the records, differs in the helpdesk from the other modules, which is a bit inconsistent from the users point of view. In this task, the above mentioned behavior is aligned to how it's done in the module - project. task - 2590082
The Map view has been modernized to use Odoo’s newer interface technology, helping make it easier to maintain and evolve. Project’s specialized map experience was updated as part of this work, while map configuration values were standardized across Event, Project, and Stock for more consistent behavior.
Original PR description
In this PR, we convert the Map view to OWL. The legacy implementation is kept as it is still used in studio and in the dashboard app (it is lazy loaded though). This PR also adapts the specialized Map view for Project. Finally, the arch attributes of the Map view have been uniformized in xml (by convention, we now use "1" or "0" for boolean values). Co-authored-by: Francois Georis <fge@odoo.com> Co-authored-by: Géry Debongnie <ged@odoo.com> Co-authored-by: Simon Genin <ges@odoo.com> Co-authored-by: Michael Mattiello <mcm@odoo.com> Co-authored-by: Bruno Boi <boi@odoo.com>
Timesheets now show quick links to related sales orders and invoices when those records exist and the user has permission to view them. Draft timesheets also use a grey status color, making the visual state more consistent and less distracting.
Original PR description
Purpose of this commit to improve generic usage of timesheet app. So, In this commit done following change: - add stat button for sale order and invoice in the form view of timesheet visible only if their values are set on timesheet and user have access right to see that form view. - change color of status in kanban view for draft timesheets from 'blue' to 'grey'. Task Id: 2604773
Resolved issues and error corrections
Product searches on the online shop now use the public website description instead of internal notes. This prevents back-office-only information from affecting customer-facing search results, making shop searches more accurate and appropriate.
Original PR description
Steps to reproduce : - Install E-commerce module - Go to Website -> Products -> Products - Edit product `Acoustic Bloc Screens` - Type "my product" in Internal Notes an save - Go to the Shop - In the search bar, type "my product" Issue : `Acoustic Bloc Screens` is in the search results list Cause : An 'ilike' for 'description' is added to the domain. Solution : Replace 'description' by 'website_description' field in the domain. opw-2649754
Miscellaneous changes
If there was parameters in the from clause, there was a possible error when reading progress bar for activities. eg. grouping product.product by "Routes" raise an error because we have in FORM clause like: FROM … ON … AND "product_template__route_ids"."route_id" IN (SELECT … WHERE … OR ("stock_location_route"."company_id" in %s)) so when we add timezone to parameters, it should be after FROM clause parameters and before WHERE clause parameters. opw-2674179 Forward-Port-Of: odoo/odoo
Original PR description
If there was parameters in the from clause, there was a possible error
when reading progress bar for activities.
eg. grouping product.product by "Routes" raise an error because we have
in FORM clause like:
FROM … ON … AND "product_template__route_ids"."route_id" IN
(SELECT … WHERE … OR ("stock_location_route"."company_id" in %s))
so when we add timezone to parameters, it should be after FROM clause
parameters and before WHERE clause parameters.
opw-2674179
Forward-Port-Of: odoo/odoo#78837Timesheet timers now stay accurate even when the browser tab is inactive. This prevents time entries from drifting due to browser performance throttling, improving confidence in recorded work time.
Original PR description
When a tab with a running timer is inactive, the timer value can become inaccurate, because timers are throttled to improve performance. To fix this, this commit will compute the timer as the difference between the current time and the time the timer was started at. Task-2649119
This change fixes an error that could occur when appraisal survey emails tried to use a signature field that was not available. Removing the unused element helps appraisal-related survey emails send correctly and avoids unnecessary interruptions for users.
Original PR description
Before we got -> AttributeError: 'survey.user_input' object has no attribute 'signature' task - 2659826
WO are released in confirmed state, but the help message says that they are released in draft. opw-2609040 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78890
Original PR description
WO are released in confirmed state, but the help message says that they are released in draft. opw-2609040 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78890
This allows to avoid tens of thousands of instructions being done at each click in the editor. At multiple places, the editor is asked to close all its widgets (for example, when clicking on another snippet to edit). The original cost of that action was to remove a class on each widget, which is a very primitive action. But in the end we had to do more to close a widget: we trigger_up an event and ask to close all sub widgets. When we ask the editor to close all widgets... it makes sens
Original PR description
This allows to avoid tens of thousands of instructions being done at each click in the editor. At multiple places, the editor is asked to close all its widgets (for example, when clicking on another snippet to edit). The original cost of that action was to remove a class on each widget, which is a very primitive action. But in the end we had to do more to close a widget: we trigger_up an event and ask to close all sub widgets. When we ask the editor to close all widgets... it makes sense not letting every sub button of every select trigger_up an event. Forward-Port-Of: odoo/odoo#79217
Description of the issue/feature this PR addresses: - Open session with cash control - Set 300 € - Close session - Add Cash 50€ - Close session - Set end Cash at 350 € --> It raise an error @caburj @pimodoo -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79214 Forward-Port-Of: odoo/odoo#78780
Original PR description
Description of the issue/feature this PR addresses: - Open session with cash control - Set 300 € - Close session - Add Cash 50€ - Close session - Set end Cash at 350 € --> It raise an error @caburj @pimodoo -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79214 Forward-Port-Of: odoo/odoo#78780
Steps to follow Edit the account.move view (with studio for example) Set the lines readonly property to [["partner_id","=",False]] Create a new move Add a partner Add a product Remove the partner -> A traceback appears: widget.$el is undefined Cause of the issue widget.$el is used after the widget has been destroyed opw-2557142 Forward-Port-Of: odoo/odoo#79066 Forward-Port-Of: odoo/odoo#78625
Original PR description
Steps to follow Edit the account.move view (with studio for example) Set the lines readonly property to [["partner_id","=",False]] Create a new move Add a partner Add a product Remove the partner -> A traceback appears: widget.$el is undefined Cause of the issue widget.$el is used after the widget has been destroyed opw-2557142 Forward-Port-Of: odoo/odoo#79066 Forward-Port-Of: odoo/odoo#78625
Before this fix, if the country is not set on the company the loading of the session may stall at some point. A check is added and will prevent to start a session if the country is not set. opw-2557989 Forward-Port-Of: odoo/odoo#79212
Original PR description
Before this fix, if the country is not set on the company the loading of the session may stall at some point. A check is added and will prevent to start a session if the country is not set. opw-2557989 Forward-Port-Of: odoo/odoo#79212
Purpose of this commit to do not copy progress of the project update model when coping project. So, In this commit make last_update_id field copy false so default progress new created project update of copied project will be 0%. TaskID-2664773 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo
Original PR description
Purpose of this commit to do not copy progress of the project update model when coping project. So, In this commit make last_update_id field copy false so default progress new created project update of copied project will be 0%. TaskID-2664773 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78073
Issue : -'Value Price Extra' cannot have the N-digit Decimal Accuracy configuration but 'Product Price' can. Solve : -Added 'Value Price Extra' in Decimal Accuracy opw-2674006 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79014
Original PR description
Issue : -'Value Price Extra' cannot have the N-digit Decimal Accuracy configuration but 'Product Price' can. Solve : -Added 'Value Price Extra' in Decimal Accuracy opw-2674006 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79014
Prior to this commit, when a subtask is copied through the recurrence, it loses its display_project_id in the copied sub-tasks. Current Behavior The display project id is left empty. Expected Behavior The display project id is copied. task-2672243 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78669
Original PR description
Prior to this commit, when a subtask is copied through the recurrence, it loses its display_project_id in the copied sub-tasks. Current Behavior The display project id is left empty. Expected Behavior The display project id is copied. task-2672243 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78669
Forward-Port-Of: odoo/odoo#79034
Original PR description
Forward-Port-Of: odoo/odoo#79034
Forward-Port-Of: odoo/enterprise#21907
Original PR description
Forward-Port-Of: odoo/enterprise#21907
Issues : In some cases where there was only end of rental during the period used for computationm we only took into account rental that took place during the entire length of the period. Solve : Also compute the current unavailable quantity (for non-full duration) at the start of the computation period. opw-2559457 Forward-Port-Of: odoo/enterprise#21932
Original PR description
Issues : In some cases where there was only end of rental during the period used for computationm we only took into account rental that took place during the entire length of the period. Solve : Also compute the current unavailable quantity (for non-full duration) at the start of the computation period. opw-2559457 Forward-Port-Of: odoo/enterprise#21932
Before this fix if you'd reconfigure any of these crons and do a -u of sale_subscription your custom configuration would be reset. By wrapping it in a no-update you can configure the cron to your likings, for example to only run the KPI cron once a month. V13 counterpart for outdated V12 at https://github.com/odoo/enterprise/pull/19797 Forward-Port-Of: odoo/enterprise#22006
Original PR description
Before this fix if you'd reconfigure any of these crons and do a -u of sale_subscription your custom configuration would be reset. By wrapping it in a no-update you can configure the cron to your likings, for example to only run the KPI cron once a month. V13 counterpart for outdated V12 at https://github.com/odoo/enterprise/pull/19797 Forward-Port-Of: odoo/enterprise#22006
Change 'LY' code to 'LT' Forward-Port-Of: odoo/enterprise#21980
Original PR description
Change 'LY' code to 'LT' Forward-Port-Of: odoo/enterprise#21980
A company dependent field is a computed field and doesn't take into account the `compute` attr in the field definition. This commit makes the on change work using the onchange api. task-2675187 Forward-Port-Of: odoo/enterprise#21827
Original PR description
A company dependent field is a computed field and doesn't take into account the `compute` attr in the field definition. This commit makes the on change work using the onchange api. task-2675187 Forward-Port-Of: odoo/enterprise#21827
task - 2659644 Forward-Port-Of: odoo/enterprise#21587
Original PR description
task - 2659644 Forward-Port-Of: odoo/enterprise#21587
Task: https://www.odoo.com/web#id=2679475&action=4043&model=project.task&view_type=form&cids=2&menu_id=4720 Forward-Port-Of: odoo/enterprise#21979
Original PR description
Task: https://www.odoo.com/web#id=2679475&action=4043&model=project.task&view_type=form&cids=2&menu_id=4720 Forward-Port-Of: odoo/enterprise#21979
In sale_subscription it is currently possible to write payment token records via RPC call and no check is done to assert that the user has access to that payment token. This means that it is possible to assign payment tokens from other users to your subscriptions. This PR fixes this issue by checking the access rules on the payment token. If an access error is raised, the write call fails and the payment token is not changed. task-2654115 Forward-Port-Of: odoo/enterprise#22005 Forward-Port-O
Original PR description
In sale_subscription it is currently possible to write payment token records via RPC call and no check is done to assert that the user has access to that payment token. This means that it is possible to assign payment tokens from other users to your subscriptions. This PR fixes this issue by checking the access rules on the payment token. If an access error is raised, the write call fails and the payment token is not changed. task-2654115 Forward-Port-Of: odoo/enterprise#22005 Forward-Port-Of: odoo/enterprise#21090
In case grid 71 is negative, some fields must be left blank in order for the BOE file not to be rejected. Also, the recent format changes introduced with OSS also added a bunch of fields that we now support. Forward-Port-Of: odoo/enterprise#21919
Original PR description
In case grid 71 is negative, some fields must be left blank in order for the BOE file not to be rejected. Also, the recent format changes introduced with OSS also added a bunch of fields that we now support. Forward-Port-Of: odoo/enterprise#21919