Wednesday, November 3, 2021
21 changes · master
Enhancements to existing features
Replenishment order quantities are now calculated using the forecast for the whole relevant day, rather than waiting for a specific hour. This helps businesses trigger purchasing or stock replenishment earlier and more predictably when demand is expected on that date.
Original PR description
Before this commit, the Replenishment orderpoints `qty_to_order` are computed according to a precise forecast which take the time in count. For example, if you plan a consumption for a product with a purchase lead time of 2 days for the 2021-12-12 at 12:30, if the current date is 2021-12-10, the orderpoint for this product will have a quantity to order once the hour is meet too but not before. With this commit, it will take the forecast for the day regardless the time. task-2652920
Users can now continue using the PDF manager while document pages are still being prepared in the background. This makes it easier to cancel or close the split tool quickly, especially when working with large PDF files or after an accidental click.
Original PR description
Before this commit, interactions were locked until all pages canvases were fully rendered, this is unnecessary and would prevent users from closing the pdf manager before all pages were rendered. Which could be inconvenient when miss clicking 'split' on a large pdf file. taskId-2683421
Resolved issues and error corrections
Website mega menu templates now use editable background shapes instead of hard-to-edit overflowing column backgrounds. This makes it easier for users to customize these menu designs in the website editor while keeping the same visual effect.
Original PR description
[1] introduced templates with columns with 'overflowing' backgrounds, using pseudo elements. These are not easily editable. For the template to be fully editable, it is simpler to use background shapes. task-2668908 [1]: 63a3ba4 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Features or functions removed from Odoo
This change removes old, unused pieces from Odoo's translation tooling. It has no expected impact on users, but helps keep the codebase simpler and easier to maintain.
Original PR description
Remove unused code of translate.py file: - remove unused trans_parse_rml method (since 3425752) - remove unused in_modules method (since eb04aa1) - remove unused ENGLISH_SMALL_WORDS set (since d85bf78) - remove unused node_pattern compiled regex (since 085e972) task-2678192
Miscellaneous changes
Suppose an automated AVCO product category. When confirming an invoice, if the associated product was a kit and if its BoM has changed during the process, a traceback can occur. To reproduce the issue: (Need sale_management) 1. Create a product category PC: - Costing Method: AVCO - Inventory Valuation: Automated 2. Create 3 products P1, P2, P3: - Product Type: Storable - Category: PC 3. Update P3's quantity > 0 4. Create two bills of materials: - BOM01:
Original PR description
Suppose an automated AVCO product category. When confirming an invoice, if the associated product was a kit and if its BoM has changed during the process, a traceback can occur. To reproduce the…
Suppose an automated AVCO product category. When confirming an invoice,
if the associated product was a kit and if its BoM has changed during
the process, a traceback can occur.
To reproduce the issue:
(Need sale_management)
1. Create a product category PC:
- Costing Method: AVCO
- Inventory Valuation: Automated
2. Create 3 products P1, P2, P3:
- Product Type: Storable
- Category: PC
3. Update P3's quantity > 0
4. Create two bills of materials:
- BOM01:
- Product: P1
- BoM Type: Kit
- Components: 1 x P2
- BOM02:
- Product: P2
- BoM Type: Kit
- Components: 1 x P3
5. Create a sale order SO with 1 x P1
6. Confirm SO and process the delivery
7. Edit BOM02:
- BoM Type: Manufacture
8. On SO, create the invoice INV
9. Confirm INV
Error: an Odoo Server Error is displayed with a traceback: "[...] in
_compute_average_price, bom_line_data = bom_lines[bom_line] [...]
KeyError: mrp.bom.line(19,)"
On step 7, when changing the BoM type, a new BoM line is created.
Therefore, in `_compute_average_price`, the BoM associated to the move
(i.e., `bom_line`) is not one of the lines in `bom_lines` (i.e., the new
BoM lines). There is already a check in case the line has been deleted,
but not if it has been changed.
OPW-2610685
Forward-Port-Of: odoo/odoo#79077
Forward-Port-Of: odoo/odoo#78917Currently, hovering on the tooltip displays some content out of the viewport. It happens because tooltip content div requires 270px width to display the text and the distance between the tour indicator and viewport is less than 270px so this commit fixes the issue by changing the position of the tooltip indicator from left to the top so that the tooltip indicator displays top of the element and hovering on it displays the full content TaskID-2667140 Forward-Port-Of: odoo/odoo#78529
Original PR description
Currently, hovering on the tooltip displays some content out of the viewport. It happens because tooltip content div requires 270px width to display the text and the distance between the tour indicator and viewport is less than 270px so this commit fixes the issue by changing the position of the tooltip indicator from left to the top so that the tooltip indicator displays top of the element and hovering on it displays the full content TaskID-2667140 Forward-Port-Of: odoo/odoo#78529
Description of the issue/feature this PR addresses: This commit fixes a bug when you clicked on an anchor link Current behavior before PR: e.g. an tag with an href="#anchor". The scroll to the element with id="anchor" didn't happen because the position of the element was not found correctly. Desired behavior after PR is merged: The fix uses getBoundingCLientRect to get more precise positions and dimensions of the element with the anchor. It is now possible to get the scrollable area scr
Original PR description
Description of the issue/feature this PR addresses: This commit fixes a bug when you clicked on an anchor link Current behavior before PR: e.g. an tag with an href="#anchor". The scroll to the element with id="anchor" didn't happen because the position of the element was not found correctly. Desired behavior after PR is merged: The fix uses getBoundingCLientRect to get more precise positions and dimensions of the element with the anchor. It is now possible to get the scrollable area scroll to the element position once you've clicked on a link related to the anchor. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79045
Steps to follow - Go to email templates - Select some text - Click on the code button - Resize the editor -> Nothing happens Cause of the issue The default view of the editor is resized but not the code view Solution Change the code view height with the default view opw-2669259 Forward-Port-Of: odoo/odoo#78803
Original PR description
Steps to follow - Go to email templates - Select some text - Click on the code button - Resize the editor -> Nothing happens Cause of the issue The default view of the editor is resized but not the code view Solution Change the code view height with the default view opw-2669259 Forward-Port-Of: odoo/odoo#78803
In the website builder, the toolbar was appearing in the theme tab incorrectly. task-2664956 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79054 Forward-Port-Of: odoo/odoo#78211
Original PR description
In the website builder, the toolbar was appearing in the theme tab incorrectly. task-2664956 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79054 Forward-Port-Of: odoo/odoo#78211
Reproduce : 1. Add a default analytical rule: if Coin Gourmand partner then Administrative analytical account 2. Create a PO at the Coin Gourmand supplier, add a product, and select the Internal analytical account. 3. Bill for this product. Result : Internal analytical account has disappeared from the invoice line. It has been replaced by Administrative. Fix : Recompute the right analytic account in the invoice. Description of the issue/feature this PR addresses: Current behavio
Original PR description
Reproduce : 1. Add a default analytical rule: if Coin Gourmand partner then Administrative analytical account 2. Create a PO at the Coin Gourmand supplier, add a product, and select the Internal analytical account. 3. Bill for this product. Result : Internal analytical account has disappeared from the invoice line. It has been replaced by Administrative. Fix : Recompute the right analytic account in the invoice. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#77182 Forward-Port-Of: odoo/odoo#76751
Current behavior: If you have 2 time the same product in the agreement and you confirm an order with just one line of this item the 2 lines in the agreement will have the quantity. Expected behavior: Only the ordered item should have the quantity applied. In this case the products are compared with the price and product ID. If you modify the price in the PO the first line of the agreement will have the quantity by default. Steps to reproduce: 1. Create a new Purchase Agreement -Add t
Original PR description
Current behavior: If you have 2 time the same product in the agreement and you confirm an order with just one line of this item the 2 lines in the agreement will have the quantity. Expected behavior:…
Current behavior: If you have 2 time the same product in the agreement and you confirm an order with just one line of this item the 2 lines in the agreement will have the quantity. Expected behavior: Only the ordered item should have the quantity applied. In this case the products are compared with the price and product ID. If you modify the price in the PO the first line of the agreement will have the quantity by default. Steps to reproduce: 1. Create a new Purchase Agreement -Add two lines with the same product - First line has a scheduled date and price that are different from the second line 2. Generate RFQ and confirm PO with only the first product line and a set quantity 3. Once the PO has been confirmed, going back to the Purchase Agreement, the ordered quantities on both lines will be the same, although the PO was generated for only the first line. opw-2627898 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78779
Previous task: odoo/odoo#61287 improved warnings for when using a duplicate SN, including an auto-update of the source location when appropriate. Unfortunately the auto-update is too risky when registering a subcontracting SN tracked components. Instead, we no longer update the source location when in a subcontracting situation and update the warning message to match the expected flow to fix the issue. Task: 2669180 Description of the issue/feature this PR addresses: Current beh
Original PR description
Previous task: odoo/odoo#61287 improved warnings for when using a duplicate SN, including an auto-update of the source location when appropriate. Unfortunately the auto-update is too risky when registering a subcontracting SN tracked components. Instead, we no longer update the source location when in a subcontracting situation and update the warning message to match the expected flow to fix the issue. Task: 2669180 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78774
Steps to follow - Edit a report with studio - Add an inline text element - Select it - Select the text in the sidebar -> An error is raised Cause of the issue firstButtonEl is undefined because the style section is not always present in the toolbar opw-2674302 Forward-Port-Of: odoo/odoo#79265
Original PR description
Steps to follow - Edit a report with studio - Add an inline text element - Select it - Select the text in the sidebar -> An error is raised Cause of the issue firstButtonEl is undefined because the style section is not always present in the toolbar opw-2674302 Forward-Port-Of: odoo/odoo#79265
The warning shown on beforeunload when quiting a page during edition was missing since the new editor merge. task-2666177 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78989
Original PR description
The warning shown on beforeunload when quiting a page during edition was missing since the new editor merge. task-2666177 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78989
- When locations are activated, fix not being able to add a quant for tracked products just after creating one from the 'update quantity' window due to Inventory Adjustment location being auto-selected [since it is the last quant] - Fix quant not properly making fields invisible after confirming from the stock track confirmation window Task-Id: 2674732 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78768
Original PR description
- When locations are activated, fix not being able to add a quant for tracked products just after creating one from the 'update quantity' window due to Inventory Adjustment location being auto-selected [since it is the last quant] - Fix quant not properly making fields invisible after confirming from the stock track confirmation window Task-Id: 2674732 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#78768
Release notes: https://github.com/odoo/owl/releases/tag/v1.4.8 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79324
Original PR description
Release notes: https://github.com/odoo/owl/releases/tag/v1.4.8 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#79324
until now when we had the analytical reports filtered for a precise date range, it was not applied in the detailed view of the entries Community PR: https://github.com/odoo/odoo/pull/78224 opw-2663970 Forward-Port-Of: odoo/enterprise#22067 Forward-Port-Of: odoo/enterprise#21619
Original PR description
until now when we had the analytical reports filtered for a precise date range, it was not applied in the detailed view of the entries Community PR: https://github.com/odoo/odoo/pull/78224 opw-2663970 Forward-Port-Of: odoo/enterprise#22067 Forward-Port-Of: odoo/enterprise#21619
…c95916a11c1b7e79ad7 Adapt enterprise code for https://github.com/odoo/odoo/pull/77182 Forward-Port-Of: odoo/enterprise#21745
Original PR description
…c95916a11c1b7e79ad7 Adapt enterprise code for https://github.com/odoo/odoo/pull/77182 Forward-Port-Of: odoo/enterprise#21745
Small fixup of commit https://github.com/odoo/enterprise/commit/30e9e272169f814367d50fe99b64b7d5c52ceb53 We need to adapt sdd_payment_mandate_form view accordingly otherwise we got an AttributeError: 'NoneType' object has no attribute while printing any SDD mandate. opw-2678792 Forward-Port-Of: odoo/enterprise#22047 Forward-Port-Of: odoo/enterprise#22009
Original PR description
Small fixup of commit https://github.com/odoo/enterprise/commit/30e9e272169f814367d50fe99b64b7d5c52ceb53 We need to adapt sdd_payment_mandate_form view accordingly otherwise we got an AttributeError: 'NoneType' object has no attribute while printing any SDD mandate. opw-2678792 Forward-Port-Of: odoo/enterprise#22047 Forward-Port-Of: odoo/enterprise#22009
The tour bubble animation that makes it to bounce up and down can cause issues when its position is at the edge of the bottom of the screen. this would make the window constantly resize to show a scrollbar and then resize to hide the scrollbar. so this commit fixes the issue by changing the position of the tooltip indicator from bottom to the top to avoid the screen glitch TaskID-2667140 Forward-Port-Of: odoo/enterprise#21914
Original PR description
The tour bubble animation that makes it to bounce up and down can cause issues when its position is at the edge of the bottom of the screen. this would make the window constantly resize to show a scrollbar and then resize to hide the scrollbar. so this commit fixes the issue by changing the position of the tooltip indicator from bottom to the top to avoid the screen glitch TaskID-2667140 Forward-Port-Of: odoo/enterprise#21914
Issue ----- By default the create_uid is insert as followers. When a lead is created from an online appointement we don't need this user as followers since most of the time the current user is the public user. This is harmless until someone is wondering why the public user do not received the email sent to follower and change the email of the public user. Solution -------- Do not add self.env.user as follower on the lead created. If a real user create the appointement and thus th
Original PR description
Issue ----- By default the create_uid is insert as followers. When a lead is created from an online appointement we don't need this user as followers since most of the time the current user is the public user. This is harmless until someone is wondering why the public user do not received the email sent to follower and change the email of the public user. Solution -------- Do not add self.env.user as follower on the lead created. If a real user create the appointement and thus the lead he will be suggested the first time someone send an email. Forward-Port-Of: odoo/enterprise#22050