Monday, December 27, 2021
11 changes · master
Enhancements to existing features
The mail app’s emoji picker has been renamed from “emojis popover” to “emoji list” in the underlying code and related tests. This makes the feature naming clearer and more consistent for future maintenance without changing how users interact with emojis.
Original PR description
Task-2694206
Odoo now avoids storing the same website and interface view data in two separate caches. This should reduce memory use and unnecessary cache refreshes without changing how users experience the system.
Original PR description
QWeb views are cached two times, first in _compile who itself calls _read_template that is also cached. The result is a 0% HIT rate on _read_template, and all frontend views are two times stored in the cache. Note that _read_template is only used by _compile, and another one in web_studio (that does not need to be cached). So, removing this cache won't impact the CPU performance, but will reuce memory usage and LRU invalidations. -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change updates the Mail/Discuss internals to prepare for a newer version of the underlying interface framework. It is a low-risk maintenance improvement intended to keep messaging features compatible and easier to evolve, with no expected change for day-to-day users.
Original PR description
In preparation for using OWL v2 in discuss code. (`shouldUpdateBasedOnProps` will be removed) Task-2695743
The mail module now detects when record creation includes information that does not match a real field, instead of silently ignoring it. This helps catch configuration or integration mistakes earlier and reduces the risk of hidden data issues, while also removing unused code uncovered by the change.
Original PR description
Invalid data provided at record creation were silently skipped by the framework without triggering an error. This commit ensures that data are no longer accidentally filtered and therefore that an error will be raised if a key that does not match an actual field is provided. This commit also removes the dead code that was detected thanks to these changes.
Website editors can now apply transparency effects to mega menus as intended. This improves visual consistency for site designs that use transparent navigation areas, while keeping existing mega menus non-transparent by default.
Original PR description
Make the transparency effect work on mega menus. This effect was not working because the container that contains the mega menu was not transparent. This comes with an upgrade script, see https://github.com/odoo/upgrade/pull/2929 **Task 2623335** -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This update changes how Odoo imports records with nested line items so existing linked lines are not unnecessarily removed and recreated. It helps prevent important tax report tags from being wiped during module updates, reducing the risk of incorrect tax and journal item data after localization updates.
Original PR description
if there is the child then write vals is created like {'field_o2m_name': None} so it removes lines and adds them again by sub_records
so in this commit, we do not add f_name in vals if there is a child of o2m
this give a big effect on account.tax.report to check just update any localization module where account.tax.report is there, after the update all tag is removed from taxes and journal items(account.move.line)
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prMiscellaneous changes
Those were not accounted for, leading to fstrings passing through unflagged. Also update the SQL checker to be stricter but smarter: The previous version would "fail open", unknown nodes would be allowed through hence f-strings not being flagged when they started appearing in arg0 position, should now fail-closed, anything that's not allowed is forbidden. This flags a few more cases, all of which seem acceptable upon review. However the previous version would also only resolve ar
Original PR description
Those were not accounted for, leading to fstrings passing through unflagged. Also update the SQL checker to be stricter but smarter: The previous version would "fail open", unknown nodes would be…
The journal filter has been restored on accounting reports after it was accidentally removed. This lets users narrow report results by journal again, helping finance teams review the right transactions more easily.
Original PR description
This filter has been wrongly removed by https://github.com/odoo/enterprise/commit/16c3de3e123e622143f2e53479d48db93d6b2621
Those were not accounted for, leading to fstrings passing through unflagged. Also update the SQL checker to be stricter but smarter: The previous version would "fail open", unknown nodes would be allowed through hence f-strings not being flagged when they started appearing in arg0 position, should now fail-closed, anything that's not allowed is forbidden. This flags a few more cases, all of which seem acceptable upon review. However the previous version would also only resolve arg0 (in case it had a `NAME`, to see if that resolved to an acceptable form of query-building). The new version performs resolution during `_check_concatenation` and should thus allow e.g. format strings to be separate variables (though not e.g. module-level constants, yet anyway). In resolution, replace the ad-hoc process by astroid's built-in `lookup` which seems to provide the same information. Slightly more in fact, as it yields every assignment in case of e.g. conditionals, but making use of that would require a lot more changes in the checker so leaving the behaviour as-is for now. It's important to *not* use `ilookup` here, because ilookup is not "iterable" but "inferring", and we don't want values, we want expression ASTs for analysis. NOTE: previous improvements as well as fixes to existing code were only implemented in 14.0, hence this being merged in 14.0 not 13.0 despite 13.0 still being supported. Forward-Port-Of: odoo/odoo#81652 Forward-Port-Of: odoo/odoo#81639
Error raised when trying to add the Wire Transfer payment method in eCommerce Steps to reproduce: 1. Install the eCommerce app 2. Open the Website app 3. Click on "Set payments" on the eCommerce Dashboard 4. Select "Custom payment instructions", fill in the fields and save Solution: Remove the piece of code that raised the error OPW-2687671 Forward-Port-Of: odoo/odoo#81507
Original PR description
Error raised when trying to add the Wire Transfer payment method in eCommerce Steps to reproduce: 1. Install the eCommerce app 2. Open the Website app 3. Click on "Set payments" on the eCommerce Dashboard 4. Select "Custom payment instructions", fill in the fields and save Solution: Remove the piece of code that raised the error OPW-2687671 Forward-Port-Of: odoo/odoo#81507
Step to reproduce: - Go to Timesheet > All Timesheets - Group by 'Project' and 'Employee' - Filter 'Project' for 'office design' => crash Current Behaviour: Traceback because employee_id is not always present (see https://github.com/odoo/enterprise/blob/15.0/timesheet_grid/models/analytic.py#L195-L196 ) Behaviour after PR: No traceback opw-2705014 Forward-Port-Of: odoo/enterprise#22825
Original PR description
Step to reproduce: - Go to Timesheet > All Timesheets - Group by 'Project' and 'Employee' - Filter 'Project' for 'office design' => crash Current Behaviour: Traceback because employee_id is not always present (see https://github.com/odoo/enterprise/blob/15.0/timesheet_grid/models/analytic.py#L195-L196 ) Behaviour after PR: No traceback opw-2705014 Forward-Port-Of: odoo/enterprise#22825
### Step to reproduce: For the French localization, The accounts "Crédit de TVA à reporter" (445670) is calculated in two different ways: One by the section "Autres créances - Brut - Débit", the other by "Dettes fiscales et sociales - credit". ### Current Behavior: So it will be a difference in the balance sheet ### Behavior after the PR: The balance sheet should not have a discrepancy anymore. opw-2698788 -- I confirm I have signed the CLA and read the PR guidelines at www.odo
Original PR description
### Step to reproduce: For the French localization, The accounts "Crédit de TVA à reporter" (445670) is calculated in two different ways: One by the section "Autres créances - Brut - Débit", the other by "Dettes fiscales et sociales - credit". ### Current Behavior: So it will be a difference in the balance sheet ### Behavior after the PR: The balance sheet should not have a discrepancy anymore. opw-2698788 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/enterprise#23029 Forward-Port-Of: odoo/enterprise#22922