Saturday, January 22, 2022
5 changes · master
Enhancements to existing features
This change removes unnecessary conversion steps when processing website assets and images, making those requests faster. Users should see quicker loading of images, avatars, and web pages, with reported performance gains of around 25% in the affected areas.
Original PR description
[IMP] Speed Imp: remove unnecessary base64 encode & decode Avoid to base64 encode, then decode to process assets and images for a ~25% speed improvement. Change image processing tool to work on images, rather than base64 encoded strings. Performance is ~25% faster on assets & images: /web/assets/...frontend.min.css: 13ms to 7ms, base64 enc/dec: 2 -> 0 /web/image/XML_ID: 10ms to 8ms, base64 enc/dec: 3 -> 0 /web/image/res.users/2/avatar_128: 40ms to 20ms, base64 enc/dec: 6 -> 2 Enterprise counterpart: https://www.github.com/odoo/enterprise/pull/23537
This update speeds up delivery of website assets and images by removing unnecessary conversion steps during processing. Users should see quicker page and image loading, with reported performance gains of around 25% for affected asset and image requests.
Original PR description
[IMP] Speed Imp: remove unnecessary base64 encode & decode
Avoid to base64 encode, then decode to process assets and images for a ~25% speed improvement.
Change image processing tool to work on images, rather than base64 encoded strings.
Renamed some "id" variables into res_id
Performance is ~25% faster on assets & images:
/web/assets/...frontend.min.css: 13ms to 7ms, base64 enc/dec: 2 -> 0
/web/image/XML_ID: 10ms to 8ms, base64 enc/dec: 3 -> 0
/web/image/res.users/2/avatar_128: 40ms to 31ms, base64 enc/dec: 4 -> 0Miscellaneous changes
Step to reproduce: - Install website_sale module - Go to the shop - Add a product to the cart and proceed to checkout - Click on Customize and activate `Accept Terms & Conditions` - Deactivate the `Accept Terms & Conditions` or click on a payment method. Issue: UI freeze. Solution: Freeze ui only when clicking on pay button. Unfreeze only if payment process fails. revert of odoo@41b91e1 See also: - Enterprise PR: odoo/enterprise#23560 opw-270279
Original PR description
Step to reproduce:
- Install website_sale module
- Go to the shop
- Add a product to the cart and proceed to checkout
- Click on Customize and activate `Accept Terms & Conditions`
- Deactivate the `Accept Terms & Conditions` or click on a
payment method.
Issue:
UI freeze.
Solution:
Freeze ui only when clicking on pay button.
Unfreeze only if payment process fails.
revert of odoo@41b91e1
See also:
- Enterprise PR: odoo/enterprise#23560
opw-2702798
Forward-Port-Of: odoo/odoo#81661…rted **Steps to follow:** - Go to the Accounting Dashboard - Click on Bank > Import statements - Follow the flow to import a file - Once redirected to the reconciliation, go back to the import from the breadcrumbs - Load a new file **Cause of the issue** The state machine used to handle events didn't allow going from imported to filed_loaded opw-2706505 Forward-Port-Of: odoo/odoo#83213 Forward-Port-Of: odoo/odoo#83101
Original PR description
…rted
**Steps to follow:**
- Go to the Accounting Dashboard
- Click on Bank > Import statements
- Follow the flow to import a file
- Once redirected to the reconciliation, go back to the import from
the breadcrumbs
- Load a new file
**Cause of the issue**
The state machine used to handle events didn't allow going from
imported to filed_loaded
opw-2706505
Forward-Port-Of: odoo/odoo#83213
Forward-Port-Of: odoo/odoo#83101Step to reproduce: - Install website_sale & payment_sepa_direct_debit modules - Set needed configuration to be able to use SEPA on Shop - Go to the shop - Add a product to the cart and proceed to checkout - Select SEPA payment method, put an IBAN an click on Pay Now Issue: UI freeze. Solution: Unfreeze if required inputs are not correctly filled. See also: - Community PR: https://github.com/odoo/odoo/pull/81661 opw-2702798 Forward-Port-Of: odoo/enterprise
Original PR description
Step to reproduce: - Install website_sale & payment_sepa_direct_debit modules - Set needed configuration to be able to use SEPA on Shop - Go to the shop - Add a product to the cart and proceed to checkout - Select SEPA payment method, put an IBAN an click on Pay Now Issue: UI freeze. Solution: Unfreeze if required inputs are not correctly filled. See also: - Community PR: https://github.com/odoo/odoo/pull/81661 opw-2702798 Forward-Port-Of: odoo/enterprise#23560