Saturday, February 26, 2022
5 changes · master
Resolved issues and error corrections
This fixes a login problem that prevented users from completing two-step authentication in Odoo's Android and iOS mobile apps. It restores the expected mobile app login flow so users can authenticate without requiring an app update, which is especially important for iOS users affected by app review delays.
Original PR description
Since PR odoo/odoo#78857 , the TOTP authentication support is broken when used inside either Android or iOS mobile apps. Due to our inability to update the iOS app (following review from Apple), this commit aims at restoring the bare minimum requirements to make the current mobile apps (specially iOS but also Android) authentication workflow works. As extended explanation: - Set-Cookie header is expected to be sent even when session_id hasn't changed (iOS specific). - Successful credentials check on `/web/session/authenticate` expect a successful response with a result containing `uid` set to `null` to mark the need of an additional totp handshake (both platforms).
Miscellaneous changes
Steps : Install Project and Dashboard. Project > My task > Favorites (search zone) > Add to Dashboard. Notice you can drag task between stages. Issue : Dashboard > Notice you cannot. Cause : m2m groupby normally (in kanban_renderer.js) does not allow drag. project_kanban overrides its _setState() method to allow it for parsonnal stages, because they "become m2o" with a user. Yet, in the dashboard, we pass through the default method, because the wrong view is created. Fix : Tak
Original PR description
Steps : Install Project and Dashboard. Project > My task > Favorites (search zone) > Add to Dashboard. Notice you can drag task between stages. Issue : Dashboard > Notice you cannot. Cause : m2m groupby normally (in kanban_renderer.js) does not allow drag. project_kanban overrides its _setState() method to allow it for parsonnal stages, because they "become m2o" with a user. Yet, in the dashboard, we pass through the default method, because the wrong view is created. Fix : Take into account the js_class in the arch to create the view. opw-2752072 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#84864
Steps to reproduce: - Install website_appointment module - Change website theme and select : Cobalt Theme - Go to website - In menu, click on Appointment - Select anyone, select any date and confirm appointment Issue: Title text on each other. Cause: The custom page_header class (in portal module) override the default line-height with 2.1 rem (instead of 1.1). In some themes, the headings tags font-size has been changed with 3.875rem (instead of 2.5rem).
Original PR description
Steps to reproduce: - Install website_appointment module - Change website theme and select : Cobalt Theme - Go to website - In menu, click on Appointment - Select anyone, select any date and confirm appointment Issue: Title text on each other. Cause: The custom page_header class (in portal module) override the default line-height with 2.1 rem (instead of 1.1). In some themes, the headings tags font-size has been changed with 3.875rem (instead of 2.5rem). => font-size is too big regarding the line-height Solution: Remove line-height rule. ref. commit: https://github.com/odoo/odoo/commit/86ab1c55b4229afb74f630b5041a8354c705f849 opw-2745485 Forward-Port-Of: odoo/odoo#85347
revert commit 5f25be8eef9a9efc18a995f2c6405d08a657ac96 https://github.com/odoo/odoo/commit/5f25be8eef9a9efc18a995f2c6405d08a657ac96 ## Goal: - Gives the expected tag to the account move line created by the PoS. - Add tests to the PoS regarding the created account move line ## Before this commit: If the configuration was set to round_globally, a pos.order.line was processed as a refund only if all order.lines were a refund. This leads to unexpected results in the tax report. Indeed,
Original PR description
revert commit 5f25be8eef9a9efc18a995f2c6405d08a657ac96 https://github.com/odoo/odoo/commit/5f25be8eef9a9efc18a995f2c6405d08a657ac96 ## Goal: - Gives the expected tag to the account move line created…
revert commit 5f25be8eef9a9efc18a995f2c6405d08a657ac96 https://github.com/odoo/odoo/commit/5f25be8eef9a9efc18a995f2c6405d08a657ac96 ## Goal: - Gives the expected tag to the account move line created by the PoS. - Add tests to the PoS regarding the created account move line ## Before this commit: If the configuration was set to round_globally, a pos.order.line was processed as a refund only if all order.lines were a refund. This leads to unexpected results in the tax report. Indeed, since commit 46769076526701d96ee4f2653e44b57604cc0b7a https://github.com/odoo/enterprise/commit/46769076526701d96ee4f2653e44b57604cc0b7a "Negative" line in PoS (debit) are processed as positive to give a correct results. This means that if a line is set as debit and is suppose to lower a line, it makes it bigger. Example: aml from PoS: debit: 10 tags: +03 ---> report.line [03] is suppose to make a -10 but will do a +10. As a result, report line [03] is false. ## After this commit: PoS never use "invoice_repartition_line" to create a refund line. ticket: 2718998, 2714310, 2746890 Community-PR: Forward-Port-Of: odoo/odoo#85452 Forward-Port-Of: odoo/odoo#85149
The Stripe Connect onboarding only allows to create production accounts. This is problematic because, before this commit, it was possible to set the state of an acquirer linked to a connected account to 'test', even though the payments would actually be made on the live environment of Stripe. Additionally, this commit fixes a minor display issue that caused the "Connect" button to be shown when an API key was set, while it should be hidden as soon as an API key is set. See also: - h
Original PR description
The Stripe Connect onboarding only allows to create production accounts. This is problematic because, before this commit, it was possible to set the state of an acquirer linked to a connected account to 'test', even though the payments would actually be made on the live environment of Stripe. Additionally, this commit fixes a minor display issue that caused the "Connect" button to be shown when an API key was set, while it should be hidden as soon as an API key is set. See also: - https://github.com/odoo/internal/pull/1568 Forward-Port-Of: odoo/odoo#85139